jak-project/game
Luminar Light 0ae0938965
Only remove -vis from name if it is part of the name. (#3257)
During level extraction, the last 4 characters of the level name are
always removed, because it is assumed that '-vis' is there. But it isn't
always there. This is especially true in post-TPL games.

This causes multiple problems:
- There can be levels in the extraction that will miss their last 4
characters from their name, which is sad, and may make it harder to
identify them.
- If there are '-vis'-less levels whose names are identical apart from
the last 4 characters, the extractor will only get the last one (it
probably extracts all but overwrites everything but the last one). For
example 'ctyasha' and 'ctykora'.

This issue affects the glb extraction and the entities json extraction.

I personally think that just keeping the -vis in the name would be the
best solution, but I guess there was a reason why it was decided that it
should be removed from the name. So to adapt to this, my implementation
will still remove '-vis' from the name, but only if it is actually in
the name - otherwise it won't remove anything.

I hope my changes didn't break anything. Extraction seemed to run fine
after my changes, and I was able to see both ctyasha and ctykora json
files. And didn't see any '-vis', so it is still properly removed.

---------

Co-authored-by: Tyler Wilding <xtvaser@gmail.com>
2024-02-24 14:13:48 -05:00
..
assets New Crowdin updates (#3382) 2024-02-19 23:17:29 -05:00
common [jak3] Decomp for gkernel, gkernel-h, gstate, gstring (#3326) 2024-01-21 18:08:05 -05:00
external game: refactor discord code and improve jak 2 support (#2714) 2023-06-17 05:16:40 +01:00
graphics game: disable keyboard input by default, give users a way to enable it via the imgui menu (#3295) 2024-02-23 18:19:07 -05:00
kernel g/j2: Dynamic speedrun mode categories and implement a significant amount of a practice mode (#3378) 2024-02-23 19:04:44 -05:00
mips2c Decompile joint, collide-func, clean up joint decompression code for all games (#3369) 2024-02-11 09:50:07 -05:00
overlord game: disable keyboard input by default, give users a way to enable it via the imgui menu (#3295) 2024-02-23 18:19:07 -05:00
sce [jak2] fully implement *user* (#3046) 2023-10-01 04:28:30 +01:00
settings Only remove -vis from name if it is part of the name. (#3257) 2024-02-24 14:13:48 -05:00
sound Switch to std::span (#3376) 2024-02-18 13:23:19 -05:00
system game: disable keyboard input by default, give users a way to enable it via the imgui menu (#3295) 2024-02-23 18:19:07 -05:00
tools i18n: transcribe missing english subtitles (#3199) 2023-11-18 14:06:01 -05:00
CMakeLists.txt g/j2: Dynamic speedrun mode categories and implement a significant amount of a practice mode (#3378) 2024-02-23 19:04:44 -05:00
main.cpp tracing: add some more startup related events and a new --profile-until-event flag (#3385) 2024-02-23 14:44:17 -05:00
runtime.cpp [jak3] Decomp for gkernel, gkernel-h, gstate, gstring (#3326) 2024-01-21 18:08:05 -05:00
runtime.h g/j2: Integrate highscores with Speedrun.com/JakSpeedruns.com when speedrunner mode is enabled (#3037) 2023-10-11 20:43:55 -04:00