* Add original asset names to all `object_h*` files
* Soften language used in `object_hunsui`, because we can't say for sure that we know the names of the collision files, even if it feels pretty clear
* Switch from "is" to "might be" on the DLs too
* Document EnTanron5 (destructible props, fragments, and item drops in Twinmold's arena)
* Respond to engineer's review
* Updated the type names, used "ruin" instead of "prop" in comments, and addressed Anon's review
* Missed this instance of "prop"
* Respond to engineer's review
* Update OutNames too
* WIP
* map static
* finish english names
* jpn
* revert map name
* name prefix
* boss to big
* more comments
* item enums
* more items
* more
* PR Suggestions
* PR Suggestion
* Change `EN_SYATEKI_*` enums/defines to `SG_*`
* Name shooting gallery weekeventregs
* Get rid of names on unions (this is what I wanted to begin with!)
* Use ARRAY_COUNT(sGuayFlagsPerWave) instead of 3
* Actually give a proper name for SG_DEKU_GET_PARAM_FF00
* Use anon's suggestion for path param name
* Remove comment that isn't true? What was I cooking back then
* Animation naming stuff + comments
* Tons of score and shooting game logic cleanup
* Fix build issues
* Some more Octorok docs
* Use ANIMMODE enum in EnShn
* Put a bug tag on the weird behavior in EnSyatekiWf
* object_firefly dLists and skel
* most limbs, textures
* more limbs, comments, outnames.
* fixed d list name in z_en_firefly
* enum name fix, limbIndex numbers fix, root name fix
* llvm changes because of format.py
* deleted llvms and max limbs number fixed
* z_en_firefly changes after clang format
* error in the build because of these two
* fixed limbIndex issue and added enum names instead
* equal sign that was missing
* limbIndex number was wrong
* z_en_firefly.h include changes and morph/joint table changes
* build retry
* format.py again and build retry
* Initial docs
* Tons of stuff done
* Fix spacing thing now that the function is actually named
* Temporarily add un-macro'd flags as comment
* Name and document EnSyatekiOkuta_IsHiddenByAnotherOctorok
* Finish naming all functions
* Better macros + explanations
* Comments on a lot of functions
* Some stuff I was supposed to revert
* Fix merge issue
* Another merge fix
* Make data static + move it in-function
* Respond to engineer's review
* circleOrCrossAlpha -> hitResultAlpha
* Respond to more of engineer's feedback
* octorokHitType -> lastHitOctorokType
* Animation enum stuff
* Start
* Try every function
* Import data
* Docs from message branch
* Fix non-equivalency for func_8016AE1C
* Everything looks NON_MATCHING
* Some more clean up and docs
* Some cleanup
* Small format
* Small improvements here and there
* Match a couple
* Anotha one
* and than there was 1
* and than there were none :)
* Lots of docs
* Finish code docs
* schedule static
* Macros + cleanup
* text ids array cleanup
* Entries cleanup
* Use sBombersNotebookEntries in macros
* Some docs from message branch
* eventIndex -> event
* Remove outdated comments
* PR
* BOMBERS_NOTEBOOK_ENTRY_SIZE
* tables
* Token pasting to simplify
* Some more fixes
* PR pt 1
* Format
* Bring over BombersNotebook docs from z_message branch
Co-authored-by: ZoeyZolotova <zoey.zolotova@gmail.com>
* Full enum glory
* Format
* Name weekeventregs
* typo
* Some comments
* bss
* Review
* bss
* Update src/code/z_play_hireso.c
Co-authored-by: engineer124 <47598039+engineer124@users.noreply.github.com>
* Fix
* Namefixer
* bss
* Format
* 0 = 0x0000
---------
Co-authored-by: ZoeyZolotova <zoey.zolotova@gmail.com>
Co-authored-by: engineer124 <47598039+engineer124@users.noreply.github.com>
* Everything below Main OK,
and some small ones at the top
* 3 more short ones
* FileChoose_Main
* SelectModeUpdate/Draw
* SelectMode update functions done
* 2 more small ones
* ConfigModeDraw
* SetWindowVtx
* FileChoose_FadeInMenuElements
* Rest of the Config Mode Update Functions
* Minor cleanup
* FileChoose_UpdateMainMenu
* Make xml for title_static
* Minor correction
* One nasty draw, thanks Synray
Co-Authored-By: Synray <31429825+Synray@users.noreply.github.com>
* import data
* some cleanup
* import OoT docs
* missed some docs
* some progress
* FileSelect_SetWindowContentVtx WIP
* improve FileSelect_SetWindowContentVtx
* match z_file_nameset_NES
* cleanup and docs
* title static
* a few more functions
* even more functions
* small cleanup
* Data Cleanup
* 2 more matches
* z_file_choose_80807940 OK
* cleanup
* fix merge master
* FileSelect_DrawFileInfo wip
* small cleanup
* minor
* fix merge
* match FileSelect_DrawFileInfo
* cleanup
* fix merge
* fix merge
* sram cleanup
* document select mode
* many docs
* more docs
* more cleanup
* small nitpick
* consistency
* more cleanup
* more cleanup
* small
* small typos
* octal bad
* pr review
* noop
* elliptic review
* more review
* non-matching
* oops
* more suggestions
* keyboard formatting
* fix master
* sound
* padding
---------
Co-authored-by: Elliptic Ellipsis <elliptic.ellipsis@gmail.com>
Co-authored-by: Synray <31429825+Synray@users.noreply.github.com>
* Match remaining functions in z_en_go:
- Changed some already matching functions for uniformity with the tricky match (early continue from loop). In some cases, this eliminated some strange constructs, in others, it didn't leave much difference.
- Comments/Notes to start understanding/naming process.
* WIP renaming
* More WIP renaming.
* More renaming, Effects (See oot for continuation) and some flags)
* MessageScript documenting.
* Util for dumping message data by textId value.
* Identify some messages.
* Formatting, figuring out event flags.
* More WIP naming
* WIP renaming.
* WIP renaming
* WIP naming and organizing
* WIP more renaming.
* WIP renaming/organizing.
* Near-Final Cleanup before review.
* Rename Taisou and Hakugin animations and associated functions/variables.
* Misc Cleanup.
* Undo changes to variables.txt
* Removed msgtableparser.py (Split to another branch)
* Removal of uncompiled Message Script details.
* Fixup spec file
* First part of hensldm's suggested changes from review. Awaiting discussion.
* Second part of hensldm's suggested changes.
* Fixup missed 'Animation' suffix and functions.txt
* Update .xml files and related source per tom-overton's comments
* Align w/ engineer124's Quake Cleanup #1102
* fixup
* Run format.sh after merge.
* Add brackets around one-line conditional blocks
* Remainder of hensldm's comments from review.
* First pass at Elliptic's comments.
* Rename functions UpdateToX -> ChangeToX
* Header cleanup.
* Run Format, remove accidental commit of .orig file.
* Fixup ActorInit
* Review comments addressed, plus a few unsolicited changes.
- Location of function declarations moved above static data, below types: References in the codebase were mixed, but this just made more sense.
- Function name changes: It didn't fit into subsystems based on Goron Type, so I quit trying to name functions that way. Loss of a bit of "which function applies to which type", but it looks a bit cleaner, sooo...
- Took a stab at making effectTable usage a bit clearer. Just using a EnGoEffect* everywhere and not inherently knowing if it was for one element, or an array really bugged me.
- "GraveBro" names changed. They're all "brothers".
* Changes from engineer124's review.
- "Stretcher" replaced with "Athletic" as a descriptor of goron type.
- Misc formatting and naming changes
* Restructure switch-case statment for early break, and added missing default cases. Removed #define for 0 for actionFlags bitmask.
* Relocate WEEKEVENTREG comments, remove SCENE comments.
* Updated WEEKEVENTREG define names
* Update WEEKEVENTREG names in Goron Shrine Door.
* ELDER -> ELDERS, and revert formatting on z64save.h
* Fixed re-applying changes over wrong defines.
* Adjust Weekeventreg names and comments.
* Update comment as well.
* Progress
* one more
* OK
* update
* finished z_demo_moonend
* update reloc
* actually updated reloc
* fix symbols
* made suggested changes
* reformat
* Made suggested changes
* forgot to run format.py
* made suggested changes
* made suggested changes
* moved cueid to be in scope
* Begin Kaleido
* WIP
* DW macros for gbi
* More Progress
* Match KaleidoScope_GrayOutTextureRGBA32
* DrawGameOver wip
* Add some function names
* A few more matching, some docs
* More docs, data wip
* Import Kaleido Data
* Data cleanup
* Some progress
* Match TitleCard_Draw Again (Thanks Roman)
* Match KaleidoScope_DrawDebugEditor
* KaleidoScope_UpdateDebugEditor WIP
* Some cleanup
* z_kaleido_debug.c OK
* Cleanup
* match func_8081B6EC
* more wip, data cleanup
* match func_80825A50
* match KaleidoScope_InitVertices
* cursor progress
* name func
* item headers
* match KaleidoScope_DrawItemSelect
* KaleidoScope_UpdateItemEquip WIP
* match kaleido item
* doc kaleido item
* z_kaleido_prompt ok
* kaleido mask setup
* small cleanup
* kaleido mask OK
* mask cleanup
* small fix
* quest page setup
* doc save prompt
* sync with prompt docs
* KaleidoScope_Update WIP
* More progress on KaleidoScope_Update
* kaleido update cleanup
* KaleidoScope_Update OK
* Slightly cleaner match in KaleidoScope_Update
* match KaleidoScope_DrawPages and KaleidoScope_DrawGameOver, organize data
* more cleanup
* match KaleidoScope_Draw and KaleidoScope_SetView
* match KaleidoScope_UpdateNamePanel
* match another 2 funcs, segment docs
* another KaleidoScope_UpdateNamePanel ?
* swap update name panel names
* another match, only 2 large/similar vtx function in kaleido nes
* more setup for drawInfoPanel
* match KaleidoScope_DrawDungeonStrayFairyCount, 8 funcs left
* document KaleidoScope_DrawDungeonStrayFairyCount
* KaleidoScope_DrawInfoPanel1 WIP
* match KaleidoScope_DrawInfoPanel2
* gameover pause states
* name two pause states
* match KaleidoScope_UpdateDungeonCursor and KaleidoScope_UpdateWorldMapCursor
* match KaleidoScope_DrawDungeonMap
* KaleidoScope_DrawWorldMap WIP
* cleanup map
* some cursor/texture docs
* more cursor docs
* KaleidoScope_UpdateQuestCursor wip
* match KaleidoScope_UpdateQuestCursor
* quest cleanup
* KaleidoScope_DrawQuestStatus WIP, broke gakufu
* match KaleidoScope_DrawInfoPanel1, Kaleido NES OK
* pause substates
* more cleanup
* map progress
* very small improvements to KaleidoScope_DrawWorldMap
* match KaleidoScope_DrawWorldMap
* cleanup KaleidoScope_DrawWorldMap
* rematch EnGakufu_ProcessNotes, thanks anon58
* gameover and misc docs
* more docs
* small cleanup of maps
* owl warp and other docs
* symmetry in pause state
* some docs and cleanup
* docs
* more docs from OoT WIP
* fix
* quest page docs
* more enums
* more cleanup and enums
* another round of docs
* doc cursor indices
* map docs
* some docs
* cleanup for-loops
* cleanup
* else if
* small docs
* icon_item_field_static
* dungeon static
* eol
* icon item jpn static
* vtx static
* jpn static comments
* import parameter texture functions
* mask cleanup
* sync with PRs
* some docs
* more docs
* fix bss
* some docs
* sync with PR
* quest docs
* fix quest vtx
* sync with PR
* sync with PR
* fix typo
* small cleanup
* vtx madness
* more vtx
* add quad docs
* cleanup vtx
* cleanup
* cleanup
* revert gbi changes
* cleanup
* more cleanup
* another cleanup
* remove empty comment
* some PR review
* more naming suggestions
* namefixer
* L button to Z button
---------
Co-authored-by: Derek Hensley <hensley.derek58@gmail.com>
* Decompiled source of tobira01
* Documented and formatted in prep for merge request
* Added spacing, renamed unused back to what it was, added definitions, changed 1.6666 to division
* Ran weekeventreg script, added additional spaces throughout the file, removed the macros for 0 and 60, updated some missed this casts, renamed spot11 out names
* Converted gSaveContext calls over to CLEAR_WEEKEVENTREG calls from review feedback
* Reformatted some files
* More review feedback
* Removed _tex
* decomped init, draw
* started slime
* finished func decomp en_slime
* object_slime and en_slime updates
* updated a few names
* finished up some naming
* en_slime and object_slime OK and documented
* slime xml cleanup
* Code cleanup round 1
* Cleanup 1 - missed a note
* Fixed improper use of bgcheck flags
* Some cleanup
* Namefix, name cleanup
* Function name cleanup, misc cleanup
* More name cleanup (pre-merge)
* Update color filter flag constants
* Tidying
---------
Co-authored-by: Blythe Hospelhorn <35576053+bhospelhorn@users.noreply.github.com>
* OK, data imported
* Permuter settings
* Name data, a few functions and variables, cleanup
* Small amount of cleanup on some related actors
* Oops
* Document object
* Type and other macros
* Some cutscene stuff and temporary function names
* Proper path function names
* Name a couple more functions
* A couple more function names
* Name PathStatus enum
* Name rest of functions and formalise the documentation a bit
* Apply suggestions from code review
Co-authored-by: Derek Hensley <hensley.derek58@gmail.com>
* limbs
* Format
* Review
* format
* weekeventregconvert and format
---------
Co-authored-by: Derek Hensley <hensley.derek58@gmail.com>
Co-authored-by: angie <angheloalf95@gmail.com>
* OK, struct documented
* Data imported, update spec
* Name data
* Name all functions and variables
* Document object
* Bit more documentation
* Document Karebaba
* Add note to object_dekubaba
* Bit more cleanup
* Review
* Shadow
* Review
* Rename functions, add hit enum
* Figured out the enum
* Review
* MarkForDeath -> Kill
