mm/tools/asm-processor
Anghelo Carvajal a04f1b8e05
Change tooling for better elf correctness (#1632)
* Add addresses for makerom and boot segments

* Mark entrypoint as the entry of the elf

* Add extra labels to macro.inc

* Use dlabel, jlabel and endlabel in disassembly

* Make jlabel global

* git subrepo pull tools/asm-processor

subrepo:
  subdir:   "tools/asm-processor"
  merged:   "92b9ec72f"
upstream:
  origin:   "git@github.com:simonlindholm/asm-processor.git"
  branch:   "main"
  commit:   "92b9ec72f"
git-subrepo:
  version:  "0.4.3"
  origin:   "https://github.com/ingydotnet/git-subrepo.git"
  commit:   "2f68596"

* Use `dlabel`s for non-functions in .text

* Add linker asserts

* Move framebuffer_lo to before the makerom segment to avoid `dot moved backwards` warnings

* fix

* Improve assert message

* fix

* Third fix

* Fix four

* Move undefined_syms to linker_script folder

* Make second linker script file to avoid abusing undefined_syms

* Update Makefile

Co-authored-by: Derek Hensley <hensley.derek58@gmail.com>

* Rename to extra.ld

* Use entrypoint symbol on ROM header

---------

Co-authored-by: Derek Hensley <hensley.derek58@gmail.com>
2024-05-17 06:41:23 -07:00
..
tests Subrepo Updates (#1368) 2023-09-08 20:17:54 +10:00
.gitignore subrepo asm-processor (#1212) 2023-03-17 15:16:30 +11:00
.gitrepo Change tooling for better elf correctness (#1632) 2024-05-17 06:41:23 -07:00
add-test.sh subrepo asm-processor (#1212) 2023-03-17 15:16:30 +11:00
asm_processor.py Change tooling for better elf correctness (#1632) 2024-05-17 06:41:23 -07:00
build.py subrepo asm-processor (#1212) 2023-03-17 15:16:30 +11:00
compile-test.sh subrepo asm-processor (#1212) 2023-03-17 15:16:30 +11:00
LICENSE subrepo asm-processor (#1212) 2023-03-17 15:16:30 +11:00
mypy.ini Subrepo Updates (#1368) 2023-09-08 20:17:54 +10:00
prelude.inc Change tooling for better elf correctness (#1632) 2024-05-17 06:41:23 -07:00
README.md subrepo asm-processor (#1212) 2023-03-17 15:16:30 +11:00
run-tests.sh subrepo asm-processor (#1212) 2023-03-17 15:16:30 +11:00

asm-processor

Pre-process .c files and post-process .o files to enable embedding MIPS assembly into IDO-compiled C.

Usage

Let's say you have a file compiled with -g on the IDO compiler, that looks like this:

float func4(void) {
    "func4";
    return 0.2f;
}

This script enables replacing it by:

GLOBAL_ASM(
.rdata
.word 0x66756e63 # func
.word 0x34000000 # 4\0\0\0

.late_rodata
glabel rv
.word 0x3e4ccccd # 0.2f

.text
glabel func4
lui     $at, %hi(rv)
jr      $ra
lwc1    $f0, %lo(rv)($at)
jr      $ra
nop
jr      $ra
nop
)

To compile the file, run python3 build.py $CC -- $AS $ASFLAGS -- $CFLAGS -o out.o in.c, where $CC points to an IDO binary (5.3/7.1 and recomp/qemu all supported), $AS is e.g. mips-linux-gnu-as, $ASFLAGS e.g. -march=vr4300 -mabi=32 and $CFLAGS e.g. -Wab,-r4300_mul -non_shared -G 0 -Xcpluscomm -g. build.py may be customized as needed.

In addition to an .o file, build.py also generates a .d file with Makefile dependencies for .s files referenced by the input .c file. This functionality may be removed if not needed.

Reading assembly from file is also supported, by either GLOBAL_ASM("file.s") or #pragma GLOBAL_ASM("file.s").

What is supported?

.text, .data, .bss and .rodata sections, .word/.incbin, .ascii/.asciz, and -g, -g3, -O1, -O2, -framepointer and -mips1/-mips2 flags to the IDO compiler.

What is not supported?

  • complicated assembly (.ifdef, macro declarations/calls other than glabel, pseudo-instructions that expand to several real instructions)
  • non-IDO compilers
  • -O3 (due to function reordering)

C #ifdefs only work outside of GLOBAL_ASM calls, but is otherwise able to replace .ifdef.

What's up with "late rodata"?

The IDO compiler emits rodata in two passes: first array/string contents, then large literals/switch jump tables.

Data declared within .rdata/.section .rodata will end up in the first half, and .late_rodata/.section .late_rodata in the second half.

How does it work?

It's a bit of a hack! The basic idea is replace GLOBAL_ASM blocks with dummy C functions/global vars of the same sections sizes as the assembly. Then the C file gets compiled, and the dummy contents overwritten with the injected assembly.

To accomplish this, asm-processor has logic for guessing the size of assembly contents (which assumes the assembly isn't too complicated, e.g. no macros), and for emitting C code of exact sizes for a bunch of different IDO compiler flags.

The assembler code is padded with nops to line it up with its correct position in the C; this allows C and asm ELF files to be merged easily without having to fix up e.g. symbol addresses.

The most difficult part is late_rodata, which is hard to create programmatically. asm-processor does that by emitting code that uses dummy float literals/double literals/jump tables, assembles the late_rodata at another location of the .rodata section, then overwrites the dummy rodata. This does require some movement of symbols and relocations, and quite a bit of care in what code to emit and how to preserve .double alignment.

It's worth noting some alternative ways in which asm-processor would have been implemented:

  • One idea to get rid of the C/asm size estimations is to emit arbitrary code, and then move code, symbols and relocations to the correct place after the sizes are known. Given the machinery for late_rodata this wouldn't have been too difficult, and it would have the upside of improved portability. There is a big downside, however: using dummy code of incorrect size throws off alignment and can introduce unintended padding. Fixing this would require running multiple passes of asm-processor, with one compile per ASM_GLOBAL.
  • Another idea is to run the compiler with -S to emit assembly, modify the emitted assembly, then run the assembler (which in IDO's case may perform additional instruction reordering etc.). This option has not been investigated in much detail, and would perhaps be superior to the current implementation. It does have a few unknowns to it, e.g. instruction encoding differences between GNU as and IDO's assembler, how to avoid reordering the injected assembly, and how .rodata/.late_rodata are implemented.

Testing

There are a few tests to ensure you don't break anything when hacking on asm-processor: ./run-tests.sh should exit without output if they pass, or else output a diff from previous to new version.

Tests need the environment variable MIPS_CC set to point to the IDO 7.1 compiler, with Pascal support enabled.

For example if asm-processor is cloned in the same directory as ido static recomp and the working directory is asm-processor, tests can be run using:

MIPS_CC=../ido-static-recomp/build/7.1/out/cc ./run-tests.sh

Or using qemu-irix (don't forget chmod u+x qemu-irix) to emulate IDO:

MIPS_CC='./qemu-irix -silent -L ../ido-static-recomp/ido/7.1/ ../ido-static-recomp/ido/7.1/usr/bin/cc' ./run-tests.sh

To skip running Pascal tests, remove the tests/*.p glob from run-tests.sh.