Game-Decompilation/pokecrystal
1
0
Fork 0
mirror of https://github.com/pret/pokecrystal.git synced 2024-11-30 08:40:49 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Improve use of palette macro and use PAL_* constants (#1087)

Browse Source 
* Improve use of palette macro and use PAL_* constants

* Use proper constant for battle stats (#1088)

* Add suggestions about function names and variables

* Add colors macro

---------

Co-authored-by: vulcandth <vulcandth@gmail.com>
This commit is contained in:
vulcandth 2023-11-17 18:25:00 +00:00
parent a2fbacf1da
commit dc1c8d32cb
12 changed files with 24 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pokecrystal.map
View File

@ -23100,8 +23100,8 @@ ROMX bank #50:
$4e35 = BGEffect_RapidCyclePals.okay_3_cgb
$4e43 = BGEffect_RapidCyclePals.okay_4_cgb
$4e49 = BGEffect_RapidCyclePals.four_cgb
$4e52 = BGEffects_LoadBGPal0_OBPal1
$4e7f = BGEffects_LoadBGPal1_OBPal0
$4e52 = BGEffects_LoadPlayerPals
$4e7f = BGEffects_LoadEnemyPals
$4eac = BattleBGEffect_GetFirstDMGPal
$4eb2 = BattleBGEffect_GetNextDMGPal
$4ec6 = BattleBGEffect_GetNextDMGPal.repeat

4
pokecrystal.sym
View File

@ -22813,8 +22813,8 @@
32:4e35 BGEffect_RapidCyclePals.okay_3_cgb
32:4e43 BGEffect_RapidCyclePals.okay_4_cgb
32:4e49 BGEffect_RapidCyclePals.four_cgb
32:4e52 BGEffects_LoadBGPal0_OBPal1
32:4e7f BGEffects_LoadBGPal1_OBPal0
32:4e52 BGEffects_LoadPlayerPals
32:4e7f BGEffects_LoadEnemyPals
32:4eac BattleBGEffect_GetFirstDMGPal
32:4eb2 BattleBGEffect_GetNextDMGPal
32:4ec6 BattleBGEffect_GetNextDMGPal.repeat

4
pokecrystal11.map
View File

@ -23100,8 +23100,8 @@ ROMX bank #50:
$4e35 = BGEffect_RapidCyclePals.okay_3_cgb
$4e43 = BGEffect_RapidCyclePals.okay_4_cgb
$4e49 = BGEffect_RapidCyclePals.four_cgb
$4e52 = BGEffects_LoadBGPal0_OBPal1
$4e7f = BGEffects_LoadBGPal1_OBPal0
$4e52 = BGEffects_LoadPlayerPals
$4e7f = BGEffects_LoadEnemyPals
$4eac = BattleBGEffect_GetFirstDMGPal
$4eb2 = BattleBGEffect_GetNextDMGPal
$4ec6 = BattleBGEffect_GetNextDMGPal.repeat

4
pokecrystal11.sym
View File

@ -22813,8 +22813,8 @@
32:4e35 BGEffect_RapidCyclePals.okay_3_cgb
32:4e43 BGEffect_RapidCyclePals.okay_4_cgb
32:4e49 BGEffect_RapidCyclePals.four_cgb
32:4e52 BGEffects_LoadBGPal0_OBPal1
32:4e7f BGEffects_LoadBGPal1_OBPal0
32:4e52 BGEffects_LoadPlayerPals
32:4e7f BGEffects_LoadEnemyPals
32:4eac BattleBGEffect_GetFirstDMGPal
32:4eb2 BattleBGEffect_GetNextDMGPal
32:4ec6 BattleBGEffect_GetNextDMGPal.repeat

4
pokecrystal11_debug.map
View File

@ -23112,8 +23112,8 @@ ROMX bank #50:
$4e35 = BGEffect_RapidCyclePals.okay_3_cgb
$4e43 = BGEffect_RapidCyclePals.okay_4_cgb
$4e49 = BGEffect_RapidCyclePals.four_cgb
$4e52 = BGEffects_LoadBGPal0_OBPal1
$4e7f = BGEffects_LoadBGPal1_OBPal0
$4e52 = BGEffects_LoadPlayerPals
$4e7f = BGEffects_LoadEnemyPals
$4eac = BattleBGEffect_GetFirstDMGPal
$4eb2 = BattleBGEffect_GetNextDMGPal
$4ec6 = BattleBGEffect_GetNextDMGPal.repeat

4
pokecrystal11_debug.sym
View File

@ -22825,8 +22825,8 @@
32:4e35 BGEffect_RapidCyclePals.okay_3_cgb
32:4e43 BGEffect_RapidCyclePals.okay_4_cgb
32:4e49 BGEffect_RapidCyclePals.four_cgb
32:4e52 BGEffects_LoadBGPal0_OBPal1
32:4e7f BGEffects_LoadBGPal1_OBPal0
32:4e52 BGEffects_LoadPlayerPals
32:4e7f BGEffects_LoadEnemyPals
32:4eac BattleBGEffect_GetFirstDMGPal
32:4eb2 BattleBGEffect_GetNextDMGPal
32:4ec6 BattleBGEffect_GetNextDMGPal.repeat

4
pokecrystal11_vc.map
View File

@ -23152,8 +23152,8 @@ ROMX bank #50:
$4e35 = BGEffect_RapidCyclePals.okay_3_cgb
$4e43 = BGEffect_RapidCyclePals.okay_4_cgb
$4e49 = BGEffect_RapidCyclePals.four_cgb
$4e52 = BGEffects_LoadBGPal0_OBPal1
$4e7f = BGEffects_LoadBGPal1_OBPal0
$4e52 = BGEffects_LoadPlayerPals
$4e7f = BGEffects_LoadEnemyPals
$4eac = BattleBGEffect_GetFirstDMGPal
$4eb2 = BattleBGEffect_GetNextDMGPal
$4ec6 = BattleBGEffect_GetNextDMGPal.repeat

4
pokecrystal11_vc.sym
View File

@ -22865,8 +22865,8 @@
32:4e35 BGEffect_RapidCyclePals.okay_3_cgb
32:4e43 BGEffect_RapidCyclePals.okay_4_cgb
32:4e49 BGEffect_RapidCyclePals.four_cgb
32:4e52 BGEffects_LoadBGPal0_OBPal1
32:4e7f BGEffects_LoadBGPal1_OBPal0
32:4e52 BGEffects_LoadPlayerPals
32:4e7f BGEffects_LoadEnemyPals
32:4eac BattleBGEffect_GetFirstDMGPal
32:4eb2 BattleBGEffect_GetNextDMGPal
32:4ec6 BattleBGEffect_GetNextDMGPal.repeat

4
pokecrystal_au.map
View File

@ -23100,8 +23100,8 @@ ROMX bank #50:
$4e35 = BGEffect_RapidCyclePals.okay_3_cgb
$4e43 = BGEffect_RapidCyclePals.okay_4_cgb
$4e49 = BGEffect_RapidCyclePals.four_cgb
$4e52 = BGEffects_LoadBGPal0_OBPal1
$4e7f = BGEffects_LoadBGPal1_OBPal0
$4e52 = BGEffects_LoadPlayerPals
$4e7f = BGEffects_LoadEnemyPals
$4eac = BattleBGEffect_GetFirstDMGPal
$4eb2 = BattleBGEffect_GetNextDMGPal
$4ec6 = BattleBGEffect_GetNextDMGPal.repeat

4
pokecrystal_au.sym
View File

@ -22813,8 +22813,8 @@
32:4e35 BGEffect_RapidCyclePals.okay_3_cgb
32:4e43 BGEffect_RapidCyclePals.okay_4_cgb
32:4e49 BGEffect_RapidCyclePals.four_cgb
32:4e52 BGEffects_LoadBGPal0_OBPal1
32:4e7f BGEffects_LoadBGPal1_OBPal0
32:4e52 BGEffects_LoadPlayerPals
32:4e7f BGEffects_LoadEnemyPals
32:4eac BattleBGEffect_GetFirstDMGPal
32:4eb2 BattleBGEffect_GetNextDMGPal
32:4ec6 BattleBGEffect_GetNextDMGPal.repeat

4
pokecrystal_debug.map
View File

@ -23112,8 +23112,8 @@ ROMX bank #50:
$4e35 = BGEffect_RapidCyclePals.okay_3_cgb
$4e43 = BGEffect_RapidCyclePals.okay_4_cgb
$4e49 = BGEffect_RapidCyclePals.four_cgb
$4e52 = BGEffects_LoadBGPal0_OBPal1
$4e7f = BGEffects_LoadBGPal1_OBPal0
$4e52 = BGEffects_LoadPlayerPals
$4e7f = BGEffects_LoadEnemyPals
$4eac = BattleBGEffect_GetFirstDMGPal
$4eb2 = BattleBGEffect_GetNextDMGPal
$4ec6 = BattleBGEffect_GetNextDMGPal.repeat

4
pokecrystal_debug.sym
View File

@ -22825,8 +22825,8 @@
32:4e35 BGEffect_RapidCyclePals.okay_3_cgb
32:4e43 BGEffect_RapidCyclePals.okay_4_cgb
32:4e49 BGEffect_RapidCyclePals.four_cgb
32:4e52 BGEffects_LoadBGPal0_OBPal1
32:4e7f BGEffects_LoadBGPal1_OBPal0
32:4e52 BGEffects_LoadPlayerPals
32:4e7f BGEffects_LoadEnemyPals
32:4eac BattleBGEffect_GetFirstDMGPal
32:4eb2 BattleBGEffect_GetNextDMGPal
32:4ec6 BattleBGEffect_GetNextDMGPal.repeat