Game-Decompilation/pokecrystal
1
0
Fork 0
mirror of https://github.com/pret/pokecrystal.git synced 2024-11-30 08:40:49 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
156 Commits 2 Branches 0 Tags 108 MiB
symbols
Commit Graph

156 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Rangi42
3ebaa45052 Identify more bit flags (#1153) 2024-11-30 00:30:47 +00:00
Rangi42
f765a30c32 Fix AI_Smart_Curse labels 
Fixes #1130
 2024-10-17 21:21:14 +00:00
Rangi42
f1f5e954f3 Rename Bill's brother to Bill's older sister (#1132) 2024-10-17 21:04:44 +00:00
Rangi42
f840d0e307 Update mislabeled sweet_scent.asm subroutine (#1140) 2024-10-17 20:59:13 +00:00
Rangi42
09de683b28 Rename dt and dd to bigdt and bigdd (#1141) 
This makes their big-endianness obvious and matches `bigdw`
 2024-10-17 18:53:59 +00:00
Rangi42
ad1101e38c Put front and back pics on a single line (#1139) 2024-09-26 04:21:16 +00:00
Rangi42
07c32c1d76 Label the unused daily flag (#1143) 2024-09-26 04:18:24 +00:00
Rangi42
aa5bddfec3 Refactor the Unown wall word data (#1131) 2024-07-24 14:58:12 +00:00
Rangi42
d4c3e70e44 Build with RGBDS 0.8.0, though it is not yet required 2024-06-28 20:13:44 +00:00
Rangi42
da22debdaa Identify various "????"s (#1125) 2024-06-12 00:55:48 +00:00
Rangi42
5dd0e98cfe Use constants for VBlank handlers 2024-05-23 01:03:55 +00:00
Rangi42
c129356b77 Fixed wrong text label (#1107) 2024-01-30 00:00:44 +00:00
mid-kid
37e4c62208 Improve some innacurate function names, labels, and comments (#1078) 
[https://github.com/pret/pokecrystal/issues/1078#issue-1869550979 and https://github.com/pret/pokecrystal/issues/1078#issuecomment-1696394371]
 2024-01-29 23:43:17 +00:00
Rangi42
c441f40afe Update to RGBDS 0.7.0 (#1101) 2024-01-03 15:59:56 +00:00
vulcandth
dc1c8d32cb Improve use of palette macro and use PAL_* constants (#1087) 
* Improve use of palette macro and use PAL_* constants

* Use proper constant for battle stats (#1088)

* Add suggestions about function names and variables

* Add colors macro

---------

Co-authored-by: vulcandth <vulcandth@gmail.com>
 2023-11-17 18:25:00 +00:00
vulcandth
a2fbacf1da Sync sprite and battle anim consts/labels (#1055) 
* Sync sprite and battle anim consts/labels

* Add `; 00` comments

* Renamed to `SpriteAnimFunc_` and `BattleAnimFunc_`
 2023-09-17 18:10:33 +00:00
mid-kid
516c0ead94 CI copy .map files to symbols branch 2023-08-23 11:05:22 +00:00
vulcandth
45be6256bf Labeled framesets and related constants (#1063) 
* Labeled Framesets and Constants Related

* Feedback Implemented with PascalCase and Constant Renames

* Fix framset.asm comment spacing

* `BATTLEANIMFRAMESET_35` to `BATTLEANIMFRAMESET_THUNDER_WAVE_EXTRA`

* Feedback applied and labeled 1E & B2

* Fixed SpinningBone

---------

Co-authored-by: vulcandth <vulcandth@gmail.com>
 2023-08-22 00:10:36 +00:00
vulcandth
6233de843d Improve mobile-related labels (#1061) 2023-07-27 01:00:15 +00:00
Rangi42
493db6b59a Use BattleAnim_Dummy in data/moves/animations.asm (#1052) 2023-06-22 20:16:45 +00:00
mid-kid
fe7b55cba4 IsMailEuropean → ParseMailLanguage (and give it constants) 2023-04-19 17:13:17 +00:00
mid-kid
956e68a2fc Minor battle tower fixes 2023-03-08 12:54:30 +00:00
mid-kid
560b13bc25 GetNicknamenamePointer -> GetNicknamePointer 
Found this commit on an old drive
 2023-02-26 11:29:35 +00:00
Rangi42
7dc5201189 Relabel some map_object struct fields (#1029) 2023-01-04 03:17:13 +00:00
Rangi42
7084008c7c Define InitDefaultEZChatMsgs and sEZChatMessages (#1022) 2022-12-26 18:56:06 +00:00
Rangi42
6f9d4e79ba wUnlockedUnowns engine_flag constants (#1025) 2022-12-26 18:15:14 +00:00
mid-kid
fe26f23ada .CheckNPC label and comment correction 2022-11-09 13:02:17 +00:00
Rangi42
1e4d38c746 Require rgbds 0.6.0 2022-10-03 02:08:11 +00:00
vulcandth
13fa9dd220 Fix Typo: GoldenrodPokecomCenterSaveBeforeTradeCornetText -> GoldenrodPokecomCenterSaveBeforeTradeCornerText 2022-09-25 01:05:16 +00:00
Rangi42
fd0e3fa9e5 Dance Theatre -> Dance Theater 
Fixes #1008
 2022-09-24 02:11:31 +00:00
vulcandth
40b5481d61 Some Mobile code labeling and removed magic numbers (#993) 
* Macro loop for EmptyAllSRAMBanks

* Many things labeled and magic numbers removed

* Conform to the style guide

* Rename URLs in mobile_46

* MOBILEAPI_19 -> MOBILEAPI_TELEPHONESTATUS

* Update engine/menus/empty_sram.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Update ram/wram.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Update mobile/mobile_46.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Update mobile/mobile_46.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Remove underscore from Set*DownloadURL symbols

* Begin Labeling TradeCornerHoldMon routines

* Add wMobileMon party_struct

* Add TRADE_CORNER_REQUEST_LENGTH constant

* Name battle tower action functions

* Label trade corner send/receive buffer

* Label the saved copy of the trade corner pokemon

also fix mailmsg_jp

* So many copies of decodeBase64Character

* Label another buffer

* Fix Alignment and use MOBILE_EMAIL_LENGTH

* `Function11ad8a` -> `MobileIncJumptableIndex`

* Apply Rangi Suggestions pass 1

Co-Authored-By: Rangi <35663410+Rangi42@users.noreply.github.com>

* Apply Suggestions 2

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
Co-authored-by: vulcandth <vulcandth@gmail.com>
 2022-09-15 00:50:56 +00:00
Rangi42
3e3999df67 Rename the object_struct field labels and constants (#1005) 
Fixes #990
 2022-09-12 13:16:53 +00:00
mid-kid
eaa4fea005 Use RS Group offset constants for slot_reel 
Co-Authored-By: Rangi <35663410+Rangi42@users.noreply.github.com>
 2022-09-05 10:18:34 +00:00
Rangi42
fb34151250 Use for loops to generate box pointer tables 
Fixes #996
 2022-08-31 22:06:49 +00:00
Rangi42
c6f153247f Refer to "Rival", not "Silver" (#983) 
Fixes #982
 2022-08-11 01:25:51 +00:00
Rangi42
062afea5b4 Rename scene and callback labels (#981) 
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
 2022-08-09 22:05:14 +00:00
Rangi42
79227f894f Define scene constants alongside scene_scripts (#979) 
Generic SCENE_DEFAULT and SCENE_FINISHED are legacy values
 2022-07-29 21:44:12 +00:00
Rangi42
2bfaeb00fb wVirtualOAM -> wShadowOAM and hTransferVirtualOAM -> hTransferShadowOAM (#971) 2022-07-09 21:19:17 +00:00
vulcandth
abc5348045 Clean up bugs commented in the source code (#912) 
Co-authored-by: Rangi <remy.oukaour+rangi42@gmail.com>
 2022-07-09 21:13:07 +00:00
Rangi42
4449b43617 Split "gfx anims" into "pic anims" and "sprite anims" 
Fixes #876
 2022-07-04 05:12:51 +00:00
mid-kid
eb8cba4a5e VC ExchangeBytes Aliases 
Co-Authored-By: aaaaaa123456789 <aaaaaa123456789@acidch.at>
 2022-06-21 09:17:21 +00:00
Rangi42
3424d1d5ef MobileCheckOwnMonAnywhere & CheckOwnMonAnywhere Label, comments, formatting (#927) 
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
 2022-06-18 03:22:08 +00:00
Rangi42
8c7428c0ec Improved Virtual Console patch identifiers (#907) 2022-06-06 21:23:45 +00:00
Rangi42
6c86c34fc7 Fix misspelled label (#904) 2022-04-17 15:37:21 +00:00
Rangi42
af75d534c3 Additional vc_asserts (#906) 2022-04-17 00:42:57 +00:00
Rangi42
1c82113d9a Allow alternate labels for patch names 2022-03-13 03:40:54 +00:00
Rangi42
53767bced8 Build the Virtual Console patch with make crystal11_vc (#882) 
Fixes #813
 2022-03-12 23:35:04 +00:00
Rangi42
a9533a6e12 Rename GetPokedexEntryBank to HeavyBall_GetDexEntryBank 2022-02-22 22:17:00 +00:00
Rangi42
6f1aa93707 Clear however many bytes are needed for wFruitTreeFlags 2022-02-14 22:29:52 +00:00
Rangi42
1132586e06 Fixed IlexForestKurtStepsDownMovement capitalization typo (#877) 2022-02-13 18:41:33 +00:00