mirror of
https://github.com/Xeeynamo/sotn-decomp.git
synced 2024-12-01 00:40:51 +00:00
4d4c039ac4
When using the `dec` script, it is possible to select a function where there are multiple functions sharing a name. The test case I had for this was `EntityEquipItemDrop`. If you run `dec EntityEquipItemDrop`, it will tell you that there are 4 occurrences of functions with that name, and list the four, telling you to re-run with -n or -f to specify which. If you choose to specify option #0, with `dec EntityEquipItemDrop -n 0`, then the number_occurence variable will be set to zero. But the if-statement `if number_occurrence` fails, because the value is zero, which is parsed as False. Decompilation therefore fails, as if you had not passed `-n`. This change explicitly tests for None, so that zero is a valid selection. |
||
|---|---|---|
| .. | ||
| asm-differ@f5fc9026f0 | ||
| dups | ||
| function_finder | ||
| gfxsotn | ||
| lints/sotn-lint | ||
| m2c@4ee07ea6b0 | ||
| maspsx@db2947b709 | ||
| mwccgap@63417712bc | ||
| n64splat@828c34950b | ||
| saturn-splitter@8d549a8042 | ||
| sotn_str | ||
| sotn-debugmodule | ||
| sotn-disk | ||
| splat_ext | ||
| split_jpt_yaml | ||
| vab-ex | ||
| analyze_calls.py | ||
| bin2c.py | ||
| decompile.py | ||
| dirt_patcher.py | ||
| gfxstage.py | ||
| m2ctx.py | ||
| permuter_settings.toml | ||
| png2bin.py | ||
| png2s.py | ||
| progress.py | ||
| requirements-debian.txt | ||
| requirements-python.txt | ||
| richter_symbols.py | ||
| spritesheet.py | ||
| symbols_test.py | ||
| symbols.py | ||
| tools.mk | ||
| update.h | ||