mirror of
https://github.com/Heretek-AI/open-code-review.git
synced 2026-11-07 10:56:07 -10:00
超級の新人andKite
e96c79d4d6
Add an independent stdio ACP adapter with slash commands, optional natural-language parsing, managed review/scan processes, CI, and multilingual setup docs. Keep the OCR CLI source and prompts unchanged. * refactor(acp): add ACP adapter and supporting services * ci(acp): use patched Go toolchain * docs(acp): trim support caveats and sync CI notes Drop dated verification claims and the prebuilt-binary disclaimer so the adapter docs match the current local-build story and acp-ci.yml. Co-authored-by: Kite <[email protected]>
94 lines
3.4 KiB
Makefile
94 lines
3.4 KiB
Makefile
.PHONY: build test check coverage license-check english-check clean
|
|
|
|
# Minimum total statement coverage enforced by `make coverage`.
|
|
# Mirrors COVERAGE_THRESHOLD in the repository root Makefile.
|
|
COVERAGE_MIN ?= 90
|
|
|
|
# Windows GitHub-hosted and native desktops often lack a C toolchain. The race
|
|
# detector needs cgo there, so Unix keeps -race and Windows matches root CI.
|
|
ifeq ($(OS),Windows_NT)
|
|
ACP_BIN ?= ../dist/ocr-acp.exe
|
|
GOTESTFLAGS ?= -v -count=1
|
|
GOCOVERFLAGS ?= -count=1
|
|
# Unix-only tests are omitted by build tags, so native Windows coverage is
|
|
# informational. Linux ACP CI remains the 90% gate.
|
|
COVERAGE_GATE ?= 0
|
|
else
|
|
ACP_BIN ?= ../dist/ocr-acp
|
|
GOTESTFLAGS ?= -v -race -count=1
|
|
GOCOVERFLAGS ?= -race -count=1
|
|
COVERAGE_GATE ?= 1
|
|
endif
|
|
|
|
build:
|
|
go build -o $(ACP_BIN) ./cmd/ocr-acp
|
|
|
|
test:
|
|
LC_ALL=C go test $(GOTESTFLAGS) ./...
|
|
|
|
# Unlike the root `check`, which formats in place with `gofmt -s -w .`, this
|
|
# one fails on unformatted files instead of fixing them, so it can run as a
|
|
# gate. `gofmt -s` matches the flag CI uses.
|
|
check: license-check english-check
|
|
@unformatted=$$(gofmt -s -l .); \
|
|
if [ -n "$$unformatted" ]; then \
|
|
echo "gofmt: the following files need formatting (run 'gofmt -s -w .'):"; \
|
|
echo "$$unformatted"; \
|
|
exit 1; \
|
|
fi
|
|
LC_ALL=C go vet ./...
|
|
@sc=$$(command -v staticcheck || echo "$$(go env GOPATH)/bin/staticcheck"); \
|
|
if [ ! -x "$$sc" ]; then \
|
|
echo "staticcheck: not installed, SKIPPED (CI installs it; see .github/workflows/acp-ci.yml)"; \
|
|
exit 0; \
|
|
fi; \
|
|
out=$$("$$sc" ./... 2>&1); \
|
|
status=$$?; \
|
|
printf '%s\n' "$$out"; \
|
|
if printf '%s' "$$out" | grep -q 'matched no packages'; then \
|
|
echo "staticcheck: analyzed no packages; refusing to report a pass."; \
|
|
echo "staticcheck 0.8.x requires a Go >= 1.26 toolchain, but this module declares go 1.23."; \
|
|
exit 1; \
|
|
fi; \
|
|
exit $$status
|
|
|
|
coverage:
|
|
# Include dependencies exercised by cross-package integration tests.
|
|
LC_ALL=C go test $(GOCOVERFLAGS) -coverpkg=./... -coverprofile=coverage.out ./...
|
|
@actual=$$(go tool cover -func=coverage.out | awk '/^total:/ {gsub(/%/, "", $$3); print $$3}'); \
|
|
awk -v actual="$$actual" -v minimum="$(COVERAGE_MIN)" -v gate="$(COVERAGE_GATE)" 'BEGIN { \
|
|
if (actual == "") { \
|
|
print "FAIL: could not parse total coverage from coverage.out"; \
|
|
exit 1; \
|
|
} \
|
|
printf "total coverage: %s%% (minimum: %s%%)\n", actual, minimum; \
|
|
if (gate != 0 && actual + 0 < minimum + 0) { \
|
|
print "FAIL: coverage is below the minimum"; \
|
|
exit 1; \
|
|
} \
|
|
if (gate == 0 && actual + 0 < minimum + 0) { \
|
|
print "coverage gate skipped on this OS (Unix-only tests omitted)"; \
|
|
} \
|
|
}'
|
|
|
|
# verify-license.sh takes no path argument and always scans the whole repository
|
|
# via `git ls-files`, so this checks more than just the acp module.
|
|
license-check:
|
|
@bash ../scripts/verify-license.sh
|
|
|
|
# Running from this module scopes git ls-files to its files. A missing script is a
|
|
# hard failure: this module lives inside the OCR repository, so the script is
|
|
# always expected to be there, and silently skipping would let `make check`
|
|
# exit 0 without having verified anything.
|
|
english-check:
|
|
@if [ ! -f ../scripts/verify-english-only.go ]; then \
|
|
echo "english-check: ../scripts/verify-english-only.go is missing"; \
|
|
exit 1; \
|
|
fi
|
|
go run ../scripts/verify-english-only.go
|
|
|
|
clean:
|
|
rm -f coverage.out
|
|
rm -f testdata/mock-ocr/mock-ocr testdata/mock-ocr/mock-ocr.exe
|
|
rm -f ../dist/ocr-acp ../dist/ocr-acp.exe
|