This reverts commit d96e9bd92c.
Revert "Bug 1993543 - Change XPCOMUtils.defineLazyServiceGetter(s) calls to pass an nsIID rather than a string. r=firefox-desktop-core-reviewers ,mtigley,joschmidt,perftest-reviewers,home-newtab-reviewers,nbarrett,Gijs,sparky"
This reverts commit 024c584172.
This flag was only used by the allocation tracker test and we can now rely on the
DevTools global spawn by mozJSModuleLoader.
Differential Revision: https://phabricator.services.mozilla.com/D253049
The 'invisibleToDebugger' flag was misleading and making all Loaders be indebuggable on xcpshell.
But we have to keep spawning the xpcshell's DevToolsServer in the distinct "devtools" global
in order to be able to debug the tests and devtools globals now all spawn in the shared system global.
Differential Revision: https://phabricator.services.mozilla.com/D252530
This reverts commit 6056567c3e.
Revert "Bug 1958081 - [devtools] Migrate object inspector to the new JS objects test framework. r=devtools-reviewers,nchevobbe"
This reverts commit 8cbc65e7b5.
Revert "Bug 1958081 - [devtools] Introduce a test framework to ease testing all possible JavaScript types against various codebases. r=frontend-codestyle-reviewers,devtools-reviewers,nchevobbe,Standard8" for causing xpc failures at test_javascript_logging.js
This reverts commit ddcbf73cd8.
Also introduce a temporary workaround in the base loader to force loading
the available ESM from vendor.
This will prevent significantly increasing firefox installer size.
All the duplicated ESM modules are removed from Firefox package,
but some are kept in-tree for some jest tests which can't use ESM.
Differential Revision: https://phabricator.services.mozilla.com/D239055
This is required as Object Inspector has to be loaded via a document scope
for its ChromeUtils.importESModule + global="current" to be functional.
Differential Revision: https://phabricator.services.mozilla.com/D237739
Land ES Modules for all React modules.
Also tweak the Browser Loader to force loading react loaded via require() to use the ES Modules.
This helps ensure these modules are loaded only once and always as a ES Module.
Otherwise require() statements from debugger frontend and import from Reps may load
distinct instances.
Differential Revision: https://phabricator.services.mozilla.com/D228995
These modules are already loaded by the Debugger frontend via the browser loader
instantiated in /index.js and we were loading a copy in the shared global loader.
This also helps the esm-ification of Reps as it ensures loading
all debugger modules in the debugger document global.
Reps modules are expected to be loaded with a document as global scope.
Differential Revision: https://phabricator.services.mozilla.com/D237738
Display requests in the netmonitor for data URIs.
Currently, some data-uris are leaking from internal stylesheets such as resource://gre-resources/html.css but this should hopefully be rare.
Another bug has been filed to properly filter out those requests.
A simple test is added to make sure we can see parent process and content process data uris.
Differential Revision: https://phabricator.services.mozilla.com/D217413
Display requests in the netmonitor for data URIs.
Currently, some data-uris are leaking from internal stylesheets such as resource://gre-resources/html.css but this should hopefully be rare.
Another bug has been filed to properly filter out those requests.
A simple test is added to make sure we can see parent process and content process data uris.
Differential Revision: https://phabricator.services.mozilla.com/D217413
Note that the ignore code for subprocess is being ported from the legacy worker watcher.
The Worker Target URL is now correctly set to the Absolute URL,
this has an impact on the context selector as we are displaying it.
Also, this patch highlights some issues around Common JS Loader and the distinct compartment
to be used when debugging privileged page, or when running the browser toolbox.
It caused leaks when running browser toolbox tests in debug builds.
The JS Process Actor is directly loaded in a distinct global and compartment "DevTools global",
thanks to `loadInDevToolsLoader` flag of BrowserToolboxDevToolsProcess JS Process Actor configuration.
There is no need to use `useDistinctSystemPrincipalLoader` helper as Loader.sys.mjs, loaded from
the JS Process Actor will also be loaded in the distinct global.
Then, we only need to ensure that the CommonJS Loader will also pick up the "DevTools global"
when it is loaded in that distinct global.
Things will be significantly easier once we migrate from CommonJS to ESM as the `{ global: "contextual" }`
option passed to `ChromeUtils.importESModule` will do the right thing, as well as static `import` statements.
Differential Revision: https://phabricator.services.mozilla.com/D204874
Note that the ignore code for subprocess is being ported from the legacy worker watcher.
The Worker Target URL is now correctly set to the Absolute URL,
this has an impact on the context selector as we are displaying it.
Also, this patch highlights some issues around Common JS Loader and the distinct compartment
to be used when debugging privileged page, or when running the browser toolbox.
It caused leaks when running browser toolbox tests in debug builds.
The JS Process Actor is directly loaded in a distinct global and compartment "DevTools global",
thanks to `loadInDevToolsLoader` flag of BrowserToolboxDevToolsProcess JS Process Actor configuration.
There is no need to use `useDistinctSystemPrincipalLoader` helper as Loader.sys.mjs, loaded from
the JS Process Actor will also be loaded in the distinct global.
Then, we only need to ensure that the CommonJS Loader will also pick up the "DevTools global"
when it is loaded in that distinct global.
Things will be significantly easier once we migrate from CommonJS to ESM as the `{ global: "contextual" }`
option passed to `ChromeUtils.importESModule` will do the right thing, as well as static `import` statements.
Differential Revision: https://phabricator.services.mozilla.com/D204874
Note that the ignore code for subprocess is being ported from the legacy worker watcher.
Also, this patch highlights some issues around Common JS Loader and the distinct compartment
to be used when debugging privileged page, or when running the browser toolbox.
It caused leaks when running browser toolbox tests in debug builds.
The JS Process Actor is directly loaded in a distinct global and compartment "DevTools global",
thanks to `loadInDevToolsLoader` flag of BrowserToolboxDevToolsProcess JS Process Actor configuration.
There is no need to use `useDistinctSystemPrincipalLoader` helper as Loader.sys.mjs, loaded from
the JS Process Actor will also be loaded in the distinct global.
Then, we only need to ensure that the CommonJS Loader will also pick up the "DevTools global"
when it is loaded in that distinct global.
Things will be significantly easier once we migrate from CommonJS to ESM as the `{ global: "contextual" }`
option passed to `ChromeUtils.importESModule` will do the right thing, as well as static `import` statements.
Differential Revision: https://phabricator.services.mozilla.com/D204874
Sylvestre Ledru