41 Commits
Author SHA1 Message Date
Gijs Kruitbosch 3288f177a4 Bug 1780071 - autofix devtools/ violations of no-comparison-or-assignment-inside-ok r=profiler-reviewers,devtools-reviewers,julienw,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D198975
2024-01-26 13:12:07 +00:00
Alexandre Poirot c158bae2fa Bug 1836856 - [devtools] Drop support of DevToolsClient.request's second onResponse argument. r=devtools-reviewers,bomsy
This is no longer used. The returned promise should be used instead.

There was also some old lefovers in WebConsole Front related to network events.
As we no longer have legacy listeners, this is no longer used.
The frontend code now uses DevToolsClient.request directly to query the NetworkEventActor's.

Differential Revision: https://phabricator.services.mozilla.com/D180980
2023-06-26 11:08:46 +00:00
Sandor Molnar 49cbc9e36b Backed out 3 changesets (bug 1836856) for causing mochitest failures in devtools/shared/webconsole/test/chrome/test_network_security-hsts.html CLOSED TREE
Backed out changeset 636272515c00 (bug 1836856)
Backed out changeset 0fe632ebb487 (bug 1836856)
Backed out changeset 6850948b14c0 (bug 1836856)
2023-06-23 14:36:31 +03:00
Alexandre Poirot e92e641b51 Bug 1836856 - [devtools] Drop support of DevToolsClient.request's second onResponse argument. r=devtools-reviewers,bomsy
This is no longer used. The returned promise should be used instead.

There was also some old lefovers in WebConsole Front related to network events.
As we no longer have legacy listeners, this is no longer used.
The frontend code now uses DevToolsClient.request directly to query the NetworkEventActor's.

Differential Revision: https://phabricator.services.mozilla.com/D180980
2023-06-23 08:22:04 +00:00
Mark Banner 0666077666 Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu
Differential Revision: https://phabricator.services.mozilla.com/D177027
2023-05-20 12:26:53 +00:00
Mark Banner 91fde42f7b Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish
Differential Revision: https://phabricator.services.mozilla.com/D177025
2023-05-20 12:26:49 +00:00
Alexandre Poirot 07e6ce0083 Bug 1792848 - [devtools] Use absolute URLs to import modules in devtools/shared. r=Honza,devtools-backward-compat-reviewers,bomsy
Differential Revision: https://phabricator.services.mozilla.com/D158643
2022-10-12 15:56:22 +00:00
Mark Banner 3387a89bc7 Bug 1786197 - Turn on ESLint rule for prefer-boolean-length-check for devtools. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D155167
2022-08-26 13:39:34 +00:00
Alexandre Poirot 8caa39da10 Bug 1693269 - [devtools] Use descriptor directly instead of pulling it via current target. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D108811
2021-05-25 08:02:10 +00:00
Alexandre Poirot f3b6620342 Bug 1701790 - Migrate ResourceWatcher to become ResourceCommand. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D113930
2021-05-04 09:29:47 +00:00
Brindusan Cristian d5be5fbb54 Backed out 5 changesets (bug 1701790) for bc failures in browser_ext_devtools_network_targetSwitch.js. CLOSED TREE
Backed out changeset 3fc4edd663d9 (bug 1701790)
Backed out changeset 2d3ea7c0d695 (bug 1701790)
Backed out changeset 6cb7502fc1a2 (bug 1701790)
Backed out changeset 8f4205a1a369 (bug 1701790)
Backed out changeset bd3c9b1482c7 (bug 1701790)
2021-05-03 22:21:59 +03:00
Alexandre Poirot b007493360 Bug 1701790 - Migrate ResourceWatcher to become ResourceCommand. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D113930
2021-05-03 18:07:30 +00:00
Alexandre Poirot fbef84abf9 Bug 1696374 - [devtools] Rename targetList to targetCommand in tests. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D110380
2021-04-12 07:59:50 +00:00
Alexandre Poirot 4dc42a1891 Bug 1699200 - [devtools] Create all commands via a CommandsFactory module. r=nchevobbe,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D109494
2021-03-25 16:02:32 +00:00
Alexandre Poirot d0cb4d3694 Bug 1693491 - [devtools] Migrate TargetList to be a command r=nchevobbe,rpl
This changeset is incomplete and focus on places where we instantiate TargetList constructor

Differential Revision: https://phabricator.services.mozilla.com/D105611
2021-03-11 12:53:18 +00:00
Julian Descottes 8ab5293a02 Bug 1694886 - [devtools] Extract test helper getTargetForTab(tab) to shared-head.js r=nchevobbe
Depends on D106037

Differential Revision: https://phabricator.services.mozilla.com/D106405
2021-02-25 18:02:54 +00:00
Brindusan Cristian ae215d4017 Backed out 10 changesets (bug 1694140, bug 1694886, bug 1688688) for devtools failures on browser_CORS-console-warnings.js. CLOSED TREE
Backed out changeset 1b7367a27d9a (bug 1694886)
Backed out changeset d5a70a3143ad (bug 1694140)
Backed out changeset 74adaced5c0a (bug 1694140)
Backed out changeset 0b8f857e3f90 (bug 1694140)
Backed out changeset 45a8dc952aba (bug 1694140)
Backed out changeset 299f17e9cb6f (bug 1694140)
Backed out changeset 6beb9dd48ef3 (bug 1694140)
Backed out changeset 5f6688e8fe4c (bug 1694140)
Backed out changeset ae1fa0484c91 (bug 1688688)
Backed out changeset 8a0f5c24ed9a (bug 1688688)
2021-02-25 16:07:39 +02:00
Julian Descottes ba68832a5b Bug 1694886 - [devtools] Extract test helper getTargetForTab(tab) to shared-head.js r=nchevobbe
Depends on D106037

Differential Revision: https://phabricator.services.mozilla.com/D106405
2021-02-25 12:58:16 +00:00
Alexandre Poirot 15d320c4f0 Bug 1692874 - [devtools] Use descriptors instead of targets in TargetList/Toolbox r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D105200
2021-02-18 18:36:47 +00:00
Nicolas Chevobbe 77e2422505 Bug 1686723 - [devtools] Observe network activity from resourceWatcher instead of webconsole listener. r=bomsy.
This patch switches all the calls to `startListeners["NetworkActivity"]` to watching
for network resources instead.
We take this opportunity to refactor them to improve readability.

Differential Revision: https://phabricator.services.mozilla.com/D102700
2021-01-27 14:38:37 +00:00
smolnar 2431d95728 Backed out 2 changesets (bug 1686723) for causing failures in browser_network_throttling. CLOSED TREE
Backed out changeset 1471a0e93735 (bug 1686723)
Backed out changeset 1c4e9624bd68 (bug 1686723)
2021-01-27 15:35:52 +02:00
Nicolas Chevobbe 9a10956c26 Bug 1686723 - [devtools] Observe network activity from resourceWatcher instead of webconsole listener. r=bomsy.
This patch switches all the calls to `startListeners["NetworkActivity"]` to watching
for network resources instead.
We take this opportunity to refactor them to improve readability.

Differential Revision: https://phabricator.services.mozilla.com/D102700
2021-01-27 12:52:20 +00:00
Alexandre Poirot 3a1e91e072 Bug 1675256 - [devtools] Remove discardRequestBody and discardResponseBody attributes of NETWORK_EVENT resource. r=bomsy,devtools-backward-compat-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D95846
2020-11-04 17:14:03 +00:00
Alexandre Poirot 1ea1a546f1 Bug 1614791 - Rename DebuggerServer to DevToolsServer. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D61363
2020-02-17 10:28:24 +00:00
Nicolas Chevobbe 2f8b59dc62 Bug 1566850 - Remove target.activeConsole usage in tests. r=ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D56688
2019-12-13 13:58:54 +00:00
Kris Maglione 8c0d38f33d Bug 1596918: Part 3a - Scripted rewrite of most ContentTask.spawn calls to SpecialPowers.spawn calls. r=mccr8,remote-protocol-reviewers,ato
This is generally pretty straightforward, and rewrites nearly all calls. It
skips the ones that it can detect using frame script globals like
`sendAsyncMessage`, though.

Differential Revision: https://phabricator.services.mozilla.com/D53740
2019-12-13 20:36:16 +00:00
shindli 9969261559 Backed out 8 changesets (bug 1566850, bug 1603035) for causing perma bc failures in browser/components/extensions/test/browser/browser_ext_devtools_inspectedWindow.js CLOSED TREE
Backed out changeset da1672f831d1 (bug 1566850)
Backed out changeset b3aea303d3ed (bug 1566850)
Backed out changeset 3c8ef35fde92 (bug 1566850)
Backed out changeset 4deadf97378f (bug 1566850)
Backed out changeset 55ac64d74725 (bug 1566850)
Backed out changeset 33c4706a4255 (bug 1566850)
Backed out changeset 1796a39b020b (bug 1566850)
Backed out changeset ae02ae71f846 (bug 1603035)
2019-12-13 12:50:45 +02:00
Nicolas Chevobbe b25e763547 Bug 1566850 - Remove target.activeConsole usage in tests. r=ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D56688
2019-12-13 09:10:33 +00:00
shindli 0aa47af90e Backed out 9 changesets (bug 1596918) for causing mochitest permafailures in toolkit/content/tests/chrome/test_findbar_events.xhtml CLOSED TREE
Backed out changeset 45a1c42118f2 (bug 1596918)
Backed out changeset db09910ffa56 (bug 1596918)
Backed out changeset 5c9d9f141c10 (bug 1596918)
Backed out changeset 6a135670d603 (bug 1596918)
Backed out changeset 3a0184e0df72 (bug 1596918)
Backed out changeset 2f0036486823 (bug 1596918)
Backed out changeset a770c6d08d52 (bug 1596918)
Backed out changeset ef062eb7a6ee (bug 1596918)
Backed out changeset a6ea596e98db (bug 1596918)
2019-12-11 03:09:26 +02:00
Kris Maglione ad3537fc50 Bug 1596918: Part 3a - Scripted rewrite of most ContentTask.spawn calls to SpecialPowers.spawn calls. r=mccr8,remote-protocol-reviewers,ato
This is generally pretty straightforward, and rewrites nearly all calls. It
skips the ones that it can detect using frame script globals like
`sendAsyncMessage`, though.

Differential Revision: https://phabricator.services.mozilla.com/D53740
2019-12-10 23:07:13 +00:00
Noemi Erli 21eec8658f Backed out 9 changesets (bug 1596918) for causing multiple browser-chrome failures
Backed out changeset 415007efd8c9 (bug 1596918)
Backed out changeset 011eb5ce927b (bug 1596918)
Backed out changeset e5fd3ee22ea1 (bug 1596918)
Backed out changeset 0bca4de31d40 (bug 1596918)
Backed out changeset 11ec4393f23d (bug 1596918)
Backed out changeset c5404a7c286d (bug 1596918)
Backed out changeset 7e9304405a46 (bug 1596918)
Backed out changeset fa0f0aeabf99 (bug 1596918)
Backed out changeset de196b077000 (bug 1596918)
2019-12-07 22:26:43 +02:00
Kris Maglione 88fbf261f8 Bug 1596918: Part 3a - Scripted rewrite of most ContentTask.spawn calls to SpecialPowers.spawn calls. r=mccr8,remote-protocol-reviewers,ato
This is generally pretty straightforward, and rewrites nearly all calls. It
skips the ones that it can detect using frame script globals like
`sendAsyncMessage`, though.

Differential Revision: https://phabricator.services.mozilla.com/D53740
2019-12-07 19:11:58 +00:00
Daniel Varga 85f263a4c2 Backed out 17 changesets (bug 1596918) for multiple browser-chrome and dev-tools failures. On a CLOSED TREE
Backed out changeset ab87d2c1afae (bug 1596918)
Backed out changeset 775f3b06a687 (bug 1596918)
Backed out changeset 67cc63ef5d7f (bug 1596918)
Backed out changeset 7d290bcd2067 (bug 1596918)
Backed out changeset 048db9f4db7c (bug 1596918)
Backed out changeset 96a79d2ba614 (bug 1596918)
Backed out changeset be770d112dd8 (bug 1596918)
Backed out changeset 302c8ab8391c (bug 1596918)
Backed out changeset 44ef8f20732e (bug 1596918)
Backed out changeset 38c11ebfb8ff (bug 1596918)
Backed out changeset b586fc081374 (bug 1596918)
Backed out changeset 12283166716f (bug 1596918)
Backed out changeset 99b0421015d8 (bug 1596918)
Backed out changeset 97ec49dbbbf3 (bug 1596918)
Backed out changeset ec79478f58f1 (bug 1596918)
Backed out changeset c6d356833bb8 (bug 1596918)
Backed out changeset 5ef6026806c8 (bug 1596918)
2019-12-07 03:12:07 +02:00
Kris Maglione e59706f08a Bug 1596918: Part 3a - Scripted rewrite of most ContentTask.spawn calls to SpecialPowers.spawn calls. r=mccr8,remote-protocol-reviewers,ato
This is generally pretty straightforward, and rewrites nearly all calls. It
skips the ones that it can detect using frame script globals like
`sendAsyncMessage`, though.

Differential Revision: https://phabricator.services.mozilla.com/D53740
2019-12-06 22:14:14 +00:00
Nicolas Chevobbe f28da82b5c Bug 1589001 - Rename (web)consoleClient variables and properties to webConsoleFront. r=Honza.
The webconsole actor now has an associated front for some
time, but the naming of variables and properties didn't
reflect that (most weren't updated and were still calling
it a client).
This patch tries to rename all those variables so it's more
obvious we're dealing with an actual front.

Differential Revision: https://phabricator.services.mozilla.com/D49401
2019-10-17 10:16:46 +00:00
Nicolas Chevobbe 290ba5cb21 Bug 1568779 - Remove editors settings comments in devtools files. r=pbro.
Differential Revision: https://phabricator.services.mozilla.com/D42300
2019-08-19 12:48:16 +00:00
Julian Descottes c632e13c61 Bug 1572390 - Split main.js in debugger-server and debugger-server-connection r=yulia,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D41009
2019-08-08 12:44:13 +00:00
Victor Porof 435f7b056d Bug 1561435 - Format remaining devtools/, a=automatic-formatting, CLOSED TREE
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D35894
2019-07-05 11:29:32 +02:00
yulia d6c65c3294 Bug 1042642 - use EventEmitter instead of eventSource on the DebuggerClient; r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D29371
2019-05-29 15:51:28 +00:00
yulia 53d216ad5e Bug 1485664 - adjust events to front events; r=ochameau
this patch introduces events for the webconsoleFront -- not all of them are being listened
to by their subscribers yet, but this is the bulk of the effort to move events to Protocol.js

Differential Revision: https://phabricator.services.mozilla.com/D18832
2019-02-20 10:49:09 +00:00
Alexandre Poirot 7b12165a46 Bug 1520782 - Convert console tests using chrome documents and using server references directly to browser mochitests. r=nchevobbe
These two tests were using chrome mochitest which forces the test page to be running in chrome and in parent process.
This doesn't reflect typical setup where the page runs unprivileged in content process.
Also, with the current bug, the pages running in system principal will be debugged with a special setup.
Actors will be run with modules loaded in a distinct loader in order to be executed
in a distinct compartment, distinct from the shared system principal compartment.
That a prerequisite for the Debugger API. It has to run in a distinct compartment than its debuggee.

Depends on D16826

Differential Revision: https://phabricator.services.mozilla.com/D16827
2019-01-23 08:53:06 +00:00