This reverts commit 446248523d.
Revert "Bug 1369833 - Part 4: Use initWithObject instead of showAlertNotification in browser/ r=firefox-desktop-core-reviewers ,Gijs"
This reverts commit 9ee3a6db7f.
Revert "Bug 1369833 - Part 3: Remove unused showAlertNotification in dom/notification/test r=asuth"
This reverts commit 153cd95271.
Revert "Bug 1369833 - Part 2: Use initWithObject instead of showAlertNotification for WebExtensions r=extension-reviewers,willdurand"
This reverts commit e36669b3f8.
Revert "Bug 1369833 - Part 1: Add a way to init with an object r=nalexander,tschuster"
This reverts commit 5e7addaf77.
D255956 started to close same-tagged notifications early and that caused test failure here. This introduces a way to tell that it's a close than error.
Differential Revision: https://phabricator.services.mozilla.com/D258261
This reverts commit c978036a73.
Revert "Bug 1948752 - Part 3: Add GeckoAppShell.onNotificationShow r=geckoview-reviewers,android-reviewers,m_kato,jonalmeida,geckoview-api-reviewers,nika"
This reverts commit 8ed24aa7d6.
Revert "Bug 1948752 - Part 2: Return Deferred<Boolean> from onShowNotification based on success result r=android-reviewers,jonalmeida"
This reverts commit 5546fa01fe.
D255956 started to close same-tagged notifications early and that caused test failure here. This introduces a way to tell that it's a close than error.
Differential Revision: https://phabricator.services.mozilla.com/D258261
D255956 started to close same-tagged notifications early and that caused test failure here. This introduces a way to tell that it's a close than error.
Differential Revision: https://phabricator.services.mozilla.com/D258261
D255956 started to close same-tagged notifications early and that caused test failure here. This introduces a way to tell that it's a close than error.
Differential Revision: https://phabricator.services.mozilla.com/D258261
I had a wrong assumption in D248312 that alertfinished will always be called by GeckoView, but turns out that each backend calls it immediately within CloseAlert implementation.
This aligns Android implementation with others, and bug 1975432 is filed for deduplication.
Differential Revision: https://phabricator.services.mozilla.com/D255956
Longer term we should move this tracking fully to nsAlertsService, but given that:
* currently it's different how each alert backend tracks notification (e.g. only Windows has IsPrivate() and macOS has separate lists for pending/active alerts)
* consolidating that would probably require bigger changes
it would be nice to first centralize how the teardown step is triggered and then try consolidating further. (See also bug 1953657.)
Differential Revision: https://phabricator.services.mozilla.com/D241477
MOZ_RUNINIT => initialized at runtime
MOZ_CONSTINIT => initialized at compile time
MOZ_GLOBINIT => initialized either at runtime or compile time, depending on template parameter, macro parameter etc
This annotation is only understood by our clang-tidy plugin. It has no
effect on regular compilation.
Differential Revision: https://phabricator.services.mozilla.com/D223341
This adds context to `CloseAlert()` such that explicitly closing the notification e.g. `notification.close()` can be differentiated from a tab or window implicitly closing the notification. This is necessary as we want notifications to persist after a tab or window is closed for Windows.
This change in behavior is necessary to match user expectations. Users expect notifications to persist in the system tray and do not expect notifications to be lost due to a tab being closed. The content of the message is more important than the interaction in that lens. This change is also necessary for parity with Chrome.
Differential Revision: https://phabricator.services.mozilla.com/D161024
Note that this patch only transforms the use of the nsDataHashtable type alias
to a directly equivalent use of nsTHashMap. It does not change the specification
of the hash key type to make use of the key class deduction that nsTHashMap
allows for in some cases. That can be done in a separate step, but requires more
attention.
Differential Revision: https://phabricator.services.mozilla.com/D106008
This makes the naming more consistent with other functions called
Insert and/or Update. Also, it removes the ambiguity whether
Put expects that an entry already exists or not, in particular because
it differed from nsTHashtable::PutEntry in that regard.
Differential Revision: https://phabricator.services.mozilla.com/D105473
Antonio Borondo