serge-sans-paille
f81328e365
Bug 2023519 - Make our codebase modernize-use-equals-default + modernize-use-equals-delete -safe wrt. clang-tidy r=sylvestre,necko-reviewers,media-playback-reviewers,profiler-reviewers,dom-storage-reviewers,layout-reviewers,dom-worker-reviewers,valentin,jesup,padenot,edenchuang,emilio
...
The changeset has been generated automatically through:
./mach static-analysis check --output ./clang-tidy-bugprone.json --format json --fix
followed by manual adjustment when needed or when the auto-fixer bailed out.
This paves the way for Bug 2023527
Differential Revision: https://phabricator.services.mozilla.com/D287941
2026-03-22 08:35:47 +00:00
Alexandru Marc
04e5f74151
Revert "Bug 2023519 - Make our codebase modernize-use-equals-default + modernize-use-equals-delete -safe wrt. clang-tidy r=sylvestre,necko-reviewers,media-playback-reviewers,profiler-reviewers,dom-storage-reviewers,layout-reviewers,dom-worker-reviewers,valentin,jesup,padenot,edenchuang,emilio"
...
This reverts commit a64dec2665 .
2026-03-19 17:29:58 +00:00
serge-sans-paille
a64dec2665
Bug 2023519 - Make our codebase modernize-use-equals-default + modernize-use-equals-delete -safe wrt. clang-tidy r=sylvestre,necko-reviewers,media-playback-reviewers,profiler-reviewers,dom-storage-reviewers,layout-reviewers,dom-worker-reviewers,valentin,jesup,padenot,edenchuang,emilio
...
The changeset has been generated automatically through:
./mach static-analysis check --output ./clang-tidy-bugprone.json --format json --fix
followed by manual adjustment when needed or when the auto-fixer bailed out.
This paves the way for Bug 2023527
Differential Revision: https://phabricator.services.mozilla.com/D287941
2026-03-18 17:25:01 +00:00
Sylvestre Ledru
eafe8b152d
Bug 2023419 - Remove Emacs/Vim modelines from accessible/ r=emilio
...
replaced by .editorconfig
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D287834
2026-03-18 10:29:47 +00:00
Serban Stanca
5a709d4a9a
Revert "Bug 2023419 - Remove Emacs/Vim modelines from accessible/ r=emilio" for causing mochitests failures in browser_action.js.
...
This reverts commit 2fa4815c8d .
2026-03-17 15:34:26 +00:00
Sylvestre Ledru
2fa4815c8d
Bug 2023419 - Remove Emacs/Vim modelines from accessible/ r=emilio
...
replaced by .editorconfig
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D287834
2026-03-17 09:21:51 +00:00
James Teh
b609a36524
Bug 1862802 part 5: Remove virtual cursor change event. r=eeejay
...
Depends on D192645
Differential Revision: https://phabricator.services.mozilla.com/D192646
2023-11-29 03:53:20 +00:00
Butkovits Atila
8d22d3874b
Backed out 5 changesets (bug 1862802) for causing multiple failures. CLOSED TREE
...
Backed out changeset 786805a2cdcc (bug 1862802)
Backed out changeset effe12f2120a (bug 1862802)
Backed out changeset 7488e7ba80c5 (bug 1862802)
Backed out changeset 3d0747ce0174 (bug 1862802)
Backed out changeset d1558d374cef (bug 1862802)
2023-11-29 03:10:17 +02:00
James Teh
2566c803eb
Bug 1862802 part 5: Remove virtual cursor change event. r=eeejay
...
Depends on D192645
Differential Revision: https://phabricator.services.mozilla.com/D192646
2023-11-28 22:03:21 +00:00
James Teh
ae4a562b81
Bug 412902: Remove unused accessibility events. r=eeejay
...
This removes the unused AccTableChangeEvent class, as well as the following unused event constants:
- EVENT_ACTIVE_DECENDENT_CHANGED
- EVENT_LOCATION_CHANGE
- EVENT_HELP_CHANGE
- EVENT_DEFACTION_CHANGE
- EVENT_ACTION_CHANGE
- EVENT_ACCELERATOR_CHANGE
- EVENT_FOREGROUND
- EVENT_CAPTURE_START
- EVENT_CAPTURE_END
- EVENT_MOVESIZE_START
- EVENT_MOVESIZE_END
- EVENT_CONTEXTHELP_START
- EVENT_CONTEXTHELP_END
- EVENT_DRAGDROP_END
- EVENT_DIALOG_START
- EVENT_DIALOG_END
- EVENT_MINIMIZE_START
- EVENT_MINIMIZE_END
- EVENT_DOCUMENT_ATTRIBUTES_CHANGED
- EVENT_DOCUMENT_CONTENT_CHANGED
- EVENT_PROPERTY_CHANGED
- EVENT_PAGE_CHANGED
- EVENT_TEXT_CHANGED
- EVENT_TEXT_UPDATED
- EVENT_VISIBLE_DATA_CHANGED
- EVENT_TEXT_COLUMN_CHANGED
- EVENT_SECTION_CHANGED
- EVENT_TABLE_CAPTION_CHANGED
- EVENT_TABLE_MODEL_CHANGED
- EVENT_TABLE_SUMMARY_CHANGED
- EVENT_TABLE_ROW_DESCRIPTION_CHANGED
- EVENT_TABLE_ROW_HEADER_CHANGED
- EVENT_TABLE_ROW_INSERT
- EVENT_TABLE_ROW_DELETE
- EVENT_TABLE_ROW_REORDER
- EVENT_TABLE_COLUMN_DESCRIPTION_CHANGED
- EVENT_TABLE_COLUMN_HEADER_CHANGED
- EVENT_TABLE_COLUMN_INSERT
- EVENT_TABLE_COLUMN_DELETE
- EVENT_TABLE_COLUMN_REORDER
- EVENT_WINDOW_CREATE
- EVENT_WINDOW_DESTROY
- EVENT_WINDOW_RESIZE
- EVENT_HYPERLINK_END_INDEX_CHANGED
- EVENT_HYPERLINK_NUMBER_OF_ANCHORS_CHANGED
- EVENT_HYPERLINK_SELECTED_LINK_CHANGED
- EVENT_HYPERTEXT_LINK_ACTIVATED
- EVENT_HYPERTEXT_LINK_SELECTED
- EVENT_HYPERLINK_START_INDEX_CHANGED
- EVENT_HYPERTEXT_CHANGED
- EVENT_HYPERTEXT_NLINKS_CHANGED
Differential Revision: https://phabricator.services.mozilla.com/D183709
2023-07-19 02:56:55 +00:00
Nathan LaPre
22e4c96a2b
Bug 1840732 Part 1: Remove unnecessary includes from accessible/base, r=Jamie
...
This revision removes unnecessary include directives from cpp files in the
accessible/base directory. These suggestions came from the Include What You Use
tool.
Differential Revision: https://phabricator.services.mozilla.com/D182288
2023-07-07 03:22:07 +00:00
Eitan Isaacson
f06c32d5d5
Bug 1839515 - Remove pivot text navigation API. r=Jamie
...
Differential Revision: https://phabricator.services.mozilla.com/D181576
2023-06-21 21:15:47 +00:00
Norisz Fay
63828a0456
Backed out changeset 8178c74a4c65 (bug 1839515) for causing mochitest failures on browser_events_vcchange.js
2023-06-21 22:21:29 +03:00
Eitan Isaacson
9abea69b99
Bug 1839515 - Remove pivot text navigation API. r=Jamie
...
Differential Revision: https://phabricator.services.mozilla.com/D181576
2023-06-21 17:55:06 +00:00
Andrew McCreight
188ac80e29
Bug 1805931, part 2 - Automated removal of uses of ROOT and UNROOT CC macros. r=smaug
...
As of the prior patch, these are no longer needed. I removed
these with a script, then ran clang-format on the files, then
manually reverted a few unrelated changed from the formatter.
Differential Revision: https://phabricator.services.mozilla.com/D164829
2022-12-15 19:45:01 +00:00
James Teh
14e0d69281
Bug 1794319: Remove a11y::EventTree, as it has been dead code for 6 years. r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D158918
2022-10-11 01:41:42 +00:00
Eitan Isaacson
a6eca0608e
Bug 1713050 - P2: Add granularity to a11y caret move events. r=morgan
...
Differential Revision: https://phabricator.services.mozilla.com/D139746
2022-03-16 05:56:25 +00:00
James Teh
c612403115
Bug 1741793 part 2: Update TextPoint/Range to use base Accessible. r=eeejay
...
Even though we'd ideally be using TextLeafRange for new things, TextRange is still needed by our selection events (which still use HyperText offsets) and IA2/ATK clients which depend on HyperText offsets.
Thus, we need TextRange to support RemoteAccessible.
Although the start and end containers are HyperTextAccessibles, I chose to store Accessible rather than HyperTextAccessibleBase because HyperTextAccessibleBase doesn't inherit from Accessible and having an Accessible is easier.
XPCOM needs to hold a reference to any state objects.
Because we can't hold a reference to an Accessible (due to RemoteAccessible), xpcAccessibleTextRange holds references to xpcAccessibleHyperText instead.
Differential Revision: https://phabricator.services.mozilla.com/D139341
2022-02-26 23:01:54 +00:00
James Teh
dd2cda5e5e
Bug 1741792 part 1: Cache the caret in the parent process using caret events. r=eeejay
...
As well as the caret offset, we also need to cache whether the caret is at the end of a line.
Therefore, this information has been added to caret events.
Differential Revision: https://phabricator.services.mozilla.com/D132097
2021-12-01 04:48:33 +00:00
Eitan Isaacson
c1ef28b8c2
Bug 1693597 - P1: Rename Accessible to LocalAccessible. r=morgan
...
Differential Revision: https://phabricator.services.mozilla.com/D105670
2021-02-19 23:14:32 +00:00
Eitan Isaacson
dd2f95aa73
Bug 1693607 - [Linux] Add braces around statements. r=morgan
...
This is a collaboration between clang-tidy and clang-format.
clang-tidy uses compiled code paths, so this patch is linux specific.
Differential Revision: https://phabricator.services.mozilla.com/D105669
2021-02-19 23:14:32 +00:00
Eitan Isaacson
7babc2c4be
Bug 1692523 - P1: Prefix local heirarchy functions with 'Local'. r=Jamie
...
Parent -> LocalParent
GetChildAt -> LocalChildAt
FirstChild -> LocalFirstChild
LastChild -> LocalLastChild
NextSibling -> LocalNextSibling
PrevSibling -> LocalPrevSibling
Differential Revision: https://phabricator.services.mozilla.com/D105034
2021-02-16 20:05:10 +00:00
Simon Giesecke
46908cfb51
Bug 1660470 - Add missing include directives/forward declarations. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D87865
2020-11-23 16:21:38 +00:00
Eitan Isaacson
403cbb9d71
Bug 1649217 - Part 3: Support isSelectionCollapsed in caret moved xpcom iface. r=Jamie
...
Differential Revision: https://phabricator.services.mozilla.com/D81913
2020-07-02 17:43:21 +00:00
Eitan Isaacson
ac190cfcb7
Bug 1647483 - Add a TextRange getter to text selection change events. r=Jamie
...
This includes 3 changes:
1. Add a lazy ranges getter to AccTextSelChangeEvent.
2. Create an XPCOM interface for testing purposes.
3. Add IPDL bindings for passing ranges in e10s.
Differential Revision: https://phabricator.services.mozilla.com/D80556
2020-06-23 18:52:42 +00:00
Edgar Chen
9ce65d9730
Bug 1578355 - Part 1: Move user-activation code from EventStateManager to UserActivation; r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D45168
2019-09-20 20:51:25 +00:00
Daniel Varga
0c8477fc87
Backed out 3 changesets (bug 1578355) for build bustage at build/src/dom/base/nsSyncLoadService.h:48:21. On a CLOSED TREE
...
Backed out changeset d50ad759f129 (bug 1578355)
Backed out changeset 339ab54ca471 (bug 1578355)
Backed out changeset 284299dac42c (bug 1578355)
2019-09-20 14:05:12 +03:00
Edgar Chen
91a465e33d
Bug 1578355 - Part 1: Move user-activation code from EventStateManager to UserActivation; r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D45168
2019-09-20 10:31:55 +00:00
Eitan Isaacson
d5cba17994
Bug 1525980 - Introduce nsIAccessibleAnnouncementEvent. r=Jamie
...
Differential Revision: https://phabricator.services.mozilla.com/D19060
2019-02-14 17:42:45 +00:00
Eitan Isaacson
19eed4f321
Bug 1527421 - Return scrolling xpc event interface in MakeXPCEvent. r=Jamie
...
Differential Revision: https://phabricator.services.mozilla.com/D19557
2019-02-13 00:37:39 +00:00
Sylvestre Ledru
e5a134f73a
Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
...
# ignore-this-changeset
2018-11-30 11:46:48 +01:00
Eitan Isaacson
9d7ce9a6ab
Bug 1479591 - Introduced accessibility scrolling event and interface. r=surkov
2018-08-15 13:07:00 -04:00
Cosmin Sabou
a649dc6fca
Backed out changeset dad95d849302 (bug 1479591) for causing linux debug leaks and security issues.
2018-08-15 04:39:43 +03:00
Eitan Isaacson
fa0caddf9b
Bug 1479591 - Introduced accessibility scrolling event and interface. r=surkov
2018-08-14 11:46:00 +03:00
Eitan Isaacson
852e77924d
Bug 1475087 - Include boundaryType in vc change event. r=surkov
2018-07-16 13:56:00 +03:00
Gurzau Raul
86ba10d043
Backed out changeset ed8baebfeb78 (bug 1475087) for Windows build bustages on mozilla/a11y/DocAccessibleParent.h on a CLOSED TREE
2018-07-16 23:20:28 +03:00
Eitan Isaacson
c51a12474e
Bug 1475087 - Include boundaryType in vc change event. r=surkov
2018-07-16 12:36:31 -07:00
Eitan Isaacson
45feaaed3c
Bug 1465823 - Add new position and offsets to pivot change notifications and vc events. r=surkov
2018-06-21 14:47:00 +03:00
Boris Zbarsky
57fa3783fa
Bug 1455676 part 2. Remove nsIDOMNode usage from accessible/. r=surkov
2018-05-29 22:58:47 -04:00
Nicholas Nethercote
a2fbdbef3a
Bug 1392993 - Change nsIAccessibleObjectAttributeChangedEvent.changedAttribute from an nsIAtom to an AString. r=MarcoZ.
...
This removes one use of nsIAtom within scripts, which is good (see bug
1392883). All the uses of this attribute within scripts just converted it to a
string anyway.
2017-08-24 17:19:09 +10:00
Trevor Saunders
35ea9597a7
bug 1270916 - allow keeping AccTreeMutation in a list r=davidb
...
Soon we will use the list to track the order of the events.
2016-11-16 23:46:51 -05:00
Wes Kocher
32887b4cd0
Backed out 12 changesets (bug 1270916) for a11y crashes a=backout CLOSED TREE
...
Backed out changeset 916cbaf21a63 (bug 1270916)
Backed out changeset 8ee47068d1fb (bug 1270916)
Backed out changeset 60189bf08272 (bug 1270916)
Backed out changeset 5ca49b5d1c51 (bug 1270916)
Backed out changeset b8ead1b86059 (bug 1270916)
Backed out changeset 034efc9a4408 (bug 1270916)
Backed out changeset a9d6410f068e (bug 1270916)
Backed out changeset eefa622b467a (bug 1270916)
Backed out changeset 91a8f65a69fe (bug 1270916)
Backed out changeset cd68b5fd88a6 (bug 1270916)
Backed out changeset 4c58195d6bcf (bug 1270916)
Backed out changeset 8e5f19f19b7f (bug 1270916)
2016-11-16 16:16:13 -08:00
Trevor Saunders
6f306e391d
bug 1270916 - allow keeping AccTreeMutation in a list r=davidb
...
Soon we will use the list to track the order of the events.
2016-11-16 18:15:21 -05:00
Iris Hsiao
88fdcfff49
Backed out changeset 10d579e5dec1 (bug 1270916)
...
CLOSED TREE
2016-11-16 14:42:12 +08:00
Trevor Saunders
5f1f55add4
bug 1270916 - allow keeping AccTreeMutation in a list r=davidb
...
Soon we will use the list to track the order of the events.
2016-11-16 01:17:39 -05:00
Alexander Surkov
e1a13d5866
Bug 1268320 - rename AccEvent::GetDocAccessible to AccEvent::Document, r=marcoz
2016-05-19 13:56:58 -04:00
Alexander Surkov
82d8b8a6d2
Bug 1261425 - coalesce mutation events by a tree structure, r=yzen
2016-04-07 09:30:22 -04:00
Trevor Saunders
51c6b28c0f
bug 1255009 - make AccShowEvent store the insertion index of the new child r=davidb
2016-03-28 09:09:22 -04:00
Nicholas Nethercote
4fab88afad
Bug 1232852 (part 3) - Remove unused parameters from some accessibility code. r=tbsaunde.
2015-12-15 21:24:06 -08:00
Alexander Surkov
31ede4d86d
Bug 1133213 - make aria-owns to alter the accessible tree, fire show/hide mutation events as we do for the accessible tree alterations, r=yzen, f=davidb
2015-09-15 12:01:51 -04:00