This makes significant changes to RelatedAccIterator, nsLabelsNodeList and nsContentList:
- RelatedAccIterator is now able to walk up shadow roots where appropriate.
- HTMLLabelsIterator now eagerly constructs a TreeOrderedArray of related elements, walking up shadow roots while the shadow root's reference target is either mAcc's content or a host of one of its ancestor shadow roots.
- nsLabelsNodeList now has an array of roots as well as mRootNode in the superclass nsContentList. This list is reset under certain conditions, adding each shadow root found by walking up from the labeled element until one is found which doesn't have either the labeled element or the host of one of its ancestor shadow roots as a reference target. The last element in this list is set as mRootNode in the superclass, and is either the containing document, or the subtree root of either the labeled element or the host element whose containing shadow root doesn't have it as a reference target. Each root has a mutation observer added to ensure that the list is marked dirty when necessary, and also that roots are removed from `mRoots` when they are destroyed.
- In order to enable nsLabelsNodeList to be a mutation observer for each root, nsContentList now inherits from nsStubMultiMutationObserver instead of nsStubMutationObserver.
This change also moves the ReferenceTargetChangeObserver-related methods from DocumentOrShadowRoot on to Element, and the related data structures on to nsExtendedDOMSlots.
It also introduces a distinction between GetControlForBindings, which returns an element in the same scope as the label element it's called on, and GetLabeledElementInternal, which returns the element which actually has the label element as its label.
Differential Revision: https://phabricator.services.mozilla.com/D261368
- Split `GetAttrAssociatedElements()` into `Internals` and `ForBindings` versions; the latter returns the shadow host(s) rather than an element inside shadow DOM
- Use `GetAttrAssociatedElementsInternal()` in `a11y::AssociatedElementsIterator`, removing the need for `AssociatedElementsIterator` to directly parse IDs or distinguish between ID-based or explicitly-set attr-associated elements.
- This required an update to `DocAccessible`'s `AddDependentIDsFor()` method which previously used `AssociatedElementsIterator`'s `NextID()` method, which is removed in this patch. `AddDependentIDsFor()` now uses the parsed attribute directly instead.
- In order to run the WPT tests which test `aria-labelledby` integration with `referenceTarget`, a new mechanism for retrieving elements inside shadow roots is added. This adds a `element_by_selector_array` action, which takes an array of selectors to be used successively from a document root to retrieve a shadow host, and then within the shadow host to retrieve the next shadow host, until the final selector returns the desired element.
Differential Revision: https://phabricator.services.mozilla.com/D261366
The existing `Element::GetAttrAssociatedElements()` and its internal lambda (which the subsequent change promotes into the `GetAttrAssociatedElementsInternal()` method, in order to use it as the internal "source of truth" method) already used arrays of `RefPtrs`, since the former interacts with scripting. In the subsequent change, since the `GetAttrAssociatedElementsInternal()` method which I adapted from the original lambda is used both by the bindings-exposed `GetAttrAssociatedElementsForBindings()` and in `AssociatedElementsIterator()`, I thought it was more straightforward to adapt `AssociatedElementsIterator` to use the array of `RefPtrs` rather than unpack the raw pointers each time, but I'm happy to modify it if this will be too slow or memory-intensive.
Differential Revision: https://phabricator.services.mozilla.com/D262170
This reverts commit d46abe6d76.
Revert "Bug 1981346 - Add referenceTarget support for the form attribute. r=credential-management-reviewers,webidl,dimi,Jamie,smaug"
This reverts commit df11a4666d.
Revert "Bug 1981345 - Implement referenceTarget support for multiple element attributes. r=dom-core,Jamie,smaug"
This reverts commit 89cc779f5e.
Revert "Bug 1984685 - Refactor: consistently return Maybe<nsTArray<RefPtr<Element>>> when getting attr-associated elements, and key AttrRelProviders on nsAtom rather than nsString. r=dom-core,morgan,Jamie,smaug"
This reverts commit 33130e712d.
Revert "Bug 1981344 - Implement referenceTarget support for single-element attributes. r=dom-core,credential-management-reviewers,webidl,layout-reviewers,emilio,keithamus,smaug,mtigley"
This reverts commit d6440c4cae.
Revert "Bug 1983766 - Split single element attribute getters into bindings/internals versions. r=dom-core,credential-management-reviewers,webidl,layout-reviewers,smaug,keithamus,jwatt,mtigley"
This reverts commit 83b70e0645.
Revert "Bug 1989323 - Make `referenceTarget` IDL attributes on ShadowRoot, HTMLTemplateElement and ShadowRootInit nullable. r=dom-core,webidl,saschanaz,smaug"
This reverts commit 3a0b29121e.
This makes significant changes to RelatedAccIterator, nsLabelsNodeList and nsContentList:
- RelatedAccIterator now eagerly constructs a TreeOrderedArray of related elements, walking up shadow roots from mDependentContent while the shadow root's reference target is either mDependentContent or a host of one of its ancestor shadow roots.
- nsLabelsNodeList now has an array of roots as well as mRootNode in the superclass nsContentList. This list is reset under certain conditions, adding each shadow root found by walking up from the labeled element until one is found which doesn't have either the labeled element or the host of one of its ancestor shadow roots as a reference target. The last element in this list is set as mRootNode in the superclass, and is either the containing document, or the subtree root of either the labeled element or the host element whose containing shadow root doesn't have it as a reference target. Each root has a mutation observer added to ensure that the list is marked dirty when necessary, and also that roots are removed from `mRoots` when they are destroyed.
- In order to enable nsLabelsNodeList to be a mutation observer for each root, nsContentList now inherits from nsStubMultiMutationObserver instead of nsStubMutationObserver.
This change also moves the ReferenceTargetChangeObserver-related methods from DocumentOrShadowRoot on to Element, and the related data structures on to nsExtendedDOMSlots.
It also introduces a distinction between GetControlForBindings, which returns an element in the same scope as the label element it's called on, and GetLabeledElementInternal, which returns the element which actually has the label element as its label.
Differential Revision: https://phabricator.services.mozilla.com/D261368
- Split `GetAttrAssociatedElements()` into `Internals` and `ForBindings` versions; the latter returns the shadow host(s) rather than an element inside shadow DOM
- Use `GetAttrAssociatedElementsInternal()` in `a11y::AssociatedElementsIterator`, removing the need for `AssociatedElementsIterator` to directly parse IDs or distinguish between ID-based or explicitly-set attr-associated elements.
- This required an update to `DocAccessible`'s `AddDependentIDsFor()` method which previously used `AssociatedElementsIterator`'s `NextID()` method, which is removed in this patch. `AddDependentIDsFor()` now uses the parsed attribute directly instead.
- In order to run the WPT tests which test `aria-labelledby` integration with `referenceTarget`, a new mechanism for retrieving elements inside shadow roots is added. This adds a `element_by_selector_array` action, which takes an array of selectors to be used successively from a document root to retrieve a shadow host, and then within the shadow host to retrieve the next shadow host, until the final selector returns the desired element.
Differential Revision: https://phabricator.services.mozilla.com/D261366
The existing `Element::GetAttrAssociatedElements()` and its internal lambda (which the subsequent change promotes into the `GetAttrAssociatedElementsInternal()` method, in order to use it as the internal "source of truth" method) already used arrays of `RefPtrs`, since the former interacts with scripting. In the subsequent change, since the `GetAttrAssociatedElementsInternal()` method which I adapted from the original lambda is used both by the bindings-exposed `GetAttrAssociatedElementsForBindings()` and in `AssociatedElementsIterator()`, I thought it was more straightforward to adapt `AssociatedElementsIterator` to use the array of `RefPtrs` rather than unpack the raw pointers each time, but I'm happy to modify it if this will be too slow or memory-intensive.
Differential Revision: https://phabricator.services.mozilla.com/D262170
This reverts commit 1b5cf4cdf8.
Revert "Bug 1981346 - Add referenceTarget support for the form attribute. r=credential-management-reviewers,webidl,dimi,Jamie,smaug"
This reverts commit 2394d9205a.
Revert "Bug 1981345 - Implement referenceTarget support for multiple element attributes. r=dom-core,Jamie,smaug"
This reverts commit 571a17ff82.
Revert "Bug 1984685 - Refactor: consistently return Maybe<nsTArray<RefPtr<Element>>> when getting attr-associated elements, and key AttrRelProviders on nsAtom rather than nsString. r=dom-core,morgan,Jamie,smaug"
This reverts commit 3b389fdd62.
Revert "Bug 1981344 - Implement referenceTarget support for single-element attributes. r=dom-core,credential-management-reviewers,webidl,layout-reviewers,emilio,keithamus,smaug,mtigley"
This reverts commit 5cc2a12756.
Revert "Bug 1983766 - Split single element attribute getters into bindings/internals versions. r=dom-core,credential-management-reviewers,webidl,layout-reviewers,smaug,keithamus,jwatt,mtigley"
This reverts commit 68e2d26aa9.
Revert "Bug 1989323 - Make `referenceTarget` IDL attributes on ShadowRoot, HTMLTemplateElement and ShadowRootInit nullable. r=dom-core,webidl,saschanaz,smaug"
This reverts commit 1234b31599.
This makes significant changes to RelatedAccIterator, nsLabelsNodeList and nsContentList:
- RelatedAccIterator now eagerly constructs a TreeOrderedArray of related elements, walking up shadow roots from mDependentContent while the shadow root's reference target is either mDependentContent or a host of one of its ancestor shadow roots.
- nsLabelsNodeList now has an array of roots as well as mRootNode in the superclass nsContentList. This list is reset under certain conditions, adding each shadow root found by walking up from the labeled element until one is found which doesn't have either the labeled element or the host of one of its ancestor shadow roots as a reference target. The last element in this list is set as mRootNode in the superclass, and is either the containing document, or the subtree root of either the labeled element or the host element whose containing shadow root doesn't have it as a reference target. Each root has a mutation observer added to ensure that the list is marked dirty when necessary, and also that roots are removed from `mRoots` when they are destroyed.
- In order to enable nsLabelsNodeList to be a mutation observer for each root, nsContentList now inherits from nsStubMultiMutationObserver instead of nsStubMutationObserver.
This change also moves the ReferenceTargetChangeObserver-related methods from DocumentOrShadowRoot on to Element, and the related data structures on to nsExtendedDOMSlots.
It also introduces a distinction between GetControlForBindings, which returns an element in the same scope as the label element it's called on, and GetLabeledElementInternal, which returns the element which actually has the label element as its label.
Differential Revision: https://phabricator.services.mozilla.com/D261368
- Split `GetAttrAssociatedElements()` into `Internals` and `ForBindings` versions; the latter returns the shadow host(s) rather than an element inside shadow DOM
- Use `GetAttrAssociatedElementsInternal()` in `a11y::AssociatedElementsIterator`, removing the need for `AssociatedElementsIterator` to directly parse IDs or distinguish between ID-based or explicitly-set attr-associated elements.
- This required an update to `DocAccessible`'s `AddDependentIDsFor()` method which previously used `AssociatedElementsIterator`'s `NextID()` method, which is removed in this patch. `AddDependentIDsFor()` now uses the parsed attribute directly instead.
- In order to run the WPT tests which test `aria-labelledby` integration with `referenceTarget`, a new mechanism for retrieving elements inside shadow roots is added. This adds a `element_by_selector_array` action, which takes an array of selectors to be used successively from a document root to retrieve a shadow host, and then within the shadow host to retrieve the next shadow host, until the final selector returns the desired element.
Differential Revision: https://phabricator.services.mozilla.com/D261366
The existing `Element::GetAttrAssociatedElements()` and its internal lambda (which the subsequent change promotes into the `GetAttrAssociatedElementsInternal()` method, in order to use it as the internal "source of truth" method) already used arrays of `RefPtrs`, since the former interacts with scripting. In the subsequent change, since the `GetAttrAssociatedElementsInternal()` method which I adapted from the original lambda is used both by the bindings-exposed `GetAttrAssociatedElementsForBindings()` and in `AssociatedElementsIterator()`, I thought it was more straightforward to adapt `AssociatedElementsIterator` to use the array of `RefPtrs` rather than unpack the raw pointers each time, but I'm happy to modify it if this will be too slow or memory-intensive.
Differential Revision: https://phabricator.services.mozilla.com/D262170
This reverts commit 7b7f37ff69.
Revert "Bug 1998255 - P4: Calculate labeled names remotely. r=morgan"
This reverts commit 7265cce8b1.
Revert "Bug 1998255 - P3: Return eNameFromRelations when name was exclusively calculated from relations. r=morgan"
This reverts commit dbe3c2b954.
Revert "Bug 1998255 - P2: Have GetTextEquivFromIDRefs return true if it used hidden content or referenced itself. r=morgan"
This reverts commit f30cc8c2c8.
Revert "Bug 1998255 - P1: Intro and use ArrayAccIterator. r=morgan"
This reverts commit 312430263f.
Revert "Bug 1998242 - P5: Perform subtree name calculation in RemoteAccessible::Name. r=morgan"
This reverts commit 4deac16ef9.
Revert "Bug 1998242 - P4: Break up name calculation to allow remote subtree calc. r=morgan"
This reverts commit ab72073e90.
Revert "Bug 1998242 - P3: Introduce DirectName() to be used by Name(). r=morgan"
This reverts commit 6f8ce31065.
Revert "Bug 1998242 - P2: Don't rely on NativeName override to suppress subtree name calc. r=morgan"
This reverts commit 1fbfdefcef.
Revert "Bug 1998242 - P1: Factor out tooltip calculation. r=morgan"
This reverts commit 695b65952f.
This reverts commit d42283eaec.
Revert "Bug 1998255 - P4: Calculate labeled names remotely. r=morgan"
This reverts commit 4684fdbfa0.
Revert "Bug 1998255 - P3: Return eNameFromRelations when name was exclusively calculated from relations. r=morgan"
This reverts commit 15919fad2f.
Revert "Bug 1998255 - P2: Have GetTextEquivFromIDRefs return true if it used hidden content or referenced itself. r=morgan"
This reverts commit 2b6d3df0da.
Revert "Bug 1998255 - P1: Intro and use ArrayAccIterator. r=morgan"
This reverts commit c6454665b0.
Revert "Bug 1998242 - P5: Perform subtree name calculation in RemoteAccessible::Name. r=morgan"
This reverts commit 0629edfc29.
Revert "Bug 1998242 - P4: Break up name calculation to allow remote subtree calc. r=morgan"
This reverts commit 24e6864b25.
Revert "Bug 1998242 - P3: Introduce DirectName() to be used by Name(). r=morgan"
This reverts commit 63a23a03e0.
Revert "Bug 1998242 - P2: Don't rely on NativeName override to suppress subtree name calc. r=morgan"
This reverts commit 95638bb76c.
Revert "Bug 1998242 - P1: Factor out tooltip calculation. r=morgan"
This reverts commit 25a9efa9b2.
This reverts commit d0c68a8888.
Revert "Bug 1998255 - P4: Calculate labeled names remotely. r=morgan"
This reverts commit 3bfddbb990.
Revert "Bug 1998255 - P3: Return eNameFromRelations when name was exclusively calculated from relations. r=morgan"
This reverts commit a66669765f.
Revert "Bug 1998255 - P2: Have GetTextEquivFromIDRefs return true if it used hidden content or referenced itself. r=morgan"
This reverts commit 99158f058d.
Revert "Bug 1998255 - P1: Intro and use ArrayAccIterator. r=morgan"
This reverts commit 5d3dbed390.
Revert "Bug 1998242 - P5: Perform subtree name calculation in RemoteAccessible::Name. r=morgan"
This reverts commit 68053ff36f.
Revert "Bug 1998242 - P4: Break up name calculation to allow remote subtree calc. r=morgan"
This reverts commit 0d01bdd7e0.
Revert "Bug 1998242 - P3: Introduce DirectName() to be used by Name(). r=morgan"
This reverts commit 9ee273d6c6.
Revert "Bug 1998242 - P2: Don't rely on NativeName override to suppress subtree name calc. r=morgan"
This reverts commit 55dc166a46.
Revert "Bug 1998242 - P1: Factor out tooltip calculation. r=morgan"
This reverts commit 602b768450.
This reverts commit 7c76213cf0.
Revert "Bug 1998255 - P4: Calculate labeled names remotely. r=morgan"
This reverts commit ebe32a1bcc.
Revert "Bug 1998255 - P3: Return eNameFromRelations when name was exclusively calculated from relations. r=morgan"
This reverts commit f4a05b1359.
Revert "Bug 1998255 - P2: Have GetTextEquivFromIDRefs return true if it used hidden content or referenced itself. r=morgan"
This reverts commit bbd365ae27.
Revert "Bug 1998255 - P1: Intro and use ArrayAccIterator. r=morgan"
This reverts commit 4cf9fc73f1.
Revert "Bug 1998242 - P5: Perform subtree name calculation in RemoteAccessible::Name. r=morgan"
This reverts commit 5a3dff09a7.
Revert "Bug 1998242 - P4: Break up name calculation to allow remote subtree calc. r=morgan"
This reverts commit 69925bd2e6.
Revert "Bug 1998242 - P3: Introduce DirectName() to be used by Name(). r=morgan"
This reverts commit a0cf5d9cd6.
Revert "Bug 1998242 - P2: Don't rely on NativeName override to suppress subtree name calc. r=morgan"
This reverts commit a4155e38e4.
Revert "Bug 1998242 - P1: Factor out tooltip calculation. r=morgan"
This reverts commit 8c278d8b8f.
The iterator uses both explicitly set element attributes and content attributes
with IDs to iterate over all associated elements
Differential Revision: https://phabricator.services.mozilla.com/D215688
The iterator uses both explicitly set element attributes and content attributes
with IDs to iterate over all associated elements
Differential Revision: https://phabricator.services.mozilla.com/D215688
The iterator uses both explicitly set element attributes and content attributes
with IDs to iterate over all associated elements
Differential Revision: https://phabricator.services.mozilla.com/D215688
The iterator uses both explicitly set element attributes and content attributes
with IDs to iterate over all associated elements
Differential Revision: https://phabricator.services.mozilla.com/D215688
As well as getting an invoker's popover target, we need to be able to do the reverse: get a popover's invokers.
We can already do this when the popovertarget content attribute is set to a string id using the dependent ids map.
However, the popover target can also be explicitly set to a DOM element using the .popoverTargetElement WebIDL attribute.
For this, we need a new map which maps from target elements instead of target ids.
RelatedAccIterator has also been updated to use this map.
DocAccessible::QueueCacheUpdateForDependentRelations had to be updated as well.
Rather than duplicating logic, RelatedAccIterator has been taught how to optionally return all relations and QueueCacheUpdateForDependentRelations now uses RelatedAccIterator.
Differential Revision: https://phabricator.services.mozilla.com/D201661
Some member functions are defined in LocalAssessible-inl.h as inline functions, but where declared in LocalAccessible.h without inline specifiers. When compiling files, such as AccIterator.cpp, that include the LocalAccessible.h declarations but not the LocalAccessible-inl.h definitions, the compiler doesn't know that those member functions are not defined out-of-line. The linker expects to find those out-of-line definitions, but can't because they are defined inline.
Solution:
1. Include LocalAccessible-inl.h where needed.
2. Mark LocalAccessible.h's member function declarations as inline if they are defined inline in LocalAccessible-inl.h. This allows the compiler to warn when a file fails to include the LocalAccessible-inl.h definitions. Example warning:
obj-aarch64-apple-darwin22.5.0/dist/include/mozilla/a11y/LocalAccessible.h:174:30: error: inline function 'mozilla::a11y::LocalAccessible::ARIARole' is not defined [-Werror,-Wundefined-inline]
inline mozilla::a11y::role ARIARole();
^
accessible/generic/DocAccessible-inl.h:127:32: note: used here
roles::Role role = aChild->ARIARole();
instead of linker errors (in non-unified builds) like:
ld64.lld: error: undefined symbol: mozilla::a11y::LocalAccessible::IsDefunct() const
>>> referenced by AccIterator.cpp:288 (/Users/chris/Code/mozilla/firefox/accessible/base/AccIterator.cpp:288)
>>> ../../../accessible/base/AccIterator.o:(symbol mozilla::a11y::SingleAccIterator::Next()+0x48)
Differential Revision: https://phabricator.services.mozilla.com/D184603
This revision removes unnecessary include directives from cpp files in the
accessible/base directory. These suggestions came from the Include What You Use
tool.
Differential Revision: https://phabricator.services.mozilla.com/D182288
We have more readable and faster versions (that just omit the namespace
arg).
Mostly done via sed, with a couple helpers to use the faster lookups
where possible.
Differential Revision: https://phabricator.services.mozilla.com/D181795
This was done using the following script:
```
matchingFiles=`git grep -l accessibility_cache_enabled`
sed -i 's/StaticPrefs::accessibility_cache_enabled_AtStartup/a11y::IsCacheActive/' $matchingFiles
for f in $matchingFiles; do
usesA11yPref=
grep -q StaticPrefs::accessibility_ $f && usesA11yPref=1
hasA11yInclude=
grep -q 'nsAccessibilityService.h' $f && hasA11yInclude=1
if [ -z $usesA11yPref ] && [ -z $hasA11yInclude ]; then
sed -i 's,mozilla/StaticPrefs_accessibility.h,nsAccessibilityService.h,' $f
elif [ -z $usesA11yPref ] && [ $hasA11yInclude ]; then
sed -i '/"mozilla.StaticPrefs_accessibility.h"/d' $f
elif [ $usesA11yPref ] && [ -z $hasA11yInclude ]; then
sed -i '/"mozilla.StaticPrefs_accessibility.h"/a#include "nsAccessibilityService.h"' $f
fi
done
```
Differential Revision: https://phabricator.services.mozilla.com/D177722
We'd like to provide NODE_CHILD_OF and NODE_PARENT_OF relations in the parent
process, relying on cached information, to avoid sync IPDL messages. This
revision implements most of the use cases for this relation for remote
accessibles, notably setting aside handling of MathML's <mroot> parent/child
relation. ARIA trees, treegrids, lists, and so on are handled in the remote
accessible largely identically to how they were handled in LocalAccessible.
Rather than define a new rule for walking the tree to find children, this
revision unifies the ItemIterator so it works on generic Accessibles, and uses
it in RemoteAccessibleBase the same way it's used in LocalAccessible. The
special case carve-out for MSAA clients now exists as a simpler IsTopLevel
check in DocAccessibleParent.
Differential Revision: https://phabricator.services.mozilla.com/D159452
This is basically RemoteExplicitHeadersIterator with naming generalised.
Support has been added for transferring ownership of the array into the iterator, which will be needed when the cache is disabled.
Differential Revision: https://phabricator.services.mozilla.com/D152958
Now that GroupPosition and GetGroupInfo are in Accessible, we can make
AccGroupInfo use the Accessible base class.
With one exception: Tables are still local only. That should be
addressed in bug 1735970.
Differential Revision: https://phabricator.services.mozilla.com/D134212
Building with --disable-xul has been busted since _at least_ bug
1082579, for more than 7 years (I didn't try to track that down
further). It's time to recognize that the option serves no purpose.
Differential Revision: https://phabricator.services.mozilla.com/D133161
James Teh