Mark Name() as final in LocalAccessible and RemoteAccessible, and rely
on DirectName for overriding name calculation in local accessibles.
Depends on D271310
Differential Revision: https://phabricator.services.mozilla.com/D271311
This reverts commit 7b7f37ff69.
Revert "Bug 1998255 - P4: Calculate labeled names remotely. r=morgan"
This reverts commit 7265cce8b1.
Revert "Bug 1998255 - P3: Return eNameFromRelations when name was exclusively calculated from relations. r=morgan"
This reverts commit dbe3c2b954.
Revert "Bug 1998255 - P2: Have GetTextEquivFromIDRefs return true if it used hidden content or referenced itself. r=morgan"
This reverts commit f30cc8c2c8.
Revert "Bug 1998255 - P1: Intro and use ArrayAccIterator. r=morgan"
This reverts commit 312430263f.
Revert "Bug 1998242 - P5: Perform subtree name calculation in RemoteAccessible::Name. r=morgan"
This reverts commit 4deac16ef9.
Revert "Bug 1998242 - P4: Break up name calculation to allow remote subtree calc. r=morgan"
This reverts commit ab72073e90.
Revert "Bug 1998242 - P3: Introduce DirectName() to be used by Name(). r=morgan"
This reverts commit 6f8ce31065.
Revert "Bug 1998242 - P2: Don't rely on NativeName override to suppress subtree name calc. r=morgan"
This reverts commit 1fbfdefcef.
Revert "Bug 1998242 - P1: Factor out tooltip calculation. r=morgan"
This reverts commit 695b65952f.
Mark Name() as final in LocalAccessible and RemoteAccessible, and rely
on DirectName for overriding name calculation in local accessibles.
Depends on D271310
Differential Revision: https://phabricator.services.mozilla.com/D271311
This reverts commit d42283eaec.
Revert "Bug 1998255 - P4: Calculate labeled names remotely. r=morgan"
This reverts commit 4684fdbfa0.
Revert "Bug 1998255 - P3: Return eNameFromRelations when name was exclusively calculated from relations. r=morgan"
This reverts commit 15919fad2f.
Revert "Bug 1998255 - P2: Have GetTextEquivFromIDRefs return true if it used hidden content or referenced itself. r=morgan"
This reverts commit 2b6d3df0da.
Revert "Bug 1998255 - P1: Intro and use ArrayAccIterator. r=morgan"
This reverts commit c6454665b0.
Revert "Bug 1998242 - P5: Perform subtree name calculation in RemoteAccessible::Name. r=morgan"
This reverts commit 0629edfc29.
Revert "Bug 1998242 - P4: Break up name calculation to allow remote subtree calc. r=morgan"
This reverts commit 24e6864b25.
Revert "Bug 1998242 - P3: Introduce DirectName() to be used by Name(). r=morgan"
This reverts commit 63a23a03e0.
Revert "Bug 1998242 - P2: Don't rely on NativeName override to suppress subtree name calc. r=morgan"
This reverts commit 95638bb76c.
Revert "Bug 1998242 - P1: Factor out tooltip calculation. r=morgan"
This reverts commit 25a9efa9b2.
Mark Name() as final in LocalAccessible and RemoteAccessible, and rely
on DirectName for overriding name calculation in local accessibles.
Depends on D271310
Differential Revision: https://phabricator.services.mozilla.com/D271311
This reverts commit d0c68a8888.
Revert "Bug 1998255 - P4: Calculate labeled names remotely. r=morgan"
This reverts commit 3bfddbb990.
Revert "Bug 1998255 - P3: Return eNameFromRelations when name was exclusively calculated from relations. r=morgan"
This reverts commit a66669765f.
Revert "Bug 1998255 - P2: Have GetTextEquivFromIDRefs return true if it used hidden content or referenced itself. r=morgan"
This reverts commit 99158f058d.
Revert "Bug 1998255 - P1: Intro and use ArrayAccIterator. r=morgan"
This reverts commit 5d3dbed390.
Revert "Bug 1998242 - P5: Perform subtree name calculation in RemoteAccessible::Name. r=morgan"
This reverts commit 68053ff36f.
Revert "Bug 1998242 - P4: Break up name calculation to allow remote subtree calc. r=morgan"
This reverts commit 0d01bdd7e0.
Revert "Bug 1998242 - P3: Introduce DirectName() to be used by Name(). r=morgan"
This reverts commit 9ee273d6c6.
Revert "Bug 1998242 - P2: Don't rely on NativeName override to suppress subtree name calc. r=morgan"
This reverts commit 55dc166a46.
Revert "Bug 1998242 - P1: Factor out tooltip calculation. r=morgan"
This reverts commit 602b768450.
Mark Name() as final in LocalAccessible and RemoteAccessible, and rely
on DirectName for overriding name calculation in local accessibles.
Depends on D271310
Differential Revision: https://phabricator.services.mozilla.com/D271311
This reverts commit 7c76213cf0.
Revert "Bug 1998255 - P4: Calculate labeled names remotely. r=morgan"
This reverts commit ebe32a1bcc.
Revert "Bug 1998255 - P3: Return eNameFromRelations when name was exclusively calculated from relations. r=morgan"
This reverts commit f4a05b1359.
Revert "Bug 1998255 - P2: Have GetTextEquivFromIDRefs return true if it used hidden content or referenced itself. r=morgan"
This reverts commit bbd365ae27.
Revert "Bug 1998255 - P1: Intro and use ArrayAccIterator. r=morgan"
This reverts commit 4cf9fc73f1.
Revert "Bug 1998242 - P5: Perform subtree name calculation in RemoteAccessible::Name. r=morgan"
This reverts commit 5a3dff09a7.
Revert "Bug 1998242 - P4: Break up name calculation to allow remote subtree calc. r=morgan"
This reverts commit 69925bd2e6.
Revert "Bug 1998242 - P3: Introduce DirectName() to be used by Name(). r=morgan"
This reverts commit a0cf5d9cd6.
Revert "Bug 1998242 - P2: Don't rely on NativeName override to suppress subtree name calc. r=morgan"
This reverts commit a4155e38e4.
Revert "Bug 1998242 - P1: Factor out tooltip calculation. r=morgan"
This reverts commit 8c278d8b8f.
Mark Name() as final in LocalAccessible and RemoteAccessible, and rely
on DirectName for overriding name calculation in local accessibles.
Depends on D271310
Differential Revision: https://phabricator.services.mozilla.com/D271311
This reverts commit 48db718d40.
Revert "Bug 1781153 - Simplify use of AXTitle/AXDescription. r=morgan"
This reverts commit 14eb8560c7.
Revert "Bug 1970234 - Add new eNameFromRelations name flag. r=morgan"
This reverts commit 799312555c.
This revision modifies the way that ProcessMutationEvents works. Rather than
firing mutation events immediately, it instead causes them to be queued on
DocAccessibleChild via HandleAccEvent. The code then fires the events in batches
with a new IPC method, SendMutationEvents. The net effect of this change is a
significant reduction in pressure on the IPC system, in favor of fewer, larger
messages. For pages that generate many mutation events often, this represents a
big win for performance. Without this, the IPC queue can get backed up, failing
to keep up with the amount of accessibility IPC messages as they flood in.
The method of batching is carefully written to maximize the amount of
accessibles that can be touched in a mutation event batch without going
over the IPC message size limit. This revision does not implement size
tracking, but does make a reasonable approximation. With these changes,
heterogenous mutation event types can sit together in batches, including
sub-batches of show events. A side effect of this change is that initial
page load is further amalgamated; multiple document children that
produce separate calls to InsertIntoIpcTree now use this queueing
mechanism and can have their show events sent together.
Some messages may fire differently from their former ordering with this change,
particularly EVENT_MENUPOPUP_END for content processes. However, that event
appears to have been fired out of order with the existing code, meaning
that this change represents a fix to that ordering issue as well.
Finally, this revision makes a slight modification to an Android test
for clarity and correctness. I discovered this issue while debugging
event ordering and realized it was valuable to fix.
Differential Revision: https://phabricator.services.mozilla.com/D229842
Since the method is deferred we need to do extra guesswork for possible
situtations where the name has changed because we don't have the
privilege to calculate the name in-line when content is deleted.
I tried to account for all cases as we have in our test coverage. I
hope that if there are edge cases they are false positives, and we are
firing extra name changes and not the opposite.
Differential Revision: https://phabricator.services.mozilla.com/D223877
Since the method is deferred we need to do extra guesswork for possible
situtations where the name has changed because we don't have the
privilege to calculate the name in-line when content is deleted.
I tried to account for all cases as we have in our test coverage. I
hope that if there are edge cases they are false positives, and we are
firing extra name changes and not the opposite.
Differential Revision: https://phabricator.services.mozilla.com/D223877
A file input contains two native anonymous children: the Browse button and the file name label.
Previously, we exposed the file input as a group in the a11y tree and its anonymous children as children of that group.
While this is semantically correct, it causes several problems for screen readers.
First, if the author provides a label or description, that gets exposed on the group.
Some screen readers ignore either one or the other depending on the screen reader, what the author specified and how the user navigated there.
Second, the file name label isn't focusable and wasn't associated to the group in any way aside from being a child.
This meant that a screen reader user might not perceive it in some cases.
Since most users understand a file input as a single control anyway, we now just expose the input as a simple button containing two text leaves.
However, unlike most buttons, we need to append the text to the name even if the author specifies a name.
As a bonus, this simplifies some code, since we no longer need to redirect focus or events.
An additional problem was that the file input previously returned false for LocalAccessible::IsWidget, which meant that a wrapping HTML label wasn't associated correctly.
This has been fixed as well, although this fix could have applied just as easily to the previous group implementation.
Differential Revision: https://phabricator.services.mozilla.com/D191264
This revision removes unnecessary include directives from cpp files in the
accessible/base directory. These suggestions came from the Include What You Use
tool.
Differential Revision: https://phabricator.services.mozilla.com/D182288
This was done using the following script:
```
matchingFiles=`git grep -l accessibility_cache_enabled`
sed -i 's/StaticPrefs::accessibility_cache_enabled_AtStartup/a11y::IsCacheActive/' $matchingFiles
for f in $matchingFiles; do
usesA11yPref=
grep -q StaticPrefs::accessibility_ $f && usesA11yPref=1
hasA11yInclude=
grep -q 'nsAccessibilityService.h' $f && hasA11yInclude=1
if [ -z $usesA11yPref ] && [ -z $hasA11yInclude ]; then
sed -i 's,mozilla/StaticPrefs_accessibility.h,nsAccessibilityService.h,' $f
elif [ -z $usesA11yPref ] && [ $hasA11yInclude ]; then
sed -i '/"mozilla.StaticPrefs_accessibility.h"/d' $f
elif [ $usesA11yPref ] && [ -z $hasA11yInclude ]; then
sed -i '/"mozilla.StaticPrefs_accessibility.h"/a#include "nsAccessibilityService.h"' $f
fi
done
```
Differential Revision: https://phabricator.services.mozilla.com/D177722
Previously, PushNameOrDescriptionChange wouldn't consider the target itself as a candidate for a name change event.
If the text of a text leaf changes without replacing the leaf, the only event we will get is text inserted on its parent.
If that parent calculated its name from its subtree, this meant that we wouldn't fire a name change in this case.
We address this by allowing this function to fire on the target itself in this case.
Differential Revision: https://phabricator.services.mozilla.com/D172953
When a selection event is dropped due to coalescence, we still include the impacted Accessible in the SelectedAccessiblesChanged notification we send to the parent process.
Although we skip events with defunct targets, we weren't skipping defunct items referenced by selection events.
This meant that if an Accessible was selected/unselected but was shut down before we sent SelectedAccessiblesChanged, the notification would include a dead Accessible.
This was causing an assertion in the parent process.
To fix this, we now ignore defunct items in selection events.
Differential Revision: https://phabricator.services.mozilla.com/D162551
Previously, Relation::Next returned a LocalAccessible.
Now, it returns an Accessible so that it can support RemoteAccessible as well.
Relation::LocalNext has been added as a convenience to return a LocalAccessible when the caller is certain that only LocalAccessible is relevant.
Callers have either been updated to use LocalNext or to handle an Accessible returned from Next.
ia2AccessibleRelation now holds an array of MsaaAccessible, as we need to hold references and we can't hold references to RemoteAccessible.
Differential Revision: https://phabricator.services.mozilla.com/D152957
It's critical that we fire mutation events first because our RemoteAccessible tree is created thus and we can't fire events on RemoteAccessibles we haven't created yet.
Beyond that, though, focus events are of primary importance.
See the comments in EventQueue::ProcessEventQueue for the reasons.
Differential Revision: https://phabricator.services.mozilla.com/D145319
It's critical that we fire mutation events first because our RemoteAccessible tree is created thus and we can't fire events on RemoteAccessibles we haven't created yet.
Beyond that, though, focus events are of primary importance.
See the comments in EventQueue::ProcessEventQueue for the reasons.
Differential Revision: https://phabricator.services.mozilla.com/D145319
Changed the browser and mochitest name tests to rely exclusively on name change
events. To make this happen, I fixed all the cases where we were
event-deficient in the code:
* Examine target in PushNameOrDescriptionChange if it has eNameFromSubtreeRule.
Fixes cases where a text change event happens with the subtree name root as target.
* Change in aria-labelledby should always result in a name change event because
that attribute has highest prescedence.
* Add eHasNameDependent/eHasDescriptionDependent context flags when dependee accessible
is added after dependent accessible to tree.
* Handle value attribute change in HTML buttons and determine if they should trigger a
name changed event.
* Use accessible tree instead of content tree when calculating HTMLSelectOptionAccessible
name, this keeps the PushNameOrDescriptionChange sees in name flags consistent with
the actual tree.
* Handle label attribute change in select options and determine if they should trigger
a name changed event.
* Determine if s summary attribute change on a table triggers a name change event.
* If a title attribute is changed, reliably fire a name change event if
it is used in name calculation.
Differential Revision: https://phabricator.services.mozilla.com/D121580
This is a collaboration between clang-tidy and clang-format.
clang-tidy uses compiled code paths, so this patch is linux specific.
Differential Revision: https://phabricator.services.mozilla.com/D105669
This uses a similar approach to HasNameDependent, introducing a new HasDescriptionDependent.
However, we don't fire events on ancestors, since a description is never computed from an Accessible's own subtree without an explicit described by relation.
Differential Revision: https://phabricator.services.mozilla.com/D102678
HasNameDependent is now set on an Accessible (and thus its descendants) which has A LABEL_FOR relation.
When text mutations occur on such an Accessible, EventQueue::PushNameChange now queues a name change for the Accessible being labelled.
Differential Revision: https://phabricator.services.mozilla.com/D102677
Daniel Holbert