Commit Graph
22 Commits
Author SHA1 Message Date
Harsheet c6f501b010 Bug 2001943 - filter out private windows when deciding what to backup. r=cdupuis
Differential Revision: https://phabricator.services.mozilla.com/D273876
2025-11-24 20:49:33 +00:00
Nicholas Rishel 28d9430d98 Bug 1993688 - Flush tab state before getting setting store state to backup. r=mconley,sthompson
Differential Revision: https://phabricator.services.mozilla.com/D270072
2025-11-05 02:16:21 +00:00
Atila Butkovits 18ff6e0d20 Revert "Bug 1993688 - Flush tab state before getting setting store state to backup. r=mconley,sthompson" for causing mass failures.
This reverts commit 75ff40df40.
2025-11-04 02:16:26 +00:00
Nicholas Rishel 75ff40df40 Bug 1993688 - Flush tab state before getting setting store state to backup. r=mconley,sthompson
Differential Revision: https://phabricator.services.mozilla.com/D270072
2025-11-04 01:23:27 +00:00
David P. 20a23bdc42 Bug 1995368: Fix saved group tab storage removal in backups r=fchasen
From the review for bug 1994513, `savedGroups` tab entries contain a state
object, the way `_closedTabs` does (but `tabs` does not).

Differential Revision: https://phabricator.services.mozilla.com/D269276
2025-10-23 20:59:23 +00:00
David P. 36e0bbeb3b Bug 1994513: Do not back up session storage r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D268753
2025-10-15 23:32:24 +00:00
Chris DuPuis 0453871a85 Bug 1983894 - Don't include cookies in backups ?#backup-reviewers r=mconley
We have not tested the impact of including cookies in restored data.

There are several ways that a website's functionality could be broken by cookies being restored on a new machine. If we can test widely to rule these out as issues, then syncing cookies may be shown to be safe and desirable.

However, it is less risky for this feature, with its aggressive release timeline, to err on the side of caution.

Therefore, we will remove cookies from the set of synced data.

Differential Revision: https://phabricator.services.mozilla.com/D261646
2025-08-29 20:27:35 +00:00
Cristian Tuns 5bea692342 Revert "Bug 1983894 - Don't include cookies in backups r=mconley,backup-reviewers" for causing xpcshell failures in test_CookiesBackupResource.js
This reverts commit 768e2de578.
2025-08-26 00:35:47 +00:00
Chris DuPuis 768e2de578 Bug 1983894 - Don't include cookies in backups r=mconley,backup-reviewers
We have not tested the impact of including cookies in restored data.

There are several ways that a website's functionality could be broken by cookies being restored on a new machine. If we can test widely to rule these out as issues, then syncing cookies may be shown to be safe and desirable.

However, it is less risky for this feature, with its aggressive release timeline, to err on the side of caution.

Therefore, we will remove cookies from the set of synced data.

Differential Revision: https://phabricator.services.mozilla.com/D261646
2025-08-25 23:19:35 +00:00
Serban Stanca dabc97220f Revert "Bug 1983894 - Don't include cookies in backups r=mconley,backup-reviewers" for causing mochitests failures in browser_all_files_referenced.js.
This reverts commit 409fad87ed.
2025-08-22 01:44:30 +00:00
Chris DuPuis 409fad87ed Bug 1983894 - Don't include cookies in backups r=mconley,backup-reviewers
We have not tested the impact of including cookies in restored data.

There are several ways that a website's functionality could be broken by cookies being restored on a new machine. If we can test widely to rule these out as issues, then syncing cookies may be shown to be safe and desirable.

However, it is less risky for this feature, with its aggressive release timeline, to err on the side of caution.

Therefore, we will remove cookies from the set of synced data.

Differential Revision: https://phabricator.services.mozilla.com/D261646
2025-08-21 23:30:30 +00:00
Chris DuPuis d43bdd9793 Bug 1980417 - Be more clear in terminology for tens vs. tenths r=backup-reviewers,mconley
The function bytesToFuzzyKilobytes uses the terminology "10th kilobyte" to mean a number of kilobytes, rounded to the nearest multiple of 10.

This changes the naming to be clear that it's multiples of 10, not tenths.

Differential Revision: https://phabricator.services.mozilla.com/D259427
2025-07-31 22:46:14 +00:00
Mike Conley 6dedf6b415 Bug 1891854 - Do not backup session cookies if backup encryption is not enabled. r=backup-reviewers,fchasen
Differential Revision: https://phabricator.services.mozilla.com/D214318
2024-06-25 00:35:44 +00:00
Sandor Molnar f5cc48988c Backed out 5 changesets (bug 1901534, bug 1891854, bug 1901520) for causing xpc failures @ test_BackupService_renderTemplate.js CLOSED TREE
Backed out changeset 5e494cb0aff6 (bug 1901534)
Backed out changeset e8773eda97c1 (bug 1891854)
Backed out changeset 4b079909d830 (bug 1901520)
Backed out changeset 5509d1905d2c (bug 1901520)
Backed out changeset 6d98566735ad (bug 1901520)
2024-06-25 01:24:56 +03:00
Mike Conley ecb25d3a8b Bug 1891854 - Do not backup session cookies if backup encryption is not enabled. r=backup-reviewers,fchasen
Differential Revision: https://phabricator.services.mozilla.com/D214318
2024-06-24 20:47:05 +00:00
kpatenio 1ed5674500 Bug 1888448 - Implement recover for SessionStoreBackupResource. r=backup-reviewers,mconley
Differential Revision: https://phabricator.services.mozilla.com/D209319
2024-05-03 21:05:55 +00:00
Mike Conley 782c9958bd Bug 1886614 - Write a marionette test for the BackupService.createBackup method. r=backup-reviewers,kpatenio
This test can be run via:

./mach marionette-test browser/components/backup/test/marionette/test_backup.py

This also makes it so that BackupResource.copySqliteDatabases does not throw if
one of the passed in database files doesn't exist - it'll just ignore it and
move on. This required me to update some tests in order to create some fake
SQLite databases to ensure that the fake Sqlite connection was made and the
backup stub was called for the SQLite databases being copied.

Finally, this also fixes something I noticed - some of our BackupResource's
weren't returning null or objects as their ManifestEntry. This fixes that
and adds tests to cover that case.

Differential Revision: https://phabricator.services.mozilla.com/D207811
2024-04-23 02:54:49 +00:00
kpatenio a6f22c8b9f Bug 1885941 - implement backup method for cookies, form history and sessions BackupResources. r=backup-reviewers,mconley
Differential Revision: https://phabricator.services.mozilla.com/D207495
2024-04-17 20:43:38 +00:00
Mike Conley 95d89beff6 Bug 1890294 - Add a requiresEncryption static getter on BackupResource for subclasses to override. r=backup-reviewers,places-reviewers,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D206910
2024-04-09 15:15:34 +00:00
Fred Chasen 3f0ce216dc Bug 1883740 - Add disk size measurements for cookies, form history and sessions. data-review=jhirsch r=backup-reviewers,mconley
- Adds `CookiesBackupResource`, `FormHistoryBackupResource` and `SessionsStoreBackupResource` classes with measurement methods for those resources.
- Exports `BYTES_IN_KB` and new `bytesToFuzzyKilobytes` methods from `BackupResource`
- Fix filename for `BackupResource` tests.

Differential Revision: https://phabricator.services.mozilla.com/D205254
2024-03-26 20:15:48 +00:00
Cristian Tuns a15db1a730 Backed out changeset 3cbb780fbe07 (bug 1883740) for causing xpcshell failures in test_measurements.js CLOSED TREE 2024-03-25 18:23:09 -04:00
Fred Chasen 0822671fd6 Bug 1883740 - Add disk size measurements for cookies, form history and sessions. data-review=jhirsch r=backup-reviewers,mconley
- Adds `CookiesBackupResource`, `FormHistoryBackupResource` and `SessionsStoreBackupResource` classes with measurement methods for those resources.
- Exports `BYTES_IN_KB` and new `bytesToFuzzyKilobytes` methods from `BackupResource`
- Fix filename for `BackupResource` tests.

Differential Revision: https://phabricator.services.mozilla.com/D205254
2024-03-25 18:45:52 +00:00