Dave Townsend
774f1b7a83
Bug 2042824: Fix tests that think that EventUtils.synthesizeMouse* returns a promise. r=Gijs,devtools-reviewers,fxview-reviewers,tabbrowser-reviewers,layout-reviewers,nchevobbe,jsudiaman,dshin,nsharpley
...
Differential Revision: https://phabricator.services.mozilla.com/D302775
2026-05-28 08:55:52 +00:00
Emilio Cobos Álvarez
e833a1757b
Bug 2033243 - Replace ownerGlobal with documentGlobal, and stop exposing ownerGlobal to JS. r=firefox-desktop-core-reviewers ,webidl,joschmidt,perftest-reviewers,sparky,smaug,mossop ,webidl,joschmidt,perftest-reviewers,sparky,smaug,mossop
...
Bug 2033191 made sure we only call ownerGlobal on nodes.
As per the discussion in dev-platform, the front-end ~always wants
.documentGlobal. This removes ownerGlobal from the bindings. Following
patch will rename internal GetOwnerGlobal in gecko to GetRelevantGlobal
as per the HTML spec terminology.
Differential Revision: https://phabricator.services.mozilla.com/D297183
2026-05-02 22:04:13 +00:00
iulian moraru
480fc572da
Revert "Bug 2036439, Bug 2033243 - Deal with ownerGlobal -> documentGlobal rename in extensions. r=robwu,home-newtab-reviewers,mconley" for causing newtab failures.
...
This reverts commit 4f62279d01 .
Revert "Bug 2033243 - Other miscellaneous ownerGlobal-related naming removal. r=dom-core,smaug"
This reverts commit 91a4ece356 .
Revert "Bug 2033243 - BindToOwner -> BindToGlobal. r=dom-core,smaug"
This reverts commit 5a95a889e1 .
Revert "Bug 2033243 - Rename GetOwnerGlobal to GetRelevantGlobal. r=dom-core,media-playback-reviewers,credential-management-reviewers,webrtc-reviewers,dom-storage-reviewers,firefox-style-system-reviewers,dimi,janv,dshin,aosmond,smaug"
This reverts commit 7177a68e67 .
Revert "Bug 2033243 - Replace ownerGlobal with documentGlobal, and stop exposing ownerGlobal to JS. r=firefox-desktop-core-reviewers ,webidl,joschmidt,perftest-reviewers,sparky,smaug,mossop ,webidl,joschmidt,perftest-reviewers,sparky,smaug,mossop"
This reverts commit 5263254690 .
2026-05-02 16:43:35 +00:00
Emilio Cobos Álvarez
5263254690
Bug 2033243 - Replace ownerGlobal with documentGlobal, and stop exposing ownerGlobal to JS. r=firefox-desktop-core-reviewers ,webidl,joschmidt,perftest-reviewers,sparky,smaug,mossop ,webidl,joschmidt,perftest-reviewers,sparky,smaug,mossop
...
Bug 2033191 made sure we only call ownerGlobal on nodes.
As per the discussion in dev-platform, the front-end ~always wants
.documentGlobal. This removes ownerGlobal from the bindings. Following
patch will rename internal GetOwnerGlobal in gecko to GetRelevantGlobal
as per the HTML spec terminology.
Differential Revision: https://phabricator.services.mozilla.com/D297183
2026-05-02 15:33:20 +00:00
rperta
d4cc71008d
Revert "Bug 2033243 - Other miscellaneous ownerGlobal-related naming removal. r=dom-core,smaug" on developer request
...
This reverts commit e58e122135 .
This reverts commit 84ca206f3e .
This reverts commit a7945292ed .
This reverts commit 367d83d299 .
2026-05-02 06:20:30 +00:00
Emilio Cobos Álvarez
367d83d299
Bug 2033243 - Replace ownerGlobal with documentGlobal, and stop exposing ownerGlobal to JS. r=firefox-desktop-core-reviewers ,webidl,joschmidt,perftest-reviewers,sparky,smaug,mossop
...
Bug 2033191 made sure we only call ownerGlobal on nodes.
As per the discussion in dev-platform, the front-end ~always wants
.documentGlobal. This removes ownerGlobal from the bindings. Following
patch will rename internal GetOwnerGlobal in gecko to GetRelevantGlobal
as per the HTML spec terminology.
Differential Revision: https://phabricator.services.mozilla.com/D297183
2026-05-01 11:58:10 +00:00
agoloman
c814da612d
Revert "Bug 2033243 - Other miscellaneous ownerGlobal-related naming removal. r=dom-core,smaug" for causing multiple failures.
...
This reverts commit c7246654bc .
Revert "Bug 2033243 - BindToOwner -> BindToGlobal. r=dom-core,smaug"
This reverts commit 8873ddf33c .
Revert "Bug 2033243 - Rename GetOwnerGlobal to GetRelevantGlobal. r=dom-core,media-playback-reviewers,credential-management-reviewers,webrtc-reviewers,dom-storage-reviewers,firefox-style-system-reviewers,dimi,janv,dshin,aosmond,smaug"
This reverts commit 8bf999e03c .
Revert "Bug 2033243 - Replace ownerGlobal with documentGlobal, and stop exposing ownerGlobal to JS. r=firefox-desktop-core-reviewers ,webidl,joschmidt,perftest-reviewers,sparky,smaug,mossop"
This reverts commit 7dea1af2e0 .
2026-04-30 20:13:14 +00:00
Emilio Cobos Álvarez
7dea1af2e0
Bug 2033243 - Replace ownerGlobal with documentGlobal, and stop exposing ownerGlobal to JS. r=firefox-desktop-core-reviewers ,webidl,joschmidt,perftest-reviewers,sparky,smaug,mossop
...
Bug 2033191 made sure we only call ownerGlobal on nodes.
As per the discussion in dev-platform, the front-end ~always wants
.documentGlobal. This removes ownerGlobal from the bindings. Following
patch will rename internal GetOwnerGlobal in gecko to GetRelevantGlobal
as per the HTML spec terminology.
Differential Revision: https://phabricator.services.mozilla.com/D297183
2026-04-30 17:47:07 +00:00
Sylvestre Ledru
bbcc7547a3
Bug 2023419 - Remove Emacs/Vim modelines from browser/ r=emilio,mkaply,webcompat-reviewers,extension-reviewers,credential-management-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,desktop-theme-reviewers,win-reviewers,omc-reviewers,migration-reviewers,home-newtab-reviewers,ai-frontend-reviewers,browser-installer-reviewers,profiles-reviewers,ip-protection-reviewers,mconley,sfoster,twisniewski,thecount,flozia,gstoll,sthompson,mimi,kpatenio,rpl,dimi,mossop,akulyk,aborondo
...
Differential Revision: https://phabricator.services.mozilla.com/D287835
2026-04-17 22:55:57 +00:00
rperta
93d1074012
Revert "Bug 2023419 - Remove Emacs/Vim modelines from browser/ r=emilio,mkaply,webcompat-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,desktop-theme-reviewers,win-reviewers,migration-reviewers,home-newtab-reviewers,ai-frontend-reviewers,mconley,twisniewski,thecount,flozia,gstoll,sthompson" for causing node related failures
...
This reverts commit 3ae5875024 .
2026-03-16 20:46:05 +00:00
Sylvestre Ledru
3ae5875024
Bug 2023419 - Remove Emacs/Vim modelines from browser/ r=emilio,mkaply,webcompat-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,desktop-theme-reviewers,win-reviewers,migration-reviewers,home-newtab-reviewers,ai-frontend-reviewers,mconley,twisniewski,thecount,flozia,gstoll,sthompson
...
replaced by .editorconfig
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D287835
2026-03-16 20:06:36 +00:00
Mark Banner
32474de169
Bug 1993543 - Change XPCOMUtils.defineLazyServiceGetter(s) calls to pass an nsIID rather than a string. r=firefox-desktop-core-reviewers ,mtigley,joschmidt,perftest-reviewers,home-newtab-reviewers,nbarrett,Gijs,sparky
...
This is all automated changes apart from ShellService.sys.mjs.
Differential Revision: https://phabricator.services.mozilla.com/D268194
2025-10-17 22:13:14 +00:00
Atila Butkovits
091d1f53bd
Revert "Bug 1993543 - Simplify XPCOMUtils.defineLazyServiceGetter to require the interface parameter as an nsIID. r=spidermonkey-reviewers,frontend-codestyle-reviewers,Gijs,arai" for causing Reftest failures.
...
This reverts commit d96e9bd92c .
Revert "Bug 1993543 - Change XPCOMUtils.defineLazyServiceGetter(s) calls to pass an nsIID rather than a string. r=firefox-desktop-core-reviewers ,mtigley,joschmidt,perftest-reviewers,home-newtab-reviewers,nbarrett,Gijs,sparky"
This reverts commit 024c584172 .
2025-10-17 12:51:54 +00:00
Mark Banner
fde74f7d41
Bug 1994217 - Enable ESLint rule jsdoc/no-bad-blocks. r=frontend-codestyle-reviewers,webdriver-reviewers,credential-management-reviewers,search-reviewers,fxview-reviewers,places-reviewers,whimboo,nsharpley,scunnane,Gijs,mtigley,daisuke
...
Mainly manual fixes to fix issues found in the jsdoc comments now that they're recognised correctly.
Also removes some configuration that is no longer needed as it is now the default.
Differential Revision: https://phabricator.services.mozilla.com/D268569
2025-10-17 11:18:43 +00:00
Mark Banner
024c584172
Bug 1993543 - Change XPCOMUtils.defineLazyServiceGetter(s) calls to pass an nsIID rather than a string. r=firefox-desktop-core-reviewers ,mtigley,joschmidt,perftest-reviewers,home-newtab-reviewers,nbarrett,Gijs,sparky
...
This is all automated changes apart from ShellService.sys.mjs.
Differential Revision: https://phabricator.services.mozilla.com/D268194
2025-10-17 11:16:12 +00:00
Narcis Beleuzu
89c0ffec7c
Revert "Bug 1994217 - Enable ESLint rule jsdoc/no-bad-blocks on the rest of the tree. r=frontend-codestyle-reviewers,Gijs" for causing Documentation opt failure
...
This reverts commit 987c3ad130 .
This reverts commit 1c5b20a293 .
This reverts commit 0a9a458465 .
2025-10-16 21:32:01 +00:00
Mark Banner
1c5b20a293
Bug 1994217 - Enable ESLint rule jsdoc/no-bad-blocks. r=frontend-codestyle-reviewers,webdriver-reviewers,credential-management-reviewers,search-reviewers,fxview-reviewers,places-reviewers,whimboo,nsharpley,scunnane,Gijs,mtigley,daisuke
...
Mainly manual fixes to fix issues found in the jsdoc comments now that they're recognised correctly.
Also removes some configuration that is no longer needed as it is now the default.
Differential Revision: https://phabricator.services.mozilla.com/D268569
2025-10-16 10:58:11 +00:00
Joel Maher
1a4fb71e2c
Bug 1975729 - adjust whitespace and newlines for most mochitest .toml files, also remove unnecessary skip-if=verify conditions. r=florian,webdriver-reviewers,necko-reviewers,mtigley,webcompat-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,credential-management-reviewers,search-reviewers,devtools-reviewers,anti-tracking-reviewers,places-reviewers,profiler-reviewers,dom-storage-reviewers,translations-reviewers,omc-reviewers,home-newtab-reviewers,sidebar-reviewers,urlbar-reviewers,firefox-ai-ml-reviewers,twisniewski,bytesized,emcminn,Standard8,karlt,padenot,jdescottes,dimi,kershaw,robwu,canaltinova,nbarrett,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D256136
2025-07-12 16:26:27 +00:00
Emma Zuehlcke
7f413a686d
Bug 1946105 - Test, r=hjones
...
Differential Revision: https://phabricator.services.mozilla.com/D237189
2025-02-10 14:18:53 +00:00
Emma Zuehlcke
478dc8efe0
Bug 1866661 - Tests, r=hjones
...
Differential Revision: https://phabricator.services.mozilla.com/D235760
2025-02-04 14:26:30 +00:00
Jan-Erik Rediger
2068ca0d1d
Bug 1933939 - Integrate changed API of Glean v63.0.0 r=android-reviewers,chutten,pollymce,afranchuk
...
This also standardizes on using the defined "test-ping" for metrics in tests.
Differential Revision: https://phabricator.services.mozilla.com/D230527
2024-12-13 16:07:35 +00:00
Alexandru Marc
1867c6e79e
Backed out 4 changesets (bug 1933939, bug 1936835) for causing xpcshell failures @ test_ExperimentAPI_ExperimentFeature.js
...
Backed out changeset 429debfba4ad (bug 1936835)
Backed out changeset f121c08017a5 (bug 1933939)
Backed out changeset a0c962daf339 (bug 1933939)
Backed out changeset ba2d50ad9ad5 (bug 1933939)
2024-12-13 17:06:38 +02:00
Jan-Erik Rediger
83ad41fdd6
Bug 1933939 - Integrate changed API of Glean v63.0.0 r=android-reviewers,chutten,pollymce,afranchuk
...
This also standardizes on using the defined "test-ping" for metrics in tests.
Differential Revision: https://phabricator.services.mozilla.com/D230527
2024-12-13 13:50:28 +00:00
Max Christian Pohle
8ec16bf12d
Bug 1911070 - Two infobars are displayed, r=nalexander
...
Differential Revision: https://phabricator.services.mozilla.com/D221394
2024-09-09 21:30:14 +00:00
Max Christian Pohle
88cd867f6d
Bug 1910910 - mailto: telemetry for dismiss buttons, r=nalexander
...
Differential Revision: https://phabricator.services.mozilla.com/D221018
2024-09-06 18:19:41 +00:00
Max Christian Pohle
3aaab52159
Bug 1900839 - mailto: Replace site specific settings with permission manager, r=pbz
...
Differential Revision: https://phabricator.services.mozilla.com/D213507
2024-06-21 11:25:55 +00:00
Max Christian Pohle
06674fbbd1
Bug 1894024 - mailto: remind users to finish the configuration of a webmailer, r=Gijs,firefox-desktop-core-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D209067
2024-05-30 15:59:30 +00:00
Max Christian Pohle
6768e636b7
Bug 1890335 - Incorrect message shown in the mailto infobar, r=mhughes,fluent-reviewers,bolsson
...
Differential Revision: https://phabricator.services.mozilla.com/D207148
2024-04-10 19:39:04 +00:00
Max Christian Pohle
0b2e8cfb92
Bug 1886203 - Incorrect confirmation message shown in the mailto infobar, r=mhughes,fluent-reviewers,bolsson
...
Differential Revision: https://phabricator.services.mozilla.com/D206678
2024-04-05 09:42:50 +00:00
Max Christian Pohle
cf4cd71f26
Bug 1877500: single click os/fx mailto default, r=mhughes,fluent-reviewers,bolsson
...
Differential Revision: https://phabricator.services.mozilla.com/D203053
2024-03-11 17:35:51 +00:00
Hanna Jones
06f64c0cdb
Bug 1845150 - Use moz-message-bar instead of message-bar in notificationbox.js r=webdriver-reviewers,desktop-theme-reviewers,media-playback-reviewers,karlt,whimboo,tgiles,dao,devtools-reviewers
...
This patch updates the `NotificationMessage` element in `notificationbox.js` so that it extends our newer `moz-message-bar` component instead of the deprecated `message-bar` component. Many of the changes are just dealing with the implications of making things async (so that we can ensure `moz-message-bar.mjs` gets imported). I tried to break out places where I modified related code and tests into separate patches to mitigate some of the review pain here.
This patch solves a longstanding issue where we were loading `in-content/common-shared.css` in the chrome since it gets used by the `message-bar` element. It also makes some small visual changes to our infobars (slight outline, icon colors, adds a bit of spacing).
Differential Revision: https://phabricator.services.mozilla.com/D189872
2024-01-10 18:55:29 +00:00
Norisz Fay
0847da64fd
Backed out 7 changesets (bug 1845150) for causing failures on browser_datachoices_notification.js CLOSED TREE
...
Backed out changeset a07c835a4bf7 (bug 1845150)
Backed out changeset 0016d7f4e556 (bug 1845150)
Backed out changeset 46cfe5fe6e6a (bug 1845150)
Backed out changeset 83190b8a08d0 (bug 1845150)
Backed out changeset ada948351267 (bug 1845150)
Backed out changeset 7aa4340bfd96 (bug 1845150)
Backed out changeset 683745289588 (bug 1845150)
2024-01-05 18:52:01 +02:00
Hanna Jones
323d6b5f81
Bug 1845150 - Use moz-message-bar instead of message-bar in notificationbox.js r=webdriver-reviewers,desktop-theme-reviewers,media-playback-reviewers,karlt,whimboo,tgiles,dao,devtools-reviewers
...
This patch updates the `NotificationMessage` element in `notificationbox.js` so that it extends our newer `moz-message-bar` component instead of the deprecated `message-bar` component. Many of the changes are just dealing with the implications of making things async (so that we can ensure `moz-message-bar.mjs` gets imported). I tried to break out places where I modified related code and tests into separate patches to mitigate some of the review pain here.
This patch solves a longstanding issue where we were loading `in-content/common-shared.css` in the chrome since it gets used by the `message-bar` element. It also makes some small visual changes to our infobars (slight outline, icon colors, adds a bit of spacing).
Differential Revision: https://phabricator.services.mozilla.com/D189872
2024-01-05 15:04:18 +00:00
Cosmin Sabou
5d4c4c0f9b
Backed out 7 changesets (bug 1845150) for causing dt failures on browser_screenshot_button_warning. CLOSED TREE
...
Backed out changeset fdc3f1b5e5ae (bug 1845150)
Backed out changeset ba7789c89bdd (bug 1845150)
Backed out changeset 6c405863be54 (bug 1845150)
Backed out changeset f66e8bb15e18 (bug 1845150)
Backed out changeset a75fe63bd39f (bug 1845150)
Backed out changeset 91365291f80f (bug 1845150)
Backed out changeset 7477fd1c48fa (bug 1845150)
2024-01-04 18:53:25 +02:00
Hanna Jones
c916533153
Bug 1845150 - Use moz-message-bar instead of message-bar in notificationbox.js r=webdriver-reviewers,desktop-theme-reviewers,media-playback-reviewers,reusable-components-reviewers,karlt,whimboo,tgiles,dao
...
This patch updates the `NotificationMessage` element in `notificationbox.js` so that it extends our newer `moz-message-bar` component instead of the deprecated `message-bar` component. Many of the changes are just dealing with the implications of making things async (so that we can ensure `moz-message-bar.mjs` gets imported). I tried to break out places where I modified related code and tests into separate patches to mitigate some of the review pain here.
This patch solves a longstanding issue where we were loading `in-content/common-shared.css` in the chrome since it gets used by the `message-bar` element. It also makes some small visual changes to our infobars (slight outline, icon colors, adds a bit of spacing).
Differential Revision: https://phabricator.services.mozilla.com/D189872
2024-01-04 15:31:12 +00:00
Max Christian Pohle
ef2f87d373
Bug 1865883 - added confirmation prompts, changed button label to 'Allow', r=fluent-reviewers,flod,mhughes
...
Differential Revision: https://phabricator.services.mozilla.com/D193829
2023-11-22 16:49:22 +00:00
Max Christian Pohle
5125bf57f1
Bug 1864216 - Allow setting the browser as the OS default mailto handler, r=mhughes,bolsson
...
Differential Revision: https://phabricator.services.mozilla.com/D193322
2023-11-15 04:32:05 +00:00
Mark Banner
1e0d5b802e
Bug 1861865 - Fix ESLint valid-jsdoc issues in various browser code and enable on directories where it is already passing. r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D192163
2023-11-01 17:20:41 +00:00
Sylvestre Ledru
2e0e132821
Bug 1856530 - run file-whitespace on toml files r=linter-reviewers,Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D189896
2023-10-03 09:22:18 +00:00
Tom Marble
ad50861ef9
Bug 1853243 - convert .ini manifests to .toml: batch 5 browser/**/browser.ini r=jmaher,mossop,webcompat-reviewers,twisniewski,search-reviewers,Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D188427
2023-09-21 22:47:07 +00:00
Marco Bonardo
6874dffc71
Bug 1852963 - Rename BrowserTestUtils.loadURIString() to .startLoadingURIString(). r=dao
...
This should make a bit clearer that it is only starting the load, not waiting
for its completion.
Differential Revision: https://phabricator.services.mozilla.com/D188213
2023-09-15 09:16:34 +00:00
Sandor Molnar
5d8dd001ad
Backed out 3 changesets (bug 1852963) for causing remote failures on remote/shared/messagehandler/test/browser/browser_session_data.js CLOSED TREE
...
Backed out changeset 98de7bc404c3 (bug 1852963)
Backed out changeset edf1527c9a99 (bug 1852963)
Backed out changeset 34357750f69c (bug 1852963)
2023-09-14 20:29:06 +03:00
Marco Bonardo
c5fb3dbb49
Bug 1852963 - Rename BrowserTestUtils.loadURIString() to .startLoadingURIString(). r=dao
...
This should make a bit clearer that it is only starting the load, not waiting
for its completion.
Differential Revision: https://phabricator.services.mozilla.com/D188213
2023-09-14 16:33:13 +00:00
Katherine Patenio
82e953e9b8
Bug 1850602 - Add spinner to in-progress-analysis shopping-message-bar r=shopping-reviewers,reusable-components-reviewers,desktop-theme-reviewers,amy,mstriemer
...
Differential Revision: https://phabricator.services.mozilla.com/D187139
2023-09-08 21:16:13 +00:00
Mark Banner
0666077666
Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu
...
Differential Revision: https://phabricator.services.mozilla.com/D177027
2023-05-20 12:26:53 +00:00
Mark Banner
91fde42f7b
Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish
...
Differential Revision: https://phabricator.services.mozilla.com/D177025
2023-05-20 12:26:49 +00:00
Mark Banner
2a801fd670
Bug 1824173 - Automatically fix some ESLint issues raised by the valid-jsdoc configuration. r=mossop,webcompat-reviewers,denschub
...
Differential Revision: https://phabricator.services.mozilla.com/D173450
2023-03-24 19:35:24 +00:00
anayo
566b076a26
Bug 1817015 - Convert JSM in browser/components/protocolhandler to ESM r=kpatenio
...
Differential Revision: https://phabricator.services.mozilla.com/D172829
2023-03-22 16:05:28 +00:00
Gijs Kruitbosch
5a903703c5
Bug 1810995 - update BrowserTestUtils.loadURI consumers to use loadURIString (automated) - browser - r=Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D167153
2023-01-19 20:16:42 +00:00
Mark Banner
1e3410cbdd
Bug 1782008 - Remove now unnecessary .eslintrc.js files. r=webcompat-reviewers,extension-reviewers,media-playback-reviewers,pip-reviewers,denschub,rpl,alwu,mossop
...
Differential Revision: https://phabricator.services.mozilla.com/D152736
2022-08-03 11:16:20 +00:00