The "default Windows launch on login" feature was registered as a
first-startup-new-profile task, which only runs from the stub
installer's --first-startup path. Full installer, MSI, MSIX, and zip
installs never hit it, leaving the new-install default silently off
for those users.
This change introduces a default-true pref
(browser.startup.windowsLaunchOnLogin.defaultEnabled) and moves the
registry write into StartupOSIntegration.onStartupIdle(), gated on:
- profileService.isFirstRun (new getter exposed from
nsToolkitProfileService.cpp via nsIToolkitProfileService.idl)
- browser.startup.windowsLaunchOnLogin.defaultEnabled
- WindowsLaunchOnLogin.getLaunchOnLoginApproved() (Windows policy)
DefaultWindowsLaunchOnLogin still runs from first-startup-new-profile
but now writes the pref bidirectionally based on Nimbus rather than
calling createLaunchOnLogin() itself, preserving the ability to opt
experiment branches in or out via Nimbus.
Differential Revision: https://phabricator.services.mozilla.com/D299301
This replaces the existing remote type prediction backend, which has been
implemented in E10SUtils.sys.mjs. This completes the transition which was
started when process selection decisions started being made in C++ for Fission
by removing the core logic completely from E10SUtils.sys.mjs.
Differential Revision: https://phabricator.services.mozilla.com/D282083
This reverts commit ba92fe5024.
Revert "Bug 2011326 - Part 4: Switch test_sitepolicies to a data URI, r=mossop"
This reverts commit 8eab4714b1.
Revert "Bug 2011326 - Part 3: Remove the test-only canLoadURIInRemoteType function, r=firefox-desktop-core-reviewers ,tabbrowser-reviewers,mossop,sthompson"
This reverts commit 8ce4078eed.
Revert "Bug 2011326 - Part 2: Predict remote types with ProcessIsolation, r=whimboo,geckoview-reviewers,extension-reviewers,tabbrowser-reviewers,omc-reviewers,layout-reviewers,tcampbell,robwu,sthompson,emilio,mimi"
This reverts commit df59bd116e.
Revert "Bug 2011326 - Part 1: Remove test for separatePrivilegedContentProcess=false, r=firefox-desktop-core-reviewers ,tabbrowser-reviewers,mossop,sthompson"
This reverts commit 879157d4f7.
Revert "Bug 2011307 - Remove test-only support for marking chrome:// URI as needing to be loaded remotely, r=smaug,tabbrowser-reviewers,nsharpley"
This reverts commit 2d20aa53d9.
This replaces the existing remote type prediction backend, which has been
implemented in E10SUtils.sys.mjs. This completes the transition which was
started when process selection decisions started being made in C++ for Fission
by removing the core logic completely from E10SUtils.sys.mjs.
Differential Revision: https://phabricator.services.mozilla.com/D282083
The telemetry previously only looked at remotingName, which isn't
accurate if --name is used. Prefer g_get_prgname here since it's used as
the default wmclass, so it better matches what we want to measure.
Differential Revision: https://phabricator.services.mozilla.com/D300629
This reverts commit bde4bcc89a.
Revert "Bug 2019113 - Part 3: Provide the window to createLinuxDesktopEntry when pinning. r=nrishel"
This reverts commit f38b471713.
Revert "Bug 2019113 - Part 2: Add tests for DynamicLauncher portal usage from the browser. r=emilio,extension-reviewers,robwu,gerard-majax,Thinker,ahal"
This reverts commit 89a81eb63b.
Revert "Bug 2019113 - Part 1: Use the DynamicLauncher portal from createLinuxDesktopEntry and deleteLinuxDesktopEntry. r=emilio,nrishel"
This reverts commit b6b202794e.
The "default Windows launch on login" feature was registered as a
first-startup-new-profile task, which only runs from the stub
installer's --first-startup path. Full installer, MSI, MSIX, and zip
installs never hit it, leaving the new-install default silently off
for those users.
This change introduces a default-true pref
(browser.startup.windowsLaunchOnLogin.defaultEnabled) and moves the
registry write into StartupOSIntegration.onStartupIdle(), gated on:
- profileService.isFirstRun (new getter exposed from
nsToolkitProfileService.cpp via nsIToolkitProfileService.idl)
- browser.startup.windowsLaunchOnLogin.defaultEnabled
- WindowsLaunchOnLogin.getLaunchOnLoginApproved() (Windows policy)
DefaultWindowsLaunchOnLogin still runs from first-startup-new-profile
but now writes the pref bidirectionally based on Nimbus rather than
calling createLaunchOnLogin() itself, preserving the ability to opt
experiment branches in or out via Nimbus.
Differential Revision: https://phabricator.services.mozilla.com/D299301
Originally this check was added in bug 1368211 due to GConf error
messages when running headless. We no longer use GConf, so that
shouldn't (crosses fingers) be a problem.
This also removes the comment about checking for GIO and GSettings---it
looks like those used to have checks, but now just the comment remains.
Differential Revision: https://phabricator.services.mozilla.com/D299817
This replaces the existing remote type prediction backend, which has been
implemented in E10SUtils.sys.mjs. This completes the transition which was
started when process selection decisions started being made in C++ for Fission
by removing the core logic completely from E10SUtils.sys.mjs.
Differential Revision: https://phabricator.services.mozilla.com/D282083
Follow-up to bbcc7547a3 which cleaned up browser/. This strips the
same modelines from the rest of the tree, excluding paths listed in
tools/rewriting/ThirdPartyPaths.txt.
Differential Revision: https://phabricator.services.mozilla.com/D295577
Bug 2033172 added an aFireAndForget parameter to PinCurrentAppToTaskbarWin11
but did not update the MinGW fallback stub, causing MinGW link failures.
Differential Revision: https://phabricator.services.mozilla.com/D295164
Worst part is, this is the obvious case! Wasn't caught because the tests
generally use an absolute path or empty string as argv[0], instead of
the more likely "firefox" etc.
Differential Revision: https://phabricator.services.mozilla.com/D294450
This is mostly the result of running ./mach static-analysis check --fix
with the new linter activated, with the following caveats:
- use std::fill when it makes sense
- use appropriate names for the loop target variable
- fix constness
- use array default initialization instead of an explicit loop when it
makes sense
Differential Revision: https://phabricator.services.mozilla.com/D289172
This is a large number of largely mechanical changes. When possible, the code
was called to directly call `.get()` instead, performing the assertions
manually. In many places PromiseFlatCString() calls were added to dynamically
copy the strings into null terminated buffers if the string was not null
terminated.
Differential Revision: https://phabricator.services.mozilla.com/D286158
We always want to user aync notifications. The filtering controls how we draw if we use a pre-existing surface that has the wrong size, but in this case that is unlikely to happen due to the sync decode flag, but it would make the most sense if it did. We should update this to use best practices in case this code gets copied (which is exactly how this issue came up).
Differential Revision: https://phabricator.services.mozilla.com/D278253
Nicolò Ribaudo