This reverts commit bde4bcc89a.
Revert "Bug 2019113 - Part 3: Provide the window to createLinuxDesktopEntry when pinning. r=nrishel"
This reverts commit f38b471713.
Revert "Bug 2019113 - Part 2: Add tests for DynamicLauncher portal usage from the browser. r=emilio,extension-reviewers,robwu,gerard-majax,Thinker,ahal"
This reverts commit 89a81eb63b.
Revert "Bug 2019113 - Part 1: Use the DynamicLauncher portal from createLinuxDesktopEntry and deleteLinuxDesktopEntry. r=emilio,nrishel"
This reverts commit b6b202794e.
Worst part is, this is the obvious case! Wasn't caught because the tests
generally use an absolute path or empty string as argv[0], instead of
the more likely "firefox" etc.
Differential Revision: https://phabricator.services.mozilla.com/D294450
This reverts commit d96e9bd92c.
Revert "Bug 1993543 - Change XPCOMUtils.defineLazyServiceGetter(s) calls to pass an nsIID rather than a string. r=firefox-desktop-core-reviewers ,mtigley,joschmidt,perftest-reviewers,home-newtab-reviewers,nbarrett,Gijs,sparky"
This reverts commit 024c584172.
Mainly manual fixes to fix issues found in the jsdoc comments now that they're recognised correctly.
Also removes some configuration that is no longer needed as it is now the default.
Differential Revision: https://phabricator.services.mozilla.com/D268569
Mainly manual fixes to fix issues found in the jsdoc comments now that they're recognised correctly.
Also removes some configuration that is no longer needed as it is now the default.
Differential Revision: https://phabricator.services.mozilla.com/D268569
A quirk of the JavaScript implementation of XPCOM's QueryInterface is that it loads the interface's functions onto the queried object. For Services like `ShellService` this creates situations where the interface can be initialized at a distance, causing races depending on how Firefox is run - e.g. Desktop vs Background Task. To ensure consistent behavior this patch forces `ShellService` initialization of the native interface so that the native functions are always present.
To accomplish this, `nsIWindowsShellService` has been modified to inherit from `nsIShellService` to match other platforms and ensure that querying it also loads the `nsIShellService` members into `shellService`.
Differential Revision: https://phabricator.services.mozilla.com/D222154
This succeeds in normal Firefox due to `QueryInterface(Ci.nsIWindowsShellService)` having likely been called on the `nsIShellService` prior to this call, which populates the root `nsIShellService` JavaScript object with the queried interface methods. In Firefox Background Tasks the relevant `QueryInterface` is unlikely to be called ahead of time, resulting in an exception.
Differential Revision: https://phabricator.services.mozilla.com/D221540
- Remove redundant check for `regRename` pref when deciding whether to show set default guidance notification
- Update guidance notification test helper to set `setDefaultBrowserUserChoice` to the same value as `...regRename` to make tests that include one-click being enabled more accurate.
These updates should not change the user experience.
Differential Revision: https://phabricator.services.mozilla.com/D215218
- Remove redundant check for `regRename` pref when deciding whether to show set default guidance notification
- Update guidance notification test helper to set `setDefaultBrowserUserChoice` to the same value as `...regRename` to make tests that include one-click being enabled more accurate.
These updates should not change the user experience.
Differential Revision: https://phabricator.services.mozilla.com/D215218
This commit includes the changes to call into the new asynchronous code to set the browser as default, using powershell.
While here, we add more logging to this interaction to allow easier
debugging with QA.
Differential Revision: https://phabricator.services.mozilla.com/D194949
This commit includes the changes to call into the new asynchronous code to set the browser as default, using powershell.
While here, we add more logging to this interaction to allow easier
debugging with QA.
Differential Revision: https://phabricator.services.mozilla.com/D194949
Duncan McIntosh