Commit Graph
88 Commits
Author SHA1 Message Date
Duncan McIntosh 932a9290b3 Bug 2019113 - Part 1: Use the DynamicLauncher portal from createLinuxDesktopEntry and deleteLinuxDesktopEntry. r=emilio,nrishel
Differential Revision: https://phabricator.services.mozilla.com/D285828
2026-05-28 23:47:02 +00:00
Duncan McIntosh 7837ad3c93 Bug 2039681 - Add nsGNOMEShellService.getGlibPrgname and use it from StartupTelemetry. r=emilio
The telemetry previously only looked at remotingName, which isn't
accurate if --name is used. Prefer g_get_prgname here since it's used as
the default wmclass, so it better matches what we want to measure.

Differential Revision: https://phabricator.services.mozilla.com/D300629
2026-05-19 16:15:55 +00:00
iulian moraru 806660fa25 Revert "Bug 2019113 - Post: Display the page action on Flatpak and Snap installations. r=nrishel" for causing ThreadSanitizer failures on nsCharTraits.h.
This reverts commit bde4bcc89a.

Revert "Bug 2019113 - Part 3: Provide the window to createLinuxDesktopEntry when pinning. r=nrishel"

This reverts commit f38b471713.

Revert "Bug 2019113 - Part 2: Add tests for DynamicLauncher portal usage from the browser. r=emilio,extension-reviewers,robwu,gerard-majax,Thinker,ahal"

This reverts commit 89a81eb63b.

Revert "Bug 2019113 - Part 1: Use the DynamicLauncher portal from createLinuxDesktopEntry and deleteLinuxDesktopEntry. r=emilio,nrishel"

This reverts commit b6b202794e.
2026-05-15 02:36:09 +00:00
Duncan McIntosh b6b202794e Bug 2019113 - Part 1: Use the DynamicLauncher portal from createLinuxDesktopEntry and deleteLinuxDesktopEntry. r=emilio,nrishel
Differential Revision: https://phabricator.services.mozilla.com/D285828
2026-05-14 21:15:36 +00:00
Duncan McIntosh 02813eca77 Bug 2038377 - Initialize nsGNOMEShellService even if headless. r=emilio
Originally this check was added in bug 1368211 due to GConf error
messages when running headless. We no longer use GConf, so that
shouldn't (crosses fingers) be a problem.

This also removes the comment about checking for GIO and GSettings---it
looks like those used to have checks, but now just the comment remains.

Differential Revision: https://phabricator.services.mozilla.com/D299817
2026-05-11 21:54:17 +00:00
Duncan McIntosh cd38c2d35f Bug 2032619 - Part 2: Add a telemetry metric determining whether the user has a desktop entry for the browser. r=mossop,emilio
Differential Revision: https://phabricator.services.mozilla.com/D294800
2026-05-08 22:28:54 +00:00
Sylvestre Ledru bbcc7547a3 Bug 2023419 - Remove Emacs/Vim modelines from browser/ r=emilio,mkaply,webcompat-reviewers,extension-reviewers,credential-management-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,desktop-theme-reviewers,win-reviewers,omc-reviewers,migration-reviewers,home-newtab-reviewers,ai-frontend-reviewers,browser-installer-reviewers,profiles-reviewers,ip-protection-reviewers,mconley,sfoster,twisniewski,thecount,flozia,gstoll,sthompson,mimi,kpatenio,rpl,dimi,mossop,akulyk,aborondo
Differential Revision: https://phabricator.services.mozilla.com/D287835
2026-04-17 22:55:57 +00:00
Duncan McIntosh dbcfc293e8 Bug 2021897 - Refer to Firefox by a relative path instead of an absolute path if possible when creating a desktop entry. r=nrishel,emilio
Differential Revision: https://phabricator.services.mozilla.com/D290515
2026-04-07 21:09:02 +00:00
serge-sans-paille 115d971353 Bug 2025273 - Activate modernize-loop-convert clang-tidy check r=media-playback-reviewers,webrtc-reviewers,profiler-reviewers,firefox-svg-reviewers,canaltinova,longsonr,mjf,alwu
This is mostly the result of running ./mach static-analysis check --fix
with the new linter activated, with the following caveats:

- use std::fill when it makes sense
- use appropriate names for the loop target variable
- fix constness
- use array default initialization instead of an explicit loop when it
  makes sense

Differential Revision: https://phabricator.services.mozilla.com/D289172
2026-03-26 12:27:13 +00:00
rperta 93d1074012 Revert "Bug 2023419 - Remove Emacs/Vim modelines from browser/ r=emilio,mkaply,webcompat-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,desktop-theme-reviewers,win-reviewers,migration-reviewers,home-newtab-reviewers,ai-frontend-reviewers,mconley,twisniewski,thecount,flozia,gstoll,sthompson" for causing node related failures
This reverts commit 3ae5875024.
2026-03-16 20:46:05 +00:00
Sylvestre Ledru 3ae5875024 Bug 2023419 - Remove Emacs/Vim modelines from browser/ r=emilio,mkaply,webcompat-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,desktop-theme-reviewers,win-reviewers,migration-reviewers,home-newtab-reviewers,ai-frontend-reviewers,mconley,twisniewski,thecount,flozia,gstoll,sthompson
replaced by .editorconfig
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D287835
2026-03-16 20:06:36 +00:00
serge-sans-paille 1667ec582b Bug 1995723 - Remove unused inclusion of mozilla/ArrayUtils.h r=necko-reviewers,application-update-reviewers,media-playback-reviewers,profiler-reviewers,win-reviewers,firefox-svg-reviewers,layout-reviewers,gstoll,canaltinova,bytesized,alwu,dholbert
Differential Revision: https://phabricator.services.mozilla.com/D269573
2025-10-23 07:30:37 +00:00
agoloman 68648b85d8 Revert "Bug 1985098 - Replace createWindowsIcon with nsIShellService.createIcon and implement it for Linux. r=nrishel,mossop" for causing xpc failures @test_createIcon.js.
This reverts commit d6e686af50.
2025-09-02 22:26:17 +00:00
Duncan McIntosh d6e686af50 Bug 1985098 - Replace createWindowsIcon with nsIShellService.createIcon and implement it for Linux. r=nrishel,mossop
Differential Revision: https://phabricator.services.mozilla.com/D263033
2025-09-02 21:45:48 +00:00
Emilio Cobos Álvarez 64c39d476f Bug 1980822 - Modernize GSettings interface. r=stransky
We don't really need to support scripting except for a single shell
test. Expose a much more reduced API for that instead.

Differential Revision: https://phabricator.services.mozilla.com/D259725
2025-08-04 15:45:50 +00:00
Ciprian Todea 604dcd0113 Revert "Bug 1980822 - Modernize GSettings interface. r=stransky" for causing xpcshell failures at test_ext_native_messaging_portal.js
This reverts commit 5cac513efe.

This reverts commit 6bddb1feb8.
2025-08-04 13:15:11 +00:00
Emilio Cobos Álvarez 5cac513efe Bug 1980822 - Modernize GSettings interface. r=stransky
We don't really need to support scripting except for a single shell
test. Expose a much more reduced API for that instead.

Differential Revision: https://phabricator.services.mozilla.com/D259725
2025-08-04 09:39:37 +00:00
Duncan McIntosh 6d6f160a3f Bug 1968563 - Avoid deprecated/removed 'draw-background' key when setting wallpaper on GNOME. r=mossop
The draw-background key was removed from gsettings-desktop-schemas in
2013 [0], but was patched into Ubuntu until 21.10. Since it was
apparently unused over a decade ago, remove all reference to the key.

Removing the references in the tests would be sufficient to fix the bug,
but then (a) running the test on older systems wouldn't restore the
key's value, and (b) it just errors on new systems, so there's no point
in running it.

[0]: https://gitlab.gnome.org/GNOME/gsettings-desktop-schemas/-/commit/a59b45e766a2b3732b3bd2473ee5fbe7607a7f75

Differential Revision: https://phabricator.services.mozilla.com/D251353
2025-05-28 20:38:43 +00:00
serge-sans-paille 262f78c07f Bug 1922838 - Replace ArrayLength, ArrayEnd and MOZ_ARRAY_LENGTH by standard alternative r=glandium,necko-reviewers,jgilbert,application-update-reviewers,media-playback-reviewers,credential-management-reviewers,anti-tracking-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,bytesized,janv,dimi,daisuke,karlt,gstoll,canaltinova,timhuang
Namely std::size, std::end and std::size. This drops C support for
MOZ_ARRAY_LENGTH but it wasn't used anyway.

Differential Revision: https://phabricator.services.mozilla.com/D224611
2024-10-28 08:21:19 +00:00
Alexandru Marc a5eb905bf4 Backed out changeset d92f391b3b0c (bug 1922838) for backing out bug 1915351 2024-10-25 16:42:33 +03:00
serge-sans-paille 07101ac24d Bug 1922838 - Replace ArrayLength, ArrayEnd and MOZ_ARRAY_LENGTH by standard alternative r=glandium,necko-reviewers,jgilbert,application-update-reviewers,media-playback-reviewers,credential-management-reviewers,anti-tracking-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,bytesized,janv,dimi,daisuke,karlt,gstoll,canaltinova,timhuang
Namely std::size, std::end and std::size. This drops C support for
MOZ_ARRAY_LENGTH but it wasn't used anyway.

Differential Revision: https://phabricator.services.mozilla.com/D224611
2024-10-24 09:06:01 +00:00
Alexandru Marc 004e704b22 Backed out changeset 448597bce69d (bug 1922838) for causing build bustages. CLOSED TREE 2024-10-24 11:37:49 +03:00
serge-sans-paille 2c916d4973 Bug 1922838 - Replace ArrayLength, ArrayEnd and MOZ_ARRAY_LENGTH by standard alternative r=glandium,necko-reviewers,jgilbert,application-update-reviewers,media-playback-reviewers,credential-management-reviewers,anti-tracking-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,bytesized,janv,dimi,daisuke,karlt,gstoll,canaltinova,timhuang
Namely std::size, std::end and std::size. This drops C support for
MOZ_ARRAY_LENGTH but it wasn't used anyway.

Differential Revision: https://phabricator.services.mozilla.com/D224611
2024-10-24 07:38:30 +00:00
Masatoshi Kimura c2dc436126 Bug 1845057 - Remove aClaimAllTypes from setDefaultBrowser. r=nrishel,settings-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D189678
2023-10-02 16:56:42 +00:00
Emilio Cobos Álvarez e43ca4b09d Bug 1805939 - Have a central source of truth for desktop environment detection. r=stransky,jld
Gfx blocklist doesn't actually use the desktop environment filter so
remove that functionality. We can reintroduce it in the future if we
need it.

Differential Revision: https://phabricator.services.mozilla.com/D166090
2023-01-20 11:26:11 +00:00
serge-sans-paille 0e0495f341 Bug 1773148 - Cleanup browser/components/shell includes r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D148621
2022-06-08 09:53:54 +00:00
Emilio Cobos Álvarez 22b9131360 Bug 1767889 - Set both picture-uri and picture-uri-dark when setting desktop background in GSettings. r=stransky
Clean up a bit the code while at it.

Differential Revision: https://phabricator.services.mozilla.com/D145559
2022-05-09 13:38:38 +00:00
Emilio Cobos Álvarez 0a450d3a7b Bug 1760839 - Use more automatic memory management in GTK code. r=stransky
This fixes a couple potential leaks (e.g., see the UPowerClient changes,
we weren't freeing all the devices properly).

Differential Revision: https://phabricator.services.mozilla.com/D141775
2022-03-23 16:14:34 +00:00
Emilio Cobos Álvarez d0bf446ddd Bug 1757209 - Don't hardcode snap instance name. r=stransky
Differential Revision: https://phabricator.services.mozilla.com/D139761
2022-02-28 15:07:16 +00:00
Emilio Cobos Álvarez e6298545a7 Bug 1756083 - Remove useless ifdef. r=stransky
We never compile nsGNOMEShellService without MOZ_WIDGET_GTK.

Depends on D139474

Differential Revision: https://phabricator.services.mozilla.com/D139475
2022-02-23 13:59:33 +00:00
Emilio Cobos Álvarez 1773cc749b Bug 1756083 - Cleanup snap name handling and enable portal when running under either flatpak or snap. r=stransky
Differential Revision: https://phabricator.services.mozilla.com/D139474
2022-02-23 13:59:33 +00:00
Noemi Erli 25fde5f9ba Backed out changeset e6e6714aa40a (bug 1516290) for causing valgrind failures 2022-01-23 18:20:28 +02:00
Emilio Cobos Álvarez 914f203041 Bug 1516290 - Check for default browser using xdg-settings before trying to use the protocol handler. r=stransky
This seems worth doing regardless of whether we do D136076.

Differential Revision: https://phabricator.services.mozilla.com/D136623
2022-01-23 13:41:12 +00:00
Valentin Gosu 18e72be3f2 Bug 1599713 - Implement IsCurrentAppOSDefaultForProtocol on Linux (GTK) r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D113951
2021-05-27 06:42:56 +00:00
Emilio Cobos Álvarez ee54cf6cc6 Bug 1706299 - Remove nsIImageToPixBuf. r=stransky
It's just useless indirection.

Differential Revision: https://phabricator.services.mozilla.com/D112705
2021-04-21 09:29:51 +00:00
Olivier Tilloy 902128c1f3 Bug 1701182 - Prepend SNAP-specific prefix to shm path. r=stransky
Differential Revision: https://phabricator.services.mozilla.com/D110269
2021-04-09 14:41:31 +00:00
Butkovits Atila ae16c0d8fb Backed out changeset caf472555c8a (bug 1701182) for causing failure on test_snap_empty.js. CLOSED TREE 2021-04-08 05:26:26 +03:00
Olivier Tilloy b4ffd5f8fa Bug 1701182 - Prepend SNAP-specific prefix to shm path. r=stransky
Differential Revision: https://phabricator.services.mozilla.com/D110269
2021-04-07 20:55:42 +00:00
Andreea Pavel be87b88319 Backed out changeset c83c9af968f8 (bug 1701182) for build bustages at system_wrappers/gdk/gdk.h on a CLOSED TREE 2021-03-31 19:33:47 +03:00
Olivier Tilloy eb655eaef7 Bug 1701182 - Prepend SNAP-specific prefix to shm path. r=stransky
Differential Revision: https://phabricator.services.mozilla.com/D110269
2021-03-31 15:52:07 +00:00
Dorel Luca b6775d6b73 Backed out changeset 627da64827ab (bug 1701182) for build bustages in gecko/browser/components/shell/nsGNOMEShellService.cpp. CLOSED TREE 2021-03-30 21:32:39 +03:00
Olivier Tilloy 6f0abee85c Bug 1701182 - Prepend SNAP-specific prefix to shm path. r=stransky
Differential Revision: https://phabricator.services.mozilla.com/D110269
2021-03-30 18:03:30 +00:00
Valentin Gosu ef679fb98f Bug 1696193 - Stop setting Firefox as default handler for FTP r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D107079
2021-03-04 08:37:02 +00:00
Simon Giesecke 46908cfb51 Bug 1660470 - Add missing include directives/forward declarations. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D87865
2020-11-23 16:21:38 +00:00
Simon Giesecke a69d79b6db Bug 1648010 - Replace uses of NS_LITERAL_STRING/NS_LITERAL_CSTRING macros by _ns literals. r=geckoview-reviewers,jgilbert,agi,hsivonen,froydnj
Differential Revision: https://phabricator.services.mozilla.com/D80860
2020-07-01 08:29:29 +00:00
Martin Stransky 02d6c61742 Bug 1239694 Implemenet Gnome search provider, r=jhorak,mak
Implement org.gnome.Shell.SearchProvider2 D-Bus interface and enable it when
widget.gnome-search-provider.enabled pref is set, so this feature is disabled
by default.

Differential Revision: https://phabricator.services.mozilla.com/D69181
2020-04-29 18:02:23 +00:00
Bogdan Tara ba91b48f29 Backed out changeset cee5051ad409 (bug 1239694) for bustages complaining about dbus CLOSED TREE 2020-04-29 14:17:16 +03:00
Martin Stransky cadb2013e9 Bug 1239694 Implemenet Gnome search provider, r=jhorak,mak
Implement org.gnome.Shell.SearchProvider2 D-Bus interface and enable it when
widget.gnome-search-provider.enabled pref is set, so this feature is disabled
by default.

Differential Revision: https://phabricator.services.mozilla.com/D69181
2020-04-29 10:50:10 +00:00
Sergio Schvezov d3c7562131 Bug 1616870 - Correctly detect when running as a snap r=stransky
Differential Revision: https://phabricator.services.mozilla.com/D64741
2020-03-04 10:52:43 +00:00
Gabriele Svelto eeb9bfc398 Bug 1600545 - Remove useless inclusions of header files generated from IDL files in accessible/, browser/, caps/, chrome/, devtools/, docshell/, editor/, extensions/, gfx/, hal/, image/, intl/, ipc/, js/, layout/, and media/ r=Ehsan
The inclusions were removed with the following very crude script and the
resulting breakage was fixed up by hand. The manual fixups did either
revert the changes done by the script, replace a generic header with a more
specific one or replace a header with a forward declaration.

find . -name "*.idl" | grep -v web-platform | grep -v third_party | while read path; do
    interfaces=$(grep "^\(class\|interface\).*:.*" "$path" | cut -d' ' -f2)
    if [ -n "$interfaces" ]; then
        if [[ "$interfaces" == *$'\n'* ]]; then
          regexp="\("
          for i in $interfaces; do regexp="$regexp$i\|"; done
          regexp="${regexp%%\\\|}\)"
        else
          regexp="$interfaces"
        fi
        interface=$(basename "$path")
        rg -l "#include.*${interface%%.idl}.h" . | while read path2; do
            hits=$(grep -v "#include.*${interface%%.idl}.h" "$path2" | grep -c "$regexp" )
            if [ $hits -eq 0 ]; then
                echo "Removing ${interface} from ${path2}"
                grep -v "#include.*${interface%%.idl}.h" "$path2" > "$path2".tmp
                mv -f "$path2".tmp "$path2"
            fi
        done
    fi
done

Differential Revision: https://phabricator.services.mozilla.com/D55443
2019-12-06 09:16:44 +00:00