HeyPuter/firefox
1
0 Fork 0
mirror of https://github.com/HeyPuter/firefox.git synced 2026-11-13 20:14:57 -10:00
Code Issues Packages Projects Releases Wiki Activity
976,508 Commits 2 Branches 0 Tags
singlethreaded
Commit Graph
229 Commits
Author SHA1 Message Date
Duncan McIntosh f1eee99f1d Bug 2035732 - Don't check whether pinning is allowed before checking if the browser is pinned. r=nrishel 
Differential Revision: https://phabricator.services.mozilla.com/D298355
 2026-05-08 16:20:46 +00:00
Harshit 75c6fdd3e5 Bug 2035660 - Condition the IOpenWith api flag based on windows versions. r=nrishel 
Differential Revision: https://phabricator.services.mozilla.com/D297956
 2026-05-05 00:56:26 +00:00
Nicholas Rishel 5d6644eba8 Bug 2033172 - Add option to request pin to taskbar, without waiting for the request. r=cdupuis 
Differential Revision: https://phabricator.services.mozilla.com/D295124
 2026-04-18 02:30:40 +00:00
Sylvestre Ledru bbcc7547a3 Bug 2023419 - Remove Emacs/Vim modelines from browser/ r=emilio,mkaply,webcompat-reviewers,extension-reviewers,credential-management-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,desktop-theme-reviewers,win-reviewers,omc-reviewers,migration-reviewers,home-newtab-reviewers,ai-frontend-reviewers,browser-installer-reviewers,profiles-reviewers,ip-protection-reviewers,mconley,sfoster,twisniewski,thecount,flozia,gstoll,sthompson,mimi,kpatenio,rpl,dimi,mossop,akulyk,aborondo 
Differential Revision: https://phabricator.services.mozilla.com/D287835
 2026-04-17 22:55:57 +00:00
Antonio Borondo 27d957a99e Bug 2022767 - Focus the set default browser button in Windows Settings from Firefox r=cdupuis,Jamie,nika 
Differential Revision: https://phabricator.services.mozilla.com/D290084
 2026-04-10 06:52:12 +00:00
Nika Layzell 5f0f9dd22a Bug 2020817 - Part 4: Annotate & clean up nsACString callers of BeginReading/Data, r=xpcom-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,toolkit-telemetry-reviewers-rotation,layout-reviewers,dom-worker-reviewers,gfx-reviewers,webgpu-reviewers,necko-reviewers,dom-core,smaug,handyman,emilio,pehrsons,kershaw,timhuang,edenchuang,padenot,bradwerth 
This is a large number of largely mechanical changes. When possible, the code
was called to directly call `.get()` instead, performing the assertions
manually. In many places PromiseFlatCString() calls were added to dynamically
copy the strings into null terminated buffers if the string was not null
terminated.

Differential Revision: https://phabricator.services.mozilla.com/D286158
 2026-03-25 08:23:04 +00:00
Harshit Sohaney 0270278573 Bug 2019409 - Provide an api to launch the open with dialog on windows with a fallback to ms-settings. r=nrishel,omc-reviewers,aminomancer,drubino 
Differential Revision: https://phabricator.services.mozilla.com/D287228
 2026-03-20 19:39:24 +00:00
rperta 93d1074012 Revert "Bug 2023419 - Remove Emacs/Vim modelines from browser/ r=emilio,mkaply,webcompat-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,desktop-theme-reviewers,win-reviewers,migration-reviewers,home-newtab-reviewers,ai-frontend-reviewers,mconley,twisniewski,thecount,flozia,gstoll,sthompson" for causing node related failures 
This reverts commit 3ae5875024.
 2026-03-16 20:46:05 +00:00
Sylvestre Ledru 3ae5875024 Bug 2023419 - Remove Emacs/Vim modelines from browser/ r=emilio,mkaply,webcompat-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,desktop-theme-reviewers,win-reviewers,migration-reviewers,home-newtab-reviewers,ai-frontend-reviewers,mconley,twisniewski,thecount,flozia,gstoll,sthompson 
replaced by .editorconfig
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D287835
 2026-03-16 20:06:36 +00:00
Antonio Borondo 07d3102cfa Bug 1908298 - Fix IsDefaultBrowser for MSIX builds r=cdupuis 
Differential Revision: https://phabricator.services.mozilla.com/D285970
 2026-03-09 07:33:41 +00:00
Timothy Nikkel 884a9c4296 Bug 2009131. Use async_notify and bilinear filtering for image Draw/GetFrame calls. r=gfx-reviewers,aosmond 
We always want to user aync notifications. The filtering controls how we draw if we use a pre-existing surface that has the wrong size, but in this case that is unlikely to happen due to the sync decode flag, but it would make the most sense if it did. We should update this to use best practices in case this code gets copied (which is exactly how this issue came up).

Differential Revision: https://phabricator.services.mozilla.com/D278253
 2026-01-20 13:55:33 +00:00
Duncan McIntosh ef8dd2aa3e Bug 2003933 - Replace the C++ implementation of createWindowsIcon with a JavaScript implementation. r=nrishel 
Differential Revision: https://phabricator.services.mozilla.com/D275002
 2026-01-19 19:38:01 +00:00
serge-sans-paille 7662b3abdc Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch 
It is replaced by a standard-conforming cast to (void) which is
understood the same by the compiler.

In some cases this could be replaced by `[[maybe_unused]]` but for
expression whose value is ignored, this requires storing to a temporary
variable first, so not going that way.

One notable change is that marking an object of type already_AddRefed as
unused used to implicitly leak memory. This is now made explicit.

Most of the heavy lifting was done through:

    $ git grep -l '\<Unused\> <<' | xargs sed -i -e 's/Unused << /(void)/g'
    $ git grep -l mozilla/Unused.h | xargs sed -i -e '/mozilla\/Unused.h/ d'

Differential Revision: https://phabricator.services.mozilla.com/D268706
 2025-10-21 19:36:01 +00:00
Cristina Horotan 8a1b1970b7 Revert "Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch" for causing Gtest failures on AlreadyAddRefed.h 
This reverts commit e98adca292.
 2025-10-21 16:16:29 +00:00
serge-sans-paille e98adca292 Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch 
It is replaced by a standard-conforming cast to (void) which is
understood the same by the compiler.

In some cases this could be replaced by `[[maybe_unused]]` but for
expression whose value is ignored, this requires storing to a temporary
variable first, so not going that way.

One notable change is that marking an object of type already_AddRefed as
unused used to implicitly leak memory. This is now made explicit.

Most of the heavy lifting was done through:

    $ git grep -l '\<Unused\> <<' | xargs sed -i -e 's/Unused << /(void)/g'
    $ git grep -l mozilla/Unused.h | xargs sed -i -e '/mozilla\/Unused.h/ d'

Differential Revision: https://phabricator.services.mozilla.com/D268706
 2025-10-21 15:05:17 +00:00
Cristina Horotan aab924e90d Revert "Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch" for causing build bustage at nsBrowserApp.cpp 
This reverts commit fd0ffa193c.
 2025-10-21 10:44:13 +00:00
serge-sans-paille fd0ffa193c Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch 
It is replaced by a standard-conforming cast to (void) which is
understood the same by the compiler.

In some cases this could be replaced by `[[maybe_unused]]` but for
expression whose value is ignored, this requires storing to a temporary
variable first, so not going that way.

One notable change is that marking an object of type already_AddRefed as
unused used to implicitly leak memory. This is now made explicit.

Most of the heavy lifting was done through:

    $ git grep -l '\<Unused\> <<' | xargs sed -i -e 's/Unused << /(void)/g'
    $ git grep -l mozilla/Unused.h | xargs sed -i -e '/mozilla\/Unused.h/ d'

Differential Revision: https://phabricator.services.mozilla.com/D268706
 2025-10-21 09:44:11 +00:00
Narcis Beleuzu e1e6bbb1c9 Revert "Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch" for causing bustages on Document.cpp 
This reverts commit b23c15e927.
 2025-10-21 06:34:58 +00:00
serge-sans-paille b23c15e927 Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch 
It is replaced by a standard-conforming cast to (void) which is
understood the same by the compiler.

In some cases this could be replaced by `[[maybe_unused]]` but for
expression whose value is ignored, this requires storing to a temporary
variable first, so not going that way.

One notable change is that marking an object of type already_AddRefed as
unused used to implicitly leak memory. This is now made explicit.

Most of the heavy lifting was done through:

    $ git grep -l '\<Unused\> <<' | xargs sed -i -e 's/Unused << /(void)/g'
    $ git grep -l mozilla/Unused.h | xargs sed -i -e '/mozilla\/Unused.h/ d'

Differential Revision: https://phabricator.services.mozilla.com/D268706
 2025-10-21 06:01:36 +00:00
serge-sans-paille 418a8f52a1 Bug 1994393 - Remove unused inclusion of mozilla/UniquePtrExtensions.h r=emilio 
Differential Revision: https://phabricator.services.mozilla.com/D268683
 2025-10-15 19:49:46 +00:00
agoloman 68648b85d8 Revert "Bug 1985098 - Replace createWindowsIcon with nsIShellService.createIcon and implement it for Linux. r=nrishel,mossop" for causing xpc failures @test_createIcon.js. 
This reverts commit d6e686af50.
 2025-09-02 22:26:17 +00:00
Duncan McIntosh d6e686af50 Bug 1985098 - Replace createWindowsIcon with nsIShellService.createIcon and implement it for Linux. r=nrishel,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D263033
 2025-09-02 21:45:48 +00:00
Nicholas Rishel 74292bb77c Bug 1972537 - Part 2: Prefer 256x256 for the SourceSurface used to generate Windows ICO images. r=dmcintosh 
This resolves scaling issues seen with images generated from SVGs.

Differential Revision: https://phabricator.services.mozilla.com/D260554
 2025-08-15 22:01:11 +00:00
Duncan McIntosh 1c7f55d8d8 Bug 1976020 - Part 2: Remove nsIWindowsShellService.getTaskbarTabShortcutPath and nsIWindowsShellService.getTaskbarTabPins. r=nrishel 
Differential Revision: https://phabricator.services.mozilla.com/D256311
 2025-07-24 22:59:14 +00:00
Duncan McIntosh ddd2725a59 Bug 1976020 - Part 1: Use relative paths when pinning and unpinning shortcuts. r=nrishel 
This removes the dependency on getTaskbarTabShortcutPath when unpinning,
freeing the way to remove it entirely.

Differential Revision: https://phabricator.services.mozilla.com/D257175
 2025-07-24 22:59:11 +00:00
Duncan McIntosh 809b0fea6b Bug 1974880 - Implement a function to delete shortcuts and remove them from the shortcut log. r=nrishel 
Differential Revision: https://phabricator.services.mozilla.com/D256310
 2025-07-24 22:59:07 +00:00
Duncan McIntosh c9701ad186 Bug 1938967 - Part 2: Use relative paths within Taskbar Tabs to create shortcuts. r=nrishel,fluent-reviewers,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D254747
 2025-07-17 17:30:38 +00:00
Duncan McIntosh 3644a62b47 Bug 1938967 - Part 1: Allow shortcuts to be located in subdirectories of the Start menu or desktop. r=nrishel 
This is intended for Taskbar Tabs, since it will allow all shortcuts for
taskbar tabs to be placed into a single folder. It also removes the
limit of ten shortcuts in a given folder, which matches the
uninstaller's behaviour; notwithstanding an INI parsing bug, it will
always terminate.

The uninstaller is already able to handle this; no changes are needed
there.

Differential Revision: https://phabricator.services.mozilla.com/D252417
 2025-07-17 17:30:35 +00:00
Alexandru Marc 93fa021ab9 Revert "Bug 1938967 - Part 2: Use relative paths within Taskbar Tabs to create shortcuts. r=nrishel,fluent-reviewers,bolsson" for causing bc failures @ browser_createWindowsShortcut.js 
This reverts commit 76c91e29a4.

Revert "Bug 1938967 - Part 1: Allow shortcuts to be located in subdirectories of the Start menu or desktop. r=nrishel"

This reverts commit 17f3a92d47.
 2025-07-14 23:34:48 +00:00
Duncan McIntosh 76c91e29a4 Bug 1938967 - Part 2: Use relative paths within Taskbar Tabs to create shortcuts. r=nrishel,fluent-reviewers,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D254747
 2025-07-14 17:24:59 +00:00
Duncan McIntosh 17f3a92d47 Bug 1938967 - Part 1: Allow shortcuts to be located in subdirectories of the Start menu or desktop. r=nrishel 
This is intended for Taskbar Tabs, since it will allow all shortcuts for
taskbar tabs to be placed into a single folder. It also removes the
limit of ten shortcuts in a given folder, which matches the
uninstaller's behaviour; notwithstanding an INI parsing bug, it will
always terminate.

The uninstaller is already able to handle this; no changes are needed
there.

Differential Revision: https://phabricator.services.mozilla.com/D252417
 2025-07-14 17:24:56 +00:00
Francesco Lodolo 8e18c07c8c Bug 1969793 - Correct path to setDesktopBackground.ftl in nsWindowsShellService, r=saschanaz 
Differential Revision: https://phabricator.services.mozilla.com/D252151
 2025-06-02 15:04:42 +00:00
jilvin 0e104cbe54 Bug 1902439 - Checks return of nsIOutputStream::Write() to NS_OK in WriteBitmap() to handle failures better. r=mpohle,nrishel 
Differential Revision: https://phabricator.services.mozilla.com/D234318
 2025-05-20 17:37:48 +00:00
Francesco Lodolo (:flod) 88fdda4cc7 Bug 1955747 - Migrate strings in shellservice.properties to Fluent, r=nrishel,eemeli 
Differential Revision: https://phabricator.services.mozilla.com/D242977
 2025-04-02 05:42:44 +00:00
Eric Chen 67bb7296ec Bug 1955385 - revise MSIX code path for CheckCurrentProcessAUMIDForTesting r=nrishel 
Differential Revision: https://phabricator.services.mozilla.com/D242588
 2025-03-23 19:07:20 +00:00
Eric Chen 192c0c6787 Bug 1950734 - Make MSIX builds skip the AUMID altering steps in taskbar pinning as it's unnecessary r=nrishel 
Differential Revision: https://phabricator.services.mozilla.com/D239827
 2025-03-19 20:41:18 +00:00
Cristina Horotan bb136e0d12 Backed out changeset c7a895ce1e23 (bug 1950734) for causing bc failures at browser_processAUMID.js. CLOSED TREE 2025-03-13 07:31:36 +02:00
Eric Chen 3fa85c5c7a Bug 1950734 - Make MSIX builds skip the AUMID altering steps in taskbar pinning as it's unnecessary r=nrishel 
Differential Revision: https://phabricator.services.mozilla.com/D239827
 2025-03-12 23:45:49 +00:00
Eric Chen d4bc2bcaee Bug 1949263 - prevent MSIX Firefox from calling PollAppsFolderForShortcut r=nrishel 
Differential Revision: https://phabricator.services.mozilla.com/D239824
 2025-03-03 15:34:20 +00:00
Nicholas Rishel 7034f58767 Bug 1932795 - Fix debug build assert by moving SourceSurface::GetFrame call to main thread during nsWindowsShellService::CreateWindowsIcon. r=nalexander,win-reviewers,rkraesig 
Differential Revision: https://phabricator.services.mozilla.com/D229849
 2024-11-27 21:56:01 +00:00
Nicholas Rishel 57ab7f1ebd Bug 1930048 - Fix MinGW compile errors. r=mpohle,win-reviewers,gstoll 
Tagalong: Clean up include order and remove unnecessary includes.

Differential Revision: https://phabricator.services.mozilla.com/D229033
 2024-11-14 20:45:22 +00:00
Max Christian Pohle 846bcd126a Bug 1923448 - Generalized Windows Pinning, r=nrishel,gfx-reviewers,nical 
Differential Revision: https://phabricator.services.mozilla.com/D224975
 2024-11-12 22:48:55 +00:00
Nicholas Rishel 2a8da6a369 Bug 1893458 - Verify Start Menu shortcuts created at runtime have propagated to shell:appsfolder before attempting to pin them. r=win-reviewers,rkraesig 
Differential Revision: https://phabricator.services.mozilla.com/D227131
 2024-11-07 21:51:23 +00:00
Stanca Serban 1cefb44ccb Backed out changeset 2fe294eb4a06 (bug 1923448) for causing nsWindowsShellService.cpp. CLOSED TREE 2024-11-07 12:37:21 +02:00
Max Christian Pohle 423ab686ff Bug 1923448 - Generalized Windows Pinning, r=nrishel,gfx-reviewers,nical 
Differential Revision: https://phabricator.services.mozilla.com/D224975
 2024-11-07 09:54:52 +00:00
Nicholas Rishel 085457c06f Bug 1926151 - Remove Desktop and Public Desktop from folders a pinnable shortcut can exist in. r=bhearsum 
We prioritize using `ITaskbarManager` now, which requires a shortcut exist in a location visible from `shell:appsfolder`. `IPinnedList3` can use shortcuts from Desktop and Public Desktop (and potentially other locations) but there's no reason to check for these cases since we have already created the shortcut for `ITaskbarManager`. The rare case of failing to create as shortcut for `ITaskbarManager` is not worth accounting for given `IPinnedList3` is not supported in newer versions of Windows.

Differential Revision: https://phabricator.services.mozilla.com/D227134
 2024-10-31 19:53:56 +00:00
Nicholas Rishel 51fef936bb Bug 1926151 - Pre: Rename Matching to Pinnable to better convey usage of hasPinnableShortcut. r=bhearsum,firefox-desktop-core-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D227133
 2024-10-31 19:53:55 +00:00
serge-sans-paille 262f78c07f Bug 1922838 - Replace ArrayLength, ArrayEnd and MOZ_ARRAY_LENGTH by standard alternative r=glandium,necko-reviewers,jgilbert,application-update-reviewers,media-playback-reviewers,credential-management-reviewers,anti-tracking-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,bytesized,janv,dimi,daisuke,karlt,gstoll,canaltinova,timhuang 
Namely std::size, std::end and std::size. This drops C support for
MOZ_ARRAY_LENGTH but it wasn't used anyway.

Differential Revision: https://phabricator.services.mozilla.com/D224611
 2024-10-28 08:21:19 +00:00
Alexandru Marc a5eb905bf4 Backed out changeset d92f391b3b0c (bug 1922838) for backing out bug 1915351 2024-10-25 16:42:33 +03:00
serge-sans-paille 07101ac24d Bug 1922838 - Replace ArrayLength, ArrayEnd and MOZ_ARRAY_LENGTH by standard alternative r=glandium,necko-reviewers,jgilbert,application-update-reviewers,media-playback-reviewers,credential-management-reviewers,anti-tracking-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,bytesized,janv,dimi,daisuke,karlt,gstoll,canaltinova,timhuang 
Namely std::size, std::end and std::size. This drops C support for
MOZ_ARRAY_LENGTH but it wasn't used anyway.

Differential Revision: https://phabricator.services.mozilla.com/D224611
 2024-10-24 09:06:01 +00:00