This reverts commit 1d08a5cd99.
Revert "Bug 2043267 - [devtools] Editing stylesheets in the debugger r=devtools-reviewers,ochameau"
This reverts commit 813e0fadb5.
Revert "Bug 2045710 - [devtools] Fix and add style sheet related test r=devtools-reviewers,ochameau"
This reverts commit 2fc4893d8a.
This reverts commit c07fcd7808.
Revert "Bug 2045710 - [devtools] Fix and add style sheet related test r=devtools-reviewers,ochameau" for causing node failures in devtools/client/*
This reverts commit e46af7df05.
With the profiler started by default during mochitests (MOZ_PROFILER_STARTUP=1),
opening the devtools performance panel reports a "recording" state, so closing
the toolbox makes ProfilerEventHandling.componentWillUnmount issue a
stopProfilerAndDiscardProfile request that races the connection teardown and
rejects. The toolbox tests don't use the profiler themselves, so they allow that
harmless rejection (see bug 2044383) and keep the profiler running. The
about:debugging profiler dialog test does drive the profiler, so it stops any
already-running profiler first via ProfilerTestUtils.assertProfilerInactive.
Differential Revision: https://phabricator.services.mozilla.com/D304133
Bug 2033191 made sure we only call ownerGlobal on nodes.
As per the discussion in dev-platform, the front-end ~always wants
.documentGlobal. This removes ownerGlobal from the bindings. Following
patch will rename internal GetOwnerGlobal in gecko to GetRelevantGlobal
as per the HTML spec terminology.
Differential Revision: https://phabricator.services.mozilla.com/D297183
Bug 2033191 made sure we only call ownerGlobal on nodes.
As per the discussion in dev-platform, the front-end ~always wants
.documentGlobal. This removes ownerGlobal from the bindings. Following
patch will rename internal GetOwnerGlobal in gecko to GetRelevantGlobal
as per the HTML spec terminology.
Differential Revision: https://phabricator.services.mozilla.com/D297183
Bug 2033191 made sure we only call ownerGlobal on nodes.
As per the discussion in dev-platform, the front-end ~always wants
.documentGlobal. This removes ownerGlobal from the bindings. Following
patch will rename internal GetOwnerGlobal in gecko to GetRelevantGlobal
as per the HTML spec terminology.
Differential Revision: https://phabricator.services.mozilla.com/D297183
Bug 2033191 made sure we only call ownerGlobal on nodes.
As per the discussion in dev-platform, the front-end ~always wants
.documentGlobal. This removes ownerGlobal from the bindings. Following
patch will rename internal GetOwnerGlobal in gecko to GetRelevantGlobal
as per the HTML spec terminology.
Differential Revision: https://phabricator.services.mozilla.com/D297183
This is written by greening up the tree with the following patch:
https://hg.mozilla.org/try/rev/4f0388e9b8f76ff3008d3ec74ee793bb8f9fc364
All uses are effectively one of these categories:
* windowRoot.ownerGlobal usage. Replaced by an explicit .window
property.
* Things that accidentally were given a window when they expected an
element. Fixed by fixing callers as appropriate. Examples of these
are using isBrowserPrivate(window) or so, or various test methods
that expect a <browser> or <tabbrowser> and were given a Window.
* Things that had a window-or-node and used ownerGlobal to normalize to
a window. E.g. the AutoScrollChild or extensions code. Fixed by
checking explicitly for Window.
* Things that had a window and called ownerGlobal on it. Fixed by just
removing the ownerGlobal accessor.
Main idea after this is to replace all .ownerGlobal usage with
.documentGlobal, and remove .ownerGlobal from JS (maybe exposing
.relevantGlobal if absolutely needed).
Differential Revision: https://phabricator.services.mozilla.com/D295189
This is written by greening up the tree with the following patch:
https://hg.mozilla.org/try/rev/4f0388e9b8f76ff3008d3ec74ee793bb8f9fc364
All uses are effectively one of these categories:
* windowRoot.ownerGlobal usage. Replaced by an explicit .window
property.
* Things that accidentally were given a window when they expected an
element. Fixed by fixing callers as appropriate. Examples of these
are using isBrowserPrivate(window) or so, or various test methods
that expect a <browser> or <tabbrowser> and were given a Window.
* Things that had a window-or-node and used ownerGlobal to normalize to
a window. E.g. the AutoScrollChild or extensions code. Fixed by
checking explicitly for Window.
* Things that had a window and called ownerGlobal on it. Fixed by just
removing the ownerGlobal accessor.
Main idea after this is to replace all .ownerGlobal usage with
.documentGlobal, and remove .ownerGlobal from JS (maybe exposing
.relevantGlobal if absolutely needed).
Differential Revision: https://phabricator.services.mozilla.com/D295189
This reverts commit 85b2d0d3dd.
Revert "Bug 2022763 - Propagate owner global from input element to DOM files properly. r=dom-core,win-reviewers,smaug,gstoll"
This reverts commit ff40c521b2.
"devtools.debugger.features.javascript-tracing" is still relevant on
other channels and fully enable the tracer (toolbox button and
keyshortcuts automatically enabled).
Otherwise the tracer is rather controlled by
"devtools.command-button-jstracer.enabled" preference, which typically
requires user's action to enable to button from the settings panel.
Differential Revision: https://phabricator.services.mozilla.com/D289229
"devtools.debugger.features.javascript-tracing" is still relevant on
other channels and fully enable the tracer (toolbox button and
keyshortcuts automatically enabled).
Otherwise the tracer is rather controlled by
"devtools.command-button-jstracer.enabled" preference, which typically
requires user's action to enable to button from the settings panel.
Differential Revision: https://phabricator.services.mozilla.com/D289229
"devtools.debugger.features.javascript-tracing" is still relevant on
other channels and fully enable the tracer (toolbox button and
keyshortcuts automatically enabled).
Otherwise the tracer is rather controlled by
"devtools.command-button-jstracer.enabled" preference, which typically
requires user's action to enable to button from the settings panel.
Differential Revision: https://phabricator.services.mozilla.com/D289229
"devtools.debugger.features.javascript-tracing" is still relevant on
other channels and fully enable the tracer (toolbox button and
keyshortcuts automatically enabled).
Otherwise the tracer is rather controlled by
"devtools.command-button-jstracer.enabled" preference, which typically
requires user's action to enable to button from the settings panel.
Differential Revision: https://phabricator.services.mozilla.com/D289229
After analyzing logs with MOZ_LOG=devtools_resourcecommand:5 we can see we start watching for document-event resources
too late, after the resource was received and emitted.
This means the popupFrameBtn.click(); line was not responsible for triggering the dom-complete resource.
Analyzing the rest of the logs, we can see only one document-event dom-complete resource is created, so
we are just waiting for it too late.
Adding a small delay before we call toolbox.commands.resourceCommand.waitForNextResource we can identify
that the actual trigger for the resource is clickOnAddonWidget(ADDON_ID);
Thanks MOZ_LOG.
Differential Revision: https://phabricator.services.mozilla.com/D286227
The `gBrowser.reloadTab` method was doing a very light reload,
which could preserve iframe overriden locations.
The new method ensures we load the original HTML content back,
this seems to also have an impact on keep-alive which is not longer guaranteed.
Only supports reloading the currently selected tab, to better replicate
real user scenarios. But also to comply to `BrowserCommands.reload`,
which only supports reloading the selected tab.
Also tune the har test, now that requests are really cancelled
and we may try to fetch reponse content for such request.
Differential Revision: https://phabricator.services.mozilla.com/D277433
In most cases, the manifest contained already the same annotation for 2404, so I simply removed the 1804 one, since we no longer run tests on this platform.
In a few cases, the 1804 annotation did not have a 2404 match. In that case I just checked if we had recorded intermittent failures. If yes, I migrated the annotation, if not, I just removed it.
Differential Revision: https://phabricator.services.mozilla.com/D271355
Hubert B Manilla