Commit Graph
39 Commits
Author SHA1 Message Date
Emilio Cobos Álvarez d659585c8e Bug 1884294 - Fix a test snapshot.
MANUAL PUSH: Trivial orange fix CLOSED TREE
2024-03-08 14:47:06 +01:00
Emilio Cobos Álvarez c8d2c23403 Bug 1824886 - Rewrite AnonymousContent to use a shadow tree. r=smaug,TYLin,sfoster,devtools-reviewers,nchevobbe
Subtle things:

 * We now have shadow trees in NAC, inception! Only a couple lines of
   code in the style system had to be changed to match :host rules and
   so properly.

 * Had to make highlighters.css contentaccessible, because otherwise we
   can't load it from the shadow tree. I don't think it's a big deal.

 * I removed some of the code from highlighters.css that claimed that
   stuff inherited from the html element. That's just no longer true.

 * Had to switch from `setAttribute("style", ...)` to `.style = ...;`.
   This is needed because CSSOM from chrome code bypasses CSP (as
   AnonymousContent did), but setAttribute() doesn't, see bug 1424474.

Differential Revision: https://phabricator.services.mozilla.com/D173998
2023-07-09 11:34:05 +00:00
Stanca Serban 27c720052b Backed out changeset 1c835137f532 (bug 1824886) for causing multiple failures. CLOSED TREE 2023-07-06 02:11:59 +03:00
Emilio Cobos Álvarez 8053b896a6 Bug 1824886 - Rewrite AnonymousContent to use a shadow tree. r=smaug,TYLin,sfoster,devtools-reviewers,nchevobbe
Subtle things:

 * We now have shadow trees in NAC, inception! Only a couple lines of
   code in the style system had to be changed to match :host rules and
   so properly.

 * Had to make highlighters.css contentaccessible, because otherwise we
   can't load it from the shadow tree. I don't think it's a big deal.

 * I removed some of the code from highlighters.css that claimed that
   stuff inherited from the html element. That's just no longer true.

 * Had to switch from `setAttribute("style", ...)` to `.style = ...;`.
   This is needed because CSSOM from chrome code bypasses CSP (as
   AnonymousContent did), but setAttribute() doesn't, see bug 1424474.

Differential Revision: https://phabricator.services.mozilla.com/D173998
2023-07-05 21:59:44 +00:00
Cosmin Sabou 20fa44fbeb Backed out 2 changesets (bug 1824886) for causing failures on browser_all_files_referenced.js. CLOSED TREE
Backed out changeset 650ef77d1c4d (bug 1824886)
Backed out changeset 1c835137f532 (bug 1824886)
2023-07-06 00:42:53 +03:00
Emilio Cobos Álvarez b1433254b6 Bug 1824886 - Rewrite AnonymousContent to use a shadow tree. r=smaug,TYLin,sfoster,devtools-reviewers,nchevobbe
Subtle things:

 * We now have shadow trees in NAC, inception! Only a couple lines of
   code in the style system had to be changed to match :host rules and
   so properly.

 * Had to make highlighters.css contentaccessible, because otherwise we
   can't load it from the shadow tree. I don't think it's a big deal.

 * I removed some of the code from highlighters.css that claimed that
   stuff inherited from the html element. That's just no longer true.

 * Had to switch from `setAttribute("style", ...)` to `.style = ...;`.
   This is needed because CSSOM from chrome code bypasses CSP (as
   AnonymousContent did), but setAttribute() doesn't, see bug 1424474.

Differential Revision: https://phabricator.services.mozilla.com/D173998
2023-07-05 18:21:31 +00:00
Alexandre Poirot f082da3878 Bug 1792847 - [devtools] Use absolute URLs to import modules in devtools/client/application. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D158371
2022-09-30 15:17:35 +00:00
Mark Banner 6d03c63e2d Bug 1330099 - Enable object-shorthand eslint rule. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D153567
2022-08-03 14:57:05 +00:00
Nicolas Chevobbe 124ea2f1a0 Bug 1573779 - [devtools] Rename WorkerTarget to WorkerDescriptor. r=ochameau,jdescottes,devtools-backward-compat-reviewers.
This renames the current WorkerTargetActor which is actually a descriptor.
We also rename the existing `workerTargetFront` occurences to `workerDescriptorFront`
to avoid confusion when we do introduce the real worker fronts and actors.

Differential Revision: https://phabricator.services.mozilla.com/D91100
2020-09-29 14:30:24 +00:00
Dorel Luca 2767dba5fe Backed out 3 changesets (bug 1573779, bug 1662734) for Geckoview failures. CLOSED TREE
Backed out changeset 0adff4f08b28 (bug 1662734)
Backed out changeset c6bb84f2a032 (bug 1573779)
Backed out changeset 0c605800aa6b (bug 1573779)
2020-09-29 12:59:39 +03:00
Nicolas Chevobbe afff47ed89 Bug 1573779 - [devtools] Rename WorkerTarget to WorkerDescriptor. r=ochameau,jdescottes,devtools-backward-compat-reviewers.
This renames the current WorkerTargetActor which is actually a descriptor.
We also rename the existing `workerTargetFront` occurences to `workerDescriptorFront`
to avoid confusion when we do introduce the real worker fronts and actors.

Differential Revision: https://phabricator.services.mozilla.com/D91100
2020-09-28 12:27:22 +00:00
Belén Albeza a25e69d62c Bug 1653998 - View source of worker from the Application panel r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D86039
2020-08-07 12:47:34 +00:00
Belén Albeza aa80cfb303 Bug 1637538 - Change debug button in the Application panel for a link as per latest UX mockups r=jdescottes,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D85605
2020-08-04 18:36:38 +00:00
Belén Albeza 60cc1d1674 Bug 1639605 - Part 2: Add a new ManifestUrlItem component to show manifest URLs correctly in RTL mode r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D84724
2020-07-24 13:25:44 +00:00
Belén Albeza cc8a5d081f Bug 1639605 - Part 1: Fix display of colors in RTL mode in the Manifest page r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D84723
2020-07-24 13:17:04 +00:00
Belén Albeza 55914b96a3 Bug 1651630 - Part 2: Hide the debug button instead of disabling it r=jdescottes,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D83484
2020-07-16 13:41:24 +00:00
Belén Albeza 3d24f1f335 Bug 1651630 - Part 1: Allow start button to work regardless of debugger pref r=jdescottes,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D83482
2020-07-16 13:13:40 +00:00
Belén Albeza 9c3652b5c4 Bug 1643253 - Part 1: Add telemetry middleware to record application panel events r=jdescottes,janerik
Differential Revision: https://phabricator.services.mozilla.com/D82044
2020-07-13 14:58:29 +00:00
Belén Albeza 3e082eea6a Bug 1635402 - UX polish: empty pages r=jdescottes,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D81362
2020-07-13 15:36:35 +00:00
Tiger Oakes 73cbde7f97 Bug 1605688 - Strip alpha when opaque, r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D82266
2020-07-06 16:34:54 +00:00
Butkovits Atila 195003e687 Backed out changeset fa56a4ad6f4a (bug 1605688) for devtools failures on browser_devtools_api_destroy.js. CLOSED TREE 2020-07-01 02:17:31 +03:00
Tiger Oakes 764c606030 Bug 1605688 - Strip alpha when opaque, r=jdescottes,ladybenko
Differential Revision: https://phabricator.services.mozilla.com/D76062
2020-06-30 14:49:42 +00:00
Belén Albeza 5d3866c17b Bug 1635403 - Part 4: Do not push about:debugging plug to the bottom r=jdescottes
Depends on D75573

Differential Revision: https://phabricator.services.mozilla.com/D75576
2020-05-26 14:44:22 +00:00
Belén Albeza 26b455670a Bug 1635403 - Part 3: Fix icons in workers page when width is too thin r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D75573
2020-05-26 14:42:51 +00:00
Belén Albeza 6b344c7e0c Bug 1635403 - Part 2: Place the unregister button in different locations depending on layout r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D75571
2020-05-26 14:41:47 +00:00
Belén Albeza da255f31c4 Bug 1635401 - Part 4: Fix about:debugging link appearance r=jdescottes
Depends on D74668

Differential Revision: https://phabricator.services.mozilla.com/D74679
2020-05-13 12:20:32 +00:00
Belén Albeza 74b9bd0697 Bug 1635401 - Part 3: Fix registration scope appearance r=jdescottes
Depends on D74659

Differential Revision: https://phabricator.services.mozilla.com/D74668
2020-05-12 15:49:02 +00:00
Belén Albeza 8ed6dcafd2 Bug 1635401 - Part 2: add colored dot to mark service worker state r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D74659
2020-05-12 15:47:54 +00:00
Belén Albeza 161fbf68f8 Bug 1635401 - Part 1: fix font sizes, weights, paddings, margins, etc. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D74656
2020-05-12 15:46:43 +00:00
Belén Albeza 3df8bc5344 Bug 1633715: Move Service Workers sidebar item to the top r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D73263
2020-04-30 13:37:27 +00:00
Belén Albeza 40a6c1de21 Bug 1459962 - Part 5: Add Jest tests for Worker and Registration components r=jdescottes
And this should be the last commit of the stack - just Jest tests

Differential Revision: https://phabricator.services.mozilla.com/D72372
2020-04-24 15:47:17 +00:00
Belén Albeza 7cc79662b0 Bug 1459962 - Part 3: Split workers into separate Registration and Worker components r=jdescottes
In this patch we actually have separate `Worker` and `Registration` components. All workers belonging to the same registration appear together under it.

{F2134654}

Note: I left the `Debug` button shown for every worker because sometimes we do have a target even though the worker might be waiting. I'm not sure when/how this happens, but I was able to debug it as well.

{F2134655}

BTW I found a quick –and more reliable? I seems I don't need to reload- way of testing this. **STR**:

- Start a local HTTP server at `mozilla-central/devtools/client/application/test/browser/resources/service-workers`
- Open `localhost:8080/simple.html` (or whatever the port) and open devtools there
- Open `localhost:8080/debug.html` (or whatever the port) and open devtools there

You should be able to see both workers under the same registration scope.

Differential Revision: https://phabricator.services.mozilla.com/D72173
2020-04-24 16:56:01 +00:00
Belén Albeza 58beccada0 Bug 1459962 - Part 2: rename WorkerList* components to RegistrationList* r=jdescottes
As a result of the first part review and some testing, there were some issues re: repeating things among workers that actually belonged to the registration (the ID's for React keys, `Unregister` button, `Last updated` time…).

Initially I wanted to do the "grouping" of all the workers belonging to the same registration, but I think this is less confusing to use and test.

This patch initiates that work by renaming our `WorkerList` and `WorkerListEmpty` components to `Registration*`.

Differential Revision: https://phabricator.services.mozilla.com/D72172
2020-04-24 15:49:01 +00:00
Belén Albeza 0d3cdd1444 Bug 1459962 - Part 1: return all service workers for a given registration r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D70365
2020-04-24 11:14:58 +00:00
Belén Albeza 4b1eb098c1 Bug 1579795 - Part 3: Test the fetchManifest action separately r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D49596
2019-10-21 10:51:30 +00:00
Belén Albeza 4f7bd0186f Bug 1579795 - Part 2: Reorganize jest tests folder structure r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D49595
2019-10-21 10:50:28 +00:00
Oana Pop Rus acdded6218 Backed out 3 changesets (bug 1579795) for causing devtools node failures. on a CLOSED TREE
Backed out changeset 141f065f3788 (bug 1579795)
Backed out changeset eb0eaf505108 (bug 1579795)
Backed out changeset 193f93f381cd (bug 1579795)
2019-10-18 18:38:49 +03:00
Belén Albeza 5d649c4fcd Bug 1579795 - Part 3: Test the fetchManifest action separately r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D49596
2019-10-18 13:42:48 +00:00
Belén Albeza c672d731f1 Bug 1579795 - Part 2: Reorganize jest tests folder structure r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D49595
2019-10-18 15:08:49 +00:00