This reverts commit 1d08a5cd99.
Revert "Bug 2043267 - [devtools] Editing stylesheets in the debugger r=devtools-reviewers,ochameau"
This reverts commit 813e0fadb5.
Revert "Bug 2045710 - [devtools] Fix and add style sheet related test r=devtools-reviewers,ochameau"
This reverts commit 2fc4893d8a.
This reverts commit c07fcd7808.
Revert "Bug 2045710 - [devtools] Fix and add style sheet related test r=devtools-reviewers,ochameau" for causing node failures in devtools/client/*
This reverts commit e46af7df05.
- Use the id the of the source for the source actor `source` property
- Remove the `url` property from the source actor.
Differential Revision: https://phabricator.services.mozilla.com/D299409
This reverts commit 55b57c396d.
Revert "Bug 2011550 - [devtools] Cleanup the source actor object r=devtools-reviewers,ochameau"
This reverts commit 44fd7b4df2.
- Use the id the of the source for the source actor `source` property
- Remove the `url` property from the source actor.
Differential Revision: https://phabricator.services.mozilla.com/D299409
This prevents trigerring an actual network/HTTP request when the source has been GC-ed.
But this also ensure that the request is flagged with the propert browsingContext/browserId
and can later be associated with the right tab if we want to show these requests.
This may also help better reproducing the request as if done by the page (cookies,..).
Differential Revision: https://phabricator.services.mozilla.com/D301314
Instead of wrapping the "Inspector" word in the empty notice in a link, add a
proper button to open the inspector below the empty notice.
Add tests to make sure the empty notice is displayed when expected, and that
the "Open Inspector" button does work as expected.
Differential Revision: https://phabricator.services.mozilla.com/D297313
Bug 2033191 made sure we only call ownerGlobal on nodes.
As per the discussion in dev-platform, the front-end ~always wants
.documentGlobal. This removes ownerGlobal from the bindings. Following
patch will rename internal GetOwnerGlobal in gecko to GetRelevantGlobal
as per the HTML spec terminology.
Differential Revision: https://phabricator.services.mozilla.com/D297183
Bug 2033191 made sure we only call ownerGlobal on nodes.
As per the discussion in dev-platform, the front-end ~always wants
.documentGlobal. This removes ownerGlobal from the bindings. Following
patch will rename internal GetOwnerGlobal in gecko to GetRelevantGlobal
as per the HTML spec terminology.
Differential Revision: https://phabricator.services.mozilla.com/D297183
Bug 2033191 made sure we only call ownerGlobal on nodes.
As per the discussion in dev-platform, the front-end ~always wants
.documentGlobal. This removes ownerGlobal from the bindings. Following
patch will rename internal GetOwnerGlobal in gecko to GetRelevantGlobal
as per the HTML spec terminology.
Differential Revision: https://phabricator.services.mozilla.com/D297183
Bug 2033191 made sure we only call ownerGlobal on nodes.
As per the discussion in dev-platform, the front-end ~always wants
.documentGlobal. This removes ownerGlobal from the bindings. Following
patch will rename internal GetOwnerGlobal in gecko to GetRelevantGlobal
as per the HTML spec terminology.
Differential Revision: https://phabricator.services.mozilla.com/D297183
This patch adds the autocomplete package to leverage the closeBrackets extension.
The autocomplete paackage will also be benefical in the future when we want to migrate
to using the full auto complete feature in codemirror 6.
Differential Revision: https://phabricator.services.mozilla.com/D279497
This reverts commit 85b2d0d3dd.
Revert "Bug 2022763 - Propagate owner global from input element to DOM files properly. r=dom-core,win-reviewers,smaug,gstoll"
This reverts commit ff40c521b2.
"devtools.debugger.features.javascript-tracing" is still relevant on
other channels and fully enable the tracer (toolbox button and
keyshortcuts automatically enabled).
Otherwise the tracer is rather controlled by
"devtools.command-button-jstracer.enabled" preference, which typically
requires user's action to enable to button from the settings panel.
Differential Revision: https://phabricator.services.mozilla.com/D289229
"devtools.debugger.features.javascript-tracing" is still relevant on
other channels and fully enable the tracer (toolbox button and
keyshortcuts automatically enabled).
Otherwise the tracer is rather controlled by
"devtools.command-button-jstracer.enabled" preference, which typically
requires user's action to enable to button from the settings panel.
Differential Revision: https://phabricator.services.mozilla.com/D289229
"devtools.debugger.features.javascript-tracing" is still relevant on
other channels and fully enable the tracer (toolbox button and
keyshortcuts automatically enabled).
Otherwise the tracer is rather controlled by
"devtools.command-button-jstracer.enabled" preference, which typically
requires user's action to enable to button from the settings panel.
Differential Revision: https://phabricator.services.mozilla.com/D289229
"devtools.debugger.features.javascript-tracing" is still relevant on
other channels and fully enable the tracer (toolbox button and
keyshortcuts automatically enabled).
Otherwise the tracer is rather controlled by
"devtools.command-button-jstracer.enabled" preference, which typically
requires user's action to enable to button from the settings panel.
Differential Revision: https://phabricator.services.mozilla.com/D289229
We add a keyup listener in Popover to handle the Escape key
and close the popover.
We don't use the context shortcuts instance, as it uses a keydown
event listener which will be dispatched before the toolbox keydown
event listener is called, and so the popover would be close before
the shouldPreventSplitConsoleToggle is called.
Differential Revision: https://phabricator.services.mozilla.com/D284016
Updates Test Manifests to new conventions for the upcoming
linter patch in Bug 2004444. These conventions are documented in
docs/code-quality/lint/linters/test-manifest-toml.rst
which will get published to
https://firefox-source-docs.mozilla.org/code-quality/lint/linters/test-manifest-toml.html
Summary of changes:
- The order of comparisons/variables is now important in conditional
expressions. Certain expressions have been edited to reflect this
order (with no semantic changes).
- The variables which are tested for equality as well as all the flags
are constrained to a known set (i.e. typos in variable/flag names
will be caught by the linter)
- Older platforms which are no longer present in the CI infrastructure
have been deprecated, for example:
* ``"os == 'linux' && os_version == '18.04'
- Combinations of platforms and flags which are no longer present in
the CI infrastructure will be removed, for example:
* ``"os == 'linux' && os_version == '22.04' && asan"``
* ``"os == 'linux' && os_version == '22.04' && tsan"``
* ``"os == 'win' && tsan``
- Old platform combination flags and isLinux style flags have been
deprecated in favor of explicitly checking os, os_version, etc.
NOTE: code changes in this patch are simply to maintain self tests
and do not reflect the updated linter changes.
Signed-off-by: Tom Marble <[email protected]>
Differential Revision: https://phabricator.services.mozilla.com/D278535
The `gBrowser.reloadTab` method was doing a very light reload,
which could preserve iframe overriden locations.
The new method ensures we load the original HTML content back,
this seems to also have an impact on keep-alive which is not longer guaranteed.
Only supports reloading the currently selected tab, to better replicate
real user scenarios. But also to comply to `BrowserCommands.reload`,
which only supports reloading the selected tab.
Also tune the har test, now that requests are really cancelled
and we may try to fetch reponse content for such request.
Differential Revision: https://phabricator.services.mozilla.com/D277433
Hubert B Manilla