Commit Graph
229 Commits
Author SHA1 Message Date
Alexandre Poirot 942adef18c Bug 2031717 - [devtools] Expose local mode settings in DevTools options panel. r=devtools-reviewers,fluent-reviewers,bolsson,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D294193
2026-06-11 07:56:50 +00:00
agoloman d69d1d8e0e Revert "Bug 2031717, Bug 2031714 - [devtools] Expose local mode settings in DevTools options panel. r=devtools-reviewers,fluent-reviewers,bolsson,nchevobbe" for causing bc failures @browser_misused_characters_in_strings.js.
This reverts commit b7f48700d7.

Revert "Bug 2031714 - [devtools] Implement "Local Mode" backend. r=devtools-reviewers,devtools-backward-compat-reviewers,bomsy"

This reverts commit 0f1b6c66ab.

Revert "Bug 2031714 - [devtools] Expose a flag on the TargetFront to know if the page is an error page. r=devtools-reviewers,nchevobbe"

This reverts commit 4cbb3ac689.
2026-06-02 09:35:20 +00:00
Alexandre Poirot b7f48700d7 Bug 2031717 - [devtools] Expose local mode settings in DevTools options panel. r=devtools-reviewers,fluent-reviewers,bolsson,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D294193
2026-06-02 08:42:04 +00:00
Sylvestre Ledru 074b376055 Bug 2023419 - Remove Emacs/Vim modelines from devtools/ r=emilio,devtools-backward-compat-reviewers,devtools-reviewers,nchevobbe
replaced by .editorconfig
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D287841
2026-03-28 10:21:10 +00:00
Chris Vander Linden f548861609 Bug 2022403 - Use private class fields in devtools/client/framework/components/ToolboxTabs.js. r=nchevobbe,devtools-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D288552
2026-03-24 01:00:04 +00:00
Alexandru Marc 630e6cf0e8 Revert "Bug 2023419 - Remove Emacs/Vim modelines from devtools/ r=emilio,devtools-backward-compat-reviewers,devtools-reviewers,nchevobbe" for causing devtools failures
This reverts commit ed535dace9.
2026-03-17 12:46:01 +00:00
Sylvestre Ledru ed535dace9 Bug 2023419 - Remove Emacs/Vim modelines from devtools/ r=emilio,devtools-backward-compat-reviewers,devtools-reviewers,nchevobbe
replaced by .editorconfig

Differential Revision: https://phabricator.services.mozilla.com/D287841
2026-03-17 12:03:34 +00:00
Mark Banner b38cd3110b Bug 1999554 - Automatically fix ESLint rule jsdoc/check-types for devtools/. r=devtools-reviewers,devtools-backward-compat-reviewers,profiler-reviewers,canaltinova
Differential Revision: https://phabricator.services.mozilla.com/D272173
2025-11-21 16:16:08 +00:00
Julian Descottes 620f57d836 Bug 1966826 - [devtools] Pass waitForLoad=false to navigateTo from DebugTargetInfo r=devtools-reviewers,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D250788
2025-05-23 08:29:01 +00:00
Alexandre Poirot d415aca971 Bug 1963915 - [devtools] Navigate back and forward from the parent process. r=devtools-reviewers,devtools-backward-compat-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D249595
2025-05-16 00:37:53 +00:00
Alexandre Poirot 6fad3a13b4 Bug 1937738 - [devtools] Expose a new navigateTo method on Tab Descriptor. r=devtools-reviewers,devtools-backward-compat-reviewers,nchevobbe
This should help VS Code load the page to debug.

Differential Revision: https://phabricator.services.mozilla.com/D232328
2025-05-16 00:37:49 +00:00
Alexandre Poirot e1f9301f4e Bug 1953578 - [devtools] Migrate all usage of react-prop-types CommonJS module to the ES Module version and remove the CommonJS version. r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D241594
2025-03-19 13:30:51 +00:00
Alexandre Poirot 26260731f1 Bug 1953578 - [devtools] Migrate all usage of react CommonJS module to the ES Module version and remove the CommonJS version. r=devtools-reviewers,profiler-reviewers,nchevobbe,canaltinova
Differential Revision: https://phabricator.services.mozilla.com/D241593
2025-03-19 13:30:51 +00:00
Alexandre Poirot e69d31e1dc Bug 1940079 - [devtools] Show manifest errors when reloading an addon from DevTools. r=devtools-reviewers,nchevobbe,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D233395
2025-01-17 09:14:57 +00:00
Alexandre Poirot 0fc6329f4b Bug 1933194 - [devtools] Fix target titles when debugging Web Extensions. r=devtools-reviewers,nchevobbe
* Display target's url's pathname instead of repeating the addon name for all documents.
* Display addon name in Debug Target Info header (instead of current target name).
* Display current target's url and title (if available) in toolbox window title.

Differential Revision: https://phabricator.services.mozilla.com/D230116
2024-12-02 16:19:59 +00:00
Alexandre Poirot 566aaa3cb8 Bug 1928336 - [devtools] Update toolbox host title on target selection and hide target URL in target info for web extensions. r=devtools-reviewers,nchevobbe
The target info url is misleading as it only refers to the top level target URL,
which in the case of add-ons is always the fallback document.
And it is also redundant with the toolbox window title which, thanks to this patch,
will be updated to the currently selected target title+url.

Differential Revision: https://phabricator.services.mozilla.com/D227466
2024-11-04 13:13:05 +00:00
Alexandre Poirot e47a979998 Bug 1921947 - [devtools] Stop relying on TargetMixin.isWebExtension. r=devtools-reviewers,bomsy
Instead, query the simpler and more reliable descriptor front's `isWebExtensionDescriptor` attribute.

Simplify the logic around target's `name` attribute by making the server return the addon name right away.

`TargetMixin.isWebExtension` is kept in tree solely for backward compat reasons.

Differential Revision: https://phabricator.services.mozilla.com/D220540
2024-10-07 09:52:06 +00:00
Alexandre Poirot 56f1de2b31 Bug 1873060 - [devtools] Move JS tracer icon to the toolbox level. r=devtools-reviewers,nchevobbe
Also moving the LOG_METHODS from actors to specs so that the frontend
can import them from devtools/shared instead of devtools/server.

Differential Revision: https://phabricator.services.mozilla.com/D215085
2024-07-09 15:19:05 +00:00
Sandor Molnar d22465071b Backed out 5 changesets (bug 1873060, bug 1906291) for causing talos perma failures @ jstracer/jstracer.js CLOSED TREE
Backed out changeset 6f0fa044aa35 (bug 1906291)
Backed out changeset 53b5ad4055ed (bug 1906291)
Backed out changeset d72f48618f38 (bug 1906291)
Backed out changeset 17873318ca4a (bug 1906291)
Backed out changeset f3c126a6f60b (bug 1873060)
2024-07-09 02:50:07 +03:00
Alexandre Poirot ca845feadc Bug 1873060 - [devtools] Move JS tracer icon to the toolbox level. r=devtools-reviewers,nchevobbe
Also moving the LOG_METHODS from actors to specs so that the frontend
can import them from devtools/shared instead of devtools/server.

Differential Revision: https://phabricator.services.mozilla.com/D215085
2024-07-08 13:10:39 +00:00
Emilio Cobos Álvarez a898423415 Bug 1902896 - Remove unnecessary fallback font family. r=devtools-reviewers,nchevobbe
system-ui should be enough. It's also equivalent to -apple-system on
macOS right now.

Differential Revision: https://phabricator.services.mozilla.com/D213881
2024-06-17 10:50:34 +00:00
Hubert Boma Manilla 4e49e8d2c5 Bug 1900475 - [devtools] Fix Proptypes boolean to bool r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D212490
2024-06-04 08:24:57 +00:00
artem manushenkov 0c607a8763 Bug 1731635 [devtools] Add option to disable split console r=nchevobbe,fluent-reviewers,devtools-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D204142
2024-03-27 06:34:50 +00:00
Dave Townsend 2af4d349f3 Bug 1864896: Autofix unused function arguments (devtools). r=profiler-reviewers,devtools-reviewers,nchevobbe,julienw
Differential Revision: https://phabricator.services.mozilla.com/D202959
2024-03-05 14:21:15 +00:00
Nicolas Chevobbe 34cdb11876 Bug 1843309 - [devtools] Add aria-pressed attribute on toolbox toggle buttons. r=devtools-reviewers,ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D189741
2023-10-03 04:59:03 +00:00
Mark Banner 0666077666 Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu
Differential Revision: https://phabricator.services.mozilla.com/D177027
2023-05-20 12:26:53 +00:00
Mark Banner 91fde42f7b Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish
Differential Revision: https://phabricator.services.mozilla.com/D177025
2023-05-20 12:26:49 +00:00
Nicolas Chevobbe 76fcf0fcdd Bug 1808708 - [devtools] Only show Alway-on-top button in about:debugging webextension toolboxes. r=ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D166097
2023-01-05 17:25:44 +00:00
Alexandre Poirot 2c8165afbf Bug 1625939 - [devtools] Remove devtools.browsertoolbox.fission preference and remove old non-fission Browser Toolbox. r=nchevobbe,fluent-reviewers,flod,perftest-reviewers,kshampur
Differential Revision: https://phabricator.services.mozilla.com/D164699
2022-12-20 10:16:48 +00:00
Julian Descottes 15d8bdc5e0 Bug 1798859 - [devtools] Add label to always on top button for webextension toolbox r=nchevobbe,fluent-reviewers,flod
Added a blink animation instead of the transition as well. Added a border when hover/active.

Differential Revision: https://phabricator.services.mozilla.com/D161370
2022-11-07 07:58:03 +00:00
Hubert Boma Manilla 692eaaac2e Bug 1794367 - [devtools] Remove backward compatibility code for 105 r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D158937
2022-10-10 15:29:38 +00:00
Alexandre Poirot 59fe57c052 Bug 1793396 - [devtools] Use absolute URLs in all usages of loader.lazyRequireGetter. r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D158489
2022-10-03 18:57:13 +00:00
Alexandre Poirot 9beeb07755 Bug 1792847 - [devtools] Use absolute URLs to import modules in devtools/client/framework. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D158373
2022-09-30 15:17:36 +00:00
Alexandre Poirot 4ff70fda6f Bug 1780912 - [devtools] Make the local web extension toolbox be always on top. r=nchevobbe,eemeli
This allows to keep the DevTools visible while interacting with the Firefox
window where the extension is running.

This behavior is enabled by default, but can be disable on-demand via a button
in the top toolbar.
Note that it requires to close and reopen the window/toolbox as platform APIs
disallow changing this behavior "live" on a given window.

Differential Revision: https://phabricator.services.mozilla.com/D155843
2022-09-15 07:31:31 +00:00
Alexandre Poirot 0f32f335e3 Bug 1789201 - [devtools] Expose Services as a global to all DevTools modules. r=perftest-reviewers,nchevobbe,julienw,AlexandruIonescu
This will help transition to ES Modules as this symbol is exposed to them.

$ sed -ie "/require(.Services.)/d" $(git grep -l 'require("Services")' devtools/)
$ sed -ie "/loader.lazyRequireGetter(this, .Services./d" $(git grep -l 'loader.lazyRequireGetter(this, "Services"' devtools/)
+ the edition of builtin-modules.js + eslintrc.js
+ manual eslint fixes
+ removal of devtools-services in the debugger, except for jest tests

Differential Revision: https://phabricator.services.mozilla.com/D156401
2022-09-09 07:22:51 +00:00
Noemi Erli 233f0fcdf4 Backed out 2 changesets (bug 1780912) for causing failures in browser_aboutdebugging_addons_debug_console.js CLOSED TREE
Backed out changeset d2360a2a3d70 (bug 1780912)
Backed out changeset 21f1e9031be0 (bug 1780912)
2022-09-08 01:59:18 +03:00
Alexandre Poirot ce1e1a4cbe Bug 1780912 - [devtools] Make the local web extension toolbox be always on top. r=nchevobbe,eemeli
This allows to keep the DevTools visible while interacting with the Firefox
window where the extension is running.

This behavior is enabled by default, but can be disable on-demand via a button
in the top toolbar.
Note that it requires to close and reopen the window/toolbox as platform APIs
disallow changing this behavior "live" on a given window.

Differential Revision: https://phabricator.services.mozilla.com/D155843
2022-09-07 21:00:17 +00:00
Alexandre Poirot 3cadeaeb46 Bug 1788536 - [devtools] Use descriptorType instead of a type decipher from toolbox URL. r=jdescottes
This helps having the right type, even if we open the toolbox without any search params
in about:devtools-toolbox URL.

Differential Revision: https://phabricator.services.mozilla.com/D156134
2022-09-02 09:10:01 +00:00
Nicolas Chevobbe a361a2ece2 Bug 1787685 - [devtools] Fix ChromeDebugToolbar styling in Windows High Contrast mode. r=jdescottes.
Differential Revision: https://phabricator.services.mozilla.com/D156274
2022-09-02 08:09:44 +00:00
Alexandre Poirot 531f08b810 Bug 1693686 - [devtools] Display the navigation buttons in WebExtension toolboxes. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D155563
2022-08-29 08:54:00 +00:00
Mark Banner 3387a89bc7 Bug 1786197 - Turn on ESLint rule for prefer-boolean-length-check for devtools. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D155167
2022-08-26 13:39:34 +00:00
Nicolas Chevobbe 1b481f44eb Bug 1776853 - [devtools] Add BrowserToolbox-specific toolbar. r=ochameau,jdescottes,fluent-reviewers,flod.
This adds an additional toolbar in the Browser Toolbox which will contain specific
tools and options.
At the moment we only display a couple input button to be able to switch from
Parent process only to multiprocess mode.
We remove the similar UI in the iframe picker and adapt the existing test.

A trait is added to not show the toolbar when debugging server where we wouldn't
get the `isSwitchingMode` property in `onTargetDestroyed`, as this can cause
misbehavior in various tool when switching between different modes.

Differential Revision: https://phabricator.services.mozilla.com/D150575
2022-08-01 09:33:17 +00:00
Bogdan Szekely 69bbe7a93b Backed out 5 changesets (bug 1777253, bug 1776853) for causing devtools failures on browser_console_modes.js CLOSED TREE
Backed out changeset dbd68a657d6f (bug 1777253)
Backed out changeset f401150fb142 (bug 1776853)
Backed out changeset 209aade12fc6 (bug 1776853)
Backed out changeset dc24308ff8ef (bug 1776853)
Backed out changeset ea98ed858bae (bug 1776853)
2022-08-01 10:43:40 +03:00
Nicolas Chevobbe c39cba2689 Bug 1776853 - [devtools] Add BrowserToolbox-specific toolbar. r=ochameau,jdescottes,fluent-reviewers,flod.
This adds an additional toolbar in the Browser Toolbox which will contain specific
tools and options.
At the moment we only display a couple input button to be able to switch from
Parent process only to multiprocess mode.
We remove the similar UI in the iframe picker and adapt the existing test.

A trait is added to not show the toolbar when debugging server where we wouldn't
get the `isSwitchingMode` property in `onTargetDestroyed`, as this can cause
misbehavior in various tool when switching between different modes.

Differential Revision: https://phabricator.services.mozilla.com/D150575
2022-08-01 06:55:54 +00:00
Alexandre Poirot 44a6b99c4a Bug 1770363 - [devtools] Introduce on-demand multiprocess browser toolbox. r=nchevobbe
This introduces a checkbox in the iframe dropdown to enable/disable multiprocess debugging live.
Switching between:
 - debugging only the main process (all documents, workers and priviledged JS)
 - debugging all the processes (same, for each process, we will debug documents, workers, JS, ...)

This helps significantly speed up the browser toolbox when debugging only parent process resources,
while still allowing to switch to debug everything when required.

Depends on D146891

Differential Revision: https://phabricator.services.mozilla.com/D148527
2022-06-20 10:12:31 +00:00
criss b77042dbdd Backed out 5 changesets (bug 1770363) for causing mochitest failures on browser_ext_addon_debugging_netmonitor.js
Backed out changeset d29f5041fd98 (bug 1770363)
Backed out changeset a91879be9b4a (bug 1770363)
Backed out changeset 27e78762006f (bug 1770363)
Backed out changeset 18a6433fd24a (bug 1770363)
Backed out changeset 5cdcd2318a9f (bug 1770363)
2022-06-16 21:57:46 +03:00
Alexandre Poirot c6c835f8de Bug 1770363 - [devtools] Introduce on-demand multiprocess browser toolbox. r=nchevobbe
This introduces a checkbox in the iframe dropdown to enable/disable multiprocess debugging live.
Switching between:
 - debugging only the main process (all documents, workers and priviledged JS)
 - debugging all the processes (same, for each process, we will debug documents, workers, JS, ...)

This helps significantly speed up the browser toolbox when debugging only parent process resources,
while still allowing to switch to debug everything when required.

Differential Revision: https://phabricator.services.mozilla.com/D148527
2022-06-16 17:19:06 +00:00
Tetsuharu Ohzeki ffcebd0019 Bug 1508688 - Add UNSAFE_ prefix to React deprecated lifecycle methods in devtools/client/framework/. r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D149479
2022-06-16 10:03:09 +00:00
Greg Tatum a1fbf5cf93 Bug 1767537 - Update pseudolocalization docs; r=platform-i18n-reviewers,dminor
Differential Revision: https://phabricator.services.mozilla.com/D145374
2022-05-05 16:25:32 +00:00
Jan Odvarko d56b1500b0 Bug 1744752 - [devtools] Browser Toolbox documentation link should be fixed r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D137749
2022-02-04 13:20:42 +00:00