Commit Graph
19 Commits
Author SHA1 Message Date
Alexandre Poirot 26260731f1 Bug 1953578 - [devtools] Migrate all usage of react CommonJS module to the ES Module version and remove the CommonJS version. r=devtools-reviewers,profiler-reviewers,nchevobbe,canaltinova
Differential Revision: https://phabricator.services.mozilla.com/D241593
2025-03-19 13:30:51 +00:00
Alexandre Poirot 9beeb07755 Bug 1792847 - [devtools] Use absolute URLs to import modules in devtools/client/framework. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D158373
2022-09-30 15:17:36 +00:00
Alexandre Poirot 4ff70fda6f Bug 1780912 - [devtools] Make the local web extension toolbox be always on top. r=nchevobbe,eemeli
This allows to keep the DevTools visible while interacting with the Firefox
window where the extension is running.

This behavior is enabled by default, but can be disable on-demand via a button
in the top toolbar.
Note that it requires to close and reopen the window/toolbox as platform APIs
disallow changing this behavior "live" on a given window.

Differential Revision: https://phabricator.services.mozilla.com/D155843
2022-09-15 07:31:31 +00:00
Noemi Erli 233f0fcdf4 Backed out 2 changesets (bug 1780912) for causing failures in browser_aboutdebugging_addons_debug_console.js CLOSED TREE
Backed out changeset d2360a2a3d70 (bug 1780912)
Backed out changeset 21f1e9031be0 (bug 1780912)
2022-09-08 01:59:18 +03:00
Alexandre Poirot ce1e1a4cbe Bug 1780912 - [devtools] Make the local web extension toolbox be always on top. r=nchevobbe,eemeli
This allows to keep the DevTools visible while interacting with the Firefox
window where the extension is running.

This behavior is enabled by default, but can be disable on-demand via a button
in the top toolbar.
Note that it requires to close and reopen the window/toolbox as platform APIs
disallow changing this behavior "live" on a given window.

Differential Revision: https://phabricator.services.mozilla.com/D155843
2022-09-07 21:00:17 +00:00
Greg Tatum 022b42f73c Bug 1580599 - Add pseudo-locale configuration to the browser toolbox; r=platform-i18n-reviewers,devtools-reviewers,fluent-reviewers,nchevobbe,dminor
This commit adds support for setting the pseudo-locale for the browser
UI directly from the Browser Toolbox. This places the icons in the same
place as the "Disable Popup Autohide" command. This will make it easier
for Firefox developers to test that their UI is properly localized.

The SVGs were optimized for size using an optimizer that dropped the
path precision and any extra tags. I tested that they work correctly in
both light and dark modes.

Pseudo-localization is documented here:
https://firefox-source-docs.mozilla.org/l10n/fluent/tutorial.html#pseudolocalization

After this patch lands I'll follow-up with updating that documentation.

Differential Revision: https://phabricator.services.mozilla.com/D134420
2022-01-10 17:09:17 +00:00
Nicolas Chevobbe d8f4979868 Bug 1685985 - [devtools] Handle error count button like other toolbox buttons. r=jdescottes.
A button configuration is now created from _buildButtons so the error count button
is part of the `toolbarButtons` property on the toolbox.
An `updateErrorCountButton` updates the property of the button, and we call it
from the function that updates the error count, from which we also trigger a new
render for the toolbar.

This way updating the error count will go through the overflow logic we have in
the toolbar (to show the chevron or not).

A "side effect" of this is that an item is automatically created in the options
panel to disable the error count button. In order for it to work properly, we
need to add a preference to store its enabled state, as well as a specific
localized string for the input label.

browser_toolbox_error_count is updated to ensure that the error button isn't
displayed if it was disabled in the option panel, even if new errors are emitted.

browser_toolbox_options_disable_buttons was updated to reflect the changes made
to the error count button.

Differential Revision: https://phabricator.services.mozilla.com/D101569
2021-01-14 07:54:44 +00:00
Nicolas Chevobbe aa9ac25544 Bug 1109362 - [devtools] Show number of errors in Toolbox toolbar. r=jdescottes,Honza.
This patch displays an error icon matching the number
of errors handled in the console.
An error can be:
- a nsIScriptError that is not a warning
- a console.error call
- a console.assert call
- a 4xx or 5xx network call

The counter is handled via the resourceWatcher of the toolbox,
where we listen for the different resources we need.
Clearing the console from the UI or via console.clear resets
the error count.
Clicking on the icon opens the split console if it wasn't already.
Navigating clears the error count, except if the persist log
option is enabled in the console.

A test is added to ensure this works as expected.

Differential Revision: https://phabricator.services.mozilla.com/D100668
2021-01-07 09:19:08 +00:00
Yura Zenevich 05ff60afc3 Bug 1640338 - remove accessibliity startup and startup functionality from tool definitions. r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D77055
2020-07-03 23:52:10 +00:00
Cosmin Sabou ce90ee5587 Backed out 4 changesets (bug 1640338, bug 1640778) for devtools failures on browser_dbg-toolbox-unselected-pause.js.
Backed out changeset 92cb02f03119 (bug 1640778)
Backed out changeset 6401dd804f28 (bug 1640338)
Backed out changeset cb4edb2627bb (bug 1640338)
Backed out changeset b2394d79f48f (bug 1640338)
2020-06-30 19:59:10 +03:00
Yura Zenevich f6e6d1d018 Bug 1640338 - remove accessibliity startup and startup functionality from tool definitions. r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D77055
2020-06-26 18:29:39 +00:00
Micah Tigley 8138396497 Bug 1617237 - Part 1: Ensure that ToolboxController updates its children when target navigates r=jdescottes,daisuke
The DebugTargetInfo component doesn't receive new target information when navigation occurs. This is because the ToolboxController doesn't seem to be aware of these changes. To trigger an update, we can force new props to be passed to DebugTargetInfo by setting the target's debug info on its local state.

Differential Revision: https://phabricator.services.mozilla.com/D70280
2020-05-07 17:22:14 +00:00
Razvan Maries 0d9dec23c1 Backed out 5 changesets (bug 1617237) for devtools perma failures. CLOSED TREE
Backed out changeset 3acc06a17b26 (bug 1617237)
Backed out changeset dfdf021a542c (bug 1617237)
Backed out changeset 358ce0a1518f (bug 1617237)
Backed out changeset 2e647ae9ec48 (bug 1617237)
Backed out changeset 3e340cc988c8 (bug 1617237)
2020-05-07 20:17:17 +03:00
Micah Tigley 6afac8a21d Bug 1617237 - Part 1: Ensure that ToolboxController updates its children when target navigates r=jdescottes,daisuke
The DebugTargetInfo component doesn't receive new target information when navigation occurs. This is because the ToolboxController doesn't seem to be aware of these changes. To trigger an update, we can force new props to be passed to DebugTargetInfo by setting the target's debug info on its local state.

Differential Revision: https://phabricator.services.mozilla.com/D70280
2020-05-07 15:19:24 +00:00
Victor Porof b7732ae890 Bug 1561435 - Format devtools/client/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D35884
2019-07-05 11:24:38 +02:00
Mark Banner 3d6aaad3f5 Bug 1486741 - Enable ESLint rule comma-dangle for all of mozilla-central (automatic fixes). r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D8389
2018-10-19 12:55:39 +00:00
Yura Zenevich 6badd76f86 Bug 1453093 - move accessible actor instantiation and panel tab highlighting into tool startup component. r=ochameau
MozReview-Commit-ID: F02RgSyupUQ
2018-06-08 13:24:20 -04:00
Julian Descottes 82711b9a8f Bug 1454696 - Run eslint --fix for prefer-const;r=yulia
MozReview-Commit-ID: F6xUXCgdRE4
2018-06-01 12:36:09 +02:00
Miguel Useche 93f930f18c Bug 1452060 - CamelCase all React component inside client framework folder. r=jdescottes 2018-05-06 14:16:17 -04:00