Commit Graph
24 Commits
Author SHA1 Message Date
Sylvestre Ledru 074b376055 Bug 2023419 - Remove Emacs/Vim modelines from devtools/ r=emilio,devtools-backward-compat-reviewers,devtools-reviewers,nchevobbe
replaced by .editorconfig
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D287841
2026-03-28 10:21:10 +00:00
Alexandru Marc 630e6cf0e8 Revert "Bug 2023419 - Remove Emacs/Vim modelines from devtools/ r=emilio,devtools-backward-compat-reviewers,devtools-reviewers,nchevobbe" for causing devtools failures
This reverts commit ed535dace9.
2026-03-17 12:46:01 +00:00
Sylvestre Ledru ed535dace9 Bug 2023419 - Remove Emacs/Vim modelines from devtools/ r=emilio,devtools-backward-compat-reviewers,devtools-reviewers,nchevobbe
replaced by .editorconfig

Differential Revision: https://phabricator.services.mozilla.com/D287841
2026-03-17 12:03:34 +00:00
Mark Banner b38cd3110b Bug 1999554 - Automatically fix ESLint rule jsdoc/check-types for devtools/. r=devtools-reviewers,devtools-backward-compat-reviewers,profiler-reviewers,canaltinova
Differential Revision: https://phabricator.services.mozilla.com/D272173
2025-11-21 16:16:08 +00:00
Mark Banner e4d3bbab0b Bug 1881270 - Fix no-case-declarations in devtools/ code. r=devtools-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D266006
2025-09-25 18:33:14 +00:00
agoloman f0289ea0d2 Revert "Bug 1881270 - Fix no-case-declarations in devtools/ code. r=devtools-reviewers,jdescottes" for causing mochitest failures @test_suppressed_events_nested_iframe.html.
This reverts commit 8e7d559526.

Revert "Bug 1881270 - Fix no-case-declarations issues in extensions code. r=extension-reviewers,willdurand"

This reverts commit 2a0800455d.

Revert "Bug 1881270 - Fix ESLint no-case-declarations issues in various files. r=frontend-codestyle-reviewers,necko-reviewers,media-playback-reviewers,layout-reviewers,dom-worker-reviewers,padenot,mossop,asuth,TYLin"

This reverts commit 3c05c4bfee.
2025-09-25 15:04:21 +00:00
Mark Banner 8e7d559526 Bug 1881270 - Fix no-case-declarations in devtools/ code. r=devtools-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D266006
2025-09-25 10:34:16 +00:00
Nicolas Chevobbe 35a9624c34 Bug 1945747 - [devtools] Remove inline stylesheet index in Changes panel. r=devtools-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D236690
2025-02-04 15:07:13 +00:00
Alexandre Poirot caaf5fa378 Bug 1792847 - [devtools] Use absolute URLs to import modules in devtools/client/inspector. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D158375
2022-09-30 15:17:37 +00:00
Ricky Stewart 31b8ca9716 Bug 1654103: Standardize on Black for Python code in mozilla-central.
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.

5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-26 18:34:53 +00:00
Bogdan Tara 612312a64c Backed out 10 changesets (bug 1654103, bug 1672023, bug 1518999) for PanZoomControllerTest.touchEventForResult gv-junit failures CLOSED TREE
Backed out changeset ff3fb0b4a512 (bug 1672023)
Backed out changeset e7834b600201 (bug 1654103)
Backed out changeset 807893ca8069 (bug 1518999)
Backed out changeset 13e6b92440e9 (bug 1518999)
Backed out changeset 8b2ac5a6c98a (bug 1518999)
Backed out changeset 575748295752 (bug 1518999)
Backed out changeset 65f07ce7b39b (bug 1518999)
Backed out changeset 4bb80556158d (bug 1518999)
Backed out changeset 8ac8461d7bd7 (bug 1518999)
Backed out changeset e8ba13ee17f5 (bug 1518999)
2020-10-24 03:36:18 +03:00
Ricky Stewart 065d2eb893 Bug 1654103: Standardize on Black for Python code in mozilla-central. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.

5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-23 20:40:42 +00:00
Dorel Luca 95b44c982f Backed out changeset 7558c8821a07 (bug 1654103) for multiple failures. CLOSED TREE 2020-10-22 03:51:06 +03:00
Ricky Stewart 43baed3c18 Bug 1654103: Standardize on Black for Python code in mozilla-central. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-21 21:27:27 +00:00
Julian Descottes 150349d1c5 Bug 1596686 - Use absolute paths for require calls r=gl
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D58243
2019-12-27 12:23:47 +00:00
Razvan Maries 0f5ce38e4c Backed out changeset 14698fa06ab8 (bug 1596686) for causing perma fails on browser_json_refresh.js. 2019-12-27 14:01:24 +02:00
Julian Descottes 3fa1b45876 Bug 1596686 - Use absolute paths for require calls r=gl
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D58243
2019-12-27 09:09:51 +00:00
Razvan Caliman dae53fa356 Bug 1525326 - Remove backwards compatibility for custom unique ids for rules and stylesheets. r=gl
Since Firefox 67 tracked changes have unique identifiers as follows:
- ruleId => StyleRuleActor.actorID
- sourceId => StylesheetActor.actorID

Given that we're at Firefox 70 and beyond the window where we support connecting to servers older than 3 versions, this patch removes the backwards compatibility provided by methods to generate unique ids  based on attributes of the rule and stylesheet for the tracked change.

Differential Revision: https://phabricator.services.mozilla.com/D37591
2019-07-10 19:51:57 +00:00
Victor Porof b7732ae890 Bug 1561435 - Format devtools/client/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D35884
2019-07-05 11:24:38 +02:00
Razvan Caliman c2fd09d549 Bug 1527924 - (Part 1) Use array of selectors for the rule in Redux structure for Changes. r=pbro
Refactors the Redux state for the Changes panel so that rules have
a `selectors` array instead of just a single `selector` string.

The `selectors` array represents the **history** of selector text the
rule has over time, not the actual list of multiple selectors it has
(multiple selectors are collapsed into a single comma-separated string
regardless of how many they are).

When the server logs changes, the rule's selector text is checked
against the history of previously logged selectors.

If the incoming selector is different than the _first_ item in
the tracked rule's `selectors` array, it means the selector was renamed
so it is pushed onto the array (added to the history).

If it's the same, the whole array can be reduced to the original value
because it means that either:
- the selector didn't change between operations (ex: after declaration changes)
- the selector reverted back to its original name.

This `selectors` array is used in the React component in Part 2 of this
series to render any necessary diff view of the selector.

The old approach (whole rule removal + whole rule addition) is replaced
by this refactor. The introduction of the StyleRyleActor actor id from
the server as the rule id on the client in Bug 1525238 means that the
selector change can no longer behave like two distinct rules.
The actorID/rule id are preserved after selector renames. This necessary
for the some export options to work consistently (like Copy Rule with changes applied).

Differential Revision: https://phabricator.services.mozilla.com/D19828
2019-02-15 16:58:58 +00:00
Razvan Caliman 5d8e8e0263 Bug 1503924 - Mark style sources from iframes in the Changes panel. r=gl
Depends on D12590

Differential Revision: https://phabricator.services.mozilla.com/D12697
2018-11-26 05:02:06 +00:00
Razvan Caliman 15791ed77b Bug 1503924 - Trim source URLs to filename in Changes panel. r=gl
Differential Revision: https://phabricator.services.mozilla.com/D12588
2018-11-23 16:25:18 +00:00
Razvan Caliman 85151f26f1 Bug 1503595 - Add empty state for Changes panel; r=gl
Design spec: https://mozilla.invisionapp.com/share/6MLNVPYGR97#/screens

- add localization file
- add strings to show when no CSS changes are available to show
- conditionally show empty state message or diff of changes in React component

MozReview-Commit-ID: 8xYJmg0yGAM

Differential Revision: https://phabricator.services.mozilla.com/D11468
2018-11-15 12:18:45 +00:00
Razvan Caliman 65cf5dbfda Bug 1499049 - (Part 3) Add new reducer logic for tracking CSS changes to nested rules; r=pbro
Depends on D8719

- Add methods to generate unique identifiers for stylesheets and CSS rules changed within those stylesheets. These are used as IDs in the Redux store;
- Add logic to generate entries in the store for each one of the rule's ancestors and assign parent/child dependencies. This single-level structure for all rules in a source helps with quickly identifying a rule on subsequent changes independent of its rule tree (it avoids needless tree traversal). The parent/child references help with rendering of the nested rule structure in the Changes panel;
- Deep clone Redux store state before aggregating tracked changes (no more mutations of previous state).

Differential Revision: https://phabricator.services.mozilla.com/D8720
2018-10-25 16:20:00 +00:00