Chris H-C
d89527a234
Bug 2039650 - Remove Legacy Telemetry devtools probes r=jdescottes,devtools-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D300855
2026-05-28 16:32:18 +00:00
Alexandre Poirot
3af4a6d2ad
Bug 1622857 - [devtools] Use MOZ_LOG to trace RDP packets in tests. r=devtools-reviewers,nchevobbe
...
Also remove disabled/commented logging.
You may use "--env MOZ_LOG=devtools_rdp:3" to trace RDP packets on try runs.
Some tests are still toggling the old preference as they may want to
trace other usages of dumpn/dumpv.
Differential Revision: https://phabricator.services.mozilla.com/D299055
2026-05-18 09:12:29 +00:00
Mark Banner
74f1513112
Bug 2017864 - Stop using Preferences.sys.mjs in simple cases. r=firefox-desktop-core-reviewers ,credential-management-reviewers,search-reviewers,devtools-reviewers,sessionstore-reviewers,migration-reviewers,chutten,bvandersloot,mconley,scunnane,dimi,sthompson
...
Differential Revision: https://phabricator.services.mozilla.com/D284059
2026-02-24 09:37:10 +00:00
Alexandre Poirot
25c8ad77e8
Bug 2007539 - [devtools] Reload pages as Firefox does in DevTools tests. r=devtools-reviewers,nchevobbe
...
The `gBrowser.reloadTab` method was doing a very light reload,
which could preserve iframe overriden locations.
The new method ensures we load the original HTML content back,
this seems to also have an impact on keep-alive which is not longer guaranteed.
Only supports reloading the currently selected tab, to better replicate
real user scenarios. But also to comply to `BrowserCommands.reload`,
which only supports reloading the selected tab.
Also tune the har test, now that requests are really cancelled
and we may try to fetch reponse content for such request.
Differential Revision: https://phabricator.services.mozilla.com/D277433
2026-01-20 20:44:46 +00:00
Ted Campbell
4f27637b16
Bug 1870810 - Update mochitest.ini references to .toml in docs r=jmaher,devtools-reviewers,dom-storage-reviewers,omc-reviewers,urlbar-reviewers,dom-worker-reviewers,whimboo,home-newtab-reviewers,nchevobbe,edenchuang,mconley,jari,emcminn DONTBUILD
...
We previously migrated mochitest.ini (and friends) to be toml files but some
stray comments and documentation were not addressed at the time. Fix that now.
Differential Revision: https://phabricator.services.mozilla.com/D271518
2025-11-26 02:40:49 +00:00
Tom Marble
5ce09d7446
Bug 1995583 - test manifest cleanup for idiomatic usage r=jmaher,necko-reviewers,webcompat-reviewers,geckoview-reviewers,application-update-reviewers,media-playback-reviewers,sessionstore-reviewers,tabbrowser-reviewers,translations-reviewers,omc-reviewers,browser-installer-reviewers,twisniewski,masayuki,dom-core,smaug,nalexander,emcminn,sthompson,alwu,ai-ondevice-reviewers,valentin
...
For TOML manifests:
1. Change processor -> arch
2. Use arch instead of bits bits == '64' =>
aarch64 (default on mac 15.30) or x86_64 bits == '32' => x86
3. Replace android_version with corresponding os_version
4. Remove conditions with linux os_version=="18.04"
(unless they contain verify or verify-standalone)
5. Remove conditions with mac os_version=='11.20',
(unless they contain verify or verify-standalone)
6. Remove conditions with win os_version=='11.2009' or win11_2009,
(unless they contain verify or verify-standalone)
7. Linux conditions should have os_version, arch and display
(simple "os == 'linux'" will get expanded to these two)
"os == 'linux' && os_version == '22.04' && arch == 'x86_64' && display == 'wayland'"
"os == 'linux' && os_version == '24.04' && arch == 'x86_64' && display == 'x11'"
8. Mac conditions should have os_version and arch
(simple "os == 'mac'" will get expanded to these three)
"os == 'mac' && os_version == '10.15' && arch == 'x86_64'",
"os == 'mac' && os_version == '14.70' && arch == 'x86_64'",
"os == 'mac' && os_version == '15.30' && arch == 'aarch64'",
9. Replace apple_catalina with
os == 'mac' && os_version == '10.15' && arch == 'x86_64'
10. Replace apple_silicon with
os == 'mac' && os_version = '15.30' && arch == 'aarch64'
11. Replace win10_2009 with
os == 'win' && os_version = '10.2009' && arch == 'x86_64'
12. Replace "!debug" with three conditions "asan", "opt", or "tsan"
13. Replace literal boolean comparison with variables
(e.g. "debug == false" => "!debug)
Resolves 2000285
Signed-off-by: Tom Marble <[email protected] https://phabricator.services.mozilla.com/D272815
2025-11-22 00:30:39 +00:00
Mark Banner
b38cd3110b
Bug 1999554 - Automatically fix ESLint rule jsdoc/check-types for devtools/. r=devtools-reviewers,devtools-backward-compat-reviewers,profiler-reviewers,canaltinova
...
Differential Revision: https://phabricator.services.mozilla.com/D272173
2025-11-21 16:16:08 +00:00
Mark Banner
3cc3379c8f
Bug 1881701 - Change the devtools configurations to work with the ESLint flat configuration.r=devtools-reviewers,profiler-reviewers,julienw,nchevobbe
...
This consolidates the jest environment definition, and the xpcshell globals into the devtools/.eslintrc.mjs file, for easier configurations.
It also changes the restart of the configurations to work with flat config.
Differential Revision: https://phabricator.services.mozilla.com/D249948
2025-05-24 17:10:59 +00:00
Mark Banner
d7c7c5369b
Bug 1881701 - Rename many ESLint files to use .mjs. r=frontend-codestyle-reviewers,perftest-reviewers,Gijs,sparky,webcompat-reviewers,twisniewski
...
This is separate to help preserve history of the files.
Differential Revision: https://phabricator.services.mozilla.com/D249945
2025-05-24 17:10:51 +00:00
Joel Maher
ce1cae83af
Bug 1959269 - clean and standardize devtools/**/xpcshell.toml. r=aryx,devtools-reviewers,ochameau
...
Differential Revision: https://phabricator.services.mozilla.com/D244831
2025-04-15 14:47:07 +00:00
Joel Maher
76447d27c5
Bug 1957258 - cleanup devtools-chrome .toml manifest, enable many tests! r=aryx,devtools-reviewers,profiler-reviewers,julienw,ochameau,jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D243603
2025-04-04 15:06:02 +00:00
Alexandre Poirot
26260731f1
Bug 1953578 - [devtools] Migrate all usage of react CommonJS module to the ES Module version and remove the CommonJS version. r=devtools-reviewers,profiler-reviewers,nchevobbe,canaltinova
...
Differential Revision: https://phabricator.services.mozilla.com/D241593
2025-03-19 13:30:51 +00:00
Alexandre Poirot
49e23bea5b
Bug 1953578 - [devtools] Migrate all usage of react-dom CommonJS module to the ES Module version and remove the CommonJS version. r=profiler-reviewers,devtools-reviewers,canaltinova,nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D241280
2025-03-19 13:30:50 +00:00
Alexandre Poirot
950e47da0b
Bug 1949461 - [devtools] Stop using Immutable-js in DevTools and drop the library. r=devtools-reviewers,nchevobbe
...
The only thing provided by immutable was returning clones Set from add/remove methods.
Differential Revision: https://phabricator.services.mozilla.com/D239057
2025-03-12 08:47:04 +00:00
Alexandre Poirot
0a42a5eddb
Bug 1906125 - [devtools] Use default Tree stylesheets for the memory panel. r=devtools-reviewers,nchevobbe
...
We could also drop the custom "focused" classname and instead rely on one being put by VirtualizedTree on tree-node
(like Tree is doing).
Differential Revision: https://phabricator.services.mozilla.com/D216025
2024-07-10 21:25:47 +00:00
Alexandre Poirot
d7f3cddc7f
Bug 1888171 - [devtools] Convert Browser Loader to ESM. r=profiler-reviewers,devtools-reviewers,nchevobbe,julienw
...
Differential Revision: https://phabricator.services.mozilla.com/D205867
2024-03-28 15:15:24 +00:00
Dave Townsend
2af4d349f3
Bug 1864896: Autofix unused function arguments (devtools). r=profiler-reviewers,devtools-reviewers,nchevobbe,julienw
...
Differential Revision: https://phabricator.services.mozilla.com/D202959
2024-03-05 14:21:15 +00:00
Gijs Kruitbosch
3288f177a4
Bug 1780071 - autofix devtools/ violations of no-comparison-or-assignment-inside-ok r=profiler-reviewers,devtools-reviewers,julienw,nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D198975
2024-01-26 13:12:07 +00:00
Joel Maher
cac31d18e3
Bug 1859873 - batch 13 xpcshell.ini -> .toml. r=aryx,devtools-reviewers,profiler-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D194161
2023-11-21 12:32:50 +00:00
Anna Yeddi
e1ba7c0b2e
Bug 1849021 - Temporarily fail-if some Tier 2 a11y_checks for DevTools while the larger a11y improvement work is in progress. r=Jamie,devtools-reviewers,nchevobbe,profiler-reviewers,julienw
...
Some Tier 2 accessibility checks for click events fired on controls that should be keyboard accessible were failing for this component. They were captured by testing/mochitest/tests/SimpleTest/AccessibilityUtils.js via bug 1692110. These failing tests were temporarily fail-if'ed in the directory's browser.ini file. After the ongoing accessibility improvements work is completed, we'll need to re-run a11y-checks, investigate new failures, and for confirmed bugs individual defects should be filed.
When the individual test failures are resolved and the individual bugs are closed, remove the fail-if condition for a11y_checks from the appropriate files/sections to ensure better test coverage and to avoid regressions in a11y of these components.
Depends on D189007
Differential Revision: https://phabricator.services.mozilla.com/D186405
2023-10-09 18:20:23 +00:00
Cristian Tuns
896197e59e
Backed out 30 changesets (bug 1854447, bug 1855491, bug 1854646, bug 1854520, bug 1854528, bug 1854506, bug 1854502, bug 1854443, bug 1854538, bug 1854525, bug 1854660, bug 1854514, bug 1854460, bug 1854625, bug 1854228, bug 1854517, bug 1854533, bug 1692110, bug 1854636, bug 1849021, bug 1854512, bug 1854522, bug 1854509, bug 1854452, bug 1854536, bug 1854531) for causing multiple tier 2 failures on a11y-checks. CLOSED TREE
...
Backed out changeset 5714b7239b70 (bug 1849021)
Backed out changeset 91e5d7de3484 (bug 1849021)
Backed out changeset cc3142b909f6 (bug 1854660)
Backed out changeset 76d2a8ae9c19 (bug 1854646)
Backed out changeset 36460a147684 (bug 1854636)
Backed out changeset c7529a962a8c (bug 1854625)
Backed out changeset 791f9b03ea96 (bug 1854538)
Backed out changeset bd3f3cb434a5 (bug 1854536)
Backed out changeset 16f4f5bdcaa7 (bug 1855491)
Backed out changeset 6258bab20196 (bug 1854533)
Backed out changeset 29dca16eee2e (bug 1854531)
Backed out changeset 3a69d2c3f562 (bug 1854528)
Backed out changeset 0c63a9ea8b34 (bug 1854525)
Backed out changeset 5795bb6187a5 (bug 1854522)
Backed out changeset 7d4a123a432f (bug 1854520)
Backed out changeset ec95287bd702 (bug 1854517)
Backed out changeset 9914c1481f0d (bug 1854514
2023-10-07 14:43:05 -04:00
Anna Yeddi
f069716c4e
Bug 1849021 - Temporarily disable some Tier 2 a11y_checks for DevTools while the larger a11y improvement work is in progress. r=Jamie,devtools-reviewers,nchevobbe,profiler-reviewers,julienw
...
Some Tier 2 accessibility checks for click events fired on controls that should be keyboard accessible were failing for this component. They were captured by testing/mochitest/tests/SimpleTest/AccessibilityUtils.js via bug 1692110. These failing tests were temporarily skipped in the directory's browser.ini file. After the ongoing accessibility improvements work is completed, we'll need to re-run a11y-checks, investigate new failures, and for confirmed bugs individual defects should be filed.
When the individual test failures are resolved and the individual bugs are closed, remove the fail-if condition for a11y_checks from the appropriate files/sections to ensure better test coverage and to avoid regressions in a11y of these components.
Differential Revision: https://phabricator.services.mozilla.com/D186405
2023-10-06 18:11:40 +00:00
Tom Marble
6c1231e2e8
Bug 1853244 - convert .ini manifests to .toml: batch 6 {caps,devtools,dom}/**/browser.ini r=jmaher,media-playback-reviewers,devtools-reviewers,profiler-reviewers,alwu,nchevobbe,canaltinova
...
Differential Revision: https://phabricator.services.mozilla.com/D188856
2023-09-22 20:42:14 +00:00
Tom Marble
d70780c99c
Bug 1850545 - convert .ini manifests to .toml: batch 3 chrome.ini (bis) r=jmaher,geckoview-reviewers,extension-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,places-reviewers,profiler-reviewers,m_kato,mak,mtigley
...
Differential Revision: https://phabricator.services.mozilla.com/D187597
2023-09-13 18:28:32 +00:00
Alexandre Poirot
140d755231
Bug 1845768 - [devtools] Only try to open URL as JS files in debugger/view-source if DevTools are opened in the current tab. r=devtools-reviewers,perftest-reviewers,jdescottes,sparky
...
This will prevent opening any links with the ":\d+" suffix anytime devtools were opened in the past.
Differential Revision: https://phabricator.services.mozilla.com/D185826
2023-08-21 08:01:36 +00:00
Barret Rennie
c21ee0d6d6
Bug 1747468 - Remove FileUtils.getFile from devtools/ r=devtools-reviewers,jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D180461
2023-06-15 01:59:11 +00:00
Mark Banner
91fde42f7b
Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish
...
Differential Revision: https://phabricator.services.mozilla.com/D177025
2023-05-20 12:26:49 +00:00
Mark Banner
b3474f4614
Bug 1812977 - Remove now unnecessary import-globals-from statements in devtools. r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D168071
2023-01-30 19:33:38 +00:00
Mark Banner
fa33e4f28f
Bug 1799314 - Convert consumers of testing modules to import ES modules direct (devtools/). r=jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D161916
2022-11-17 12:00:31 +00:00
Mark Banner
5407bdffa8
Bug 1792341 - Migrate more toolkit/modules consumers to use direct ES module import. r=Gijs,webdriver-reviewers,perftest-reviewers,necko-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,sgalich,owlish,bytesized,AlexandruIonescu,whimboo,mconley,mixedpuppy
...
Mainly automated changes. Some manual ESLint fixes and whitespace cleanup.
Differential Revision: https://phabricator.services.mozilla.com/D158452
2022-10-18 11:21:26 +00:00
Alexandre Poirot
a3b72117bf
Bug 1793575 - [devtools] Convert jsdebugger.jsm to jsdebugger.sys.mjs. r=Honza,webdriver-reviewers,whimboo
...
Differential Revision: https://phabricator.services.mozilla.com/D158571
2022-10-06 14:21:22 +00:00
Alexandre Poirot
fb1494f232
Bug 1792847 - [devtools] Use absolute URLs to import modules in devtools/client/memory. r=jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D158376
2022-09-30 15:17:37 +00:00
Alexandre Poirot
58b38d7c16
Bug 1791969 - [devtools] Import all JSM in DevTools via ChromeUtils.import. r=jdescottes
...
Convert all imports but the one related to SessionDataHelper
as that's an hybrid module which is loaded as a JSM from the main thread,
but loaded as a common js module from the worker thread.
We will be able to drop this once we can migrate this JSM to ESM
once we support loading ESM from the worker thread.
Differential Revision: https://phabricator.services.mozilla.com/D158007
2022-09-26 13:01:33 +00:00
Alexandre Poirot
0f32f335e3
Bug 1789201 - [devtools] Expose Services as a global to all DevTools modules. r=perftest-reviewers,nchevobbe,julienw,AlexandruIonescu
...
This will help transition to ES Modules as this symbol is exposed to them.
$ sed -ie "/require(.Services.)/d" $(git grep -l 'require("Services")' devtools/)
$ sed -ie "/loader.lazyRequireGetter(this, .Services./d" $(git grep -l 'loader.lazyRequireGetter(this, "Services"' devtools/)
+ the edition of builtin-modules.js + eslintrc.js
+ manual eslint fixes
+ removal of devtools-services in the debugger, except for jest tests
Differential Revision: https://phabricator.services.mozilla.com/D156401
2022-09-09 07:22:51 +00:00
Mark Banner
3387a89bc7
Bug 1786197 - Turn on ESLint rule for prefer-boolean-length-check for devtools. r=jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D155167
2022-08-26 13:39:34 +00:00
Barret Rennie
30427fba8c
Bug 1772916 - Port osfile.jsm usage to IOUtils in devtools/client/ r=nchevobbe
...
The bulk was removed in bug 1771608, but some vestigial bits were missed.
We cannot yet fix the remaining import in devtools/shared/ until we have a way
to replace osfile.jsm in a content process.
Differential Revision: https://phabricator.services.mozilla.com/D153700
2022-08-04 20:03:22 +00:00
Mark Banner
6d03c63e2d
Bug 1330099 - Enable object-shorthand eslint rule. r=jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D153567
2022-08-03 14:57:05 +00:00
Mark Banner
1e3410cbdd
Bug 1782008 - Remove now unnecessary .eslintrc.js files. r=webcompat-reviewers,extension-reviewers,media-playback-reviewers,pip-reviewers,denschub,rpl,alwu,mossop
...
Differential Revision: https://phabricator.services.mozilla.com/D152736
2022-08-03 11:16:20 +00:00
Kagami Sascha Rosylight
4fb733cb3b
Bug 1773740 - Part 4: Reapply mach -l eslint --fix with use-isInstance changes r=Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D148939
2022-06-27 20:31:34 +00:00
Michael Ratcliffe
d6307b5774
Bug 1771608 - Eliminate mozilla/reject-osfile eslint warning in devTools code r=devtools-reviewers,perftest-reviewers,jdescottes,sparky
...
## Removed Some Osfile.jsm and ChromeUtils Dependencies
```diff
- const { OS } = require("resource://gre/modules/osfile.jsm");
And / Or
- const ChromeUtils = require("ChromeUtils");
```
- devtools/client/memory/actions/io.js
- devtools/client/memory/utils.js
- devtools/client/netmonitor/src/har/har-menu-utils.js
- devtools/client/responsive/test/browser/browser_screenshot_button.js
- devtools/client/shared/remote-debugging/adb/adb-binary.js
- devtools/client/shared/screenshot.js
- devtools/client/styleeditor/StyleEditorUI.jsm
- devtools/client/styleeditor/StyleSheetEditor.jsm
- devtools/client/webconsole/components/Input/JSTerm.js
- devtools/client/webconsole/test/browser/stub-generator-helpers.js
- devtools/server/actors/heap-snapshot-file.js
- devtools/server/actors/storage.js
- devtools/server/tests/xpcshell/test_MemoryActor_saveHeapSnapshot_01.js
- devtools/server/tests/xpcshell/test_MemoryActor_saveHeapSnapshot_02.js
- devtools/server/tests/xpcshell/test_MemoryActor_saveHeapSnapshot_03.js
- devtools/shared/DevToolsUtils.js
- devtools/shared/heapsnapshot/HeapSnapshotFileUtils.js
- devtools/shared/tests/xpcshell/test_fetch-file.js
- testing/talos/talos/tests/devtools/addon/content/tests/toolbox/screenshot.js
## IOUtils.read()
```diff
- OS.File.read(path);
+ IOUtils.read(path);
```
- devtools/client/aboutdebugging/test/browser/helper-real-usb.js
- devtools/client/netmonitor/src/har/har-menu-utils.js
- devtools/client/shared/remote-debugging/adb/adb-binary.js
- devtools/client/styleeditor/StyleSheetEditor.jsm
- devtools/client/webconsole/components/Input/JSTerm.js
- devtools/client/webconsole/test/browser/browser_jsterm_file_load_save_keyboard_shortcut.js
- devtools/client/webconsole/test/browser/browser_webconsole_context_menu_export_console_output.js
- devtools/shared/DevToolsUtils.js
## IOUtils.write()
```diff
- OS.File.writeAtomic(filePath, fileContent);
+ IOUtils.write(filePath, fileContent);
```
- devtools/client/webconsole/test/browser/stub-generator-helpers.js
- devtools/shared/DevToolsUtils.js
- devtools/shared/tests/xpcshell/test_fetch-file.js
## PathUtils.split()
```diff
- OS.Path.split(path);
+ PathUtils.split(path);
```
- devtools/client/styleeditor/StyleSheetEditor.jsm
## PathUtils.join()
```diff
- OS.Path.join(path, filename);
+ PathUtils.join(path, filename);
```
NOTE: If `filename` is an absolute path then `OS.Path` will ignore `path` and use `filename` but `PathUtils` will try to concatenate both paths. If filename can be an absolute path we need to use `PathUtils.isAbsolute()` and `PathUtils.joinRelative()` to make our desired behaviour explicit.
- devtools/client/debugger/test/mochitest/browser_dbg-chrome-create.js
- devtools/client/shared/remote-debugging/adb/adb-binary.js
- devtools/client/styleeditor/StyleSheetEditor.jsm
- devtools/shared/heapsnapshot/HeapSnapshotFileUtils.js
## PathUtils.isAbsolute() and PathUtils.joinRelative()
```diff
- filename = OS.Path.join(path, filename);
+ filename = PathUtils.isAbsolute(filename)
+ ? filename
+ : PathUtils.joinRelative(path, filename);
```
- devtools/client/shared/screenshot.js
## IOUtils.remove()
```diff
- OS.File.remove(filePath);
+ IOUtils.remove(filePath);
```
- devtools/client/framework/test/browser_toolbox_screenshot_tool.js
- devtools/client/responsive/test/browser/browser_screenshot_button.js
- devtools/client/responsive/test/browser/browser_screenshot_button_warning.js
- devtools/client/shared/test/shared-head.js
- devtools/client/webconsole/test/browser/browser_console_screenshot.js
- devtools/client/webconsole/test/browser/browser_jsterm_screenshot_command_file.js
- devtools/client/webconsole/test/browser/browser_jsterm_screenshot_command_fixed_header.js
- devtools/client/webconsole/test/browser/browser_jsterm_screenshot_command_selector.js
- testing/talos/talos/tests/devtools/addon/content/tests/toolbox/screenshot.js
## PathUtils.toFileURI()
```diff
- OS.Path.toFileURI(filePath);
+ PathUtils.toFileURI(filePath);
```
- devtools/client/framework/test/browser_toolbox_screenshot_tool.js
- devtools/client/responsive/test/browser/browser_screenshot_button.js
- devtools/client/shared/test/shared-head.js
- devtools/client/webconsole/test/browser/browser_console_screenshot.js
- devtools/client/webconsole/test/browser/browser_jsterm_screenshot_command_file.js
- devtools/client/webconsole/test/browser/browser_jsterm_screenshot_command_fixed_header.js
- devtools/client/webconsole/test/browser/browser_jsterm_screenshot_command_selector.js
## PathUtils.filename()
```diff
- OS.Path.basename(path),
+ PathUtils.filename(path),
```
- devtools/client/memory/actions/io.js
- devtools/client/memory/utils.js
- devtools/client/styleeditor/StyleEditorUI.jsm
- devtools/client/styleeditor/StyleSheetEditor.jsm
## IOUtils.copy()
```diff
- OS.File.copy(path, dest);
+ IOUtils.copy(path, dest);
```
- devtools/client/memory/actions/io.js
## IOUtils.stat()
```diff
- OS.File.stat(filePath);
+ IOUtils.stat(filePath);
```
The objects that these `stat()` versions return differ from one another. This hasn't made much difference to the codebase but our changed usage is included here for completeness:
```diff
- this._fileModDate = info.lastModificationDate.getTime();
+ this._fileModDate = info.lastModified;
```
- devtools/client/memory/test/browser/browser_memory_transferHeapSnapshot_e10s_01.js
- devtools/client/memory/test/xpcshell/head.js
- devtools/client/memory/test/xpcshell/test_action-export-snapshot.js
- devtools/client/styleeditor/StyleSheetEditor.jsm
- devtools/server/actors/heap-snapshot-file.js
- devtools/server/tests/xpcshell/test_MemoryActor_saveHeapSnapshot_01.js
- devtools/server/tests/xpcshell/test_MemoryActor_saveHeapSnapshot_02.js
- devtools/server/tests/xpcshell/test_MemoryActor_saveHeapSnapshot_03.js
- devtools/shared/heapsnapshot/HeapSnapshotFileUtils.js
## IOUtils.setPermissions
```diff
- OS.File.setPermissions(filePath, { unixMode: 0o744 });
+ IOUtils.setPermissions(filePath, 0o744);
```
- devtools/client/shared/remote-debugging/adb/adb-binary.js
## IOUtils.makeDirectory
```diff
- OS.File.makeDir(path);
+ IOUtils.makeDirectory(path);
```
- devtools/client/shared/remote-debugging/adb/adb-binary.js
## IOUtils.exists
```diff
- OS.File.exists(path);
+ IOUtils.exists(path);
```
- devtools/client/shared/remote-debugging/adb/adb-binary.js
- devtools/client/shared/screenshot.js
- devtools/client/webconsole/test/browser/browser_jsterm_file_load_save_keyboard_shortcut.js
- devtools/client/webconsole/test/browser/browser_webconsole_context_menu_export_console_output.js
## PathUtils.profileDir, PathUtils.localProfileDir and PathUtils.tempDir
```diff
- const profileDir = OS.Constants.Path.profileDir;
+ const profileDir = PathUtils.profileDir;
```
We can reduce reliance on `Osfile.jsm` in another bug bug this is a small step in that direction.
- devtools/client/shared/remote-debugging/adb/adb-binary.js
- devtools/server/actors/storage.js
- devtools/shared/heapsnapshot/HeapSnapshotFileUtils.js
## IOUtils.getChildren(storagePath)
`IOUtils` does not have a direct equivalent of `OS.File.DirectoryIterator()` so we need to iterate more explicitely using `IOUtils.getChildren()`.
```diff
- async findStorageTypePaths(storagePath) {
- const iterator = new OS.File.DirectoryIterator(storagePath);
- const typePaths = [];
-
- await iterator.forEach(entry => {
- if (entry.isDir) {
- typePaths.push(entry.path);
- }
- });
-
- iterator.close();
- return typePaths;
- }
+ async findStorageTypePaths(storagePath) {
+ const children = await IOUtils.getChildren(storagePath);
+ const typePaths = [];
+
+ for (const path of children) {
+ const exists = await IOUtils.exists(path);
+ if (!exists) {
+ continue;
+ }
+
+ const stats = await IOUtils.stat(path);
+ if (stats.type === "directory") {
+ typePaths.push(path);
+ }
+ }
+
+ return typePaths;
+ }
```
- devtools/server/actors/storage.js
## Misc
Made `IOUtils` and `PathUtils` available to DevTools modules.
```diff
HeapSnapshot,
+ IOUtils,
L10nRegistry,
Localization,
NamedNodeMap,
NodeFilter,
+ PathUtils,
StructuredCloneHolder,
TelemetryStopwatch,
```
- devtools/shared/loader/builtin-modules.js
Differential Revision: https://phabricator.services.mozilla.com/D147589
2022-06-02 21:13:56 +00:00
Alexandre Poirot
ef54952887
Bug 1759741 - [devtools] Remove shared-redux-head being redundant with shared-head.js r=jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D141139
2022-03-16 19:11:57 +00:00
Alexandre Poirot
810d2d973d
Bug 1759741 - [devtools] Start using shared-head by a first xpcshell test. r=jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D141138
2022-03-16 19:11:56 +00:00
Alexandre Poirot
691d3cfd53
Bug 1517383 - [devtools] Remove the history middleware. r=nchevobbe
...
This history middleware is bad as it forces leaking all action until firefox is closed.
This doesn't seem to be enough to reduce the runtime of browser_toolbox_hosts.js,
but this may help free more objects in test and reduce intermittent and timeouts.
I suspect that there is some other leaks happening in this toolbox host test.
Differential Revision: https://phabricator.services.mozilla.com/D138297
2022-02-11 20:37:52 +00:00
Iulian Moraru
37221dc5c7
Backed out 3 changesets (bug 1517383) for causing multiple xpcshell failures. CLOSED TREE
...
Backed out changeset dabb45fc61d2 (bug 1517383)
Backed out changeset ee82d562286b (bug 1517383)
Backed out changeset ce2c2450ad04 (bug 1517383)
2022-02-10 14:09:25 +02:00
Alexandre Poirot
beac0fc781
Bug 1517383 - [devtools] Remove the history middleware. r=nchevobbe
...
This history middleware is bad as it forces leaking all action until firefox is closed.
This doesn't seem to be enough to reduce the runtime of browser_toolbox_hosts.js,
but this may help free more objects in test and reduce intermittent and timeouts.
I suspect that there is some other leaks happening in this toolbox host test.
Differential Revision: https://phabricator.services.mozilla.com/D138297
2022-02-10 11:30:15 +00:00
Julian Descottes
06b42b006a
Bug 1741369 - [devtools] Update paths to loader files in devtools/ r=ochameau
...
Depends on D131216
Differential Revision: https://phabricator.services.mozilla.com/D131217
2021-11-17 12:43:26 +00:00
Julian Descottes
205887e3d0
Bug 1740438 - [devtools] Remove backward compatibility code for recordAllocations target configuration option r=devtools-reviewers,bomsy
...
Depends on D130847
Differential Revision: https://phabricator.services.mozilla.com/D130848
2021-11-16 14:34:27 +00:00
Julian Descottes
1270b2bae9
Bug 1735143 - Ensure various tests within devtools are https-first compliant r=bomsy
...
The following test suites are green in https-first with this patch:
devtools/client/memory/test/browser/browser.ini
devtools/client/responsive/test/browser/browser.ini
devtools/client/shared/test/browser.ini
devtools/client/styleeditor/test/browser.ini
devtools/shared/commands/resource/tests/browser.ini
Differential Revision: https://phabricator.services.mozilla.com/D128082
2021-10-13 09:41:21 +00:00
Alexandre Poirot
96997f4d74
Bug 1729500 - [devtools] Fix stack recording in the memory panel. r=jdescottes
...
Without this, server side target were breaking stack record in the memory panel.
We have to ensure toggling stack record ON before the page starts loading.
Differential Revision: https://phabricator.services.mozilla.com/D124823
2021-09-14 12:46:48 +00:00
Julian Descottes
994c5bb325
Bug 1688067 - [devtools] Repurpose refreshTab as reloadBrowser and use in browser_toolbox_error_count_reset_on_navigation.js r=ochameau
...
Differential Revision: https://phabricator.services.mozilla.com/D124168
2021-09-01 19:24:24 +00:00
Chris H-C