Bug 2033191 made sure we only call ownerGlobal on nodes.
As per the discussion in dev-platform, the front-end ~always wants
.documentGlobal. This removes ownerGlobal from the bindings. Following
patch will rename internal GetOwnerGlobal in gecko to GetRelevantGlobal
as per the HTML spec terminology.
Differential Revision: https://phabricator.services.mozilla.com/D297183
Bug 2033191 made sure we only call ownerGlobal on nodes.
As per the discussion in dev-platform, the front-end ~always wants
.documentGlobal. This removes ownerGlobal from the bindings. Following
patch will rename internal GetOwnerGlobal in gecko to GetRelevantGlobal
as per the HTML spec terminology.
Differential Revision: https://phabricator.services.mozilla.com/D297183
Bug 2033191 made sure we only call ownerGlobal on nodes.
As per the discussion in dev-platform, the front-end ~always wants
.documentGlobal. This removes ownerGlobal from the bindings. Following
patch will rename internal GetOwnerGlobal in gecko to GetRelevantGlobal
as per the HTML spec terminology.
Differential Revision: https://phabricator.services.mozilla.com/D297183
Bug 2033191 made sure we only call ownerGlobal on nodes.
As per the discussion in dev-platform, the front-end ~always wants
.documentGlobal. This removes ownerGlobal from the bindings. Following
patch will rename internal GetOwnerGlobal in gecko to GetRelevantGlobal
as per the HTML spec terminology.
Differential Revision: https://phabricator.services.mozilla.com/D297183
This test is still failing very frequently. Most of the failures seem to be around the long_tap step, so I hope that isolating it to a dedicated file will at least make the intermittent easier to track and investigate.
Maybe the additional isolation will help.
Unable to reproduce consistently locally or on try / verify, so I can't verify my assumptions here.
Differential Revision: https://phabricator.services.mozilla.com/D279823
Adding some checkpoints where we wait in the test instead of asserting immediately, but so far I am not reproducing the issue on try, so not guaranteed to fix it.
Differential Revision: https://phabricator.services.mozilla.com/D279816
The `gBrowser.reloadTab` method was doing a very light reload,
which could preserve iframe overriden locations.
The new method ensures we load the original HTML content back,
this seems to also have an impact on keep-alive which is not longer guaranteed.
Only supports reloading the currently selected tab, to better replicate
real user scenarios. But also to comply to `BrowserCommands.reload`,
which only supports reloading the selected tab.
Also tune the har test, now that requests are really cancelled
and we may try to fetch reponse content for such request.
Differential Revision: https://phabricator.services.mozilla.com/D277433
At the moment, if RDM is opened when a browser/tab is discarded, it will remain in a buggy state, and can no longer be disabled on this tab.
Add a new custom event emitted before the tab is discarded so that RDM can cleanly close the RDM ui.
A test is added to check the new close codepath.
Differential Revision: https://phabricator.services.mozilla.com/D279126
This string should normally only be built at failure time, so I hope it will capture the live list of events captured on the target frame, and might give some insights when the test fails.
Differential Revision: https://phabricator.services.mozilla.com/D278935
In most cases, the manifest contained already the same annotation for 2404, so I simply removed the 1804 one, since we no longer run tests on this platform.
In a few cases, the 1804 annotation did not have a 2404 match. In that case I just checked if we had recorded intermittent failures. If yes, I migrated the annotation, if not, I just removed it.
Differential Revision: https://phabricator.services.mozilla.com/D271355
And specify `<!DOCTYPE html>` in relevant test cases to use standards mode.
The proper window.inner{Width,Height} values depend on the minimum-scale
value, rather documentElement.client{Width,Height} are independent from
the zoom value.
Note that documentElement.clientHeight on quirks mode is diffrent from
the one on standards mode. E.g. if the document is zoomed by 0.5x, then
documentElement.clientHeight on quirks mode is twice the value of the
one on standards mode. I've confirmed the behavior is same in Chrome's
RDM.
Differential Revision: https://phabricator.services.mozilla.com/D264163
This reverts commit 8ebbc62f8c.
Revert "Bug 1598487 - Add a "minimum-scale=1" meta viewport into get_actions_origin_page(). r=webdriver-reviewers,jdescottes"
This reverts commit 4ef0efd4c3.
Revert "Bug 1598487 - Add a "minimum-scale=1" meta viewport to both of the reference and the test case for test_clip_box_partially_visible. r=webdriver-reviewers,jdescottes"
This reverts commit 426333bc1b.
Revert "Bug 1598487 - Specify a meta viewport tag to avoid scaling down the content. r=layout-reviewers,dshin"
This reverts commit 86c53ef806.
Revert "Bug 1598487 - Use documentElement.client{Width,Height} in PanZoomControllerTest.kt r=botond,geckoview-reviewers"
This reverts commit ca7531474e.
Revert "Bug 1598487 - Use documentElement.client{Width,Height} in testViewportZoomWidthAndHeight. r=botond,bradwerth,devtools-reviewers,ochameau"
This reverts commit b86d915a07.
Revert "Bug 1598487 - Add `scrollbar-width:none` to avoid scrollbar area affecting window.innerWidth. r=emilio"
This reverts commit 539615e702.
Revert "Bug 1598487 - Use document.documentElement.clientHeight rather than window.innerHeight in helper_doubletap_zoom_hscrollable2.html. r=tnikkel"
This reverts commit e69ee818f9.
And specify `<!DOCTYPE html>` in relevant test cases to use standards mode.
The proper window.inner{Width,Height} values depend on the minimum-scale
value, rather documentElement.client{Width,Height} are independent from
the zoom value.
Note that documentElement.clientHeight on quirks mode is diffrent from
the one on standards mode. E.g. if the document is zoomed by 0.5x, then
documentElement.clientHeight on quirks mode is twice the value of the
one on standards mode. I've confirmed the behavior is same in Chrome's
RDM.
Differential Revision: https://phabricator.services.mozilla.com/D264163
Chris H-C