This reverts commit 1d08a5cd99.
Revert "Bug 2043267 - [devtools] Editing stylesheets in the debugger r=devtools-reviewers,ochameau"
This reverts commit 813e0fadb5.
Revert "Bug 2045710 - [devtools] Fix and add style sheet related test r=devtools-reviewers,ochameau"
This reverts commit 2fc4893d8a.
This reverts commit c07fcd7808.
Revert "Bug 2045710 - [devtools] Fix and add style sheet related test r=devtools-reviewers,ochameau" for causing node failures in devtools/client/*
This reverts commit e46af7df05.
Any code asking for a declaration change preview will trigger unecessary
updates if the value is the same as the current value.
Because of this we were awaiting for more than one rule-view-changed
event in a couple of tests.
It looks like we can also get rid of `flushCount` workaround.
Shapes highlighter are now doing full updates instead of light preview+commit.
Differential Revision: https://phabricator.services.mozilla.com/D294905
The swatches are currently broken when a rule view updates while they
are already opened. This is hard to reproduce yet as the rule view
rarely updates and it often requires interacting with the page or the
browser window to trigger one.
But this is much easier to reproduce with bug 2032221 patches.
Differential Revision: https://phabricator.services.mozilla.com/D294904
This reverts commit d1e8e2dad9.
Revert "Bug 2032220 - [devtools] Re-attach swatches when the declaration value is updated. r=devtools-reviewers,nchevobbe"
This reverts commit 70bb651cb9.
Revert "Bug 2032220 - [devtools] Fix unregistering for filter swatches. r=devtools-reviewers,nchevobbe"
This reverts commit a054f4fc68.
Any code asking for a declaration change preview will trigger unecessary
updates if the value is the same as the current value.
Because of this we were awaiting for more than one rule-view-changed
event in a couple of tests.
It looks like we can also get rid of `flushCount` workaround.
Shapes highlighter are now doing full updates instead of light preview+commit.
Differential Revision: https://phabricator.services.mozilla.com/D294905
The swatches are currently broken when a rule view updates while they
are already opened. This is hard to reproduce yet as the rule view
rarely updates and it often requires interacting with the page or the
browser window to trigger one.
But this is much easier to reproduce with bug 2032221 patches.
Differential Revision: https://phabricator.services.mozilla.com/D294904
Check if the attribute value does match the definedd attr() attr-type parameter
to see if the attribute value or the fallback is being used.
In the attr() tooltip, indicate when the attribute value doesn't match the specified
type.
Differential Revision: https://phabricator.services.mozilla.com/D301490
The implementation is setting a timestamp measured since the process started, however
the metrics.yaml file suggests that this session_id should be unix timestamp (counted from
epoch).
Based on https://bugzilla.mozilla.org/show_bug.cgi?id=1466880#c16 it's intentional to make
the timestamp relative to the start of the browser session so we should update the comments
to reflect that.
However I don't know if the requirement still holds. Also worth noting that a timestamp in ms might
not be enough to differentiate toolboxes started at the same time from the same browser.
Differential Revision: https://phabricator.services.mozilla.com/D301237
Don't put the (undefined) stack entry function name in nestedFunctions,
this would prevent the data-function-expression attribute to be set
properly on the parent stack entry when closing it.
Differential Revision: https://phabricator.services.mozilla.com/D299989
We add the image function in the COLOR_TAKING_FUNCTIONS Set and add a test case
to make sure we show the color swatch for the color parameter.
Differential Revision: https://phabricator.services.mozilla.com/D299949
When any exception happens from the DevToolsProcess's JSProcessActor,
the stacktrace is lost when the exception reaches the parent process.
Manually transfer the exception payload between processes
so that RDP server can send the full stack to the client.
Using callbacks was losing async stack trace, so I moved super.sendQuery
into an inline async function to be able to use await and preserve async
stacks in case of errors.
Differential Revision: https://phabricator.services.mozilla.com/D298390
This is moving the last special cases for Function tokens to onCloseParenthesis,
which means we can also remove `#parseVariable`, `#parseMatchingParens` and the
`stopAtComma` parameter for `#doParse`.
This has the nice side effects of adding color swatches for some declarations
where we didn't use to be able to compute those (results of `color-mix()`,
`contrast-color()`, relative color syntax `from` color, `var()` with fallback),
which are reflected in the changes in the tests.
With this final change, we also needed to change how we're handling font family
names so they can fit nicely in this new design. So instead of keeping track
of the different font family parts, and then appending them to `parts`, we
now keep a single index when we detect a font family name, and when we find
a delimiter or a closing parenthesis, we wrap the meaningful part of the
font family in a dedicated element.
As we needed something similar to what we have for stack entry for fonts, in order
to map a "part" to multiple tokens, we update the `CLOSED_STACK_ENTRY` "token",
renaming it to better convey what it does, and renaming the `stackEntry` into
a more generic `data` property.
Differential Revision: https://phabricator.services.mozilla.com/D296786
We still want to share code between proper url() and UnquotedUrl/BadUrl, so we
transform `#appendURL` into `#createURLElements` that we can use in the new
function that handle closing the url function.
It makes us throw away the part that were computed before, but that's quite limited
and I'd rather pay this cost than having to maintain 2 different places to handle
URLs.
Differential Revision: https://phabricator.services.mozilla.com/D296127
Bug 2033191 made sure we only call ownerGlobal on nodes.
As per the discussion in dev-platform, the front-end ~always wants
.documentGlobal. This removes ownerGlobal from the bindings. Following
patch will rename internal GetOwnerGlobal in gecko to GetRelevantGlobal
as per the HTML spec terminology.
Differential Revision: https://phabricator.services.mozilla.com/D297183
Bug 2033191 made sure we only call ownerGlobal on nodes.
As per the discussion in dev-platform, the front-end ~always wants
.documentGlobal. This removes ownerGlobal from the bindings. Following
patch will rename internal GetOwnerGlobal in gecko to GetRelevantGlobal
as per the HTML spec terminology.
Differential Revision: https://phabricator.services.mozilla.com/D297183
Bug 2033191 made sure we only call ownerGlobal on nodes.
As per the discussion in dev-platform, the front-end ~always wants
.documentGlobal. This removes ownerGlobal from the bindings. Following
patch will rename internal GetOwnerGlobal in gecko to GetRelevantGlobal
as per the HTML spec terminology.
Differential Revision: https://phabricator.services.mozilla.com/D297183
Bug 2033191 made sure we only call ownerGlobal on nodes.
As per the discussion in dev-platform, the front-end ~always wants
.documentGlobal. This removes ownerGlobal from the bindings. Following
patch will rename internal GetOwnerGlobal in gecko to GetRelevantGlobal
as per the HTML spec terminology.
Differential Revision: https://phabricator.services.mozilla.com/D297183
Nicolas Chevobbe