Commit Graph
44 Commits
Author SHA1 Message Date
Mark Banner b38cd3110b Bug 1999554 - Automatically fix ESLint rule jsdoc/check-types for devtools/. r=devtools-reviewers,devtools-backward-compat-reviewers,profiler-reviewers,canaltinova
Differential Revision: https://phabricator.services.mozilla.com/D272173
2025-11-21 16:16:08 +00:00
Gijs Kruitbosch 780b4fb75f Bug 1967204 - remove devtools eslint-env browser annotations, r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D266835
2025-10-01 09:59:33 +00:00
Alexandre Poirot e1f9301f4e Bug 1953578 - [devtools] Migrate all usage of react-prop-types CommonJS module to the ES Module version and remove the CommonJS version. r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D241594
2025-03-19 13:30:51 +00:00
Alexandre Poirot 26260731f1 Bug 1953578 - [devtools] Migrate all usage of react CommonJS module to the ES Module version and remove the CommonJS version. r=devtools-reviewers,profiler-reviewers,nchevobbe,canaltinova
Differential Revision: https://phabricator.services.mozilla.com/D241593
2025-03-19 13:30:51 +00:00
Alexandre Poirot abae55ed07 Bug 1929387 - [devtools] Convert scroll module to ES Module. r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D229001
2025-03-05 17:06:01 +00:00
Alexandre Poirot 6fda8456bd Bug 1929387 - [devtools] Convert focus to ES Module. r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D229000
2025-03-05 17:06:00 +00:00
Alexandre Poirot 4c946b19bd Bug 1885054 - [devtools] Display tracer data in a debugger sidebar. r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D204446
2024-07-22 18:49:43 +00:00
Sandor Molnar 0e45f1b380 Backed out changeset b6571a4222fb (bug 1885054) for causing bug 1909068 CLOSED TREE 2024-07-22 18:24:44 +03:00
Alexandre Poirot c2af106622 Bug 1885054 - [devtools] Display tracer data in a debugger sidebar. r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D204446
2024-07-18 09:02:06 +00:00
Alexandre Poirot b76baed99c Bug 1906125 - [devtools] Implement memory panel odd background in CSS instead of JS. r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D216061
2024-07-10 21:25:48 +00:00
Alexandre Poirot 0a42a5eddb Bug 1906125 - [devtools] Use default Tree stylesheets for the memory panel. r=devtools-reviewers,nchevobbe
We could also drop the custom "focused" classname and instead rely on one being put by VirtualizedTree on tree-node
(like Tree is doing).

Differential Revision: https://phabricator.services.mozilla.com/D216025
2024-07-10 21:25:47 +00:00
Dave Townsend 2af4d349f3 Bug 1864896: Autofix unused function arguments (devtools). r=profiler-reviewers,devtools-reviewers,nchevobbe,julienw
Differential Revision: https://phabricator.services.mozilla.com/D202959
2024-03-05 14:21:15 +00:00
Mark Banner 91fde42f7b Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish
Differential Revision: https://phabricator.services.mozilla.com/D177025
2023-05-20 12:26:49 +00:00
Alexandre Poirot 59fe57c052 Bug 1793396 - [devtools] Use absolute URLs in all usages of loader.lazyRequireGetter. r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D158489
2022-10-03 18:57:13 +00:00
Alexandre Poirot a85b82697f Bug 1792847 - [devtools] Use absolute URLs to import modules in devtools/client/shared. r=jdescottes,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D158379
2022-09-30 15:17:39 +00:00
Tetsuharu Ohzeki 7c92bd768e Bug 1508688 - Add UNSAFE_ prefix to React deprecated lifecycle methods in devtools/client/shared/. r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D149483
2022-06-16 10:03:11 +00:00
Julian Descottes 104a567eab Bug 1656825 - Fix duplicate calls to lazyRequireGetter r=nchevobbe
Depends on D85288

Differential Revision: https://phabricator.services.mozilla.com/D85720
2020-08-03 07:53:50 +00:00
Julian Descottes 03cdcd7b0a Bug 1593921 - Use eslint-disable-next-line to disable complexity checks in DevTools r=pbro
Using next-line is less error prone for refactorings than wrapping methods with enable/disable blocks.

Differential Revision: https://phabricator.services.mozilla.com/D51782
2019-11-05 14:29:04 +00:00
Maliha Islam 20551f411c Bug 1478156 - Move shareable focus methods to be used for color picker accessibility, r=yzen,gl
Differential Revision: https://phabricator.services.mozilla.com/D33885
2019-07-15 11:01:04 +00:00
Narcis Beleuzu 309cad7d16 Backed out 6 changesets (bug 1478156) for dt failures on browser_html_tooltip_xul-wrapper.js . CLOSED TREE
Backed out changeset 5ca694230ffa (bug 1478156)
Backed out changeset fcc9123589fd (bug 1478156)
Backed out changeset 83a10c635fe9 (bug 1478156)
Backed out changeset a363971fffb0 (bug 1478156)
Backed out changeset 314855eab887 (bug 1478156)
Backed out changeset 041f51c9d4d1 (bug 1478156)
2019-07-14 05:32:45 +03:00
Maliha Islam 8097eeda63 Bug 1478156 - Move shareable focus methods to be used for color picker accessibility, r=yzen,gl
Differential Revision: https://phabricator.services.mozilla.com/D33885
2019-07-13 18:37:18 +00:00
Victor Porof b7732ae890 Bug 1561435 - Format devtools/client/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D35884
2019-07-05 11:24:38 +02:00
Patrick Brosset d93842478f Bug 1553451 - Lower the eslint complexity level to 20 for devtools and exlude more complex functions; r=jdescottes
We want to go back to ESLint's default complexity level so that newly introduced code is checked for complexity.
At the same time, to make that work, we're excluding all of the more complex functions for now.
We should fix them: make them less complex, and remove the eslint-disable comment.
See bug 1553449 for more information about this.

Differential Revision: https://phabricator.services.mozilla.com/D32139
2019-05-23 09:06:16 +00:00
Mihai Alexandru Michis c358baf0c3 Backed out changeset 0f9626b48a66 (bug 1553451) for linting failures. CLOSED TREE 2019-05-23 10:58:22 +03:00
Patrick Brosset 18bd75fb8c Bug 1553451 - Lower the eslint complexity level to 20 for devtools and exlude more complex functions; r=jdescottes
We want to go back to ESLint's default complexity level so that newly introduced code is checked for complexity.
At the same time, to make that work, we're excluding all of the more complex functions for now.
We should fix them: make them less complex, and remove the eslint-disable comment.
See bug 1553449 for more information about this.

Differential Revision: https://phabricator.services.mozilla.com/D32139
2019-05-23 07:07:49 +00:00
Michael Ratcliffe 89a6aa6015 Bug 1531845 - Silence various React warnings to help clear up debug mode test logs r=rcaliman
Differential Revision: https://phabricator.services.mozilla.com/D23115
2019-03-19 15:29:37 +00:00
Yura Zenevich 4413c6d1a1 Bug 1535070 - add aria-hidden to ArrowExpander in VirtualizedTree component. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D23359
2019-03-15 17:08:22 +00:00
Yura Zenevich d65fd81594 Bug 1535063 - add shown property to VirtualizedTree component that defines a tree item to be rendered and shown within the tree. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D23358
2019-03-18 07:48:30 +00:00
Yura Zenevich 6c0a07222d Bug 1535063 - fix scrolling into view for VirtualizedTree items that are part of the traversal but not rendered. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D23357
2019-03-16 04:34:59 +00:00
Julian Descottes cc811db468 Bug 1524982 - Use browser loader in performance panel to avoid blocking toolbox destroy;r=gregtatum,ochameau
The main goal is to use the browser loader instead of script tags to avoid using promises tied to the document during the panel's destroy.
I tried to cleanup a bit the modules, to rely less on globals and more on explicit require calls, but there is room for improvement left.
I will write an additional test to check that toolboxes in WINDOW hosts can be closed and reopened for any of our panels in a second changeset.

Differential Revision: https://phabricator.services.mozilla.com/D19865
2019-02-18 16:37:18 +00:00
Yura Zenevich 489af50f29 Bug 1424159 - make virtualized tree nodes tabbable similar to how the inspector markup tree works. r=nchevobbe
MozReview-Commit-ID: LfSppQgpI0O

Differential Revision: https://phabricator.services.mozilla.com/D18591
2019-02-13 13:08:14 +00:00
Yura Zenevich 0be3f10c3a Bug 1518487 - make sure VirtualizedTree keyboard focus scrolling works for trees that are themselves inside scrollable containers. Use the same approach as the tree component in debugger.html. r=nchevobbe
MozReview-Commit-ID: 4HO7WDbyPKA

Differential Revision: https://phabricator.services.mozilla.com/D19051
2019-02-12 19:39:46 +00:00
Csoregi Natalia 845ccf6e5f Backed out 7 changesets (bug 1518487) for failures on devtools/client/accessibility/test/browser/browser_accessibility_sidebar_checks.js. CLOSED TREE
Backed out changeset 7a4f96a4d71c (bug 1518487)
Backed out changeset 8031278b4a17 (bug 1518487)
Backed out changeset d55e9ed92676 (bug 1518487)
Backed out changeset fc1687cc488d (bug 1518487)
Backed out changeset 0d2800976a32 (bug 1518487)
Backed out changeset 62f78c63d9f1 (bug 1518487)
Backed out changeset bc6cc126a9b4 (bug 1518487)
2019-02-12 00:33:42 +02:00
Yura Zenevich 16b297a57b Bug 1518487 - make sure VirtualizedTree keyboard focus scrolling works for trees that are themselves inside scrollable containers. Use the same approach as the tree component in debugger.html. r=nchevobbe
MozReview-Commit-ID: 4HO7WDbyPKA

Differential Revision: https://phabricator.services.mozilla.com/D19051
2019-02-11 20:45:54 +00:00
Mark Banner 3d6aaad3f5 Bug 1486741 - Enable ESLint rule comma-dangle for all of mozilla-central (automatic fixes). r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D8389
2018-10-19 12:55:39 +00:00
Julian Descottes 82711b9a8f Bug 1454696 - Run eslint --fix for prefer-const;r=yulia
MozReview-Commit-ID: F6xUXCgdRE4
2018-06-01 12:36:09 +02:00
Yura Zenevich 3b91ad9038 Bug 1461977 - sync tree's scrollTop with scroll state when tree scrollTop value changes outside of user scroll. r=nchevobbe
MozReview-Commit-ID: 4aIX9mSkg1T
2018-05-28 11:27:00 +03:00
Yura Zenevich 046bfe48e5 Bug 1438912 - by default, do not navigate to next node on ArrowRight key. r=nchevobbe
MozReview-Commit-ID: KQlHIA7pYAn
2018-03-13 09:39:46 -04:00
J. Ryan Stinnett 8d1c817851 Bug 1443081 - Apply spacing via eslint --fix for DevTools. r=jdescottes
MozReview-Commit-ID: 2RVNt140Zte
2018-03-12 13:44:41 -05:00
Yura Zenevich a568a3d975 Bug 1438835 - [VirtualizedTree] keep inner state for when the tree is moused down, to help with deciding when to keyboard focus on tree container. r=nchevobbe
MozReview-Commit-ID: 6W9N242QmmU
2018-03-07 15:38:14 -05:00
Yura Zenevich afa52a72f9 Bug 1438837 - fix VirtualizedTree node aria-level attribute to start with 1 not 0. r=nchevobbe
MozReview-Commit-ID: KLb964Irdkd
2018-03-01 10:41:47 -05:00
Yura Zenevich f64428a194 Bug 1428432 - further improve keyboard accessibility for VirtualizedTree. r=nchevobbe
MozReview-Commit-ID: 8Es17Q5J87a
2018-02-12 22:33:20 -05:00
Yura Zenevich ee506cb68e Bug 1428432 - prevent unnecessary VirtualizedTree render when the client height does not change. r=nchevobbe
MozReview-Commit-ID: FErkeNwUuGF
2018-02-12 22:33:07 -05:00
Leo Huang db9e3f19d5 Bug 1426634 - Rename devtools/client/shared/components/Tree.js to VirtualizedTree.js; r=nchevobbe
MozReview-Commit-ID: 80ebj9CJODR
2017-12-22 12:10:00 +08:00