Commit Graph
394 Commits
Author SHA1 Message Date
Chris H-C d89527a234 Bug 2039650 - Remove Legacy Telemetry devtools probes r=jdescottes,devtools-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D300855
2026-05-28 16:32:18 +00:00
Mark Banner fd62657728 Bug 2004680 - Fix ESLint rule jsdoc/check-tag-names issues in devtools. r=devtools-reviewers,devtools-backward-compat-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D275754
2025-12-22 12:41:26 +00:00
Tom Marble 5ce09d7446 Bug 1995583 - test manifest cleanup for idiomatic usage r=jmaher,necko-reviewers,webcompat-reviewers,geckoview-reviewers,application-update-reviewers,media-playback-reviewers,sessionstore-reviewers,tabbrowser-reviewers,translations-reviewers,omc-reviewers,browser-installer-reviewers,twisniewski,masayuki,dom-core,smaug,nalexander,emcminn,sthompson,alwu,ai-ondevice-reviewers,valentin
For TOML manifests:

1. Change processor -> arch
2. Use arch instead of bits bits == '64' =>
   aarch64 (default on mac 15.30) or x86_64 bits == '32' => x86
3. Replace android_version with corresponding os_version
4. Remove conditions with linux os_version=="18.04"
   (unless they contain verify or verify-standalone)
5. Remove conditions with mac os_version=='11.20',
   (unless they contain verify or verify-standalone)
6. Remove conditions with win os_version=='11.2009' or win11_2009,
   (unless they contain verify or verify-standalone)
7. Linux conditions should have os_version, arch and display
   (simple "os == 'linux'" will get expanded to these two)
   "os == 'linux' && os_version == '22.04' && arch == 'x86_64' && display == 'wayland'"
   "os == 'linux' && os_version == '24.04' && arch == 'x86_64' && display == 'x11'"
8. Mac conditions should have os_version and arch
   (simple "os == 'mac'" will get expanded to these three)
   "os == 'mac' && os_version == '10.15' && arch == 'x86_64'",
   "os == 'mac' && os_version == '14.70' && arch == 'x86_64'",
   "os == 'mac' && os_version == '15.30' && arch == 'aarch64'",
9. Replace apple_catalina with
   os == 'mac' && os_version == '10.15' && arch == 'x86_64'
10. Replace apple_silicon with
   os == 'mac' && os_version = '15.30' && arch == 'aarch64'
11. Replace win10_2009 with
   os == 'win' && os_version = '10.2009' && arch == 'x86_64'
12. Replace "!debug" with three conditions "asan", "opt", or "tsan"
13. Replace literal boolean comparison with variables
    (e.g. "debug == false" => "!debug)

Resolves 2000285

Signed-off-by: Tom Marble <[email protected]>

Differential Revision: https://phabricator.services.mozilla.com/D272815
2025-11-22 00:30:39 +00:00
Mark Banner b38cd3110b Bug 1999554 - Automatically fix ESLint rule jsdoc/check-types for devtools/. r=devtools-reviewers,devtools-backward-compat-reviewers,profiler-reviewers,canaltinova
Differential Revision: https://phabricator.services.mozilla.com/D272173
2025-11-21 16:16:08 +00:00
Mark Banner 2542790f53 Bug 1998787 - Automatic fixes for enabling ESLint jsdoc/tag-line rule everywhere. r=frontend-codestyle-reviewers,mtigley,perftest-reviewers,nchevobbe,home-newtab-reviewers,Gijs,mconley,sparky
Differential Revision: https://phabricator.services.mozilla.com/D271745
2025-11-10 21:27:12 +00:00
Julian Descottes 10d9b0bae3 Bug 1965131 - [devtools] Wait for focus/blur events in test_list_keyboard.html r=devtools-reviewers,nchevobbe
The test fails regularly locally in debug mode. With the change proposed in this patch it passes consistently with --repeat 50 so I assume this should fix the problem.

Differential Revision: https://phabricator.services.mozilla.com/D268521
2025-10-14 13:20:29 +00:00
Emilio Cobos Álvarez fdee03ec98 Bug 1982307 - Remove dom.disable_tab_focus_to_root_element. r=smaug,dom-core
Shipped for more than a year.

Differential Revision: https://phabricator.services.mozilla.com/D260630
2025-08-11 11:35:40 +00:00
Julian Descottes b3efbc9810 Bug 1978538 - [devtools] Attach Memory panel splitter events to panel iframe r=devtools-reviewers,nchevobbe
Also cleanup an unnecessary assertion in the HSplitBox render.

Differential Revision: https://phabricator.services.mozilla.com/D258315
2025-07-24 08:05:18 +00:00
Joel Maher 1a4fb71e2c Bug 1975729 - adjust whitespace and newlines for most mochitest .toml files, also remove unnecessary skip-if=verify conditions. r=florian,webdriver-reviewers,necko-reviewers,mtigley,webcompat-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,credential-management-reviewers,search-reviewers,devtools-reviewers,anti-tracking-reviewers,places-reviewers,profiler-reviewers,dom-storage-reviewers,translations-reviewers,omc-reviewers,home-newtab-reviewers,sidebar-reviewers,urlbar-reviewers,firefox-ai-ml-reviewers,twisniewski,bytesized,emcminn,Standard8,karlt,padenot,jdescottes,dimi,kershaw,robwu,canaltinova,nbarrett,asuth
Differential Revision: https://phabricator.services.mozilla.com/D256136
2025-07-12 16:26:27 +00:00
Joel Maher 4f12cd2a96 Bug 1971285 - additional test manifest annotations for Ubuntu 24.04 migration. r=aryx,webdriver-reviewers,necko-reviewers,mtigley,webcompat-reviewers,extension-reviewers,settings-reviewers,credential-management-reviewers,webrtc-reviewers,devtools-reviewers,fxview-reviewers,anti-tracking-reviewers,places-reviewers,translations-reviewers,omc-reviewers,migration-reviewers,home-newtab-reviewers,urlbar-reviewers,twisniewski,whimboo,nsharpley,nchevobbe,dimi,kershaw,robwu,Standard8,mconley,timhuang,jprickett
Differential Revision: https://phabricator.services.mozilla.com/D253172
2025-06-13 19:52:33 +00:00
Mark Banner 3cc3379c8f Bug 1881701 - Change the devtools configurations to work with the ESLint flat configuration.r=devtools-reviewers,profiler-reviewers,julienw,nchevobbe
This consolidates the jest environment definition, and the xpcshell globals into the devtools/.eslintrc.mjs file, for easier configurations.
It also changes the restart of the configurations to work with flat config.

Differential Revision: https://phabricator.services.mozilla.com/D249948
2025-05-24 17:10:59 +00:00
Mark Banner d7c7c5369b Bug 1881701 - Rename many ESLint files to use .mjs. r=frontend-codestyle-reviewers,perftest-reviewers,Gijs,sparky,webcompat-reviewers,twisniewski
This is separate to help preserve history of the files.

Differential Revision: https://phabricator.services.mozilla.com/D249945
2025-05-24 17:10:51 +00:00
Hubert Boma Manilla 6e90ce0ab2 Bug 1953851 - [devtools] Update the MDN links r=devtools-reviewers,nchevobbe,cookie-reviewers,valentin,fluent-reviewers,shtrom,zeid,anti-tracking-reviewers,translations-reviewers,android-reviewers,flod,bvandersloot,jonalmeida,tthibaud
Differential Revision: https://phabricator.services.mozilla.com/D241589
2025-04-01 17:12:54 +00:00
Sandor Molnar a839d26316 Backed out changeset 376442637e13 (bug 1953851) for causing build bustages. CLOSED TREE 2025-03-25 21:28:09 +02:00
Hubert Boma Manilla b6ef2193f9 Bug 1953851 - [devtools] Update the MDN links r=devtools-reviewers,nchevobbe,cookie-reviewers,valentin,fluent-reviewers,zeid,anti-tracking-reviewers,translations-reviewers,android-reviewers,flod,bvandersloot,jonalmeida,tthibaud
Differential Revision: https://phabricator.services.mozilla.com/D241589
2025-03-25 15:57:37 +00:00
Alexandre Poirot f758c5ec7d Bug 1953957 - [devtools] Stop shipping react-test-renderer-shallow.mjs in Firefox while it is only used in tests. r=devtools-reviewers,nchevobbe
This sizeable file is only used by two tests.
On top of that, we could easily use some other way to test them.

Differential Revision: https://phabricator.services.mozilla.com/D241595
2025-03-19 13:30:51 +00:00
Alexandre Poirot 49e23bea5b Bug 1953578 - [devtools] Migrate all usage of react-dom CommonJS module to the ES Module version and remove the CommonJS version. r=profiler-reviewers,devtools-reviewers,canaltinova,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D241280
2025-03-19 13:30:50 +00:00
Stanca Serban 73122005bc Backed out changeset f123a8f22b50 (bug 1953851) for causing devtools failures in browser_webconsole_warning_group_cookies.js. 2025-03-17 18:02:37 +02:00
Hubert Boma Manilla d7ffb0dafb Bug 1953851 - [devtools] Update the MDN links in devtools r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D241589
2025-03-17 13:09:47 +00:00
Stanca Serban 826842a16d Backed out changeset 9d11f76b4c4d (bug 1953851) for causing devtools failures in browser_webconsole_cors_errors.js. CLOSED TREE 2025-03-17 13:17:45 +02:00
Hubert Boma Manilla 123c53908c Bug 1953851 - [devtools] Update the MDN links in devtools r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D241589
2025-03-17 09:04:32 +00:00
Alexandre Poirot 9bea8fb282 Bug 1671400 - [devtools] Remove now unused reps stubs. r=devtools-reviewers,frontend-codestyle-reviewers,nchevobbe,mossop
Differential Revision: https://phabricator.services.mozilla.com/D241040
2025-03-11 23:52:21 +00:00
Alexandre Poirot f9515764a5 Bug 1929387 - [devtools] Convert Tree shared component to ES Modules. r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D228999
2025-03-05 17:05:59 +00:00
Alexandre Poirot 539c95c4f6 Bug 1929387 - [devtools] Remove object-inspector tests. r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D230120
2025-03-05 17:05:57 +00:00
Alexandre Poirot ec42a98f0d Bug 1929387 - [devtools] Remove all Reps tests. r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D230119
2025-03-05 17:05:56 +00:00
Nicolas Chevobbe f0790c3bc7 Bug 1950865 - [devtools] Remove "Object" title in ObjectRep. r=devtools-reviewers,ochameau.
This Reps is only displayed for JSON, where we can't have class instances,
so the curly brackets should be enough to indicate this is an object.
Also, we don't show a title for in ArrayRep, so we'll be consistent.

Differential Revision: https://phabricator.services.mozilla.com/D240021
2025-03-04 06:53:21 +00:00
Nicolas Chevobbe 7f06d3d190 Bug 1949793 - [devtools] Display length bubble in ArrayRep, like we do for GripArrayRep. r=devtools-reviewers,jdescottes.
Differential Revision: https://phabricator.services.mozilla.com/D239169
2025-02-25 14:31:50 +00:00
Stanca Serban 389d4c2477 Backed out changeset fac980cc9810 (bug 1949793) for causing devtools failures in browser_net_params_sorted.js. CLOSED TREE 2025-02-25 11:17:42 +02:00
Nicolas Chevobbe 10897108aa Bug 1949793 - [devtools] Display length bubble in ArrayRep, like we do for GripArrayRep. r=devtools-reviewers,jdescottes.
Differential Revision: https://phabricator.services.mozilla.com/D239169
2025-02-25 07:37:08 +00:00
Nicolas Chevobbe f781ce2dac Bug 1935499 - [devtools] Use actual button for accordion toggle. r=devtools-reviewers,jdescottes.
With this change we can remove a few fail-if annotations.
This also allows us to remove the specific handling of Enter/Space since it will
go through onClick now.

Differential Revision: https://phabricator.services.mozilla.com/D233148
2025-01-03 13:16:59 +00:00
Mark Banner d0718e3c69 Bug 1937739. r=frontend-codestyle-reviewers,perftest-reviewers,mossop,sparky
Differential Revision: https://phabricator.services.mozilla.com/D232598
2024-12-19 17:05:08 +00:00
Hubert Boma Manilla 02b1a793bc Bug 1843324 - [devtools] Fix the accessibility for the callstack r=devtools-reviewers,accessibility-frontend-reviewers,nchevobbe,nlapre
### Some highlights of this patch

- Add up/down arrow navigation to the list
- Add support for the HOME and END keys to jump to the first and last elements
- Use different inactive colors for dead frames
- Added tests for the navigation

Differential Revision: https://phabricator.services.mozilla.com/D227353
2024-12-11 09:07:47 +00:00
Nicolas Chevobbe c35e2154e0 Bug 1935178 - [devtools] Add test for Tabs keyboard navigation. r=devtools-reviewers,ochameau.
Also use the selected index to retrieve the selected tab instead of the is-active class.

Differential Revision: https://phabricator.services.mozilla.com/D231390
2024-12-11 06:10:33 +00:00
Logan Rosen d24c9d9ff4 Bug 1857834 - auto-formatting with Prettier v3 r=linter-reviewers,webdriver-reviewers,perftest-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,reusable-components-reviewers,profiler-reviewers,dom-storage-reviewers,android-reviewers,firefox-ai-ml-reviewers,hjones,mcheang,mstange,sparky,janv,nchevobbe,tarek,Standard8,markh
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D230598
2024-11-29 15:18:25 +00:00
Alexandre Poirot 4c946b19bd Bug 1885054 - [devtools] Display tracer data in a debugger sidebar. r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D204446
2024-07-22 18:49:43 +00:00
Sandor Molnar 0e45f1b380 Backed out changeset b6571a4222fb (bug 1885054) for causing bug 1909068 CLOSED TREE 2024-07-22 18:24:44 +03:00
Alexandre Poirot c2af106622 Bug 1885054 - [devtools] Display tracer data in a debugger sidebar. r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D204446
2024-07-18 09:02:06 +00:00
Alexandre Poirot 27ee6fdd0f Bug 1906125 - [devtools] Unify VirtualizedTree and Tree CSS and move SourcesTree specifics to Tree. r=devtools-reviewers,nchevobbe
- make them both use .theme-twisty to show an arrow icon.
- move some specifics stylings of SourcesTree to the base class.
- make SourcesTree use the arrow React component provided by Tree class.
- use .theme-twisty instead of .arrow (which already implements rotation and colors on expand). But it uses "open" instead of "expanded" classname.
  (VirtualizedTree was already using theme-twisty)

This impacts the Source Tree, ObjectInspector (console, debugger), Watch Expressions, memory panel (dominator view).

Differential Revision: https://phabricator.services.mozilla.com/D215637
2024-07-10 21:25:46 +00:00
Nicolas Chevobbe e249389848 Bug 1844087 - [devtools] Make SearchBox input described by summary element. r=devtools-reviewers,accessibility-frontend-reviewers,ochameau,ayeddi.
This should allow the number of hidden messages to be notified to
screen reader users.
We update the Console FilterBar behavior to always show the "X hidden" message
when the input is focused, so screen reader can also pick up when no messages
are hidden.

Differential Revision: https://phabricator.services.mozilla.com/D213181
2024-06-17 06:31:26 +00:00
Alexandre Poirot d7f3cddc7f Bug 1888171 - [devtools] Convert Browser Loader to ESM. r=profiler-reviewers,devtools-reviewers,nchevobbe,julienw
Differential Revision: https://phabricator.services.mozilla.com/D205867
2024-03-28 15:15:24 +00:00
Dave Townsend 2af4d349f3 Bug 1864896: Autofix unused function arguments (devtools). r=profiler-reviewers,devtools-reviewers,nchevobbe,julienw
Differential Revision: https://phabricator.services.mozilla.com/D202959
2024-03-05 14:21:15 +00:00
Sean Feng 58b1092a75 Bug 1483828 - [Part 3] Update the expected focusing behavior for some devtools tests r=smaug,devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D202505
2024-03-04 14:16:31 +00:00
Sean Feng d7254ccf1b Bug 1483828 - [Part 1] Disallow <tab> to move focus to root element r=smaug
Brings us on-par with Chrome and Safari

Differential Revision: https://phabricator.services.mozilla.com/D198436
2024-03-04 14:16:30 +00:00
Nicolas Chevobbe 11771bdcb9 Bug 1867726 - [devtools] Handle cross-process iframe content window in previewers. r=devtools-reviewers,ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D196289
2023-12-18 14:36:50 +00:00
Joel Maher 4072dc32c4 Bug 1869590 - Batch 19 - convert remaining mochitest ini to toml. r=aryx,necko-reviewers,devtools-reviewers,dom-storage-reviewers,asuth,valentin,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D196203
2023-12-13 15:44:04 +00:00
Nicolas Chevobbe 7ad78b458f Bug 1844088 - [devtools] Add title on Tree toggle button. r=devtools-reviewers,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D194771
2023-11-27 18:38:23 +00:00
Tom Marble 6c1231e2e8 Bug 1853244 - convert .ini manifests to .toml: batch 6 {caps,devtools,dom}/**/browser.ini r=jmaher,media-playback-reviewers,devtools-reviewers,profiler-reviewers,alwu,nchevobbe,canaltinova
Differential Revision: https://phabricator.services.mozilla.com/D188856
2023-09-22 20:42:14 +00:00
Tom Marble d70780c99c Bug 1850545 - convert .ini manifests to .toml: batch 3 chrome.ini (bis) r=jmaher,geckoview-reviewers,extension-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,places-reviewers,profiler-reviewers,m_kato,mak,mtigley
Differential Revision: https://phabricator.services.mozilla.com/D187597
2023-09-13 18:28:32 +00:00
Nicolas Chevobbe 639acf139e Bug 1847517 - [devtools] Tweak preview popup style. r=devtools-reviewers,ochameau.
Don't display the arrow on the root node, and remove the ability to collapse it.
Add a border at the bottom of the root node so it looks like a header
Add a new `HEADER` Rep mode that will be used for the root node, so we're
showing relevant information in this context (e.g. the object type/class name)
but not the preview when it would be redundant with the content of the tooltip.

For example, we don't want to show the preview for simple objects, arrays, maps, …
but we still have a "longer" description for objects where the properties in
the preview are handpicked (e.g. elements, window, document, …)

Differential Revision: https://phabricator.services.mozilla.com/D185770
2023-08-16 09:53:17 +00:00
Iulian Moraru 45c3204b14 Backed out changeset bc9a3a0b8e55 (bug 1847517) for causing Bug 1848531. 2023-08-14 18:55:39 +03:00