Commit Graph
77 Commits
Author SHA1 Message Date
Chris H-C d89527a234 Bug 2039650 - Remove Legacy Telemetry devtools probes r=jdescottes,devtools-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D300855
2026-05-28 16:32:18 +00:00
Sylvestre Ledru 074b376055 Bug 2023419 - Remove Emacs/Vim modelines from devtools/ r=emilio,devtools-backward-compat-reviewers,devtools-reviewers,nchevobbe
replaced by .editorconfig
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D287841
2026-03-28 10:21:10 +00:00
Alexandru Marc 630e6cf0e8 Revert "Bug 2023419 - Remove Emacs/Vim modelines from devtools/ r=emilio,devtools-backward-compat-reviewers,devtools-reviewers,nchevobbe" for causing devtools failures
This reverts commit ed535dace9.
2026-03-17 12:46:01 +00:00
Sylvestre Ledru ed535dace9 Bug 2023419 - Remove Emacs/Vim modelines from devtools/ r=emilio,devtools-backward-compat-reviewers,devtools-reviewers,nchevobbe
replaced by .editorconfig

Differential Revision: https://phabricator.services.mozilla.com/D287841
2026-03-17 12:03:34 +00:00
Tom Marble 5ce09d7446 Bug 1995583 - test manifest cleanup for idiomatic usage r=jmaher,necko-reviewers,webcompat-reviewers,geckoview-reviewers,application-update-reviewers,media-playback-reviewers,sessionstore-reviewers,tabbrowser-reviewers,translations-reviewers,omc-reviewers,browser-installer-reviewers,twisniewski,masayuki,dom-core,smaug,nalexander,emcminn,sthompson,alwu,ai-ondevice-reviewers,valentin
For TOML manifests:

1. Change processor -> arch
2. Use arch instead of bits bits == '64' =>
   aarch64 (default on mac 15.30) or x86_64 bits == '32' => x86
3. Replace android_version with corresponding os_version
4. Remove conditions with linux os_version=="18.04"
   (unless they contain verify or verify-standalone)
5. Remove conditions with mac os_version=='11.20',
   (unless they contain verify or verify-standalone)
6. Remove conditions with win os_version=='11.2009' or win11_2009,
   (unless they contain verify or verify-standalone)
7. Linux conditions should have os_version, arch and display
   (simple "os == 'linux'" will get expanded to these two)
   "os == 'linux' && os_version == '22.04' && arch == 'x86_64' && display == 'wayland'"
   "os == 'linux' && os_version == '24.04' && arch == 'x86_64' && display == 'x11'"
8. Mac conditions should have os_version and arch
   (simple "os == 'mac'" will get expanded to these three)
   "os == 'mac' && os_version == '10.15' && arch == 'x86_64'",
   "os == 'mac' && os_version == '14.70' && arch == 'x86_64'",
   "os == 'mac' && os_version == '15.30' && arch == 'aarch64'",
9. Replace apple_catalina with
   os == 'mac' && os_version == '10.15' && arch == 'x86_64'
10. Replace apple_silicon with
   os == 'mac' && os_version = '15.30' && arch == 'aarch64'
11. Replace win10_2009 with
   os == 'win' && os_version = '10.2009' && arch == 'x86_64'
12. Replace "!debug" with three conditions "asan", "opt", or "tsan"
13. Replace literal boolean comparison with variables
    (e.g. "debug == false" => "!debug)

Resolves 2000285

Signed-off-by: Tom Marble <[email protected]>

Differential Revision: https://phabricator.services.mozilla.com/D272815
2025-11-22 00:30:39 +00:00
Mark Banner b38cd3110b Bug 1999554 - Automatically fix ESLint rule jsdoc/check-types for devtools/. r=devtools-reviewers,devtools-backward-compat-reviewers,profiler-reviewers,canaltinova
Differential Revision: https://phabricator.services.mozilla.com/D272173
2025-11-21 16:16:08 +00:00
Mark Banner 2542790f53 Bug 1998787 - Automatic fixes for enabling ESLint jsdoc/tag-line rule everywhere. r=frontend-codestyle-reviewers,mtigley,perftest-reviewers,nchevobbe,home-newtab-reviewers,Gijs,mconley,sparky
Differential Revision: https://phabricator.services.mozilla.com/D271745
2025-11-10 21:27:12 +00:00
Julian Descottes 4775083d65 Bug 1998335 - [devtools] Remove and migrate linux 1804 annotations from DevTools browser.toml manifests r=profiler-reviewers,devtools-reviewers,florian,nchevobbe
In most cases, the manifest contained already the same annotation for 2404, so I simply removed the 1804 one, since we no longer run tests on this platform.
In a few cases, the 1804 annotation did not have a 2404 match. In that case I just checked if we had recorded intermittent failures. If yes, I migrated the annotation, if not, I just removed it.

Differential Revision: https://phabricator.services.mozilla.com/D271355
2025-11-05 08:25:24 +00:00
Mark Banner e4d3bbab0b Bug 1881270 - Fix no-case-declarations in devtools/ code. r=devtools-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D266006
2025-09-25 18:33:14 +00:00
agoloman f0289ea0d2 Revert "Bug 1881270 - Fix no-case-declarations in devtools/ code. r=devtools-reviewers,jdescottes" for causing mochitest failures @test_suppressed_events_nested_iframe.html.
This reverts commit 8e7d559526.

Revert "Bug 1881270 - Fix no-case-declarations issues in extensions code. r=extension-reviewers,willdurand"

This reverts commit 2a0800455d.

Revert "Bug 1881270 - Fix ESLint no-case-declarations issues in various files. r=frontend-codestyle-reviewers,necko-reviewers,media-playback-reviewers,layout-reviewers,dom-worker-reviewers,padenot,mossop,asuth,TYLin"

This reverts commit 3c05c4bfee.
2025-09-25 15:04:21 +00:00
Mark Banner 8e7d559526 Bug 1881270 - Fix no-case-declarations in devtools/ code. r=devtools-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D266006
2025-09-25 10:34:16 +00:00
Alexandre Poirot 9677d792ee Bug 1971817 - [devtools] Clear the source map loader when removing sources. r=devtools-reviewers,bomsy
If a worker thread was using source maps, we weren't clearing the source map worker.
This will also be important when removing pretty printed source in order to stop
having the minimized source to be mapped when we disable pretty print.

Differential Revision: https://phabricator.services.mozilla.com/D255805
2025-07-28 15:29:35 +00:00
Serban Stanca 014d790c57 Revert "Bug 1977637, Bug 1971817 - [devtools] Better highlight pretty print state in Footers. r=devtools-reviewers,nchevobbe"
This reverts commit 46299ee751.

This reverts commit 54ad0c64a0.

This reverts commit fd568f41df.

This reverts commit cba6b633df.

This reverts commit 66e8617afe.

This reverts commit fa37bc5a94.
2025-07-23 01:31:38 +00:00
Alexandre Poirot cba6b633df Bug 1971817 - [devtools] Clear the source map loader when removing sources. r=devtools-reviewers,bomsy
If a worker thread was using source maps, we weren't clearing the source map worker.
This will also be important when removing pretty printed source in order to stop
having the minimized source to be mapped when we disable pretty print.

Differential Revision: https://phabricator.services.mozilla.com/D255805
2025-07-22 15:04:10 +00:00
Tom Schuster 608c0bf059 Bug 1968479 - Fix or allow eval in various tests r=webdriver-reviewers,extension-reviewers,settings-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,anti-tracking-reviewers,necko-reviewers,valentin,jdescottes,dimi,zombie
Differential Revision: https://phabricator.services.mozilla.com/D251365
2025-06-17 10:14:58 +00:00
Alexandru Marc f01958b1f8 Revert "Bug 1968479 - Fix or allow eval in various tests r=webdriver-reviewers,extension-reviewers,settings-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,anti-tracking-reviewers,necko-reviewers,valentin,jdescottes,dimi,zombie" for causing talos perf failures @ source-map-library.js
This reverts commit 6e4877ba23.

Revert "Bug 1968479 - Use evalInSandbox instead of eval in BrowserTestUtils r=mccr8"

This reverts commit 3d33fadf29.

Revert "Bug 1968479 - Allow eval in a11y tests. r=Jamie"

This reverts commit 91269aaf23.

Revert "Bug 1968479 - Use evalInSandbox instead of eval in ChromeTask.spawn. r=emilio"

This reverts commit 2c02bc4a3c.

Revert "Bug 1968479 - Disable DetectJsHacks for eval in Nightly builds. r=tjr"

This reverts commit a1948709ce.
2025-06-17 02:28:21 +00:00
Tom Schuster 6e4877ba23 Bug 1968479 - Fix or allow eval in various tests r=webdriver-reviewers,extension-reviewers,settings-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,anti-tracking-reviewers,necko-reviewers,valentin,jdescottes,dimi,zombie
Differential Revision: https://phabricator.services.mozilla.com/D251365
2025-06-16 18:04:53 +00:00
Atila Butkovits b8675a9642 Revert "Bug 1968479 - Fix or allow eval in various tests r=webdriver-reviewers,extension-reviewers,settings-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,anti-tracking-reviewers,necko-reviewers,valentin,jdescottes,dimi,zombie" for causing failures at browser_devices_select_audio_output.js.
This reverts commit 5f72916916.

Revert "Bug 1968479 - Use evalInSandbox instead of eval in BrowserTestUtils r=mccr8"

This reverts commit d1cf11936b.

Revert "Bug 1968479 - Allow eval in a11y tests. r=Jamie"

This reverts commit efe56ee9d8.

Revert "Bug 1968479 - Use evalInSandbox instead of eval in ChromeTask.spawn. r=emilio"

This reverts commit 0e771b2156.

Revert "Bug 1968479 - Disable DetectJsHacks for eval in Nightly builds. r=tjr"

This reverts commit 9a4a55bd7b.
2025-06-16 13:59:56 +00:00
Tom Schuster 5f72916916 Bug 1968479 - Fix or allow eval in various tests r=webdriver-reviewers,extension-reviewers,settings-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,anti-tracking-reviewers,necko-reviewers,valentin,jdescottes,dimi,zombie
Differential Revision: https://phabricator.services.mozilla.com/D251365
2025-06-16 12:53:22 +00:00
Joel Maher 7e69b821f2 Bug 1967293 - Update mochitest manifest annotations to support Ubuntu 24.04. r=aryx,webcompat-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,sessionstore-reviewers,profiler-reviewers,dom-storage-reviewers,twisniewski,asuth,accessibility-frontend-reviewers,julienw,dimi,morgan,mconley,ochameau,nsharpley
Differential Revision: https://phabricator.services.mozilla.com/D250070
2025-05-23 20:13:29 +00:00
Joel Maher 76447d27c5 Bug 1957258 - cleanup devtools-chrome .toml manifest, enable many tests! r=aryx,devtools-reviewers,profiler-reviewers,julienw,ochameau,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D243603
2025-04-04 15:06:02 +00:00
Tooru Fujisawa 850a941bc2 Bug 1938858 - Remove the jsm support from the source map loader. r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D233742
2025-01-23 12:09:38 +00:00
Logan Rosen d24c9d9ff4 Bug 1857834 - auto-formatting with Prettier v3 r=linter-reviewers,webdriver-reviewers,perftest-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,reusable-components-reviewers,profiler-reviewers,dom-storage-reviewers,android-reviewers,firefox-ai-ml-reviewers,hjones,mcheang,mstange,sparky,janv,nchevobbe,tarek,Standard8,markh
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D230598
2024-11-29 15:18:25 +00:00
Alexandre Poirot 10100b0ce6 Bug 1919785 - [devtools] Improve error logging when an exception is thrown in devtools workers. r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D222790
2024-10-07 11:40:04 +00:00
Stanca Serban bfe1d00dbd Backed out 2 changesets (bug 1919785, bug 1919570) for causing damp-other failures.
Backed out changeset a5a762ada6bd (bug 1919785)
Backed out changeset 88fafd5296fe (bug 1919570)
2024-10-01 06:45:04 +03:00
Alexandre Poirot 5d2bda79c8 Bug 1919785 - [devtools] Improve error logging when an exception is thrown in devtools workers. r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D222790
2024-09-30 20:48:02 +00:00
Sandor Molnar 4063155409 Backed out 2 changesets (bug 1919570, bug 1919785) for causing dt failures @ browser_dbg-sourcemaps-bogus.js CLOSED TREE
Backed out changeset 3371f31eeb2a (bug 1919785)
Backed out changeset 98d74e2fc2d5 (bug 1919570)
2024-09-30 18:24:49 +03:00
Alexandre Poirot 760fc01014 Bug 1919785 - [devtools] Improve error logging when an exception is thrown in devtools workers. r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D222790
2024-09-30 12:04:31 +00:00
Julian Descottes 1bb7ba8e3b Bug 1899389 - [devtools] Use credentials for devtools sourcemap fetch call r=devtools-reviewers,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D212059
2024-05-30 08:27:28 +00:00
Dave Townsend 2af4d349f3 Bug 1864896: Autofix unused function arguments (devtools). r=profiler-reviewers,devtools-reviewers,nchevobbe,julienw
Differential Revision: https://phabricator.services.mozilla.com/D202959
2024-03-05 14:21:15 +00:00
Alexandre Poirot eae3d6b2b7 Bug 1834725 - [devtools] Retrieve the resolved source map URL and source map error. r=devtools-reviewers,nchevobbe
Extract information out of the source map worker to be stored into the Debugger store.

Renamed SourceMapLoader getOriginalURLs to loadSourceMap to better translate the heavy process involved in this method.
While doing that, also inline the transfer of source map ignore list in this call (instead of always having another worker message right after).

This will be used and tested in the next changeset.

Differential Revision: https://phabricator.services.mozilla.com/D188585
2024-01-15 12:57:19 +00:00
Alexandre Poirot e1abf62065 Bug 1834725 - [devtools] Log source map errors to the console directly from SourceMapLoader. r=devtools-reviewers,nchevobbe
The main goal here is to re-throw the exception so that the debugger can start displaying source map errors.

Note that the previous changeset tweaked the StyleEditor code to handle exceptions.
The Debugger will be handled in the next changeset.

Differential Revision: https://phabricator.services.mozilla.com/D187576
2024-01-15 12:57:19 +00:00
Natalia Csoregi 63d346b505 Backed out 4 changesets (bug 1834725) for causing failures on browser_styleeditor_loading_with_containers.js. CLOSED TREE
Backed out changeset 0965e956200a (bug 1834725)
Backed out changeset 4a8151163607 (bug 1834725)
Backed out changeset a56f42223377 (bug 1834725)
Backed out changeset a920356b63eb (bug 1834725)
2024-01-11 19:57:47 +02:00
Alexandre Poirot e563562e9a Bug 1834725 - [devtools] Retrieve the resolved source map URL and source map error. r=devtools-reviewers,nchevobbe
Extract information out of the source map worker to be stored into the Debugger store.

Renamed SourceMapLoader getOriginalURLs to loadSourceMap to better translate the heavy process involved in this method.
While doing that, also inline the transfer of source map ignore list in this call (instead of always having another worker message right after).

This will be used and tested in the next changeset.

Differential Revision: https://phabricator.services.mozilla.com/D188585
2024-01-11 15:27:25 +00:00
Alexandre Poirot 31e7b41420 Bug 1834725 - [devtools] Log source map errors to the console directly from SourceMapLoader. r=devtools-reviewers,nchevobbe
The main goal here is to re-throw the exception so that the debugger can start displaying source map errors.

Note that the previous changeset tweaked the StyleEditor code to handle exceptions.
The Debugger will be handled in the next changeset.

Differential Revision: https://phabricator.services.mozilla.com/D187576
2024-01-11 15:27:25 +00:00
Alexandre Poirot 242b81d5ff Bug 1834729 - [devtools] Provide link to the related original file in the footer. r=devtools-reviewers,nchevobbe
For now, we were only showing the related bundle file,
so that we can easily navigate from original file to bundle file.
But we could also show the related original file for a location.
This is slightly more complex because the mapped location can now be different
depending on the precise location in the selected file.
Also, there is no synchronous API to compute this mapped location.
We have to involve an asynchronous action to compute this data for bundles.

Tweak Source Map Loader in order to do a loose bundle to original mapping
in case we aren't in a cursor location that has a perfect match.
Try mapping the first column of the same line and then all first column of
the next 10 following lines.

Differential Revision: https://phabricator.services.mozilla.com/D187573
2023-12-20 23:01:21 +00:00
Mark Banner ebbea0ff69 Bug 1866641 - Rename workers to use the .worker.(m)js pattern for ESLint (devtools/). r=devtools-reviewers,profiler-reviewers,nchevobbe,canaltinova
Differential Revision: https://phabricator.services.mozilla.com/D194698
2023-11-30 11:42:17 +00:00
Iulian Moraru 619a2745f7 Backed out 3 changesets (bug 1866641) for causing talos damp failures on browser-toolbox.js. CLOSED TREE
Backed out changeset 7cab7eb61b23 (bug 1866641)
Backed out changeset dbe3fabc6e89 (bug 1866641)
Backed out changeset 1dfb7cfdc26e (bug 1866641)
2023-11-29 21:00:42 +02:00
Mark Banner a3b85c10e2 Bug 1866641 - Rename workers to use the .worker.(m)js pattern for ESLint (devtools/). r=devtools-reviewers,profiler-reviewers,nchevobbe,canaltinova
Differential Revision: https://phabricator.services.mozilla.com/D194698
2023-11-29 11:49:18 +00:00
Alexandre Poirot d1f78ac0a4 Bug 1856658 - [devtools] Better integrate SourceMapLoader into breakable positions computation. r=devtools-reviewers,nchevobbe
We can avoid the creation of an handful of object creations by passing
the "breakpoint positions" objects directly to the Source Map Loader.
(avoid convertToList)

We can also tune `SourceMapLoader.getOriginalLocations` output to better
fit the requirements of the main thread.

Differential Revision: https://phabricator.services.mozilla.com/D189950
2023-10-05 15:03:32 +00:00
Alexandre Poirot 3b21974b94 Bug 1856658 - [devtools] Drop unused options/search argument to getOriginalLocation(s). r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D189949
2023-10-05 15:03:31 +00:00
Tom Marble 6c1231e2e8 Bug 1853244 - convert .ini manifests to .toml: batch 6 {caps,devtools,dom}/**/browser.ini r=jmaher,media-playback-reviewers,devtools-reviewers,profiler-reviewers,alwu,nchevobbe,canaltinova
Differential Revision: https://phabricator.services.mozilla.com/D188856
2023-09-22 20:42:14 +00:00
Kershaw Chang 8c73084fff Bug 1838829 - Skip failed tests, r=necko-reviewers,extension-reviewers,credential-management-reviewers,devtools-reviewers,dimi,valentin,robwu
Differential Revision: https://phabricator.services.mozilla.com/D181251
2023-06-28 13:21:00 +00:00
Norisz Fay a17cc174f1 Backed out 2 changesets (bug 1838829) for causing perma mochitest failure with dom/websocket/tests being skipped CLOSED TREE
Backed out changeset 19a5d4f1850a (bug 1838829)
Backed out changeset 97cd8a256954 (bug 1838829)
2023-06-27 02:52:52 +03:00
Kershaw Chang 49115434d9 Bug 1838829 - Skip failed tests, r=necko-reviewers,extension-reviewers,credential-management-reviewers,devtools-reviewers,dimi,valentin,robwu
Differential Revision: https://phabricator.services.mozilla.com/D181251
2023-06-26 14:22:14 +00:00
Norisz Fay da37f6c50c Backed out 5 changesets (bug 1838829) for causing mochitest failures CLOSED TREE
Backed out changeset 693d34c8447d (bug 1838829)
Backed out changeset 903d9ff4afaa (bug 1838829)
Backed out changeset 5e51feff7467 (bug 1838829)
Backed out changeset e125be49d2a6 (bug 1838829)
Backed out changeset 1a8cf3c83dc4 (bug 1838829)
2023-06-22 03:37:07 +03:00
Kershaw Chang 8ae645cecc Bug 1838829 - Skip failed tests, r=necko-reviewers,extension-reviewers,credential-management-reviewers,devtools-reviewers,dimi,valentin,robwu
Differential Revision: https://phabricator.services.mozilla.com/D181251
2023-06-21 19:43:33 +00:00
Alexandre Poirot f9f9928fef Bug 1833095 - [devtools] Return null from source map loader/worker when no mapping is found. r=devtools-reviewers,bomsy
This helps the callsite in the main thread to distinguish between being mapped
or lack of mappings.
Doing this prevent returning back the exact same location and could spare some cycles.

Differential Revision: https://phabricator.services.mozilla.com/D178389
2023-05-25 21:16:23 +00:00
Hubert Boma Manilla 0ab4d94f23 Bug 1824705 - [devtools] Add support for sourcemaps ignore list r=devtools-reviewers,nchevobbe
Also there is a patch to add support for ignoreList to the sourcemap library
https://github.com/mozilla/source-map/pull/481

Differential Revision: https://phabricator.services.mozilla.com/D174357
2023-05-23 08:16:55 +00:00
Butkovits Atila f21dc3465a Backed out 2 changesets (bug 1824705) for causing failures at browser_misused_characters_in_strings.js. CLOSED TREE
Backed out changeset d67c783fcd63 (bug 1824705)
Backed out changeset d6d2c97f858d (bug 1824705)
2023-05-23 00:40:24 +03:00