Commit Graph
228 Commits
Author SHA1 Message Date
Hubert B Manilla 1b9a5776fa Bug 2043267 - [devtools] Editing stylesheets in the debugger r=devtools-reviewers,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D303071
2026-06-12 07:24:24 +00:00
agoloman f008f80b1e Revert "Bug 2041780, Bug 2043267, Bug 2045710 - [devtools] Pretty printing stylesheets in the debugger r=devtools-reviewers,ochameau" for causing dt failures @browser_dbg-javascript-tracer-sidebar.js.
This reverts commit 1d08a5cd99.

Revert "Bug 2043267 - [devtools] Editing stylesheets in the debugger r=devtools-reviewers,ochameau"

This reverts commit 813e0fadb5.

Revert "Bug 2045710 - [devtools] Fix and add style sheet related test r=devtools-reviewers,ochameau"

This reverts commit 2fc4893d8a.
2026-06-12 06:37:36 +00:00
Hubert B Manilla 813e0fadb5 Bug 2043267 - [devtools] Editing stylesheets in the debugger r=devtools-reviewers,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D303071
2026-06-12 04:49:02 +00:00
Cristian Tuns bf6ae1ed70 Revert "Bug 2043267, Bug 2045710 - [devtools] Editing stylesheets in the debugger r=devtools-reviewers,ochameau" for causing node failures in devtools/client/*
This reverts commit c07fcd7808.

Revert "Bug 2045710 - [devtools] Fix and add style sheet related test r=devtools-reviewers,ochameau" for causing node failures in devtools/client/*

This reverts commit e46af7df05.
2026-06-11 23:27:54 +00:00
Hubert B Manilla c07fcd7808 Bug 2043267 - [devtools] Editing stylesheets in the debugger r=devtools-reviewers,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D303071
2026-06-11 22:57:08 +00:00
Freya Arbjerg ab5588d47c Bug 2036767 - Fix devtools server ignoring blackbox columns; fix client sending wrong columns. r=ochameau,devtools-reviewers
This also fixes a typo in test_blackboxing-08.js, which caused the end column to be undefined.

Differential Revision: https://phabricator.services.mozilla.com/D300173
2026-05-18 08:17:00 +00:00
Emilio Cobos Álvarez e833a1757b Bug 2033243 - Replace ownerGlobal with documentGlobal, and stop exposing ownerGlobal to JS. r=firefox-desktop-core-reviewers ,webidl,joschmidt,perftest-reviewers,sparky,smaug,mossop ,webidl,joschmidt,perftest-reviewers,sparky,smaug,mossop
Bug 2033191 made sure we only call ownerGlobal on nodes.

As per the discussion in dev-platform, the front-end ~always wants
.documentGlobal. This removes ownerGlobal from the bindings. Following
patch will rename internal GetOwnerGlobal in gecko to GetRelevantGlobal
as per the HTML spec terminology.

Differential Revision: https://phabricator.services.mozilla.com/D297183
2026-05-02 22:04:13 +00:00
iulian moraru 480fc572da Revert "Bug 2036439, Bug 2033243 - Deal with ownerGlobal -> documentGlobal rename in extensions. r=robwu,home-newtab-reviewers,mconley" for causing newtab failures.
This reverts commit 4f62279d01.

Revert "Bug 2033243 - Other miscellaneous ownerGlobal-related naming removal. r=dom-core,smaug"

This reverts commit 91a4ece356.

Revert "Bug 2033243 - BindToOwner -> BindToGlobal. r=dom-core,smaug"

This reverts commit 5a95a889e1.

Revert "Bug 2033243 - Rename GetOwnerGlobal to GetRelevantGlobal. r=dom-core,media-playback-reviewers,credential-management-reviewers,webrtc-reviewers,dom-storage-reviewers,firefox-style-system-reviewers,dimi,janv,dshin,aosmond,smaug"

This reverts commit 7177a68e67.

Revert "Bug 2033243 - Replace ownerGlobal with documentGlobal, and stop exposing ownerGlobal to JS. r=firefox-desktop-core-reviewers ,webidl,joschmidt,perftest-reviewers,sparky,smaug,mossop ,webidl,joschmidt,perftest-reviewers,sparky,smaug,mossop"

This reverts commit 5263254690.
2026-05-02 16:43:35 +00:00
Emilio Cobos Álvarez 5263254690 Bug 2033243 - Replace ownerGlobal with documentGlobal, and stop exposing ownerGlobal to JS. r=firefox-desktop-core-reviewers ,webidl,joschmidt,perftest-reviewers,sparky,smaug,mossop ,webidl,joschmidt,perftest-reviewers,sparky,smaug,mossop
Bug 2033191 made sure we only call ownerGlobal on nodes.

As per the discussion in dev-platform, the front-end ~always wants
.documentGlobal. This removes ownerGlobal from the bindings. Following
patch will rename internal GetOwnerGlobal in gecko to GetRelevantGlobal
as per the HTML spec terminology.

Differential Revision: https://phabricator.services.mozilla.com/D297183
2026-05-02 15:33:20 +00:00
rperta d4cc71008d Revert "Bug 2033243 - Other miscellaneous ownerGlobal-related naming removal. r=dom-core,smaug" on developer request
This reverts commit e58e122135.

This reverts commit 84ca206f3e.

This reverts commit a7945292ed.

This reverts commit 367d83d299.
2026-05-02 06:20:30 +00:00
Emilio Cobos Álvarez 367d83d299 Bug 2033243 - Replace ownerGlobal with documentGlobal, and stop exposing ownerGlobal to JS. r=firefox-desktop-core-reviewers ,webidl,joschmidt,perftest-reviewers,sparky,smaug,mossop
Bug 2033191 made sure we only call ownerGlobal on nodes.

As per the discussion in dev-platform, the front-end ~always wants
.documentGlobal. This removes ownerGlobal from the bindings. Following
patch will rename internal GetOwnerGlobal in gecko to GetRelevantGlobal
as per the HTML spec terminology.

Differential Revision: https://phabricator.services.mozilla.com/D297183
2026-05-01 11:58:10 +00:00
agoloman c814da612d Revert "Bug 2033243 - Other miscellaneous ownerGlobal-related naming removal. r=dom-core,smaug" for causing multiple failures.
This reverts commit c7246654bc.

Revert "Bug 2033243 - BindToOwner -> BindToGlobal. r=dom-core,smaug"

This reverts commit 8873ddf33c.

Revert "Bug 2033243 - Rename GetOwnerGlobal to GetRelevantGlobal. r=dom-core,media-playback-reviewers,credential-management-reviewers,webrtc-reviewers,dom-storage-reviewers,firefox-style-system-reviewers,dimi,janv,dshin,aosmond,smaug"

This reverts commit 8bf999e03c.

Revert "Bug 2033243 - Replace ownerGlobal with documentGlobal, and stop exposing ownerGlobal to JS. r=firefox-desktop-core-reviewers ,webidl,joschmidt,perftest-reviewers,sparky,smaug,mossop"

This reverts commit 7dea1af2e0.
2026-04-30 20:13:14 +00:00
Emilio Cobos Álvarez 7dea1af2e0 Bug 2033243 - Replace ownerGlobal with documentGlobal, and stop exposing ownerGlobal to JS. r=firefox-desktop-core-reviewers ,webidl,joschmidt,perftest-reviewers,sparky,smaug,mossop
Bug 2033191 made sure we only call ownerGlobal on nodes.

As per the discussion in dev-platform, the front-end ~always wants
.documentGlobal. This removes ownerGlobal from the bindings. Following
patch will rename internal GetOwnerGlobal in gecko to GetRelevantGlobal
as per the HTML spec terminology.

Differential Revision: https://phabricator.services.mozilla.com/D297183
2026-04-30 17:47:07 +00:00
Hubert Boma Manilla 0e447a0b24 Bug 2026569 - [devtools] Add the extension to support the auto close bracket feature r=devtools-reviewers,nchevobbe
This patch adds the autocomplete package to leverage the closeBrackets extension.
The autocomplete paackage will also be benefical in the future when we want to  migrate
to using the full auto complete feature in codemirror 6.

Differential Revision: https://phabricator.services.mozilla.com/D279497
2026-04-27 06:55:58 +00:00
Hubert Boma Manilla 900b9acd82 Bug 2013481 - [devtools] Make sure we get actual variable definitions r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D291642
2026-04-26 22:06:44 +00:00
Hubert Boma Manilla 85cdd4bf91 Bug 2013481 - [devtools] Update the Autocompletion API's to support CM6 r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D290766
2026-04-26 22:06:38 +00:00
Hubert Boma Manilla 278d30f4e0 Bug 2013481 - [devtools] Add source editor API's to handle operations around the cursor position r=devtools-reviewers,perftest-reviewers,nchevobbe,sparky
Differential Revision: https://phabricator.services.mozilla.com/D290765
2026-04-26 22:06:36 +00:00
pstanciu f7ff215c7e Revert "Bug 2013481 - [devtools] Make sure we get actual variable definitions r=devtools-reviewers,nchevobbe" for causing WPT leak failures
This reverts commit 58d1d10790.

Revert "Bug 2013481 - [devtools] Avoid setting autocomplete text from a transaction filter r=devtools-reviewers,nchevobbe"

This reverts commit e85159f216.

Revert "Bug 2013481 - [devtools] Remove the pref checks for Autocompletion r=devtools-reviewers,nchevobbe"

This reverts commit 8329e7b7b5.

Revert "Bug 2013481 - [devtools] Update the Autocompletion API's to support CM6 r=devtools-reviewers,nchevobbe"

This reverts commit 3ca8e58daf.

Revert "Bug 2013481 - [devtools] Add source editor API's to handle operations around the cursor position r=devtools-reviewers,perftest-reviewers,nchevobbe,sparky"

This reverts commit 856a9a8d13.

Revert "Bug 2013481 - [devtools] Add cursor class for codemirror 6 r=devtools-reviewers,nchevobbe"

This reverts commit ca6c4826d4.
2026-04-26 21:14:39 +00:00
Hubert Boma Manilla 58d1d10790 Bug 2013481 - [devtools] Make sure we get actual variable definitions r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D291642
2026-04-26 17:31:20 +00:00
Hubert Boma Manilla 3ca8e58daf Bug 2013481 - [devtools] Update the Autocompletion API's to support CM6 r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D290766
2026-04-26 17:31:09 +00:00
Hubert Boma Manilla 856a9a8d13 Bug 2013481 - [devtools] Add source editor API's to handle operations around the cursor position r=devtools-reviewers,perftest-reviewers,nchevobbe,sparky
Differential Revision: https://phabricator.services.mozilla.com/D290765
2026-04-26 17:31:05 +00:00
Hubert B Manilla 5b3f4c5da0 Bug 2032758 - [devtools] Do not check mapped CM5 methods for CM6 r=devtools-reviewers,nchevobbe
These mapped CM5 methods should not be called for CM6, but lets add a check to makes sure we do not attempt to lookup on the CM6 codemirror instance.

Differential Revision: https://phabricator.services.mozilla.com/D295187
2026-04-20 11:43:13 +00:00
rperta 1b7dfbabe2 Revert "Bug 2026569 - [devtools] Add the extension to support the auto close bracket feature r=devtools-reviewers,nchevobbe" for causing dt failures at browser_dbg-breakpoints-cond-functional.js
This reverts commit b4bc42dbc5.
2026-03-30 18:11:55 +00:00
Hubert Boma Manilla b4bc42dbc5 Bug 2026569 - [devtools] Add the extension to support the auto close bracket feature r=devtools-reviewers,nchevobbe
This patch adds the autocomplete package to leverage the closeBrackets extension.
The autocomplete paackage will also be benefical in the future when we want to  migrate
to using the full auto complete feature in codemirror 6.

Differential Revision: https://phabricator.services.mozilla.com/D279497
2026-03-30 11:43:43 +00:00
Hubert Boma Manilla 8eba0eb18b Bug 2019905 - [devtools] Toggle the editor gutter based on the editor mode vs inline mode r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D285398
2026-03-26 13:31:02 +00:00
Hubert Boma Manilla 782964ec67 Bug 2014714 - [devtools] Key bindings for CM6 r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D282504
2026-03-20 09:34:16 +00:00
Hubert Boma Manilla 3e06d32077 Bug 2020293 - [devtools] Enable CM6 Source Editor for JSTerm based on the preference r=devtools-reviewers,nchevobbe
Highlights of this patch
- Enables CM6 when the pref is set to true
- Autocompletion features are not working and disabled for CM6 (enabled in subsequent patch)
- No key bindings support for CM6 (support in subsequent patch)

Differential Revision: https://phabricator.services.mozilla.com/D282290
2026-03-20 09:34:14 +00:00
Hubert Boma Manilla 5e7e190f81 Bug 2015281 - [devtools] SourceEditor API to get expression variables r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D282265
2026-03-04 09:11:42 +00:00
Hubert Boma Manilla adda306932 Bug 2015292 - [devtools] Source Editor API to return the width of a character r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D282309
2026-02-13 05:02:35 +00:00
Hubert Boma Manilla 89ad810209 Bug 2015290 - [devtools] SourceEditor API's to toggle the editor gutter r=devtools-reviewers,nchevobbe
JSTerm usage in D282290

Differential Revision: https://phabricator.services.mozilla.com/D282285
2026-02-13 05:02:29 +00:00
Hubert Boma Manilla 8765c15e32 Bug 2015287 - [devtools] SourceEditor API to get the text before the cursor position r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D282281
2026-02-13 05:02:26 +00:00
Alexandre Poirot e5e95f4ef0 Bug 2016171 - [devtools] Unregister automatically all event listeners on PrefObserver destruction. r=devtools-reviewers,bomsy
This helps avoid having to manually register every single one of them on destroy.

Differential Revision: https://phabricator.services.mozilla.com/D282913
2026-02-12 12:22:48 +00:00
Mark Banner b38cd3110b Bug 1999554 - Automatically fix ESLint rule jsdoc/check-types for devtools/. r=devtools-reviewers,devtools-backward-compat-reviewers,profiler-reviewers,canaltinova
Differential Revision: https://phabricator.services.mozilla.com/D272173
2025-11-21 16:16:08 +00:00
Mark Banner 2542790f53 Bug 1998787 - Automatic fixes for enabling ESLint jsdoc/tag-line rule everywhere. r=frontend-codestyle-reviewers,mtigley,perftest-reviewers,nchevobbe,home-newtab-reviewers,Gijs,mconley,sparky
Differential Revision: https://phabricator.services.mozilla.com/D271745
2025-11-10 21:27:12 +00:00
Mark Banner e73114dd2b Bug 1996350 - Automatic fixes for ESLint rule jsdoc/no-multi-asterisks (remainder). r=frontend-codestyle-reviewers,mtigley,mossop
Differential Revision: https://phabricator.services.mozilla.com/D270035
2025-10-29 11:35:08 +00:00
Hubert Boma Manilla 000aa5a98c Bug 1991431 - [devtools] Migrate the HTML Editor to CM6 r=devtools-reviewers,nchevobbe
Highlights of this patch
- Updates the codemirror 6 bundle
- Restructured the `setText` api to have an options object
- Added a new `saveToHistory` option to handle not add to history (when set true), when re setting
  the editor content. This is used to replace `clearHistory` behaviour in cm5.
- uses `config.keyMap` for setting the cm6 key maps
- Stop propagating `keydown` event to avoid the hijack when pressing the backspace key by the markup component
- Small cleanup on the usage of compartments
- Remove the extra `undo` intermediate change needed for cm5

Differential Revision: https://phabricator.services.mozilla.com/D267558
2025-10-28 12:01:54 +00:00
Alexandru Marc 2501d68306 Revert "Bug 1991431 - [devtools] Migrate the HTML Editor to CM6 r=devtools-reviewers,nchevobbe" for causing dt failures @ browser_markup_html_edit_undo-redo.js
This reverts commit 79e1d3c86d.

Revert "Bug 1991431 - [devtools] Update codemirror bundle r=devtools-reviewers,nchevobbe"

This reverts commit 9552db23d1.

Revert "Bug 1991431 - [devtools] Update browser_markup_html_edit_undo-redo.js to properly test the Html Editor undo redo behaviour r=devtools-reviewers,nchevobbe"

This reverts commit f1bcc97077.
2025-10-27 17:11:08 +00:00
Hubert Boma Manilla 79e1d3c86d Bug 1991431 - [devtools] Migrate the HTML Editor to CM6 r=devtools-reviewers,nchevobbe
Highlights of this patch
- Updates the codemirror 6 bundle
- Restructured the `setText` api to have an options object
- Added a new `saveToHistory` option to handle not add to history (when set true), when re setting
  the editor content. This is used to replace `clearHistory` behaviour in cm5.
- uses `config.keyMap` for setting the cm6 key maps
- Stop propagating `keydown` event to avoid the hijack when pressing the backspace key by the markup component
- Small cleanup on the usage of compartments
- Remove the extra `undo` intermediate change needed for cm5

Differential Revision: https://phabricator.services.mozilla.com/D267558
2025-10-27 12:49:47 +00:00
Alexandru Marc 497e1cb0b0 Revert "Bug 1991431 - [devtools] Migrate the HTML Editor to CM6 r=devtools-reviewers,nchevobbe" for causing dt failures @ browser_markup_html_edit_undo-redo.js
This reverts commit 329755a4ba.

Revert "Bug 1991431 - [devtools] Update codemirror bundle r=devtools-reviewers,nchevobbe"

This reverts commit 31aebb3a4d.

Revert "Bug 1991431 - [devtools] Update browser_markup_html_edit_undo-redo.js to properly test the Html Editor undo redo behaviour r=devtools-reviewers,nchevobbe"

This reverts commit df4f346c04.
2025-10-27 10:46:44 +00:00
Hubert Boma Manilla 329755a4ba Bug 1991431 - [devtools] Migrate the HTML Editor to CM6 r=devtools-reviewers,nchevobbe
Highlights of this patch
- Updates the codemirror 6 bundle
- Restructured the `setText` api to have an options object
- Added a new `saveToHistory` option to handle not add to history (when set true), when re setting
  the editor content. This is used to replace `clearHistory` behaviour in cm5.
- uses `config.keyMap` for setting the cm6 key maps
- Stop propagating `keydown` event to avoid the hijack when pressing the backspace key by the markup component
- Small cleanup on the usage of compartments
- Remove the extra `undo` intermediate change needed for cm5

Differential Revision: https://phabricator.services.mozilla.com/D267558
2025-10-27 09:03:23 +00:00
Hubert Boma Manilla 664775850c Bug 1988710 - [devtools] Should scroll by default when setting the cursor r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D267381
2025-10-06 12:57:49 +00:00
Hubert Boma Manilla 7eed621ff2 Bug 1988710 - [devtools] Cleanup setCursorAt for just CM6 r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D267380
2025-10-06 12:57:45 +00:00
Hubert Boma Manilla fb186490a6 Bug 1979902 - [devtools] Enable codemirror 6 default search for the source preview r=devtools-reviewers,nchevobbe
To test, check the codemirror view in the Netmonitor's response panel

Differential Revision: https://phabricator.services.mozilla.com/D259086
2025-10-01 18:51:32 +00:00
Alexandru Marc 04a772b041 Revert (Bug 1979902, Bug 1978284) for causing dt failures @ webconsole/index.html
This reverts commit 6d6b71f2b6.

Revert "Bug 1978284 - [devtools] Migrate Source preview to Cm6 r=devtools-reviewers,nchevobbe,perftest-reviewers,tschuster,afinder"

This reverts commit e835bebd76.
2025-09-30 18:25:31 +00:00
Hubert Boma Manilla 6d6b71f2b6 Bug 1979902 - [devtools] Enable codemirror 6 default search for the source preview r=devtools-reviewers,nchevobbe
To test, check the codemirror view in the Netmonitor's response panel

Differential Revision: https://phabricator.services.mozilla.com/D259086
2025-09-30 15:21:03 +00:00
Alexandre Poirot c0a08e0182 Bug 1908889 - [devtools] Implement an inlined trace panel. r=devtools-reviewers,nchevobbe
This panel allows to easily jump between each call of the currently selected function.

Differential Revision: https://phabricator.services.mozilla.com/D208324
2025-09-24 10:04:49 +00:00
Hubert Boma Manilla dac43a3b86 Bug 1978284 - [devtools] Move the marker types to the source editor r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D265092
2025-09-23 08:44:22 +00:00
Hubert Boma Manilla 0eec3a8c60 Bug 1978284 - [devtools] Add language support for styling and markup content r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D258553
2025-09-23 08:44:19 +00:00
Sandor Molnar 0c6a4f627a Revert "Bug 1978284 - [devtools] Add language support for styling and markup content r=devtools-reviewers,nchevobbe" for causing dt failures @ browser_dbg-editor-scroll.js
This reverts commit 2c5508429f.
2025-09-01 19:24:31 +00:00
Hubert Boma Manilla 2c5508429f Bug 1978284 - [devtools] Add language support for styling and markup content r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D258553
2025-09-01 13:44:02 +00:00