Commit Graph
636 Commits
Author SHA1 Message Date
Nicolas Chevobbe 62dc0bee6a Bug 2044406 - [devtools] Add space between XHR and request method in Console Network Messages. r=devtools-reviewers,jdescottes.
The .status element is turned into a simple <span> (instead of a <a>),
so it's 1. more semantically correct, and 2. doesn't create a new line.

We also handle null request `totalTime` by not showing the time in the status info,
as that could make the test to fail in chaos mode.

Differential Revision: https://phabricator.services.mozilla.com/D304391
2026-06-03 13:44:22 +00:00
Hubert Boma Manilla 96c349f580 Bug 2013481 - [devtools] Avoid setting autocomplete text from a transaction filter r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D291643
2026-04-26 22:06:42 +00:00
Hubert Boma Manilla 5f146374f4 Bug 2013481 - [devtools] Remove the pref checks for Autocompletion r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D290768
2026-04-26 22:06:40 +00:00
Hubert Boma Manilla 85cdd4bf91 Bug 2013481 - [devtools] Update the Autocompletion API's to support CM6 r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D290766
2026-04-26 22:06:38 +00:00
Hubert Boma Manilla 278d30f4e0 Bug 2013481 - [devtools] Add source editor API's to handle operations around the cursor position r=devtools-reviewers,perftest-reviewers,nchevobbe,sparky
Differential Revision: https://phabricator.services.mozilla.com/D290765
2026-04-26 22:06:36 +00:00
pstanciu f7ff215c7e Revert "Bug 2013481 - [devtools] Make sure we get actual variable definitions r=devtools-reviewers,nchevobbe" for causing WPT leak failures
This reverts commit 58d1d10790.

Revert "Bug 2013481 - [devtools] Avoid setting autocomplete text from a transaction filter r=devtools-reviewers,nchevobbe"

This reverts commit e85159f216.

Revert "Bug 2013481 - [devtools] Remove the pref checks for Autocompletion r=devtools-reviewers,nchevobbe"

This reverts commit 8329e7b7b5.

Revert "Bug 2013481 - [devtools] Update the Autocompletion API's to support CM6 r=devtools-reviewers,nchevobbe"

This reverts commit 3ca8e58daf.

Revert "Bug 2013481 - [devtools] Add source editor API's to handle operations around the cursor position r=devtools-reviewers,perftest-reviewers,nchevobbe,sparky"

This reverts commit 856a9a8d13.

Revert "Bug 2013481 - [devtools] Add cursor class for codemirror 6 r=devtools-reviewers,nchevobbe"

This reverts commit ca6c4826d4.
2026-04-26 21:14:39 +00:00
Hubert Boma Manilla e85159f216 Bug 2013481 - [devtools] Avoid setting autocomplete text from a transaction filter r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D291643
2026-04-26 17:31:16 +00:00
Hubert Boma Manilla 8329e7b7b5 Bug 2013481 - [devtools] Remove the pref checks for Autocompletion r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D290768
2026-04-26 17:31:13 +00:00
Hubert Boma Manilla 3ca8e58daf Bug 2013481 - [devtools] Update the Autocompletion API's to support CM6 r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D290766
2026-04-26 17:31:09 +00:00
Hubert Boma Manilla 856a9a8d13 Bug 2013481 - [devtools] Add source editor API's to handle operations around the cursor position r=devtools-reviewers,perftest-reviewers,nchevobbe,sparky
Differential Revision: https://phabricator.services.mozilla.com/D290765
2026-04-26 17:31:05 +00:00
Julian Descottes 02c359a70d Bug 2028930 - [devtools] Avoid toolbox crashes due to missing localization file r=nchevobbe,devtools-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D293945
2026-04-16 12:00:23 +00:00
Alexandra Borovova 574778d7e5 Bug 2005054 - [devtools] Extract "formatMessageParametersAndText" into a shared module to make it easier to reuse in WebDriver BiDi. r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D289754
2026-03-31 09:40:31 +00:00
Sylvestre Ledru 074b376055 Bug 2023419 - Remove Emacs/Vim modelines from devtools/ r=emilio,devtools-backward-compat-reviewers,devtools-reviewers,nchevobbe
replaced by .editorconfig
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D287841
2026-03-28 10:21:10 +00:00
Julian Descottes 9248164902 Bug 2026755 - [devtools] Bail out of JSTerm editor changes callback if already destroyed r=devtools-reviewers,nchevobbe
An event / changes handler is async and JSTerm might be destroyed midflight, leading to window leaks in tests.

Differential Revision: https://phabricator.services.mozilla.com/D290292
2026-03-27 07:42:30 +00:00
Hubert Boma Manilla 8eba0eb18b Bug 2019905 - [devtools] Toggle the editor gutter based on the editor mode vs inline mode r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D285398
2026-03-26 13:31:02 +00:00
Hubert Boma Manilla 782964ec67 Bug 2014714 - [devtools] Key bindings for CM6 r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D282504
2026-03-20 09:34:16 +00:00
Hubert Boma Manilla 3e06d32077 Bug 2020293 - [devtools] Enable CM6 Source Editor for JSTerm based on the preference r=devtools-reviewers,nchevobbe
Highlights of this patch
- Enables CM6 when the pref is set to true
- Autocompletion features are not working and disabled for CM6 (enabled in subsequent patch)
- No key bindings support for CM6 (support in subsequent patch)

Differential Revision: https://phabricator.services.mozilla.com/D282290
2026-03-20 09:34:14 +00:00
Alexandru Marc 630e6cf0e8 Revert "Bug 2023419 - Remove Emacs/Vim modelines from devtools/ r=emilio,devtools-backward-compat-reviewers,devtools-reviewers,nchevobbe" for causing devtools failures
This reverts commit ed535dace9.
2026-03-17 12:46:01 +00:00
Sylvestre Ledru ed535dace9 Bug 2023419 - Remove Emacs/Vim modelines from devtools/ r=emilio,devtools-backward-compat-reviewers,devtools-reviewers,nchevobbe
replaced by .editorconfig

Differential Revision: https://phabricator.services.mozilla.com/D287841
2026-03-17 12:03:34 +00:00
Hubert B Manilla 21260f873f Bug 2022166 - [devtools] Move shared debugger icons to a shared folder r=devtools-reviewers,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D286898
2026-03-16 09:50:00 +00:00
Alexandru Marc 73d1dc9c20 Revert "Bug 2022166 - [devtools] Move shared debugger icons to a shared folder r=devtools-reviewers,ochameau" for causing devtools failures @ nsNetUtil
This reverts commit 811ab0573b.
2026-03-12 23:38:02 +00:00
Hubert B Manilla 811ab0573b Bug 2022166 - [devtools] Move shared debugger icons to a shared folder r=devtools-reviewers,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D286898
2026-03-12 22:07:11 +00:00
Hubert Boma Manilla 655485ea0b Bug 2020293 - [devtools] Use source editor specific apis for text selection r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D286302
2026-03-10 06:17:44 +00:00
Serban Stanca f233b49863 Revert "Bug 2020293 - [devtools] Use source editor specific apis for text selection r=devtools-reviewers,nchevobbe" for causing devtools failures in browser_webconsole_network_attach.js.
This reverts commit b7b29c832e.
2026-03-10 02:04:41 +00:00
Hubert Boma Manilla b7b29c832e Bug 2020293 - [devtools] Use source editor specific apis for text selection r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D286302
2026-03-09 20:57:04 +00:00
rperta c879ab87d9 Revert "Bug 2020293 - [devtools] Use source editor specific apis for text selection r=devtools-reviewers,nchevobbe" for causing devtools related failures.
This reverts commit fdac847f97.
2026-03-09 11:27:22 +00:00
Hubert Boma Manilla fdac847f97 Bug 2020293 - [devtools] Use source editor specific apis for text selection r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D286302
2026-03-09 09:53:33 +00:00
Hubert Boma Manilla 5e7e190f81 Bug 2015281 - [devtools] SourceEditor API to get expression variables r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D282265
2026-03-04 09:11:42 +00:00
Julian Descottes 75d403291c Bug 2017628 - [devtools] lint: update react/sort-comp rule to expect instance variables before constructor r=frontend-codestyle-reviewers,devtools-reviewers,profiler-reviewers,nchevobbe,mossop
Differential Revision: https://phabricator.services.mozilla.com/D283883
2026-02-19 13:44:07 +00:00
Hubert Boma Manilla adda306932 Bug 2015292 - [devtools] Source Editor API to return the width of a character r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D282309
2026-02-13 05:02:35 +00:00
Hubert Boma Manilla 89bae90fc0 Bug 2014715 - [devtools] Fix the styles for CM6 source editor r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D282289
2026-02-13 05:02:32 +00:00
Hubert Boma Manilla 8765c15e32 Bug 2015287 - [devtools] SourceEditor API to get the text before the cursor position r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D282281
2026-02-13 05:02:26 +00:00
Alexandre Poirot 1bab0e4ff3 Bug 2013935 - [devtools] Show exception message and stack when failing to render a console message. r=devtools-reviewers,nchevobbe
Also ensure logging an error to the console.

Differential Revision: https://phabricator.services.mozilla.com/D281501
2026-02-09 09:31:14 +00:00
Mark Banner 88ea51175c Bug 2004680 - Automatically fix issues raised by jsdoc/check-tag-names. r=frontend-codestyle-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D275753
2025-12-22 12:41:23 +00:00
Andrea Marchesini 23f4d7c658 Bug 1986320 - Implement an add-on block URL-Classifier feature - part 3 - devtool support, r=devtools-reviewers,dimi,devtools-backward-compat-reviewers,bomsy
Differential Revision: https://phabricator.services.mozilla.com/D263364
2025-12-04 01:26:51 +00:00
Cristian Tuns c99c271730 Revert "Bug 1986320: apply code formatting via Lando" for causing lint failures in browser_ext_urlclassifier.js
This reverts commit 8c2c577a03.

Revert "Bug 1986320 - Implement an add-on block URL-Classifier feature - part 6 - Mobile r=geckoview-reviewers,android-reviewers,geckoview-api-reviewers,tcampbell,ohall"

This reverts commit 7b0c7db7c3.

Revert "Bug 1986320 - Implement an add-on block URL-Classifier feature - part 5 - Block top-level documents when loaded by add-ons, r=extension-reviewers,dimi,fluent-reviewers,robwu,bolsson,android-reviewers,android-l10n-reviewers,delphine,tcampbell"

This reverts commit 9a058ba0d5.

Revert "Bug 1986320 - Implement an add-on block URL-Classifier feature - part 4 - Expose the URLClassifier addon feature to non-recommended addons only, r=zombie"

This reverts commit 41e8a464d9.

Revert "Bug 1986320 - Implement an add-on block URL-Classifier feature - part 3 - devtool support, r=devtools-reviewers,dimi,devtools-backward-compat-reviewers,bomsy"

This reverts commit c0f866931b.

Revert "Bug 1986320 - Implement an add-on block URL-Classifier feature - part 2 - telemetry, r=dimi,extension-reviewers,robwu"

This reverts commit 1bdba2f426.

Revert "Bug 1986320 - Implement an add-on block URL-Classifier feature - part 1, r=dimi,geckoview-reviewers,extension-reviewers,tcampbell,robwu"

This reverts commit f1a3613f44.
2025-12-03 19:15:17 +00:00
Andrea Marchesini c0f866931b Bug 1986320 - Implement an add-on block URL-Classifier feature - part 3 - devtool support, r=devtools-reviewers,dimi,devtools-backward-compat-reviewers,bomsy
Differential Revision: https://phabricator.services.mozilla.com/D263364
2025-12-03 18:47:30 +00:00
iulian moraru a5862a7e70 Revert "Bug 1999177 - Support cursor scroll in the composable toolbar r=android-reviewers,moyin" for causing linting failures on browser_ext_urlclassifier.js.
This reverts commit ae35529fab.

Revert "Bug 1986320: apply code formatting via Lando"

This reverts commit 768f3614ff.

Revert "Bug 1986320 - Implement an add-on block URL-Classifier feature - part 5 - Block top-level documents when loaded by add-ons, r=extension-reviewers,dimi,fluent-reviewers,robwu,bolsson,android-reviewers,android-l10n-reviewers,delphine,tcampbell"

This reverts commit 5f2e690d2b.

Revert "Bug 1986320 - Implement an add-on block URL-Classifier feature - part 4 - Expose the URLClassifier addon feature to non-recommended addons only, r=zombie"

This reverts commit 1e7b1753d4.

Revert "Bug 1986320 - Implement an add-on block URL-Classifier feature - part 3 - devtool support, r=devtools-reviewers,dimi,devtools-backward-compat-reviewers,bomsy"

This reverts commit 928a253e9e.

Revert "Bug 1986320 - Implement an add-on block URL-Classifier feature - part 2 - telemetry, r=dimi,extension-reviewers,robwu"

This reverts commit 2a13eb6ec3.

Revert "Bug 1986320 - Implement an add-on block URL-Classifier feature - part 1, r=dimi,geckoview-reviewers,extension-reviewers,tcampbell,robwu"

This reverts commit 1ef88130d9.
2025-12-03 10:26:32 +00:00
Andrea Marchesini 928a253e9e Bug 1986320 - Implement an add-on block URL-Classifier feature - part 3 - devtool support, r=devtools-reviewers,dimi,devtools-backward-compat-reviewers,bomsy
Differential Revision: https://phabricator.services.mozilla.com/D263364
2025-12-03 09:47:52 +00:00
Mark Banner b38cd3110b Bug 1999554 - Automatically fix ESLint rule jsdoc/check-types for devtools/. r=devtools-reviewers,devtools-backward-compat-reviewers,profiler-reviewers,canaltinova
Differential Revision: https://phabricator.services.mozilla.com/D272173
2025-11-21 16:16:08 +00:00
Mark Banner 2542790f53 Bug 1998787 - Automatic fixes for enabling ESLint jsdoc/tag-line rule everywhere. r=frontend-codestyle-reviewers,mtigley,perftest-reviewers,nchevobbe,home-newtab-reviewers,Gijs,mconley,sparky
Differential Revision: https://phabricator.services.mozilla.com/D271745
2025-11-10 21:27:12 +00:00
Alexandre Poirot 58266a6f66 Bug 1991420 - [devtools] Properly unregister listeners on console closing. r=devtools-reviewers,nchevobbe
The blur listener wasn't removed and would still be fired on toolbox closing.
But now the action throws and pollutes tests output.

Differential Revision: https://phabricator.services.mozilla.com/D267561
2025-10-06 10:21:42 +00:00
Artem Manushenkov 31b290a8cb Bug 1984993 - add hotkey hint to clear webconsole button r=devtools-reviewers,ochameau,flod
This introduces a shared helper to convert electron accelerator strings into pretty strings with unicode symbols for modifier keys on macos

Differential Revision: https://phabricator.services.mozilla.com/D262341
2025-09-15 11:04:59 +00:00
Nicolas Chevobbe 9afd55e6c3 Bug 1982823 - [devtools] Remove unnecessary display flex on buttons. r=devtools-reviewers,bomsy.
Bug 1873301 introduced some alignment regression which we worked around quickly (Bug 1977545, Bug 1977647),
but the regression was fixed in Bug 1977669, so the workaround aren't needed anymore.

Differential Revision: https://phabricator.services.mozilla.com/D260971
2025-08-18 10:14:01 +00:00
Nicolas Chevobbe f70676c645 Bug 1615206 - [devtools] Make the "Group similar message" setting control repeating messages. r=devtools-reviewers,ochameau
The existing setting was added to control grouping similar warning messages.
Due to the wording of the setting, users were also thinking it could control
repeated messages (the small badge/bubble we put next to messages when successibe
messages have the same text).
This patch renames the warning group pref into something that can drive both of
these, and we make the repeat mechanism check the value of the pref befor repeating.

Note that for repeated message, unlike warning groups, this doesn't "ungroup"
the messages, but that should be fine like this.

A node test case is added, as well as a mochitest (event though the test was already
checking repeated messages in a specific context, it's still nice to have
some basic actual coverage)

Differential Revision: https://phabricator.services.mozilla.com/D257841
2025-07-22 08:55:54 +00:00
Nicolas Chevobbe 9606525bfb Bug 1977545 - [devtools] Align context selector button text and its icon. r=devtools-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D257465
2025-07-16 09:11:15 +00:00
Julian Descottes 077d55e8aa Bug 1976336 - [devtools] Center the search icon for Console reverse history search input r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D256529
2025-07-09 06:39:45 +00:00
Serah Nderi 4bd88f6d90 Bug 1602351 - Allow to print the stacktrace in logpoint; r=nchevobbe,devtools-reviewers,devtools-backward-compat-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D243803
2025-06-12 12:19:02 +00:00
Hubert Boma Manilla f0190d869c Bug 1966005 - [devtools] Make sure to try auto-scroll after the completion of the sourcemap service r=devtools-reviewers,nchevobbe
Issue: After the sourcemap service has completed it should trigger and update which would cause `maybeScrollToBottomMessageCallback` ( which handles the auto scrolling)
to fire. But the `shouldScrollBottom` was failing, as it does not considrer the delayed updates which happen after the sourcemap service is done.

Differential Revision: https://phabricator.services.mozilla.com/D249904
2025-06-11 07:06:26 +00:00
Atila Butkovits a372b777d2 Revert "Bug 1557795 - [devtools] Cleanup and unify network event types r=devtools-reviewers,jdescottes" for causing dt failures.
This reverts commit fcd3970805.

Revert "Bug 1966005 - [devtools] Make sure to try auto-scroll after the completion of the sourcemap service r=devtools-reviewers,nchevobbe"

This reverts commit d6fc5d489d.

Revert "Bug 1959452 - [devtools] Throttle parent process events on the server side r=devtools-reviewers,jdescottes,ochameau"

This reverts commit b96015ae28.
2025-06-09 14:18:49 +00:00