Commit Graph
59 Commits
Author SHA1 Message Date
Hubert B Manilla 21260f873f Bug 2022166 - [devtools] Move shared debugger icons to a shared folder r=devtools-reviewers,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D286898
2026-03-16 09:50:00 +00:00
Alexandru Marc 73d1dc9c20 Revert "Bug 2022166 - [devtools] Move shared debugger icons to a shared folder r=devtools-reviewers,ochameau" for causing devtools failures @ nsNetUtil
This reverts commit 811ab0573b.
2026-03-12 23:38:02 +00:00
Hubert B Manilla 811ab0573b Bug 2022166 - [devtools] Move shared debugger icons to a shared folder r=devtools-reviewers,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D286898
2026-03-12 22:07:11 +00:00
Hubert Boma Manilla 89bae90fc0 Bug 2014715 - [devtools] Fix the styles for CM6 source editor r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D282289
2026-02-13 05:02:32 +00:00
hannajones ebb4af9656 Bug 1606785 - Format devtools CSS files with Prettier r=devtools-reviewers,nchevobbe,frontend-codestyle-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D249174
2025-05-28 02:08:02 +00:00
agoloman 63c83deb26 Revert "Bug 1606785 - Enable Prettier for CSS files r=desktop-theme-reviewers,Standard8,frontend-codestyle-reviewers,emilio" for causing multiple failures.
This reverts commit ec5fa1d4c0.

Revert "Bug 1606785 - Format Firefox CSS files with Prettier r=desktop-theme-reviewers,perftest-reviewers,places-reviewers,translations-reviewers,omc-reviewers,backup-reviewers,browser-installer-reviewers,sparky,dao,pdahiya,nrishel,kpatenio"

This reverts commit baa5d72bbd.

Revert "Bug 1606785 - Format browser/themes and toolkit/themes CSS files with Prettier r=desktop-theme-reviewers,pip-reviewers,tabbrowser-reviewers,places-reviewers,dao,mconley"

This reverts commit 9604b0a8ae.

Revert "Bug 1606785 - Format browser/themes/preferences CSS files with Prettier r=settings-reviewers,desktop-theme-reviewers,dao,mconley"

This reverts commit 686c1cf85f.

Revert "Bug 1606785 - Format urlbar CSS files with Prettier r=urlbar-reviewers,desktop-theme-reviewers,dao"

This reverts commit a7a4f31251.

Revert "Bug 1606785 - Format webcompat CSS files with Prettier r=webcompat-reviewers,denschub"

This reverts commit 41bc4d5237.

Revert "Bug 1606785 - Format search CSS files with Prettier r=search-reviewers,jteow"

This reverts commit 7bb7f82374.

Revert "Bug 1606785 - Format dom CSS files with Prettier r=emilio"

This reverts commit c22e910235.

Revert "Bug 1606785 - Format android CSS files with Prettier r=geckoview-reviewers,hiro"

This reverts commit c08e43fc3d.

Revert "Bug 1606785 - Format layout CSS files with Prettier r=layout-reviewers,dholbert"

This reverts commit 4f2a32d1a4.

Revert "Bug 1606785 - Format devtools CSS files with Prettier r=devtools-reviewers,nchevobbe,frontend-codestyle-reviewers"

This reverts commit c05f675ddf.

Revert "Bug 1606785 - Format recomp CSS files with Prettier r=reusable-components-reviewers,desktop-theme-reviewers,dao,mkennedy"

This reverts commit b10c7de8d0.

Revert "Bug 1606785 - Format sidebar CSS files with Prettier r=sidebar-reviewers,desktop-theme-reviewers,dao,nsharpley"

This reverts commit d32c555e37.

Revert "Bug 1606785 - Format shopping CSS files with Prettier r=shopping-reviewers,desktop-theme-reviewers,dao,rking"

This reverts commit 965887a708.

Revert "Bug 1606785 - Format profiles CSS files with Prettier r=profiles-reviewers,desktop-theme-reviewers,dao,mossop"

This reverts commit 8338860f74.

Revert "Bug 1606785 - Format genai and ml CSS files with Prettier r=firefox-ai-ml-reviewers,Mardak"

This reverts commit d66681f553.

Revert "Bug 1606785 - Format firefoxview CSS files with Prettier r=fxview-reviewers,desktop-theme-reviewers,dao,jsudiaman"

This reverts commit 530b815cad.

Revert "Bug 1606785 - Format aboutlogins, megalist, and form autofill CSS files with Prettier r=credential-management-reviewers,mtigley,desktop-theme-reviewers,dao"

This reverts commit 813c864381.
2025-05-21 04:49:28 +00:00
hannajones c05f675ddf Bug 1606785 - Format devtools CSS files with Prettier r=devtools-reviewers,nchevobbe,frontend-codestyle-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D249174
2025-05-21 03:54:40 +00:00
Nicolas Chevobbe f68f27d35a Bug 1916341 - [devtools] Make Console Editor pretty print icon visible in High Contrast Mode. r=devtools-reviewers,ochameau,accessibility-frontend-reviewers,nlapre.
The button was still using mask-image to properly style the icon, but the svg
does have a context-fill property, so we can use `fill` directly, which is what
the debugger and style editor are already doing.

With that fixed, it seems reasonable define a specific color for `--theme-icon-color`
in High Contrast Mode, as it does fix the original bug issue, and will probably
cover a lot of the other issues regarding icon colors in High Contrast Mode.

Differential Revision: https://phabricator.services.mozilla.com/D221982
2024-09-20 12:58:07 +00:00
Emilio Cobos Álvarez a898423415 Bug 1902896 - Remove unnecessary fallback font family. r=devtools-reviewers,nchevobbe
system-ui should be enough. It's also equivalent to -apple-system on
macOS right now.

Differential Revision: https://phabricator.services.mozilla.com/D213881
2024-06-17 10:50:34 +00:00
Hubert Boma Manilla aae1a14a42 Bug 1858076 - [devtools] Show notification in the console when original variable mapping is disabled r=devtools-reviewers,nchevobbe
This patch displays a notification in the console when the debugger is paused
in an original file with original variable mapping is turned off.

The notification is displayed when console input is focused, also if the user selects
a generated file, or is no longer paused or switches on varaible mapping, the notification is removed
once the console input is refocused.

Also added support for specific notifications to control displaying the close button.

Differential Revision: https://phabricator.services.mozilla.com/D191568
2023-11-14 07:35:49 +00:00
Sandor Molnar bcd249053b Backed out 4 changesets (bug 1858652, bug 1858032, bug 1858076, bug 1856270) for causing talos damp failures
Backed out changeset 569b6a151d3e (bug 1858076)
Backed out changeset 3c66fbe494de (bug 1858652)
Backed out changeset 966ce8c9e339 (bug 1858032)
Backed out changeset 3e08029e8f01 (bug 1856270)
2023-11-08 07:21:25 +02:00
Hubert Boma Manilla 513736cd5d Bug 1858076 - [devtools] Show notification in the console when original variable mapping is disabled r=devtools-reviewers,nchevobbe
This patch displays a notification in the console when the debugger is paused
in an original file with original variable mapping is turned off.

The notification is displayed when console input is focused, also if the user selects
a generated file, or is no longer paused or switches on varaible mapping, the notification is removed
once the console input is refocused.

Also added support for specific notifications to control displaying the close button.

Differential Revision: https://phabricator.services.mozilla.com/D191568
2023-11-07 19:51:31 +00:00
Iulian Moraru e0636fa387 Backed out 4 changesets (bug 1856270, bug 1858652, bug 1858032, bug 1858076) for causing dt failures on browser_dbg-reducer-cleanup-on-target-removal.js. CLOSED TREE
Backed out changeset 492052d366fe (bug 1858076)
Backed out changeset a5a765a10588 (bug 1858652)
Backed out changeset 7797ecc20515 (bug 1858032)
Backed out changeset b8a3c66f7fdc (bug 1856270)
2023-11-06 17:54:12 +02:00
Hubert Boma Manilla a52a4207b0 Bug 1858076 - [devtools] Show notification in the console when original variable mapping is disabled r=devtools-reviewers,nchevobbe
This patch displays a notification in the console when the debugger is paused
in an original file with original variable mapping is turned off.

The notification is displayed when console input is focused, also if the user selects
a generated file, or is no longer paused or switches on varaible mapping, the notification is removed
once the console input is refocused.

Also added support for specific notifications to control displaying the close button.

Differential Revision: https://phabricator.services.mozilla.com/D191568
2023-11-06 14:00:53 +00:00
Nicolas Chevobbe 27a299dc67 Bug 1855200 - [devtools] Fix and harmonize focus indicator across the toolbox. r=devtools-reviewers,ochameau.
The new focus indicator is bigger and has a better contrast, making it more accessible
than the thin dotted line we had previously.
It also includes a white box-shadow so even on our blue "active/selected" backgrounds,
the indicator is still visible (e.g. in the markup view, for a selected node, with
focus on badges / text inputs).

Finally, I tried to go over the elements of the shared components and most used
panels to adjust the outline offset when it was not visible/clipped, or when
it could be conflated with the focused element border/background.

Differential Revision: https://phabricator.services.mozilla.com/D192185
2023-11-03 10:05:53 +00:00
Zachary Svoboda 824d105a3d Bug 1673582 - Introduce theme-link-color for better contrast on devtools links r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D187863
2023-09-19 07:00:47 +00:00
Nicolas Chevobbe a8fb4b6283 Bug 1814855 - [devtools] Better message layout on narrow console output. r=bomsy.
First, we set the max-width of the message location in percentage
instead of vw, as the console output inline-size can be different
than the viewport one (e.g. when it is in editor mode).
We then turn the media query we had to hide the timestamp into a
container query, again, to take into account editor mode.
Finally, we place the location on its own row when the output is
narrow so the message text itself can still be readable.

Differential Revision: https://phabricator.services.mozilla.com/D168778
2023-02-06 07:48:04 +00:00
Nicolas Chevobbe 5c69992d9a Bug 1776853 - [devtools] Show ChromeDebugToolbar in Browser Console. r=ochameau.
We need to load the toolbox.ftl bundle and wrap the WebConsole App in a LocalizationProvider
when we're in the Browser Console.

Differential Revision: https://phabricator.services.mozilla.com/D150576
2022-08-01 09:33:18 +00:00
Bogdan Szekely 69bbe7a93b Backed out 5 changesets (bug 1777253, bug 1776853) for causing devtools failures on browser_console_modes.js CLOSED TREE
Backed out changeset dbd68a657d6f (bug 1777253)
Backed out changeset f401150fb142 (bug 1776853)
Backed out changeset 209aade12fc6 (bug 1776853)
Backed out changeset dc24308ff8ef (bug 1776853)
Backed out changeset ea98ed858bae (bug 1776853)
2022-08-01 10:43:40 +03:00
Nicolas Chevobbe 74022f1fe6 Bug 1776853 - [devtools] Show ChromeDebugToolbar in Browser Console. r=ochameau.
We need to load the toolbox.ftl bundle and wrap the WebConsole App in a LocalizationProvider
when we're in the Browser Console.

Differential Revision: https://phabricator.services.mozilla.com/D150576
2022-08-01 06:55:55 +00:00
Nicolas Chevobbe 485dc1a3bc Bug 1777249 - [devtools] Create CSS variable for alternate element background instead of abusing --theme-selection-background-hover. r=bomsy.
In a few places we were using the variable to have a different background than
the ones we have everywhere (blueish on light theme, dark-grey blue in dark mode).
In order to avoid any confusion, this patch adds a dedicated variable with a name
that should be more explicit.

Differential Revision: https://phabricator.services.mozilla.com/D150574
2022-07-21 05:36:40 +00:00
Cristian Tuns 3af62db16b Backed out 3 changesets (bug 1780156, bug 1777249) for causing mochitest on failures browser_console_evaluation_context_selector.js CLOSED TREE
Backed out changeset 6040e53370dc (bug 1777249)
Backed out changeset 61c455e77edc (bug 1780156)
Backed out changeset 2acbfa79b63e (bug 1780156)
2022-07-19 13:35:45 -04:00
Nicolas Chevobbe dd10600b7b Bug 1777249 - [devtools] Create CSS variable for alternate element background instead of abusing --theme-selection-background-hover. r=bomsy.
In a few places we were using the variable to have a different background than
the ones we have everywhere (blueish on light theme, dark-grey blue in dark mode).
In order to avoid any confusion, this patch adds a dedicated variable with a name
that should be more explicit.

Differential Revision: https://phabricator.services.mozilla.com/D150574
2022-07-19 14:02:59 +00:00
Kartik Gautam 98f23747dc Bug 1679452 - Replace :not(X):not(Y) with :not(X, Y) r=ntim
Differential Revision: https://phabricator.services.mozilla.com/D100147
2020-12-19 11:24:13 +00:00
Itiel 69c2c94b06 Bug 1681554 - Fix the Console's multi-line editor Search History borders when focused r=nchevobbe
Also fix the border radius for RTL on macOS

Differential Revision: https://phabricator.services.mozilla.com/D99269
2020-12-11 13:16:27 +00:00
Ping Chen 5b0f6f95f5 Bug 1577900: Add a prettyPrint button to the multiline editor of devtools. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D95457
2020-11-17 07:38:54 +00:00
Itiel 9cb8cfe999 Bug 1641066 - Force LTR the console sidebar contents r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D76938
2020-05-27 13:18:04 +00:00
Nicolas Chevobbe aa1d19088f Bug 1622820 - Fix evaluation context selector button UI. r=jlast.
The button was stretching vertically as the console input grew,
which looked weird.
This is fixed by aligning the item of the container differently
and adjusting padding and margins in order to properly aligh
the context selector and the editor switch button.
We take this as an opportunity to set a max width on the button,
since it could be quite large if the context name is long.

Differential Revision: https://phabricator.services.mozilla.com/D67860
2020-03-23 15:36:30 +00:00
Nicolas Chevobbe d2433fe9bc Bug 1620255 - Change context selector button color when non-top context is selected. r=jlast.
This patch changes the color of the evaluation context selector button
when another context than Top is selected.
This hopefully will help the user to see they're in a different context
than the regular one, which can be helpful since the context can be
changed by actions in the toolbox, and not only from the user explicitely
selecting another context.

Differential Revision: https://phabricator.services.mozilla.com/D65963
2020-03-10 10:28:03 +00:00
Nicolas Chevobbe cd19d05e7c Bug 1615322 - Display context selector button in Editor toolbar. r=jlast.
Differential Revision: https://phabricator.services.mozilla.com/D64977
2020-03-03 19:17:06 +00:00
Florens Verschelde 273f728731 Bug 1616343 - Align EagerEvaluation vertical spacing to message spacing; r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D63243
2020-02-26 13:49:53 +00:00
Jason Laster 50b84bfb56 Bug 1605154 - Implement JS execution context selector UI. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D59027
2020-02-13 15:00:06 +00:00
Nicolas Chevobbe e9c10634bd Bug 1613668 - Fix filterbar in split console. r=Honza.
The filterbar grid should only have subgrid for grid-template-rows,
not columns, as we want it to have its own column (1 for the main
ui elements, and another one for the close button).

Differential Revision: https://phabricator.services.mozilla.com/D61859
2020-02-11 11:10:49 +00:00
Nicolas Chevobbe 3d574b9a26 Bug 1613599 - Implement final eager evaluation design. r=jlast.
This patch adds a dedicated EagerEvaluation.css file so
it's easier to see all the related rules and properties.
The colors of the results are tweaked (mostly to grey)
so eager evaluation doesn't feel as intrusive.
The font-size is lowered for the same reason.
When eager evaluation is enabled, the padding of the console
input is reduced in order to have the input + eager results
to be 40px.

Differential Revision: https://phabricator.services.mozilla.com/D61806
2020-02-07 09:18:58 +00:00
Nicolas Chevobbe 144cd91162 Bug 1609941 - Display eager evaluation result in editor mode. r=jlast.
Differential Revision: https://phabricator.services.mozilla.com/D61568
2020-02-07 09:17:07 +00:00
Nicolas Chevobbe a02a06efe6 Bug 1612913 - Name grid areas for the WebConsole main grid. r=Honza.
This is done for both inline and editor grid. This gives us a
clearer way the grid should be used, and also allows us to
not have dedicated rules for editor layout in some cases.

Differential Revision: https://phabricator.services.mozilla.com/D61567
2020-02-04 14:39:57 +00:00
Nicolas Chevobbe 8e5115d1ee Bug 1601347 - Fix reverse search input jumpiness. r=Honza.
Making the reverse search input not taking into account
for the editor grid layout.
This meant we needed to group icons in their own
element to be able to wrap.

Differential Revision: https://phabricator.services.mozilla.com/D61395
2020-02-03 15:17:33 +00:00
Jason Laster 130675edf1 Bug 1607310 - Polish Eager Evaluation UI. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D58842
2020-01-10 16:39:48 +00:00
Itiel f6e0472863 Bug 1590212 - More RTL fixes to the console editor r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D49986
2019-10-29 12:40:13 +00:00
Narcis Beleuzu d77346d4db Backed out changeset 3534c1bfbd8e (bug 1590212) as per Itiel`s request. CLOSED TREE 2019-10-29 14:11:43 +02:00
Itiel f7f1e63e87 Bug 1590212 - More RTL fixes to the console editor r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D49986
2019-10-29 07:59:04 +00:00
Florens Verschelde 80e4b9a839 Bug 1589233 - Align CodeMirror line-height with Debugger in Inspector, Style Editor and Console editor; r=gl,nchevobbe
We have a few CodeMirror instances where we're using the default line height (`line-height: normal`), resulting in a line-height in the 13-14.5px range (depending on the font, OS, resolution). By contrast, the Debugger uses 15px explictly, and that's a style we're trying to generalize.

This patch sets a 15px line-height for:
- Inspector: the CodeMirror instance used in the markup view for "Edit as HTML" and in event tooltips
- Style Editor: the main editor instance
- Console: the jsterm but only in editor mode (since the output uses a 14px line-height on purpose, the jsterm in standard mode keeps this 14px line-height to minimize visual jumps when sending a command)

Differential Revision: https://phabricator.services.mozilla.com/D49593
2019-10-21 14:18:07 +00:00
Nicolas Chevobbe a8f2e6f266 Bug 1589867 - Fix browser_parsable_css.js failure on beta. r=Honza.
The rotate property is only enabled on Nightly.
For beta, we need to use transform: rotate instead.

Differential Revision: https://phabricator.services.mozilla.com/D49847
2019-10-21 08:31:52 +00:00
Nicolas Chevobbe 753b08a5f7 Bug 1589592 - Fix console editor Run button icon in RTL. r=Honza.
Since we want the button to be placed on the right side
in RTL languages and we don't have logical properties
on background-position yet, we display the icon in
a :before pseudo element which will adapt for both LTR
and RTL languages. The icon is then mirrored in RTL.

Differential Revision: https://phabricator.services.mozilla.com/D49718
2019-10-18 12:46:46 +00:00
Nicolas Chevobbe 7a54cdfae8 Bug 1577896 - Fix GridElementResizer on overflowing container. r=fvsch.
We remove the pseudo elements we were using to draw the borders and
put them on the grid elements instead.
We make the GridElementResizer 6px and translate it so there's
handle on "both sides" of the splitter.

Differential Revision: https://phabricator.services.mozilla.com/D45302
2019-10-18 10:17:48 +00:00
Armando Ferreira ab0447079c Bug 1523868 - Add a doorhanger options menu in console toolbar - Part 1.
Differential Revision: https://phabricator.services.mozilla.com/D47979
2019-10-15 17:04:30 +00:00
Dorel Luca b9570dcb8c Backed out changeset 03643a08fe82 (bug 1523868) for Node failure in Unexpected token y in JSON at position 0. CLOSED TREE 2019-10-15 18:42:20 +03:00
Armando Ferreira 736a79a179 Bug 1523868 - Add a doorhanger options menu in console toolbar - Part 1.
Differential Revision: https://phabricator.services.mozilla.com/D47979
2019-10-15 15:31:32 +00:00
Armando Ferreira 2df3915410 Bug 1567372 - Add a reverse search button to the Editor Toolbar. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D45095
2019-09-17 21:58:17 +00:00
Nicolas Chevobbe 307d41d644 Bug 1578326 - Make history navigation icons same color as other icons in webconsole. r=Honza.
Differential Revision: https://phabricator.services.mozilla.com/D44428
2019-09-03 07:43:35 +00:00