Commit Graph
163 Commits
Author SHA1 Message Date
Nicolas Chevobbe 62dc0bee6a Bug 2044406 - [devtools] Add space between XHR and request method in Console Network Messages. r=devtools-reviewers,jdescottes.
The .status element is turned into a simple <span> (instead of a <a>),
so it's 1. more semantically correct, and 2. doesn't create a new line.

We also handle null request `totalTime` by not showing the time in the status info,
as that could make the test to fail in chaos mode.

Differential Revision: https://phabricator.services.mozilla.com/D304391
2026-06-03 13:44:22 +00:00
Sylvestre Ledru 074b376055 Bug 2023419 - Remove Emacs/Vim modelines from devtools/ r=emilio,devtools-backward-compat-reviewers,devtools-reviewers,nchevobbe
replaced by .editorconfig
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D287841
2026-03-28 10:21:10 +00:00
Alexandru Marc 630e6cf0e8 Revert "Bug 2023419 - Remove Emacs/Vim modelines from devtools/ r=emilio,devtools-backward-compat-reviewers,devtools-reviewers,nchevobbe" for causing devtools failures
This reverts commit ed535dace9.
2026-03-17 12:46:01 +00:00
Sylvestre Ledru ed535dace9 Bug 2023419 - Remove Emacs/Vim modelines from devtools/ r=emilio,devtools-backward-compat-reviewers,devtools-reviewers,nchevobbe
replaced by .editorconfig

Differential Revision: https://phabricator.services.mozilla.com/D287841
2026-03-17 12:03:34 +00:00
Julian Descottes 75d403291c Bug 2017628 - [devtools] lint: update react/sort-comp rule to expect instance variables before constructor r=frontend-codestyle-reviewers,devtools-reviewers,profiler-reviewers,nchevobbe,mossop
Differential Revision: https://phabricator.services.mozilla.com/D283883
2026-02-19 13:44:07 +00:00
Alexandre Poirot 1bab0e4ff3 Bug 2013935 - [devtools] Show exception message and stack when failing to render a console message. r=devtools-reviewers,nchevobbe
Also ensure logging an error to the console.

Differential Revision: https://phabricator.services.mozilla.com/D281501
2026-02-09 09:31:14 +00:00
Mark Banner 88ea51175c Bug 2004680 - Automatically fix issues raised by jsdoc/check-tag-names. r=frontend-codestyle-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D275753
2025-12-22 12:41:23 +00:00
Andrea Marchesini 23f4d7c658 Bug 1986320 - Implement an add-on block URL-Classifier feature - part 3 - devtool support, r=devtools-reviewers,dimi,devtools-backward-compat-reviewers,bomsy
Differential Revision: https://phabricator.services.mozilla.com/D263364
2025-12-04 01:26:51 +00:00
Cristian Tuns c99c271730 Revert "Bug 1986320: apply code formatting via Lando" for causing lint failures in browser_ext_urlclassifier.js
This reverts commit 8c2c577a03.

Revert "Bug 1986320 - Implement an add-on block URL-Classifier feature - part 6 - Mobile r=geckoview-reviewers,android-reviewers,geckoview-api-reviewers,tcampbell,ohall"

This reverts commit 7b0c7db7c3.

Revert "Bug 1986320 - Implement an add-on block URL-Classifier feature - part 5 - Block top-level documents when loaded by add-ons, r=extension-reviewers,dimi,fluent-reviewers,robwu,bolsson,android-reviewers,android-l10n-reviewers,delphine,tcampbell"

This reverts commit 9a058ba0d5.

Revert "Bug 1986320 - Implement an add-on block URL-Classifier feature - part 4 - Expose the URLClassifier addon feature to non-recommended addons only, r=zombie"

This reverts commit 41e8a464d9.

Revert "Bug 1986320 - Implement an add-on block URL-Classifier feature - part 3 - devtool support, r=devtools-reviewers,dimi,devtools-backward-compat-reviewers,bomsy"

This reverts commit c0f866931b.

Revert "Bug 1986320 - Implement an add-on block URL-Classifier feature - part 2 - telemetry, r=dimi,extension-reviewers,robwu"

This reverts commit 1bdba2f426.

Revert "Bug 1986320 - Implement an add-on block URL-Classifier feature - part 1, r=dimi,geckoview-reviewers,extension-reviewers,tcampbell,robwu"

This reverts commit f1a3613f44.
2025-12-03 19:15:17 +00:00
Andrea Marchesini c0f866931b Bug 1986320 - Implement an add-on block URL-Classifier feature - part 3 - devtool support, r=devtools-reviewers,dimi,devtools-backward-compat-reviewers,bomsy
Differential Revision: https://phabricator.services.mozilla.com/D263364
2025-12-03 18:47:30 +00:00
iulian moraru a5862a7e70 Revert "Bug 1999177 - Support cursor scroll in the composable toolbar r=android-reviewers,moyin" for causing linting failures on browser_ext_urlclassifier.js.
This reverts commit ae35529fab.

Revert "Bug 1986320: apply code formatting via Lando"

This reverts commit 768f3614ff.

Revert "Bug 1986320 - Implement an add-on block URL-Classifier feature - part 5 - Block top-level documents when loaded by add-ons, r=extension-reviewers,dimi,fluent-reviewers,robwu,bolsson,android-reviewers,android-l10n-reviewers,delphine,tcampbell"

This reverts commit 5f2e690d2b.

Revert "Bug 1986320 - Implement an add-on block URL-Classifier feature - part 4 - Expose the URLClassifier addon feature to non-recommended addons only, r=zombie"

This reverts commit 1e7b1753d4.

Revert "Bug 1986320 - Implement an add-on block URL-Classifier feature - part 3 - devtool support, r=devtools-reviewers,dimi,devtools-backward-compat-reviewers,bomsy"

This reverts commit 928a253e9e.

Revert "Bug 1986320 - Implement an add-on block URL-Classifier feature - part 2 - telemetry, r=dimi,extension-reviewers,robwu"

This reverts commit 2a13eb6ec3.

Revert "Bug 1986320 - Implement an add-on block URL-Classifier feature - part 1, r=dimi,geckoview-reviewers,extension-reviewers,tcampbell,robwu"

This reverts commit 1ef88130d9.
2025-12-03 10:26:32 +00:00
Andrea Marchesini 928a253e9e Bug 1986320 - Implement an add-on block URL-Classifier feature - part 3 - devtool support, r=devtools-reviewers,dimi,devtools-backward-compat-reviewers,bomsy
Differential Revision: https://phabricator.services.mozilla.com/D263364
2025-12-03 09:47:52 +00:00
Mark Banner b38cd3110b Bug 1999554 - Automatically fix ESLint rule jsdoc/check-types for devtools/. r=devtools-reviewers,devtools-backward-compat-reviewers,profiler-reviewers,canaltinova
Differential Revision: https://phabricator.services.mozilla.com/D272173
2025-11-21 16:16:08 +00:00
Serah Nderi 4bd88f6d90 Bug 1602351 - Allow to print the stacktrace in logpoint; r=nchevobbe,devtools-reviewers,devtools-backward-compat-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D243803
2025-06-12 12:19:02 +00:00
Hubert Boma Manilla f0190d869c Bug 1966005 - [devtools] Make sure to try auto-scroll after the completion of the sourcemap service r=devtools-reviewers,nchevobbe
Issue: After the sourcemap service has completed it should trigger and update which would cause `maybeScrollToBottomMessageCallback` ( which handles the auto scrolling)
to fire. But the `shouldScrollBottom` was failing, as it does not considrer the delayed updates which happen after the sourcemap service is done.

Differential Revision: https://phabricator.services.mozilla.com/D249904
2025-06-11 07:06:26 +00:00
Atila Butkovits a372b777d2 Revert "Bug 1557795 - [devtools] Cleanup and unify network event types r=devtools-reviewers,jdescottes" for causing dt failures.
This reverts commit fcd3970805.

Revert "Bug 1966005 - [devtools] Make sure to try auto-scroll after the completion of the sourcemap service r=devtools-reviewers,nchevobbe"

This reverts commit d6fc5d489d.

Revert "Bug 1959452 - [devtools] Throttle parent process events on the server side r=devtools-reviewers,jdescottes,ochameau"

This reverts commit b96015ae28.
2025-06-09 14:18:49 +00:00
Hubert Boma Manilla d6fc5d489d Bug 1966005 - [devtools] Make sure to try auto-scroll after the completion of the sourcemap service r=devtools-reviewers,nchevobbe
Issue: After the sourcemap service has completed it should trigger and update which would cause `maybeScrollToBottomMessageCallback` ( which handles the auto scrolling)
to fire. But the `shouldScrollBottom` was failing, as it does not considrer the delayed updates which happen after the sourcemap service is done.

Differential Revision: https://phabricator.services.mozilla.com/D249904
2025-06-09 10:29:58 +00:00
Alexandre Poirot e1f9301f4e Bug 1953578 - [devtools] Migrate all usage of react-prop-types CommonJS module to the ES Module version and remove the CommonJS version. r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D241594
2025-03-19 13:30:51 +00:00
Alexandre Poirot 26260731f1 Bug 1953578 - [devtools] Migrate all usage of react CommonJS module to the ES Module version and remove the CommonJS version. r=devtools-reviewers,profiler-reviewers,nchevobbe,canaltinova
Differential Revision: https://phabricator.services.mozilla.com/D241593
2025-03-19 13:30:51 +00:00
Joshua O'Brien 026ddab7bd Bug 1948347 - Add date title to timestamps in developer console. r=nchevobbe,devtools-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D241190
2025-03-13 07:18:46 +00:00
Julian Descottes 44faa9088d Bug 1953352 - [devtools] Fix the network Tabbox in the Browser Console r=nchevobbe,devtools-reviewers
The toolbox store is not available in the Browser Console.
The netmonitor's TabboxPanel component now exports two variants:
- TabboxPanel: raw TabboxPanel without toolbox store derived props
- ConnectedTabboxPanel: connected to the toolbox store for override props

Differential Revision: https://phabricator.services.mozilla.com/D241159
2025-03-12 20:39:17 +00:00
Alexandre Poirot a1f71632ba Bug 1929387 - [devtools] Convert Reps to ES Modules. r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D228996
2025-03-05 17:05:55 +00:00
Nicolas Chevobbe e3f5e97135 Bug 1948581 - [devtools] Fix Network messages raw response toggle. r=devtools-reviewers,bomsy.
This is only to make the toggle works as before,
it doesn't handle persisting the toggle state
like in the Netmonitor.
We also pass `targetSearchResult` to `TabboxPanel` to avoid
unnecessary re-renders that were messing up the test.

Differential Revision: https://phabricator.services.mozilla.com/D238416
2025-02-19 08:04:01 +00:00
Julian Descottes 41a9ae7ec0 Bug 1849920 - [devtools] Pass the toolbox store from console to TabBox r=devtools-reviewers,nchevobbe
Depends on D233302

Differential Revision: https://phabricator.services.mozilla.com/D235540
2025-02-07 07:55:07 +00:00
Alexandre Poirot 536aab5a96 Bug 1943351 - [devtools] Also avoid uncessary redux updates when the console is hidden. r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D235345
2025-02-06 19:17:48 +00:00
Goloman Adrian cdcdea13da Backed out 5 changesets (bug 1943351, bug 1943543) for causing bc failures @browser_ext_devtools_panel.js. CLOSED TREE
Backed out changeset bdf540812b20 (bug 1943351)
Backed out changeset d958cc2493a6 (bug 1943351)
Backed out changeset 9ad9f4004de4 (bug 1943351)
Backed out changeset cd2dd8259eba (bug 1943543)
Backed out changeset cd5fce018c5a (bug 1943543)
2025-02-06 16:40:58 +02:00
Alexandre Poirot fed8e8dfd0 Bug 1943351 - [devtools] Also avoid uncessary redux updates when the console is hidden. r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D235345
2025-02-06 13:41:09 +00:00
Alexandre Poirot adeb60b754 Bug 1929390 - [devtools] Import objectInspector without going through Reps. r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D228994
2024-11-14 21:43:34 +00:00
Alexandre Poirot 5c313922f8 Bug 1908615 - [devtools] Pass raw DOM event name from tracer RDP packet. r=devtools-reviewers,nchevobbe
That, instead of prefixing them with "DOM | ".

Differential Revision: https://phabricator.services.mozilla.com/D219780
2024-09-13 13:06:30 +00:00
Julian Descottes de8604d428 Bug 1913472 - [devtools] Fix propTypes warnings when using the console r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D219339
2024-08-16 13:44:11 +00:00
Nicolas Chevobbe e39b6ccdc1 Bug 1897139 - [devtools] Share blocked request string between console and netmonitor. r=devtools-reviewers,ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D210649
2024-05-17 07:42:17 +00:00
Nicolas Chevobbe e58349d131 Bug 1895536 - [devtools] Update network request blocked string. r=devtools-reviewers,ochameau.
Requests can be blocked because of many reasons, but the label was always
saying it was because of DevTools.
Update the label so we follow what's done in Netmonitor.

Differential Revision: https://phabricator.services.mozilla.com/D210471
2024-05-16 12:40:22 +00:00
Nicolas Chevobbe 468323a509 Bug 1888645 - [devtools] Fix SmartTrace crash with wasm frames. r=devtools-reviewers,bomsy.
In some cases, we were getting null sourceId, which was causing an exception
to be thrown in `getFormattedSourceId` since it expects a string.
We add a simple guard in this function so we don't throw anymore.

But we shouldn't get null sourceId in the first place. It looks like for
some Wasm sources, the SavedFrame sourceId can be 0, which wasn't playing
well with some loose check we were doing in the sources manager.

Finally, the "Copy metadata" button we display when a console message crash
wasn't working. The message now includes the targetFront, which can be serialized
in JSON, so we simply ignore it.

Differential Revision: https://phabricator.services.mozilla.com/D206105
2024-05-13 10:17:15 +00:00
Alexandre Poirot 8c9338e858 Bug 1827382 - [devtools] Migrate tracer from JSM to ESM. r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D202437
2024-03-26 08:29:21 +00:00
Alexandre Poirot d22ddaa6e6 Bug 1884717 - [devtools] Only log "returns" when logging exit frames without tracing values. r=devtools-reviewers,bomsy
We were logging "returns undefined" everywhere.

Differential Revision: https://phabricator.services.mozilla.com/D204301
2024-03-13 13:48:54 +00:00
Dave Townsend 2af4d349f3 Bug 1864896: Autofix unused function arguments (devtools). r=profiler-reviewers,devtools-reviewers,nchevobbe,julienw
Differential Revision: https://phabricator.services.mozilla.com/D202959
2024-03-05 14:21:15 +00:00
Alexandre Poirot 8fd4e3f6d4 Bug 1721427 - [devtools] Trace each step in a function call. r=devtools-reviewers,nchevobbe
This feature is only exposed to internal usages of tracer.jsm, by passing traceStep boolean option:
```
startTracing({ global, traceSteps: true });
```
This will automatically log to stdout all traces, including each frame step within a function execution.
Without this flag, the tracer would only trace function calls and nothing more.
We would not know which line is being executed within the function execution.

Differential Revision: https://phabricator.services.mozilla.com/D201977
2024-02-27 14:52:12 +00:00
Alexandre Poirot de907e9f52 Bug 1879087 - [devtools] Trace DOM mutations. r=devtools-reviewers,nchevobbe
Also allow logging trace whenever any DOM Element get added, removed or modified.
For now this is exposed only via the console command via:
  :tracer --dom-mutations  (for all types of mutation)
  :tracer --dom-mutations add,attributes,remove (coma separated list of mutation types you want to listen for)

Also revise the handling of "isWorker" so that all checks have the best possible check.

Differential Revision: https://phabricator.services.mozilla.com/D201976
2024-02-22 08:52:21 +00:00
Mark Banner b5df22ad0f Bug 1880535 - Enable ESLint rule no-unused-private-class-members. r=Gijs,webdriver-reviewers,webcompat-reviewers,extension-reviewers,application-update-reviewers,devtools-reviewers,translations-reviewers,bytesized,twisniewski,jhirsch,robwu,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D202002
2024-02-20 22:09:21 +00:00
Alexandre Poirot d42ef20edd Bug 1852028 - [devtools] Log function return in javascript tracer. r=devtools-reviewers,nchevobbe
For now, we were only logging when we enter a function call, but not when we exit.

Differential Revision: https://phabricator.services.mozilla.com/D200173
2024-02-13 09:38:50 +00:00
Alexandre Poirot 6fc6849dbd Bug 1848159 - [devtools] Use tracing icon for all messages related to the tracing. r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D199975
2024-01-30 20:18:51 +00:00
Alexandre Poirot fd5a144115 Bug 1873066 - [devtools] Avoid some computation when receiving new messages. r=devtools-reviewers,nchevobbe
The "is in opening group" computation, which goes through all message arrays
can be avoided until it is meaningful to check for this particular edge case.
Also we can remove the redundant check against `nextProps.messagesUi`.

Differential Revision: https://phabricator.services.mozilla.com/D197770
2024-01-17 15:10:46 +00:00
Nicolas Chevobbe 5a608228ab Bug 1872689 - [devtools] Prepare codebase for eslint-plugin-react update. r=devtools-reviewers,ochameau.
Updating eslint-plugin-react to 7.33.2 raises new eslint errors.
A few component needed to have their proptypes fixed (or added).
JSPropertyProvider was considered as a react component by the plugin,
I guess because it is a function starting with an uppercase letter.
Since it is a bit unusual to have such thing, I renamed it slightly
to make it look more like a function.

Differential Revision: https://phabricator.services.mozilla.com/D197596
2024-01-04 16:06:08 +00:00
Alexandre Poirot 641c35b909 Bug 1835614 - [devtools] Use a custom resource for traces. r=devtools-reviewers,nchevobbe
This help reduce the RDP overhead by only transferring what is strictly necessary.
The console message resources bundles various useless attributes.

This also help use a custom rendering in the frontend so that traces can
be displayed distinctly and differently from the console API calls.

Differential Revision: https://phabricator.services.mozilla.com/D196020
2023-12-19 18:01:52 +00:00
Narcis Beleuzu 54a3764889 Backed out 2 changesets (bug 1835614) for xpcshell failure on test_tracer.js . CLOSED TREE
Backed out changeset 4501d1fb176a (bug 1835614)
Backed out changeset 60b933696a41 (bug 1835614)
2023-12-19 12:54:32 +02:00
Alexandre Poirot 193fc9986e Bug 1835614 - [devtools] Use a custom resource for traces. r=devtools-reviewers,nchevobbe
This help reduce the RDP overhead by only transferring what is strictly necessary.
The console message resources bundles various useless attributes.

This also help use a custom rendering in the frontend so that traces can
be displayed distinctly and differently from the console API calls.

Differential Revision: https://phabricator.services.mozilla.com/D196020
2023-12-19 09:20:33 +00:00
Nicolas Chevobbe 9a88c4becd Bug 1844091 - [devtools] Add proper labels to evaluation and evaluation result message icons. r=devtools-reviewers,ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D189332
2023-09-29 05:23:22 +00:00
Mark Banner 0666077666 Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu
Differential Revision: https://phabricator.services.mozilla.com/D177027
2023-05-20 12:26:53 +00:00
Mark Banner 91fde42f7b Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish
Differential Revision: https://phabricator.services.mozilla.com/D177025
2023-05-20 12:26:49 +00:00
Nicolas Chevobbe 02a1214926 Bug 1829100 - [devtools] Prevent navigation from network message link. r=bomsy,devtools-reviewers.
Differential Revision: https://phabricator.services.mozilla.com/D176152
2023-04-24 12:21:39 +00:00