This includes the following API:
* Debugger.Object.prototype.createSource
* startColumn field of the parameter object
* Debugger.Script.prototype.startColumn
* return value
* Debugger.Script.prototype.getPossibleBreakpoints
* minColumn and maxColumn property of the query
* columnNumber property of the returned array elements
* Debugger.Script.prototype.getOffsetMetadata
* columnNumber property of the returned array elements
* Debugger.Script.prototype.getOffsetLocation
* columnNumber property of the returned array elements
* Debugger.Script.prototype.getAllColumnOffsets
* columnNumber property of the returned array elements
* Debugger.Script.prototype.getOffsetsCoverage
* columnNumber property of the returned array elements
* Debugger.Source.prototype.startColumn
* return value
This patch modifies DevTools code to convert the column number from/to 1-origin,
while keep using 0-origin on their side.
One exception is the WASM's column number, which had been using 1-origin 1.
Each consumer in DevTools handles the WASM case, and the code can be removed
once DevTools internal also switches to 1-origin column number.
The other exception is to use 1-based column number in logCustomFormatterError,
which is folded from bug 1864783 patch.
Differential Revision: https://phabricator.services.mozilla.com/D193270
This includes the following API:
* Debugger.Object.prototype.createSource
* startColumn field of the parameter object
* Debugger.Script.prototype.startColumn
* return value
* Debugger.Script.prototype.getPossibleBreakpoints
* minColumn and maxColumn property of the query
* columnNumber property of the returned array elements
* Debugger.Script.prototype.getOffsetMetadata
* columnNumber property of the returned array elements
* Debugger.Script.prototype.getOffsetLocation
* columnNumber property of the returned array elements
* Debugger.Script.prototype.getAllColumnOffsets
* columnNumber property of the returned array elements
* Debugger.Script.prototype.getOffsetsCoverage
* columnNumber property of the returned array elements
* Debugger.Source.prototype.startColumn
* return value
This patch modifies DevTools code to convert the column number from/to 1-origin,
while keep using 0-origin on their side.
One exception is the WASM's column number, which had been using 1-origin 1.
Each consumer in DevTools handles the WASM case, and the code can be removed
once DevTools internal also switches to 1-origin column number.
The other exception is to use 1-based column number in logCustomFormatterError,
which is folded from bug 1864783 patch.
Differential Revision: https://phabricator.services.mozilla.com/D193270
Use 'globalThis' instead of 'this' when trying to attach a debugger to the
current global to avoid subtle footguns with the varied definitions of 'this'.
The debugger interface needs a true GlobalObject so this is much clearer. In
particular, this is a problem in test_nativewrappers.js when the test runs in
strict mode since the 'this' in the test function is no long implicitly the
global.
Differential Revision: https://phabricator.services.mozilla.com/D157544
Nicolas Chevobbe