Added a tooltip to the Priority column to show final priority.
Added getRequestPriorityAsNumber function to convert HAR priority string back into a value.
Update representation of the priority value of a resource when it changes.
Added field priority to HAR file export and importing.
Linting wants double quotes.
priority **needs** to be gathered first before assigning into resource.
Check if the priority has changed to decide if Priority should re-render.
Added test to check priority of images above and below the fold.
Changed test HTML file into a hand written example with some explanation.
Guard against null priority when updating it.
Use isInteger to check priority is really a number.
We do not want to overwrite priority with "undefined".
Defer setting up the first test image a little bit, but do not check its priority.
Test HTML needs to be large.
Differential Revision: https://phabricator.services.mozilla.com/D287020
This reverts commit 80834d18d5.
Revert "Bug 2044644 - Make HeapSnapshot.cpp compatible with bugprone-forwarding-reference-overload check r=jandem"
This reverts commit 81ddd9da57.
Revert "Bug 2044644 - Make http/Capsule.h compatible with bugprone-forwarding-reference-overload check r=necko-reviewers,valentin"
This reverts commit 5443d86b53.
Revert "Bug 2044644 - Make xpcom/threads/nsThreadUtils.h compatible with bugprone-forwarding-reference-overload check r=xpcom-reviewers,nika"
This reverts commit 912dd4e34d.
Revert "Bug 2044644 - Use standard [[maybe_unused]] instead of custom approach to inform the compiler about potential usage of a variable r=spidermonkey-reviewers,jandem"
This reverts commit 0ea4c039c9.
Display storage.sync items alongside storage.local items in the extension
storage inspector.
Because storage.local and storage.sync can each contain an item with the same
name, the item name alone is no longer unique. Use a compound uniqueKey
consisting of the item name and storage area to disambiguate them within the
same table. This approach follows the one used by the cookies storage actor.
The Storage Inspector client automatically uses the first field returned by
getFields() as the unique identifier for table rows, so exposing the compound
uniqueKey there lets existing interfaces such as getValuesForHost(),
editItem(), and removeItem() receive it without changes to their external
signatures.
Differential Revision: https://phabricator.services.mozilla.com/D304326
animationsPlayBackRateMultiplier is a synced BrowsingContext field whose CanSet
requires IsTop(). When a root target actor (e.g. the Browser Toolbox) has an
iframe selected as the currently targeted document via the iframe picker,
this.browsingContext is no longer the top context, so setting the multiplier on
it crashed with "CanSet failed for field(s): AnimationsPlayBackRateMultiplier".
Set the field on this.browsingContext.top instead, which matches the field's
getter (which reads from Top()) and is a no-op for the regular tab toolbox where
the targeted context is already top.
Differential Revision: https://phabricator.services.mozilla.com/D305790
This reverts commit 739a225b8a.
Revert "Bug 2041004 - Make ::picker-icon generated content, add UA styles r=layout-reviewers,firefox-style-system-reviewers,emilio"
This reverts commit 4b7b2a4083.
This will then help know if Local Mode logic should reload the page or
not if we register a mapping while the currently debugged page has the
same origin **and** is an error page.
Differential Revision: https://phabricator.services.mozilla.com/D302981
This reverts commit 6b8775f47f.
Revert "Bug 2041004 - Make ::picker-icon generated content, add UA styles r=layout-reviewers,firefox-style-system-reviewers,emilio"
This reverts commit e3529d76f3.
This reverts commit f2d8553f79.
Revert "Bug 2031714 - [devtools] Expose a flag on the TargetFront to know if the page is an error page. r=devtools-reviewers,nchevobbe"
This reverts commit 0ef861f993.
This will then help know if Local Mode logic should reload the page or
not if we register a mapping while the currently debugged page has the
same origin **and** is an error page.
Differential Revision: https://phabricator.services.mozilla.com/D302981
This reverts commit b434b10988.
Revert "Bug 2041004 - Make ::picker-icon generated content, add UA styles r=layout-reviewers,firefox-style-system-reviewers,emilio"
This reverts commit e92bda8433.
This reverts commit 13896a724c.
Revert "Bug 2031714 - [devtools] Expose a flag on the TargetFront to know if the page is an error page. r=devtools-reviewers,nchevobbe"
This reverts commit d6ca9ef038.
This will then help know if Local Mode logic should reload the page or
not if we register a mapping while the currently debugged page has the
same origin **and** is an error page.
Differential Revision: https://phabricator.services.mozilla.com/D302981
A failing test with fail-if was throwing midway and leaving unhandled promises and creating leaks.
Move to skip-if.
The auth listener test seems to also create frequent leaks, skip it on ASAN.
Differential Revision: https://phabricator.services.mozilla.com/D304370
This reverts commit 78970467d8.
Revert "Bug 2031714 - [devtools] Expose a flag on the TargetFront to know if the page is an error page. r=devtools-reviewers,nchevobbe"
This reverts commit 6b862813ef.
This will then help know if Local Mode logic should reload the page or
not if we register a mapping while the currently debugged page has the
same origin **and** is an error page.
Differential Revision: https://phabricator.services.mozilla.com/D302981
Added a tooltip to the Priority column to show final priority.
Added getRequestPriorityAsNumber function to convert HAR priority string back into a value.
Update representation of the priority value of a resource when it changes.
Added field priority to HAR file export and importing.
Linting wants double quotes.
priority **needs** to be gathered first before assigning into resource.
Check if the priority has changed to decide if Priority should re-render.
Added test to check priority of images above and below the fold.
Changed test HTML file into a hand written example with some explanation.
Guard against null priority when updating it.
Use isInteger to check priority is really a number.
We do not want to overwrite priority with "undefined".
Differential Revision: https://phabricator.services.mozilla.com/D287020
This reverts commit b7f48700d7.
Revert "Bug 2031714 - [devtools] Implement "Local Mode" backend. r=devtools-reviewers,devtools-backward-compat-reviewers,bomsy"
This reverts commit 0f1b6c66ab.
Revert "Bug 2031714 - [devtools] Expose a flag on the TargetFront to know if the page is an error page. r=devtools-reviewers,nchevobbe"
This reverts commit 4cbb3ac689.
This will then help know if Local Mode logic should reload the page or
not if we register a mapping while the currently debugged page has the
same origin **and** is an error page.
Differential Revision: https://phabricator.services.mozilla.com/D302981
This reverts commit cc333d322a.
Revert "Bug 2043924 - [devtools] Improve the error message for a method which expect bulk response but return a value r=devtools-reviewers,ochameau"
This reverts commit 19e0d76011.
This incoming variable is the JSON packet as a string,
and so is possibly large and forces to create a new string
even if we aren't logging.
Differential Revision: https://phabricator.services.mozilla.com/D302982
Check if the attribute value does match the definedd attr() attr-type parameter
to see if the attribute value or the fallback is being used.
In the attr() tooltip, indicate when the attribute value doesn't match the specified
type.
Differential Revision: https://phabricator.services.mozilla.com/D301490
- Re-vendored protobuf at v35.0 alongside third_party/utf8_range, a
build-time dependency pulled in by extension_set_inl.h. Expanded
moz.yaml excludes to cover the reorganized upstream layout (json/,
util/, bridge/, compiler/, plus test/build-config files leaked past
the default exclude pattern), and dropped the now-upstreamed
remove_iostream_header.patch.
- Added /third_party/abseil-cpp to chromium-config.mozbuild's
LOCAL_INCLUDES so transitive absl/* includes resolve in every
protobuf consumer that includes chromium-config; added direct
LOCAL_INCLUDES on the few that don't.
- Added a pragma to abseil's check_op.h to suppress sign-compare in
CHECK_OP macros, scoping the suppression to translation units that
include this header rather than globally.
- Added USE_LIBS += ["abseil"] to the content_analysis_sdk_agent
Program() so it can link absl symbols.
- Audited moz.build SOURCES and EXPORTS against actual usage and
removed full-runtime files (well-known type .pb.cc/.pb.h,
reflection_ops, dynamic_message, text_format, descriptor, etc.)
that our lite-mode generated code doesn't reach.
- Taught generate_files.py to update gradle/libs.versions.toml's
`protobuf` (Java/Maven) value to match the vendored C++ revision
on future re-vendors.
- Suppressed nodiscard warnings on pre-existing SerializeToString
calls in url-classifier with (void) casts.
Differential Revision: https://phabricator.services.mozilla.com/D300213