HeyPuter/firefox
1
0 Fork 0
mirror of https://github.com/HeyPuter/firefox.git synced 2026-11-13 20:14:57 -10:00
Code Issues Packages Projects Releases Wiki Activity
976,508 Commits 2 Branches 0 Tags
singlethreaded
Commit Graph
175 Commits
Author SHA1 Message Date
Hubert B Manilla 6c0d6e099d Bug 2043924 - [devtools] Improve the error message for a method which expect bulk response but return a value r=devtools-reviewers,ochameau 
Differential Revision: https://phabricator.services.mozilla.com/D303667
 2026-06-02 09:18:10 +00:00
Atila Butkovits b58730abd8 Revert "Bug 2043924 - [devtools] Assert that a method which expects a bulk response throws when a value is returned r=devtools-reviewers,ochameau" for causing failures at test_bulk_error.js. 
This reverts commit cc333d322a.

Revert "Bug 2043924 - [devtools] Improve the error message for a method which expect bulk response but return a value r=devtools-reviewers,ochameau"

This reverts commit 19e0d76011.
 2026-06-01 18:20:21 +00:00
Hubert B Manilla 19e0d76011 Bug 2043924 - [devtools] Improve the error message for a method which expect bulk response but return a value r=devtools-reviewers,ochameau 
Differential Revision: https://phabricator.services.mozilla.com/D303667
 2026-06-01 16:00:38 +00:00
Antonette Caldwell 4c36030555 Bug 2031735 - Throw Error instead of Actor for invalid bulk response return value in protocol Actor. r=devtools-reviewers,bomsy 
Differential Revision: https://phabricator.services.mozilla.com/D302684
 2026-05-31 20:11:15 +00:00
Alexandre Poirot 5e8593b7bc Bug 1622857 - [devtools] Highlights pairs of outgoing/incoming RDP packets in MOZ_LOG output. r=devtools-reviewers,nchevobbe 
Differential Revision: https://phabricator.services.mozilla.com/D299054
 2026-05-18 09:12:25 +00:00
Alexandre Poirot 9c63514236 Bug 1622857 - [devtools] Log RDP packets via MOZ_LOG. r=devtools-reviewers,jdescottes,nchevobbe 
RDP can be easily traced via stdout by running:
$ MOZ_LOG="devtools_rdp:3" ./mach run

Differential Revision: https://phabricator.services.mozilla.com/D298483
 2026-05-18 09:12:21 +00:00
Alexandre Poirot 59149c9a82 Bug 2019873 - [devtools] Transfer stack to the parent process for content process exceptions. r=devtools-reviewers,jdescottes 
When any exception happens from the DevToolsProcess's JSProcessActor,
the stacktrace is lost when the exception reaches the parent process.
Manually transfer the exception payload between processes
so that RDP server can send the full stack to the client.

Using callbacks was losing async stack trace, so I moved super.sendQuery
into an inline async function to be able to use await and preserve async
stacks in case of errors.

Differential Revision: https://phabricator.services.mozilla.com/D298390
 2026-05-14 00:42:17 +00:00
Sylvestre Ledru 074b376055 Bug 2023419 - Remove Emacs/Vim modelines from devtools/ r=emilio,devtools-backward-compat-reviewers,devtools-reviewers,nchevobbe 
replaced by .editorconfig
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D287841
 2026-03-28 10:21:10 +00:00
Alexandru Marc 630e6cf0e8 Revert "Bug 2023419 - Remove Emacs/Vim modelines from devtools/ r=emilio,devtools-backward-compat-reviewers,devtools-reviewers,nchevobbe" for causing devtools failures 
This reverts commit ed535dace9.
 2026-03-17 12:46:01 +00:00
Sylvestre Ledru ed535dace9 Bug 2023419 - Remove Emacs/Vim modelines from devtools/ r=emilio,devtools-backward-compat-reviewers,devtools-reviewers,nchevobbe 
replaced by .editorconfig

Differential Revision: https://phabricator.services.mozilla.com/D287841
 2026-03-17 12:03:34 +00:00
Alexandre Poirot a0c5761e78 Bug 1990493 - [devtools] Show out of memory stack from server exceptions. r=devtools-reviewers,nchevobbe 
Differential Revision: https://phabricator.services.mozilla.com/D277899
 2026-01-06 16:07:04 +00:00
Mark Banner fd62657728 Bug 2004680 - Fix ESLint rule jsdoc/check-tag-names issues in devtools. r=devtools-reviewers,devtools-backward-compat-reviewers,nchevobbe 
Differential Revision: https://phabricator.services.mozilla.com/D275754
 2025-12-22 12:41:26 +00:00
Mark Banner 88ea51175c Bug 2004680 - Automatically fix issues raised by jsdoc/check-tag-names. r=frontend-codestyle-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D275753
 2025-12-22 12:41:23 +00:00
Lorenz A 1f0813b5a9 Bug 2004212 - [devtools] Turn devtools/shared/protocol/tests/xpcshell/head.js into an ES class. r=devtools-reviewers,nchevobbe 
Differential Revision: https://phabricator.services.mozilla.com/D275473
 2025-12-08 22:32:55 +00:00
Lorenz A b2b57855e3 Bug 2004232 - [devtools] Turn Response.js into an ES class. r=devtools-reviewers,nchevobbe 
Differential Revision: https://phabricator.services.mozilla.com/D275226
 2025-12-08 08:08:47 +00:00
Lorenz A d1efa285f9 Bug 2004231 - [devtools] Turn lazy-pool.js into an ES class. r=devtools-reviewers,nchevobbe 
Differential Revision: https://phabricator.services.mozilla.com/D275229
 2025-12-08 06:53:38 +00:00
Lorenz A cbcae85afa Bug 2004038 - [devtools] Turn classes in Request.js into proper ES class. r=devtools-reviewers,nchevobbe 
Differential Revision: https://phabricator.services.mozilla.com/D275081
 2025-12-05 06:26:20 +00:00
Tom Marble 5ce09d7446 Bug 1995583 - test manifest cleanup for idiomatic usage r=jmaher,necko-reviewers,webcompat-reviewers,geckoview-reviewers,application-update-reviewers,media-playback-reviewers,sessionstore-reviewers,tabbrowser-reviewers,translations-reviewers,omc-reviewers,browser-installer-reviewers,twisniewski,masayuki,dom-core,smaug,nalexander,emcminn,sthompson,alwu,ai-ondevice-reviewers,valentin 
For TOML manifests:

1. Change processor -> arch
2. Use arch instead of bits bits == '64' =>
   aarch64 (default on mac 15.30) or x86_64 bits == '32' => x86
3. Replace android_version with corresponding os_version
4. Remove conditions with linux os_version=="18.04"
   (unless they contain verify or verify-standalone)
5. Remove conditions with mac os_version=='11.20',
   (unless they contain verify or verify-standalone)
6. Remove conditions with win os_version=='11.2009' or win11_2009,
   (unless they contain verify or verify-standalone)
7. Linux conditions should have os_version, arch and display
   (simple "os == 'linux'" will get expanded to these two)
   "os == 'linux' && os_version == '22.04' && arch == 'x86_64' && display == 'wayland'"
   "os == 'linux' && os_version == '24.04' && arch == 'x86_64' && display == 'x11'"
8. Mac conditions should have os_version and arch
   (simple "os == 'mac'" will get expanded to these three)
   "os == 'mac' && os_version == '10.15' && arch == 'x86_64'",
   "os == 'mac' && os_version == '14.70' && arch == 'x86_64'",
   "os == 'mac' && os_version == '15.30' && arch == 'aarch64'",
9. Replace apple_catalina with
   os == 'mac' && os_version == '10.15' && arch == 'x86_64'
10. Replace apple_silicon with
   os == 'mac' && os_version = '15.30' && arch == 'aarch64'
11. Replace win10_2009 with
   os == 'win' && os_version = '10.2009' && arch == 'x86_64'
12. Replace "!debug" with three conditions "asan", "opt", or "tsan"
13. Replace literal boolean comparison with variables
    (e.g. "debug == false" => "!debug)

Resolves 2000285

Signed-off-by: Tom Marble <[email protected]>

Differential Revision: https://phabricator.services.mozilla.com/D272815
 2025-11-22 00:30:39 +00:00
Mark Banner b38cd3110b Bug 1999554 - Automatically fix ESLint rule jsdoc/check-types for devtools/. r=devtools-reviewers,devtools-backward-compat-reviewers,profiler-reviewers,canaltinova 
Differential Revision: https://phabricator.services.mozilla.com/D272173
 2025-11-21 16:16:08 +00:00
Mark Banner 2542790f53 Bug 1998787 - Automatic fixes for enabling ESLint jsdoc/tag-line rule everywhere. r=frontend-codestyle-reviewers,mtigley,perftest-reviewers,nchevobbe,home-newtab-reviewers,Gijs,mconley,sparky 
Differential Revision: https://phabricator.services.mozilla.com/D271745
 2025-11-10 21:27:12 +00:00
Mark Banner dde0952bd6 Bug 1994217 - Enable ESLint rule jsdoc/no-bad-blocks on the rest of the tree. r=frontend-codestyle-reviewers,Gijs 
This is mainly automatic changes, with some manual fixes to move text off of the first line.

Differential Revision: https://phabricator.services.mozilla.com/D268570
 2025-10-17 11:18:46 +00:00
Narcis Beleuzu 89c0ffec7c Revert "Bug 1994217 - Enable ESLint rule jsdoc/no-bad-blocks on the rest of the tree. r=frontend-codestyle-reviewers,Gijs" for causing Documentation opt failure 
This reverts commit 987c3ad130.

This reverts commit 1c5b20a293.

This reverts commit 0a9a458465.
 2025-10-16 21:32:01 +00:00
Mark Banner 987c3ad130 Bug 1994217 - Enable ESLint rule jsdoc/no-bad-blocks on the rest of the tree. r=frontend-codestyle-reviewers,Gijs 
This is mainly automatic changes, with some manual fixes to move text off of the first line.

Differential Revision: https://phabricator.services.mozilla.com/D268570
 2025-10-16 10:58:14 +00:00
Nicolas Chevobbe da35303962 Bug 1599082 - [devtools] Remove external usage of static EventEmitter methods. r=devtools-reviewers,jdescottes. 
Replace those with inheritance/decorations, extends classes that needed it.
Next patch in stack will remove the static methods alltogether.

Differential Revision: https://phabricator.services.mozilla.com/D267589
 2025-10-07 05:37:53 +00:00
Florian Quèze c6561de6fe Bug 1982887 - add the ChromeUtils.now API to use it in ChromeUtils.addProfilerMarker, r=canaltinova,webdriver-reviewers,perftest-reviewers,geckoview-reviewers,extension-reviewers,settings-reviewer-rotation,search-reviewers,devtools-reviewers,places-reviewers,profiler-reviewers,translations-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,toolkit-telemetry-reviewers,scunnane,robwu,owlish,nchevobbe,Gijs,sparky,mconley. 
Differential Revision: https://phabricator.services.mozilla.com/D261007
 2025-08-18 21:59:08 +00:00
Joel Maher b0a2bcee11 Bug 1976582 - Carry over android emulator annotations from api 24 to api 34. r=aryx,necko-reviewers,devtools-reviewers,nchevobbe,kershaw 
Differential Revision: https://phabricator.services.mozilla.com/D256730
 2025-07-11 19:02:18 +00:00
iulian moraru ddc73f5922 Revert "Bug 1976582 - Carry over android emulator annotations from api 24 to api 34. r=aryx,necko-reviewers,devtools-reviewers,nchevobbe,kershaw" for causing reftest failures on color_quads.html. 
This reverts commit e59ec21b7b.
 2025-07-11 14:15:07 +00:00
Joel Maher e59ec21b7b Bug 1976582 - Carry over android emulator annotations from api 24 to api 34. r=aryx,necko-reviewers,devtools-reviewers,nchevobbe,kershaw 
Differential Revision: https://phabricator.services.mozilla.com/D256730
 2025-07-11 12:43:35 +00:00
Gijs Kruitbosch 9c5be039df Bug 1971751 - update tests that misuse Assert.ok after no-comparison-or-assignment-inside-ok update, r=frontend-codestyle-reviewers,webdriver-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,cookie-reviewers,sessionstore-reviewers,tabbrowser-reviewers,places-reviewers,profiler-reviewers,omc-reviewers,migration-reviewers,home-newtab-reviewers,webcompat-reviewers,urlbar-reviewers,permissions-reviewers,firefox-ai-ml-reviewers,profiles-reviewers,robwu,julienw,bytesized,sthompson,valentin,jhirsch,markh,twisniewski,Standard8,dimi,nbarrett,mconley,timhuang 
Differential Revision: https://phabricator.services.mozilla.com/D253662
 2025-06-26 10:33:09 +00:00
agoloman fd1e9e499d Revert "Bug 1971751 - update no-comparison-or-assignment-inside-ok to also cover Assert.ok, r=frontend-codestyle-reviewers,Standard8" for causing lint failures @test_maybeCapExpiry.js. 
This reverts commit 2744165954.

Revert "Bug 1971751 - update tests that misuse Assert.ok after no-comparison-or-assignment-inside-ok update, r=frontend-codestyle-reviewers,webdriver-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,cookie-reviewers,sessionstore-reviewers,tabbrowser-reviewers,places-reviewers,profiler-reviewers,omc-reviewers,migration-reviewers,home-newtab-reviewers,webcompat-reviewers,urlbar-reviewers,permissions-reviewers,firefox-ai-ml-reviewers,profiles-reviewers,robwu,julienw,bytesized,sthompson,valentin,jhirsch,markh,twisniewski,Standard8,dimi,nbarrett,mconley,timhuang"

This reverts commit ba7298d756.

Revert "Bug 1971751 - manual test updates where linter autofix creates issues, r=frontend-codestyle-reviewers,Standard8"

This reverts commit e12e0d3181.
 2025-06-26 01:11:00 +00:00
Gijs Kruitbosch ba7298d756 Bug 1971751 - update tests that misuse Assert.ok after no-comparison-or-assignment-inside-ok update, r=frontend-codestyle-reviewers,webdriver-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,cookie-reviewers,sessionstore-reviewers,tabbrowser-reviewers,places-reviewers,profiler-reviewers,omc-reviewers,migration-reviewers,home-newtab-reviewers,webcompat-reviewers,urlbar-reviewers,permissions-reviewers,firefox-ai-ml-reviewers,profiles-reviewers,robwu,julienw,bytesized,sthompson,valentin,jhirsch,markh,twisniewski,Standard8,dimi,nbarrett,mconley,timhuang 
Differential Revision: https://phabricator.services.mozilla.com/D253662
 2025-06-26 00:07:43 +00:00
Mark Banner 3cc3379c8f Bug 1881701 - Change the devtools configurations to work with the ESLint flat configuration.r=devtools-reviewers,profiler-reviewers,julienw,nchevobbe 
This consolidates the jest environment definition, and the xpcshell globals into the devtools/.eslintrc.mjs file, for easier configurations.
It also changes the restart of the configurations to work with flat config.

Differential Revision: https://phabricator.services.mozilla.com/D249948
 2025-05-24 17:10:59 +00:00
Mark Banner d7c7c5369b Bug 1881701 - Rename many ESLint files to use .mjs. r=frontend-codestyle-reviewers,perftest-reviewers,Gijs,sparky,webcompat-reviewers,twisniewski 
This is separate to help preserve history of the files.

Differential Revision: https://phabricator.services.mozilla.com/D249945
 2025-05-24 17:10:51 +00:00
Julien Wajsberg b65e26de56 Bug 1581963 - [devtools] Add copyFromBuffer and copyToBuffer to the bulk packet r=ochameau,devtools-reviewers,profiler-reviewers,canaltinova 
Differential Revision: https://phabricator.services.mozilla.com/D250276
 2025-05-22 18:02:32 +00:00
Alexandre Poirot a7b0d37072 Bug 949595 - [devtools] Implement bulk requests in protocol.js. r=devtools-reviewers,nchevobbe 
This mimic what was only supported via legacy DevToolsClient.request() method (bug 797639).

Differential Revision: https://phabricator.services.mozilla.com/D245922
 2025-05-16 00:38:46 +00:00
Joel Maher ce1cae83af Bug 1959269 - clean and standardize devtools/**/xpcshell.toml. r=aryx,devtools-reviewers,ochameau 
Differential Revision: https://phabricator.services.mozilla.com/D244831
 2025-04-15 14:47:07 +00:00
Alexandre Poirot 32a09e4edb Bug 1955134 - [devtools] Display client and server RDP packet when a request fails. r=devtools-reviewers,nchevobbe 
Differential Revision: https://phabricator.services.mozilla.com/D242236
 2025-03-20 14:15:40 +00:00
Alexandre Poirot 055ade3146 Bug 1941886 - [devtools] Prompt user to fill bug with details on early exception during toolbox opening. r=devtools-reviewers,nchevobbe 
Also add a tweak to protocol.js in order to transfer the server side stack trace to the client.

Differential Revision: https://phabricator.services.mozilla.com/D234890
 2025-01-30 21:21:34 +00:00
Alexandre Poirot 2afc0db7b1 Bug 1921118 - [devtools] Introduce a connect method on the root actor to communicate the frontend version to the backend. r=devtools-reviewers,devtools-backward-compat-reviewers,jdescottes 
Differential Revision: https://phabricator.services.mozilla.com/D223648
 2024-10-14 12:24:22 +00:00
Alexandre Poirot a72f741d1f Bug 1921948 - [devtools] Use an immutable attribute instead of actorID to identify targets in the iframe dropdown. r=devtools-reviewers,bomsy 
With Web Extension, when the targets are destroyed, their front is destroyed
before being notified to the toolbox, which makes their `actorID` being null.
We should be using a safer attribute to uniquely identify them.

Differential Revision: https://phabricator.services.mozilla.com/D220669
 2024-10-07 09:52:07 +00:00
Dave Townsend 2af4d349f3 Bug 1864896: Autofix unused function arguments (devtools). r=profiler-reviewers,devtools-reviewers,nchevobbe,julienw 
Differential Revision: https://phabricator.services.mozilla.com/D202959
 2024-03-05 14:21:15 +00:00
Alexandre Poirot a5717331be Bug 1879087 - [devtools] Avoid exception on page reload with the tracer enabled. r=devtools-reviewers,nchevobbe 
For some unexplained reason, `conn` could be null.

Differential Revision: https://phabricator.services.mozilla.com/D201975
 2024-02-22 08:52:20 +00:00
Nicolas Chevobbe 2711398289 Bug 1864842 - [devtools] Remove devtools/shared/defer.js . r=devtools-reviewers,ochameau. 
This can now be replaced with native Promise.withResolvers,
so we can remove our custom implementation module.

Differential Revision: https://phabricator.services.mozilla.com/D198033
 2024-01-10 06:30:28 +00:00
Joel Maher cac31d18e3 Bug 1859873 - batch 13 xpcshell.ini -> .toml. r=aryx,devtools-reviewers,profiler-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D194161
 2023-11-21 12:32:50 +00:00
Mark Banner 0666077666 Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu 
Differential Revision: https://phabricator.services.mozilla.com/D177027
 2023-05-20 12:26:53 +00:00
Mark Banner 91fde42f7b Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish 
Differential Revision: https://phabricator.services.mozilla.com/D177025
 2023-05-20 12:26:49 +00:00
Alexandre Poirot fe2edc6770 Bug 1817729 - [devtools] Ensure computing Actor's requestTypes only once. r=jdescottes 
This complex object used to be computed only once per Class,
but this regressed to be computed once per Class instance.

Differential Revision: https://phabricator.services.mozilla.com/D170412
 2023-02-21 10:48:35 +00:00
Alexandre Poirot 8ae9b24f22 Bug 1816635 - [devtools] Move conn nullification to Pool. r=jdescottes 
So that it isn't only done for Actors, but also for all Fronts.

Differential Revision: https://phabricator.services.mozilla.com/D169800
 2023-02-14 14:47:17 +00:00
Alexandre Poirot 44e5012d2c Bug 1813648 - [devtools] Remove ActorClassWithSpec and all its dependencies. r=devtools-reviewers,jdescottes 
Some actors weren't using any specification. They now have to pass a bare minimal spec object.
Unifying them to the regular Actor interface helps merging constructor with initialize
and instantiate all the actors without any code branch.

Differential Revision: https://phabricator.services.mozilla.com/D169359
 2023-02-14 10:34:19 +00:00
Alexandre Poirot a6ffe0d5fb Bug 1813477 - [devtools] Convert all tests still using ActorClassWithSpec. r=devtools-reviewers,perftest-reviewers,jdescottes,sparky 
Differential Revision: https://phabricator.services.mozilla.com/D169358
 2023-02-14 10:34:19 +00:00