HeyPuter/firefox
1
0 Fork 0
mirror of https://github.com/HeyPuter/firefox.git synced 2026-11-13 20:14:57 -10:00
Code Issues Packages Projects Releases Wiki Activity
976,508 Commits 2 Branches 0 Tags
singlethreaded
Commit Graph
49 Commits
Author SHA1 Message Date
Lorenz A 1f0813b5a9 Bug 2004212 - [devtools] Turn devtools/shared/protocol/tests/xpcshell/head.js into an ES class. r=devtools-reviewers,nchevobbe 
Differential Revision: https://phabricator.services.mozilla.com/D275473
 2025-12-08 22:32:55 +00:00
Tom Marble 5ce09d7446 Bug 1995583 - test manifest cleanup for idiomatic usage r=jmaher,necko-reviewers,webcompat-reviewers,geckoview-reviewers,application-update-reviewers,media-playback-reviewers,sessionstore-reviewers,tabbrowser-reviewers,translations-reviewers,omc-reviewers,browser-installer-reviewers,twisniewski,masayuki,dom-core,smaug,nalexander,emcminn,sthompson,alwu,ai-ondevice-reviewers,valentin 
For TOML manifests:

1. Change processor -> arch
2. Use arch instead of bits bits == '64' =>
   aarch64 (default on mac 15.30) or x86_64 bits == '32' => x86
3. Replace android_version with corresponding os_version
4. Remove conditions with linux os_version=="18.04"
   (unless they contain verify or verify-standalone)
5. Remove conditions with mac os_version=='11.20',
   (unless they contain verify or verify-standalone)
6. Remove conditions with win os_version=='11.2009' or win11_2009,
   (unless they contain verify or verify-standalone)
7. Linux conditions should have os_version, arch and display
   (simple "os == 'linux'" will get expanded to these two)
   "os == 'linux' && os_version == '22.04' && arch == 'x86_64' && display == 'wayland'"
   "os == 'linux' && os_version == '24.04' && arch == 'x86_64' && display == 'x11'"
8. Mac conditions should have os_version and arch
   (simple "os == 'mac'" will get expanded to these three)
   "os == 'mac' && os_version == '10.15' && arch == 'x86_64'",
   "os == 'mac' && os_version == '14.70' && arch == 'x86_64'",
   "os == 'mac' && os_version == '15.30' && arch == 'aarch64'",
9. Replace apple_catalina with
   os == 'mac' && os_version == '10.15' && arch == 'x86_64'
10. Replace apple_silicon with
   os == 'mac' && os_version = '15.30' && arch == 'aarch64'
11. Replace win10_2009 with
   os == 'win' && os_version = '10.2009' && arch == 'x86_64'
12. Replace "!debug" with three conditions "asan", "opt", or "tsan"
13. Replace literal boolean comparison with variables
    (e.g. "debug == false" => "!debug)

Resolves 2000285

Signed-off-by: Tom Marble <[email protected]>

Differential Revision: https://phabricator.services.mozilla.com/D272815
 2025-11-22 00:30:39 +00:00
Nicolas Chevobbe da35303962 Bug 1599082 - [devtools] Remove external usage of static EventEmitter methods. r=devtools-reviewers,jdescottes. 
Replace those with inheritance/decorations, extends classes that needed it.
Next patch in stack will remove the static methods alltogether.

Differential Revision: https://phabricator.services.mozilla.com/D267589
 2025-10-07 05:37:53 +00:00
Joel Maher b0a2bcee11 Bug 1976582 - Carry over android emulator annotations from api 24 to api 34. r=aryx,necko-reviewers,devtools-reviewers,nchevobbe,kershaw 
Differential Revision: https://phabricator.services.mozilla.com/D256730
 2025-07-11 19:02:18 +00:00
iulian moraru ddc73f5922 Revert "Bug 1976582 - Carry over android emulator annotations from api 24 to api 34. r=aryx,necko-reviewers,devtools-reviewers,nchevobbe,kershaw" for causing reftest failures on color_quads.html. 
This reverts commit e59ec21b7b.
 2025-07-11 14:15:07 +00:00
Joel Maher e59ec21b7b Bug 1976582 - Carry over android emulator annotations from api 24 to api 34. r=aryx,necko-reviewers,devtools-reviewers,nchevobbe,kershaw 
Differential Revision: https://phabricator.services.mozilla.com/D256730
 2025-07-11 12:43:35 +00:00
Gijs Kruitbosch 9c5be039df Bug 1971751 - update tests that misuse Assert.ok after no-comparison-or-assignment-inside-ok update, r=frontend-codestyle-reviewers,webdriver-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,cookie-reviewers,sessionstore-reviewers,tabbrowser-reviewers,places-reviewers,profiler-reviewers,omc-reviewers,migration-reviewers,home-newtab-reviewers,webcompat-reviewers,urlbar-reviewers,permissions-reviewers,firefox-ai-ml-reviewers,profiles-reviewers,robwu,julienw,bytesized,sthompson,valentin,jhirsch,markh,twisniewski,Standard8,dimi,nbarrett,mconley,timhuang 
Differential Revision: https://phabricator.services.mozilla.com/D253662
 2025-06-26 10:33:09 +00:00
agoloman fd1e9e499d Revert "Bug 1971751 - update no-comparison-or-assignment-inside-ok to also cover Assert.ok, r=frontend-codestyle-reviewers,Standard8" for causing lint failures @test_maybeCapExpiry.js. 
This reverts commit 2744165954.

Revert "Bug 1971751 - update tests that misuse Assert.ok after no-comparison-or-assignment-inside-ok update, r=frontend-codestyle-reviewers,webdriver-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,cookie-reviewers,sessionstore-reviewers,tabbrowser-reviewers,places-reviewers,profiler-reviewers,omc-reviewers,migration-reviewers,home-newtab-reviewers,webcompat-reviewers,urlbar-reviewers,permissions-reviewers,firefox-ai-ml-reviewers,profiles-reviewers,robwu,julienw,bytesized,sthompson,valentin,jhirsch,markh,twisniewski,Standard8,dimi,nbarrett,mconley,timhuang"

This reverts commit ba7298d756.

Revert "Bug 1971751 - manual test updates where linter autofix creates issues, r=frontend-codestyle-reviewers,Standard8"

This reverts commit e12e0d3181.
 2025-06-26 01:11:00 +00:00
Gijs Kruitbosch ba7298d756 Bug 1971751 - update tests that misuse Assert.ok after no-comparison-or-assignment-inside-ok update, r=frontend-codestyle-reviewers,webdriver-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,cookie-reviewers,sessionstore-reviewers,tabbrowser-reviewers,places-reviewers,profiler-reviewers,omc-reviewers,migration-reviewers,home-newtab-reviewers,webcompat-reviewers,urlbar-reviewers,permissions-reviewers,firefox-ai-ml-reviewers,profiles-reviewers,robwu,julienw,bytesized,sthompson,valentin,jhirsch,markh,twisniewski,Standard8,dimi,nbarrett,mconley,timhuang 
Differential Revision: https://phabricator.services.mozilla.com/D253662
 2025-06-26 00:07:43 +00:00
Mark Banner 3cc3379c8f Bug 1881701 - Change the devtools configurations to work with the ESLint flat configuration.r=devtools-reviewers,profiler-reviewers,julienw,nchevobbe 
This consolidates the jest environment definition, and the xpcshell globals into the devtools/.eslintrc.mjs file, for easier configurations.
It also changes the restart of the configurations to work with flat config.

Differential Revision: https://phabricator.services.mozilla.com/D249948
 2025-05-24 17:10:59 +00:00
Mark Banner d7c7c5369b Bug 1881701 - Rename many ESLint files to use .mjs. r=frontend-codestyle-reviewers,perftest-reviewers,Gijs,sparky,webcompat-reviewers,twisniewski 
This is separate to help preserve history of the files.

Differential Revision: https://phabricator.services.mozilla.com/D249945
 2025-05-24 17:10:51 +00:00
Joel Maher ce1cae83af Bug 1959269 - clean and standardize devtools/**/xpcshell.toml. r=aryx,devtools-reviewers,ochameau 
Differential Revision: https://phabricator.services.mozilla.com/D244831
 2025-04-15 14:47:07 +00:00
Alexandre Poirot 2afc0db7b1 Bug 1921118 - [devtools] Introduce a connect method on the root actor to communicate the frontend version to the backend. r=devtools-reviewers,devtools-backward-compat-reviewers,jdescottes 
Differential Revision: https://phabricator.services.mozilla.com/D223648
 2024-10-14 12:24:22 +00:00
Dave Townsend 2af4d349f3 Bug 1864896: Autofix unused function arguments (devtools). r=profiler-reviewers,devtools-reviewers,nchevobbe,julienw 
Differential Revision: https://phabricator.services.mozilla.com/D202959
 2024-03-05 14:21:15 +00:00
Joel Maher cac31d18e3 Bug 1859873 - batch 13 xpcshell.ini -> .toml. r=aryx,devtools-reviewers,profiler-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D194161
 2023-11-21 12:32:50 +00:00
Mark Banner 0666077666 Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu 
Differential Revision: https://phabricator.services.mozilla.com/D177027
 2023-05-20 12:26:53 +00:00
Mark Banner 91fde42f7b Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish 
Differential Revision: https://phabricator.services.mozilla.com/D177025
 2023-05-20 12:26:49 +00:00
Alexandre Poirot 44e5012d2c Bug 1813648 - [devtools] Remove ActorClassWithSpec and all its dependencies. r=devtools-reviewers,jdescottes 
Some actors weren't using any specification. They now have to pass a bare minimal spec object.
Unifying them to the regular Actor interface helps merging constructor with initialize
and instantiate all the actors without any code branch.

Differential Revision: https://phabricator.services.mozilla.com/D169359
 2023-02-14 10:34:19 +00:00
Alexandre Poirot a6ffe0d5fb Bug 1813477 - [devtools] Convert all tests still using ActorClassWithSpec. r=devtools-reviewers,perftest-reviewers,jdescottes,sparky 
Differential Revision: https://phabricator.services.mozilla.com/D169358
 2023-02-14 10:34:19 +00:00
Alexandre Poirot bde84f5b65 Bug 1793604 - [devtools] Convert Loader.jsm to ESM. r=perftest-reviewers,geckoview-reviewers,preferences-reviewers,owlish,kshampur,jdescottes 
Differential Revision: https://phabricator.services.mozilla.com/D158582
 2022-10-14 12:19:42 +00:00
Alexandre Poirot 07e6ce0083 Bug 1792848 - [devtools] Use absolute URLs to import modules in devtools/shared. r=Honza,devtools-backward-compat-reviewers,bomsy 
Differential Revision: https://phabricator.services.mozilla.com/D158643
 2022-10-12 15:56:22 +00:00
Alexandre Poirot 0f32f335e3 Bug 1789201 - [devtools] Expose Services as a global to all DevTools modules. r=perftest-reviewers,nchevobbe,julienw,AlexandruIonescu 
This will help transition to ES Modules as this symbol is exposed to them.

$ sed -ie "/require(.Services.)/d" $(git grep -l 'require("Services")' devtools/)
$ sed -ie "/loader.lazyRequireGetter(this, .Services./d" $(git grep -l 'loader.lazyRequireGetter(this, "Services"' devtools/)
+ the edition of builtin-modules.js + eslintrc.js
+ manual eslint fixes
+ removal of devtools-services in the debugger, except for jest tests

Differential Revision: https://phabricator.services.mozilla.com/D156401
 2022-09-09 07:22:51 +00:00
Mark Banner 6d03c63e2d Bug 1330099 - Enable object-shorthand eslint rule. r=jdescottes 
Differential Revision: https://phabricator.services.mozilla.com/D153567
 2022-08-03 14:57:05 +00:00
Julian Descottes 06b42b006a Bug 1741369 - [devtools] Update paths to loader files in devtools/ r=ochameau 
Depends on D131216

Differential Revision: https://phabricator.services.mozilla.com/D131217
 2021-11-17 12:43:26 +00:00
Alexandre Poirot d48123ef45 Bug 1726238 - [devtools] Fix browser_toolbox_backward_forward_navigation.js intermittent failure. r=bomsy 
Inspector fronts initialization is still pending while we navigate away to another top target.
Leading to various possible exception in protocol.js.
I'm adding a set of new explicit exception in order to help debugging all these cases.

Differential Revision: https://phabricator.services.mozilla.com/D123441
 2021-09-01 08:30:23 +00:00
Julian Descottes b4379f28ba Bug 1717580 - [devtools] Actor/Front isDestroyed should not return true for uninitialized objects r=ochameau 
Differential Revision: https://phabricator.services.mozilla.com/D118469
 2021-06-23 15:28:33 +00:00
Alexandre Poirot 3c4356b16b Bug 1699111 - [devtools] Rename transports onClosed callback to onTransportClosed. r=jdescottes 
This will better highlight what is closing. Not the DevToolsClient, but just the transport class.

Differential Revision: https://phabricator.services.mozilla.com/D108812
 2021-04-13 13:44:24 +00:00
Alexandre Poirot ce54040455 Bug 1631451 - [devtools] Prevent re-entrant destroy loop in Pool.destroy. r=jdescottes 
Differential Revision: https://phabricator.services.mozilla.com/D110097
 2021-04-01 13:43:58 +00:00
bfmags 676c844cd1 Bug 1681894 - Remove unused defer require from devtools/shared/protocol/tests/xpcshell/head.js. r=ntim 
Differential Revision: https://phabricator.services.mozilla.com/D100500
 2020-12-28 16:10:08 +00:00
Julian Descottes 46b1e8a024 Bug 1673897 - [devtools] Throw if a spec method defines an array return value r=ochameau 
Depends on D96940

Differential Revision: https://phabricator.services.mozilla.com/D96941
 2020-12-02 14:35:53 +00:00
Julian Descottes 1008bc0c03 Bug 1673897 - [devtools] Stop using arrays as return values for rdp responses r=ochameau,devtools-backward-compat-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D96940
 2020-12-02 14:35:46 +00:00
Andrey Bienkowski c5d43b4b60 Bug 1674841 - [devtools] Clean up devtools/shared/protocol/tests/xpcshell/test_protocol_async.js r=nchevobbe 
Differential Revision: https://phabricator.services.mozilla.com/D95553
 2020-11-10 12:55:29 +00:00
Julian Descottes ec70eaf5f2 Bug 1674357 - [devtools] Remove lifetime from DevTools protocol r=ochameau,devtools-backward-compat-reviewers 
Depends on D95299

The lifetime feature seems unused in DevTools. Removing it should have no impact.

Differential Revision: https://phabricator.services.mozilla.com/D95302
 2020-11-03 16:43:52 +00:00
Alexandre Poirot 0b6fdaf74e Bug 1620248 - [devtools] Make hooks.onClosed optional for all Transport classes. r=nchevobbe 
Differential Revision: https://phabricator.services.mozilla.com/D93193
 2020-10-22 10:02:34 +00:00
Ben Delevingne 49c63c1905 Bug 1672347 - remove defer from devtools/shared/discovery/tests/xpcshell. r=Honza 
Differential Revision: https://phabricator.services.mozilla.com/D94283
 2020-10-21 10:59:32 +00:00
Logan Smyth 2746f14953 Bug 1601179 - Enable async stacks but limit captured async stacks to debuggees. r=jorendorff,smaug 
The 'asyncStack' flag on JS execution contexts is used as a general switch
to enable async stack capture across all locations in SpiderMonkey, but
this causes problems because it can at times be too much of a performance
burden to general and track all of these stacks.

Since the introduction of this option, we have only enabled it on Nightly
and DevEdition for non-mobile builds, which has left a lot of users unable
to take advantage of this data while debugging.

This patch enables async stack traces across all of Firefox, but introduces
a new pref to toggle the scope of the actual expensive part of async stacks,
which is _capturing_ them and keeping them alive in memory. The new pref
limits the capturing of async stack traces to only debuggees, unless an
explicit pref is flipped to capture async traces for all cases.

This means that while async stacks are technically enabled, and code could
manually capture a stack and pass it back to SpiderMonkey and see that stack
reflected in later captured stacks, SpiderMonkey itself and related async
DOM APIs, among others, will not capture stacks or pass them to SpiderMonkey,
so there should be no general change in performance by enabling the broader
feature itself, unless the user is actively debugging the page.

One effect of this patch is that if you have the debugger open and then close
it, objects that have async stacks associated with them will retain those
stacks and they will continue to show up in stack traces, no _new_ stacks
will be captured. jorendorff and I have decided that this is okay because
the expectation that the debugger fully revert every possible effect that it
could have on a page is a nice goal but not a strict requirement.

Differential Revision: https://phabricator.services.mozilla.com/D68503
 2020-06-14 02:41:45 +00:00
Julian Descottes edb7e1459b Bug 1625495 - Remove devtools/shared/client folder r=daisuke,ochameau,nchevobbe 
Depends on D68599

This changeset moves devtools-client.js and constants.js to devtools/client and removes devtools/shared/client

Differential Revision: https://phabricator.services.mozilla.com/D68600
 2020-03-31 08:36:29 +00:00
Julian Descottes 7e4ee510bf Bug 1604539 - Rename shared/fronts to client/fronts in the devtools codebase r=nchevobbe 
Depends on D67603
This patch is an automated string replace of shared/fronts/ to client/fronts/ in devtools.

Differential Revision: https://phabricator.services.mozilla.com/D67604
 2020-03-20 13:58:56 +00:00
Bogdan Tara cc5d7d8232 Backed out 5 changesets (bug 1604539) for xpc failures complanining about test_encryption.js CLOSED TREE 
Backed out changeset 8455e50002a9 (bug 1604539)
Backed out changeset fb410a1bf9aa (bug 1604539)
Backed out changeset da94f7d503a1 (bug 1604539)
Backed out changeset b4b54335ee2d (bug 1604539)
Backed out changeset 866d6794bbba (bug 1604539)
 2020-03-20 15:53:23 +02:00
Julian Descottes 0cac844f0c Bug 1604539 - Rename shared/fronts to client/fronts in the devtools codebase r=nchevobbe 
Depends on D67603
This patch is an automated string replace of shared/fronts/ to client/fronts/ in devtools.

Differential Revision: https://phabricator.services.mozilla.com/D67604
 2020-03-20 12:57:58 +00:00
Nicolas Chevobbe 8648a90536 Bug 1620288 - Rename Pool#parent to getParent. r=ochameau. 
This makes it more obvious that it's a function, and not
a property.

Differential Revision: https://phabricator.services.mozilla.com/D66603
 2020-03-16 17:34:32 +00:00
Nicolas Chevobbe 3fb22af2db Bug 1622005 - Make RootFront more protocol.js-y .r=ochameau. 
This patch make it so the RootFront is created from its spec file,
like any other front.

Protocol xpcshell tests are modified to take these changes into account.

Differential Revision: https://phabricator.services.mozilla.com/D66597
 2020-03-16 17:29:25 +00:00
Jason Laster 7eb986e407 Bug 1620025 - Improve source front management. r=ochameau 
Differential Revision: https://phabricator.services.mozilla.com/D65803
 2020-03-13 20:04:49 +00:00
Tom Schuster b26dd8a1d2 Bug 1619177 - Fix two tests outside js/. r=jdescottes,zombie 
For test_protocol_stack we now generate a different function name like
onConnect/>. This happens because the test doesn't execute with strict mode
anymore, which would inhibit lazy parsing. With lazy parsing we get
different function naming ..

option("strict") will throw now.

Differential Revision: https://phabricator.services.mozilla.com/D65833
 2020-03-10 22:59:49 +00:00
Mark Banner d375cfec54 Bug 1620542 - Automatically fix ESLint errors in .eslintrc.js files. r=mossop 
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D65703
 2020-03-07 10:09:44 +00:00
Alexandre Poirot 35634f4f44 Bug 1614792 - Rename DebuggerClient to DevToolsClient. r=jdescottes 
Differential Revision: https://phabricator.services.mozilla.com/D62495
 2020-02-17 13:39:25 +00:00
Alexandre Poirot 1ea1a546f1 Bug 1614791 - Rename DebuggerServer to DevToolsServer. r=jdescottes 
Differential Revision: https://phabricator.services.mozilla.com/D61363
 2020-02-17 10:28:24 +00:00
Alexandre Poirot 6ef4a7bf63 Bug 1609128 - Implement polymorphism in protocol.js r=jdescottes 
Differential Revision: https://phabricator.services.mozilla.com/D59333
 2020-01-16 16:47:01 +00:00
Alexandre Poirot 31f7ee716c Bug 1609128 - Move all protocol.js tests next to its implementation. r=jdescottes 
Differential Revision: https://phabricator.services.mozilla.com/D59866
 2020-01-16 16:46:53 +00:00