Alexandre Poirot
3af4a6d2ad
Bug 1622857 - [devtools] Use MOZ_LOG to trace RDP packets in tests. r=devtools-reviewers,nchevobbe
...
Also remove disabled/commented logging.
You may use "--env MOZ_LOG=devtools_rdp:3" to trace RDP packets on try runs.
Some tests are still toggling the old preference as they may want to
trace other usages of dumpn/dumpv.
Differential Revision: https://phabricator.services.mozilla.com/D299055
2026-05-18 09:12:29 +00:00
Sylvestre Ledru
074b376055
Bug 2023419 - Remove Emacs/Vim modelines from devtools/ r=emilio,devtools-backward-compat-reviewers,devtools-reviewers,nchevobbe
...
replaced by .editorconfig
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D287841
2026-03-28 10:21:10 +00:00
Alexandru Marc
630e6cf0e8
Revert "Bug 2023419 - Remove Emacs/Vim modelines from devtools/ r=emilio,devtools-backward-compat-reviewers,devtools-reviewers,nchevobbe" for causing devtools failures
...
This reverts commit ed535dace9 .
2026-03-17 12:46:01 +00:00
Sylvestre Ledru
ed535dace9
Bug 2023419 - Remove Emacs/Vim modelines from devtools/ r=emilio,devtools-backward-compat-reviewers,devtools-reviewers,nchevobbe
...
replaced by .editorconfig
Differential Revision: https://phabricator.services.mozilla.com/D287841
2026-03-17 12:03:34 +00:00
Lorenz A
1f5b7af922
Bug 2004229 - [devtools] Turn devtools/shared/security/socket.js into an ES class. r=devtools-reviewers,nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D276566
2025-12-16 08:46:05 +00:00
Lorenz A
e1e2f73357
Bug 2004230 - [devtools] Turn devtools/shared/security/auth.js into an ES class. r=devtools-reviewers,bomsy
...
Differential Revision: https://phabricator.services.mozilla.com/D275634
2025-12-11 07:13:59 +00:00
Tom Marble
5ce09d7446
Bug 1995583 - test manifest cleanup for idiomatic usage r=jmaher,necko-reviewers,webcompat-reviewers,geckoview-reviewers,application-update-reviewers,media-playback-reviewers,sessionstore-reviewers,tabbrowser-reviewers,translations-reviewers,omc-reviewers,browser-installer-reviewers,twisniewski,masayuki,dom-core,smaug,nalexander,emcminn,sthompson,alwu,ai-ondevice-reviewers,valentin
...
For TOML manifests:
1. Change processor -> arch
2. Use arch instead of bits bits == '64' =>
aarch64 (default on mac 15.30) or x86_64 bits == '32' => x86
3. Replace android_version with corresponding os_version
4. Remove conditions with linux os_version=="18.04"
(unless they contain verify or verify-standalone)
5. Remove conditions with mac os_version=='11.20',
(unless they contain verify or verify-standalone)
6. Remove conditions with win os_version=='11.2009' or win11_2009,
(unless they contain verify or verify-standalone)
7. Linux conditions should have os_version, arch and display
(simple "os == 'linux'" will get expanded to these two)
"os == 'linux' && os_version == '22.04' && arch == 'x86_64' && display == 'wayland'"
"os == 'linux' && os_version == '24.04' && arch == 'x86_64' && display == 'x11'"
8. Mac conditions should have os_version and arch
(simple "os == 'mac'" will get expanded to these three)
"os == 'mac' && os_version == '10.15' && arch == 'x86_64'",
"os == 'mac' && os_version == '14.70' && arch == 'x86_64'",
"os == 'mac' && os_version == '15.30' && arch == 'aarch64'",
9. Replace apple_catalina with
os == 'mac' && os_version == '10.15' && arch == 'x86_64'
10. Replace apple_silicon with
os == 'mac' && os_version = '15.30' && arch == 'aarch64'
11. Replace win10_2009 with
os == 'win' && os_version = '10.2009' && arch == 'x86_64'
12. Replace "!debug" with three conditions "asan", "opt", or "tsan"
13. Replace literal boolean comparison with variables
(e.g. "debug == false" => "!debug)
Resolves 2000285
Signed-off-by: Tom Marble <[email protected] >
Differential Revision: https://phabricator.services.mozilla.com/D272815
2025-11-22 00:30:39 +00:00
Mark Banner
b38cd3110b
Bug 1999554 - Automatically fix ESLint rule jsdoc/check-types for devtools/. r=devtools-reviewers,devtools-backward-compat-reviewers,profiler-reviewers,canaltinova
...
Differential Revision: https://phabricator.services.mozilla.com/D272173
2025-11-21 16:16:08 +00:00
Mark Banner
2542790f53
Bug 1998787 - Automatic fixes for enabling ESLint jsdoc/tag-line rule everywhere. r=frontend-codestyle-reviewers,mtigley,perftest-reviewers,nchevobbe,home-newtab-reviewers,Gijs,mconley,sparky
...
Differential Revision: https://phabricator.services.mozilla.com/D271745
2025-11-10 21:27:12 +00:00
Joel Maher
b0a2bcee11
Bug 1976582 - Carry over android emulator annotations from api 24 to api 34. r=aryx,necko-reviewers,devtools-reviewers,nchevobbe,kershaw
...
Differential Revision: https://phabricator.services.mozilla.com/D256730
2025-07-11 19:02:18 +00:00
iulian moraru
ddc73f5922
Revert "Bug 1976582 - Carry over android emulator annotations from api 24 to api 34. r=aryx,necko-reviewers,devtools-reviewers,nchevobbe,kershaw" for causing reftest failures on color_quads.html.
...
This reverts commit e59ec21b7b .
2025-07-11 14:15:07 +00:00
Joel Maher
e59ec21b7b
Bug 1976582 - Carry over android emulator annotations from api 24 to api 34. r=aryx,necko-reviewers,devtools-reviewers,nchevobbe,kershaw
...
Differential Revision: https://phabricator.services.mozilla.com/D256730
2025-07-11 12:43:35 +00:00
Mark Banner
3cc3379c8f
Bug 1881701 - Change the devtools configurations to work with the ESLint flat configuration.r=devtools-reviewers,profiler-reviewers,julienw,nchevobbe
...
This consolidates the jest environment definition, and the xpcshell globals into the devtools/.eslintrc.mjs file, for easier configurations.
It also changes the restart of the configurations to work with flat config.
Differential Revision: https://phabricator.services.mozilla.com/D249948
2025-05-24 17:10:59 +00:00
Mark Banner
d7c7c5369b
Bug 1881701 - Rename many ESLint files to use .mjs. r=frontend-codestyle-reviewers,perftest-reviewers,Gijs,sparky,webcompat-reviewers,twisniewski
...
This is separate to help preserve history of the files.
Differential Revision: https://phabricator.services.mozilla.com/D249945
2025-05-24 17:10:51 +00:00
Joel Maher
ce1cae83af
Bug 1959269 - clean and standardize devtools/**/xpcshell.toml. r=aryx,devtools-reviewers,ochameau
...
Differential Revision: https://phabricator.services.mozilla.com/D244831
2025-04-15 14:47:07 +00:00
Logan Rosen
d24c9d9ff4
Bug 1857834 - auto-formatting with Prettier v3 r=linter-reviewers,webdriver-reviewers,perftest-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,reusable-components-reviewers,profiler-reviewers,dom-storage-reviewers,android-reviewers,firefox-ai-ml-reviewers,hjones,mcheang,mstange,sparky,janv,nchevobbe,tarek,Standard8,markh
...
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D230598
2024-11-29 15:18:25 +00:00
Alexandre Poirot
eeadbc4866
Bug 1651518 - [devtools] Ensure spawning DistinctSystemPrincipalLoader.sys.mjs only once. r=devtools-reviewers,nchevobbe
...
This is important to spawn this ESM only once between regular and browser toolbox,
and especially between various callsites used by the browser toolbox.
Otherwise we may start loading modules in two distinct system loaders
and may have inconsistancies when using `instanceof`.
Differential Revision: https://phabricator.services.mozilla.com/D207432
2024-05-27 09:53:54 +00:00
Cristian Tuns
d0272b92b7
Backed out 8 changesets (bug 1651518, bug 1883847) dt failures in nsTArray.h. CLOSED TREE
...
Backed out changeset 481558275c1d (bug 1651518)
Backed out changeset 5337435e8bca (bug 1651518)
Backed out changeset 8fe0c1a4da7f (bug 1651518)
Backed out changeset 840a0d9db260 (bug 1651518)
Backed out changeset eaab9de5819d (bug 1651518)
Backed out changeset cf71de92d782 (bug 1651518)
Backed out changeset d778691464db (bug 1651518)
Backed out changeset af28e5f719e8 (bug 1883847)
2024-05-22 09:02:19 -04:00
Alexandre Poirot
34e5032104
Bug 1651518 - [devtools] Ensure spawning DistinctSystemPrincipalLoader.sys.mjs only once. r=devtools-reviewers,nchevobbe
...
This is important to spawn this ESM only once between regular and browser toolbox,
and especially between various callsites used by the browser toolbox.
Otherwise we may start loading modules in two distinct system loaders
and may have inconsistancies when using `instanceof`.
Differential Revision: https://phabricator.services.mozilla.com/D207432
2024-05-22 11:50:44 +00:00
Cristina Horotan
ca70119cfa
Backed out 8 changesets (bug 1651518, bug 1883847) for causing damp failures at toolbox/browser-toolbox.js CLOSED TREE
...
Backed out changeset 4ec70db12f48 (bug 1651518)
Backed out changeset b2b138889ad6 (bug 1651518)
Backed out changeset efda5c09b0ea (bug 1651518)
Backed out changeset b0de4113f8fb (bug 1651518)
Backed out changeset 03cf235d2a80 (bug 1651518)
Backed out changeset 58e71c27f1fd (bug 1651518)
Backed out changeset f7fb390c3965 (bug 1651518)
Backed out changeset b8a2473c47c0 (bug 1883847)
2024-05-22 04:00:53 +03:00
Alexandre Poirot
3d2406db93
Bug 1651518 - [devtools] Ensure spawning DistinctSystemPrincipalLoader.sys.mjs only once. r=devtools-reviewers,nchevobbe
...
This is important to spawn this ESM only once between regular and browser toolbox,
and especially between various callsites used by the browser toolbox.
Otherwise we may start loading modules in two distinct system loaders
and may have inconsistancies when using `instanceof`.
Differential Revision: https://phabricator.services.mozilla.com/D207432
2024-05-21 14:09:33 +00:00
Tooru Fujisawa
0791e8d3c4
Bug 1875639 - Part 1: Use global option instead of loadInDevToolsLoader option. r=ochameau,devtools-reviewers
...
global option supercedes loadInDevToolsLoader, with omitting the
implicit contextual loader behavior.
In order to make the API less error-prone, use global option, with requireing
global option in DevTools global, to choose from shared global or explicit
contextual loader.
Differential Revision: https://phabricator.services.mozilla.com/D199466
2024-02-20 04:49:57 +00:00
Joel Maher
cac31d18e3
Bug 1859873 - batch 13 xpcshell.ini -> .toml. r=aryx,devtools-reviewers,profiler-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D194161
2023-11-21 12:32:50 +00:00
Tom Marble
d70780c99c
Bug 1850545 - convert .ini manifests to .toml: batch 3 chrome.ini (bis) r=jmaher,geckoview-reviewers,extension-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,places-reviewers,profiler-reviewers,m_kato,mak,mtigley
...
Differential Revision: https://phabricator.services.mozilla.com/D187597
2023-09-13 18:28:32 +00:00
Mark Banner
91fde42f7b
Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish
...
Differential Revision: https://phabricator.services.mozilla.com/D177025
2023-05-20 12:26:49 +00:00
Alexandre Poirot
dd2ec2e844
Bug 1814013 - [devtools] Remove test-only echo request from the root actor. r=devtools-reviewers,devtools-backward-compat-reviewers,nchevobbe
...
This wasn't so trivial to revisit tests, but at least we stop shipping test-only
features in RDP. And the cryptic echo implement now only exists in tests.
Differential Revision: https://phabricator.services.mozilla.com/D168360
2023-02-07 10:36:59 +00:00
Julian Descottes
3b13369671
Bug 1808252 - [devtools] Load DevToolsSocketStatus in the shared global instead of the devtools global r=ochameau
...
Differential Revision: https://phabricator.services.mozilla.com/D165840
2023-01-03 14:52:09 +00:00
Alexandre Poirot
bde84f5b65
Bug 1793604 - [devtools] Convert Loader.jsm to ESM. r=perftest-reviewers,geckoview-reviewers,preferences-reviewers,owlish,kshampur,jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D158582
2022-10-14 12:19:42 +00:00
Alexandre Poirot
07e6ce0083
Bug 1792848 - [devtools] Use absolute URLs to import modules in devtools/shared. r=Honza,devtools-backward-compat-reviewers,bomsy
...
Differential Revision: https://phabricator.services.mozilla.com/D158643
2022-10-12 15:56:22 +00:00
Alexandre Poirot
c6cf5fdf86
Bug 1793573 - [devtools] Convert DevToolsSocketStatus.jsm to DevToolsSocketStatus.sys.mjs. r=Honza
...
Differential Revision: https://phabricator.services.mozilla.com/D158572
2022-10-05 16:07:25 +00:00
Alexandre Poirot
59fe57c052
Bug 1793396 - [devtools] Use absolute URLs in all usages of loader.lazyRequireGetter. r=Honza
...
Differential Revision: https://phabricator.services.mozilla.com/D158489
2022-10-03 18:57:13 +00:00
Alexandre Poirot
450d14d375
Bug 1793395 - [devtools] Use absolute URLs for all custom loader's require. r=Honza
...
Differential Revision: https://phabricator.services.mozilla.com/D158488
2022-10-03 18:57:12 +00:00
Alexandre Poirot
acb64f5211
Bug 1791969 - [devtools] Migrate lazyRequireGetter for JSM to ChromeUtils.defineModuleGetter. r=jdescottes
...
There was some imports of sys.mjs which I migrated to `ChromeUtils.defineESModuleGetters`.
Differential Revision: https://phabricator.services.mozilla.com/D158129
2022-09-28 16:20:08 +00:00
Alexandre Poirot
0c4e317914
Bug 1789980 - [devtools] Migrate all callsites using require("chrome") to use Components.* global symbols. r=jdescottes,perftest-reviewers,AlexandruIonescu
...
This will help transition to ES Modules as we won't be able to expose a magic "chrome" ESM.
Also, most of these symbols are exposed as global already.
All but:
* `components` which is `Components`,
* `CC` which is `Components.Constructor`,
* `Cm` which is `Components.manager`.
$ sed -ie "/require(.chrome.)/d" $(git grep -l 'require("chrome")' devtools/)
+ manual edits for all three exceptions
Differential Revision: https://phabricator.services.mozilla.com/D156936
2022-09-20 12:52:27 +00:00
Julian Descottes
41bc0c5d10
Bug 1790753 - [devtools] Track all devtools sockets in DevToolsSocketStatus r=ochameau,Gijs
...
The DevToolsSocketStatus could be misleading for any usage other than the current one from browser.js since it misses browser toolbox sockets
This patch allows the singleton to track all sockets but changes the API to allow consumers to exclude browser toolbox sockets.
Differential Revision: https://phabricator.services.mozilla.com/D157300
2022-09-14 19:11:22 +00:00
Alexandre Poirot
0f32f335e3
Bug 1789201 - [devtools] Expose Services as a global to all DevTools modules. r=perftest-reviewers,nchevobbe,julienw,AlexandruIonescu
...
This will help transition to ES Modules as this symbol is exposed to them.
$ sed -ie "/require(.Services.)/d" $(git grep -l 'require("Services")' devtools/)
$ sed -ie "/loader.lazyRequireGetter(this, .Services./d" $(git grep -l 'loader.lazyRequireGetter(this, "Services"' devtools/)
+ the edition of builtin-modules.js + eslintrc.js
+ manual eslint fixes
+ removal of devtools-services in the debugger, except for jest tests
Differential Revision: https://phabricator.services.mozilla.com/D156401
2022-09-09 07:22:51 +00:00
Mark Banner
6d03c63e2d
Bug 1330099 - Enable object-shorthand eslint rule. r=jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D153567
2022-08-03 14:57:05 +00:00
Mark Banner
1e3410cbdd
Bug 1782008 - Remove now unnecessary .eslintrc.js files. r=webcompat-reviewers,extension-reviewers,media-playback-reviewers,pip-reviewers,denschub,rpl,alwu,mossop
...
Differential Revision: https://phabricator.services.mozilla.com/D152736
2022-08-03 11:16:20 +00:00
Tooru Fujisawa
b10d0289af
Bug 1667455 - Part 4: Stop importing Services.jsm from JSM. r=kmag,webdriver-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,application-update-reviewers,pip-reviewers,twisniewski,devtools-reviewers,m_kato,jdescottes,ochameau,mconley,sfoster,AlexandruIonescu
...
Differential Revision: https://phabricator.services.mozilla.com/D150893
2022-07-11 12:41:50 +00:00
Dana Keeler
2c7040cb54
Bug 1770869 - remove unused client certificate authentication for remote devtools r=ochameau
...
Client certificate authentication for remote devtools was used in WebIDE, which
was removed from Firefox 71 in bug 1539462.
Differential Revision: https://phabricator.services.mozilla.com/D147121
2022-06-01 23:20:57 +00:00
Butkovits Atila
22b3e62b6b
Backed out 3 changesets (bug 1770869) for causing xpcshell failures at test_tls_server.js. CLOSED TREE
...
Backed out changeset 5c95392b800d (bug 1770869)
Backed out changeset 149d04a209b6 (bug 1770869)
Backed out changeset 5a138d047be1 (bug 1770869)
2022-06-02 00:18:26 +03:00
Dana Keeler
5d42654aa6
Bug 1770869 - remove unused client certificate authentication for remote devtools r=ochameau
...
Client certificate authentication for remote devtools was used in WebIDE, which
was removed from Firefox 71 in bug 1539462.
Differential Revision: https://phabricator.services.mozilla.com/D147121
2022-06-01 20:00:57 +00:00
Kershaw Chang
6996daa060
Bug 1741425 - Enable more xpcshell tests with socket process, r=ahal
...
Differential Revision: https://phabricator.services.mozilla.com/D134484
2022-01-11 09:50:14 +00:00
Julian Descottes
06b42b006a
Bug 1741369 - [devtools] Update paths to loader files in devtools/ r=ochameau
...
Depends on D131216
Differential Revision: https://phabricator.services.mozilla.com/D131217
2021-11-17 12:43:26 +00:00
Nicolas Chevobbe
0eda79a4e5
Bug 1733643 - [devtools] Remove Promise.jsm usage in devtools/shared/security/socket.js. r=ochameau.
...
We take this opportunity to refactor the `_authenticate` method.
Since it's already an async function, we don't have to explicitely return
Promise objects.
Differential Revision: https://phabricator.services.mozilla.com/D127283
2021-10-04 11:39:22 +00:00
R. Martinho Fernandes
de4f66ca1a
Bug 1597600 - make certificate overrides depend on origin attributes r=keeler,geckoview-reviewers,smaug,agi
...
Differential Revision: https://phabricator.services.mozilla.com/D91962
2021-06-01 06:55:07 +00:00
Dorel Luca
d5c3a7bd8e
Backed out changeset 089c88b9657b (bug 1597600) for XPCshell failures in toolkit/components/cleardata/tests/unit/test_certs.js. CLOSED TREE
2021-05-29 23:31:00 +03:00
R. Martinho Fernandes
a855765213
Bug 1597600 - make certificate overrides depend on origin attributes r=keeler,geckoview-reviewers,smaug,agi
...
Differential Revision: https://phabricator.services.mozilla.com/D91962
2021-05-29 19:34:35 +00:00
Alexandre Poirot
3c4356b16b
Bug 1699111 - [devtools] Rename transports onClosed callback to onTransportClosed. r=jdescottes
...
This will better highlight what is closing. Not the DevToolsClient, but just the transport class.
Differential Revision: https://phabricator.services.mozilla.com/D108812
2021-04-13 13:44:24 +00:00
Mattias de los Rios Rogers
077318ed66
Bug 1681895 - Remove defer from exported functions list in devtools/shared/security/tests/xpcshell/head_dbg.js r=nchevobbe
...
Depends on D107385
Differential Revision: https://phabricator.services.mozilla.com/D107386
2021-03-08 08:00:41 +00:00