Commit Graph
20 Commits
Author SHA1 Message Date
Alexandre Poirot 07e6ce0083 Bug 1792848 - [devtools] Use absolute URLs to import modules in devtools/shared. r=Honza,devtools-backward-compat-reviewers,bomsy
Differential Revision: https://phabricator.services.mozilla.com/D158643
2022-10-12 15:56:22 +00:00
Nicolas Chevobbe 7fc66cbf3c Bug 1492497 - [devtools] Add a way to disable (and re-enable) event listener for a given node. r=ochameau,devtools-backward-compat-reviewers,bomsy.
This patch adds a checkbox at the end of each event listeners in the EventTooltip,
which allow the user to disable/re-enable a given event listener.

This is done by managing a Map of nsIEventListenerInfo object in the NodeActor,
which we populate from `getEventListenerInfo`. Each `nsIEventListenerInfo` is
assigned a generated id, which can then be used to call the new NodeActor
methods, `(enable|disable)EventListener`.

We don't support disabling jquery/React event listeners at the moment, so we
display the checkbox for them as well, but disabled.

Differential Revision: https://phabricator.services.mozilla.com/D135133
2022-01-12 18:36:23 +00:00
Cristian Tuns 6667e23bc9 Backed out changeset 5a82b7a2951e (bug 1492497) for causing leaks CLOSED TREE 2022-01-12 09:29:06 -05:00
Nicolas Chevobbe 226f76a547 Bug 1492497 - [devtools] Add a way to disable (and re-enable) event listener for a given node. r=ochameau,devtools-backward-compat-reviewers,bomsy.
This patch adds a checkbox at the end of each event listeners in the EventTooltip,
which allow the user to disable/re-enable a given event listener.

This is done by managing a Map of nsIEventListenerInfo object in the NodeActor,
which we populate from `getEventListenerInfo`. Each `nsIEventListenerInfo` is
assigned a generated id, which can then be used to call the new NodeActor
methods, `(enable|disable)EventListener`.

We don't support disabling jquery/React event listeners at the moment, so we
display the checkbox for them as well, but disabled.

Differential Revision: https://phabricator.services.mozilla.com/D135133
2022-01-12 12:42:48 +00:00
Nicolas Chevobbe db85d63745 Bug 1733537 - [devtools] Replace usage of NodeFront#getAllSelectors with a command. r=jdescottes,devtools-backward-compat-reviewers.
`getAllSelectors` was used to retrieve a given nodeFront selector from the top
window (e.g. it would go up through documents).
This doesn't work with nodeFronts in remote frames, as we wouldn't be able to
reach for cross-process parent documents.
This patchs adds a new inspector command that computes the selector, reaching the
different documents.
All usages of `NodeFront#getAllSelectors` are switched to the new command, which
allows us to delete the method and another function that was only used there.
With the new command doing a bit more work, this highlighted some issue in our
codebase. Some consumers were relying on `selectionCssSelectors`, without waiting
for it to be updated when a new node was selected.
As a result a few tests were failing because of this.
So where it's possible and not perf critical, we simply compute the selector again.
We also emit a new event, `selection-css-selectors-updated`, so tests can wait
until it's properly set before doing further actions.

Differential Revision: https://phabricator.services.mozilla.com/D127928
2021-11-04 08:58:05 +00:00
Nicolas Chevobbe a50985f865 Bug 1730449 - [devtools] Remove non-existent connectToRemoteFrame in NodeActor spec. r=ochameau,devtools-backward-compat-reviewers.
The actor method was removed in https://hg.mozilla.org/mozilla-central/rev/103be18558b0.

Differential Revision: https://phabricator.services.mozilla.com/D125814
2021-09-16 13:26:22 +00:00
Julian Descottes 289d1eb14c Bug 1590050 - Preserve markup view selection in iframes after reload r=rcaliman,gl
Depends on D49940

To support this feature we perform two main changes
- the node actor exposes a getAllSelectors method, and the inspector now stores all selectors rather than just one
- the node actor exposes a waitForFrameLoad method, and the walkerFront findNodeFront helper uses it to make sure frames are loaded before querying a selector

Also added a test

Differential Revision: https://phabricator.services.mozilla.com/D49941
2019-10-28 07:55:14 +00:00
Julian Descottes 5b24b75a5b Bug 1577092 - Remove connectTo* helpers in debugger-server and use connectors directly r=nchevobbe
Depends on D43728

Differential Revision: https://phabricator.services.mozilla.com/D43729
2019-08-28 13:07:56 +00:00
Maliha Islam 928311444a Bug 1568053 - Create node actor method for getting complex bg color data for text nodes and refactor existing contrast calculation methods, r=yzen,gl
Differential Revision: https://phabricator.services.mozilla.com/D40086
2019-08-16 00:55:26 +00:00
yulia 1eb63569c7 Bug 1560200 - Implement very basic markup view support traversing remote frames via resource api. r=ochameau,rcaliman
Differential Revision: https://phabricator.services.mozilla.com/D39525
2019-08-13 11:54:06 +00:00
Victor Porof 435f7b056d Bug 1561435 - Format remaining devtools/, a=automatic-formatting, CLOSED TREE
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D35894
2019-07-05 11:29:32 +02:00
Gabriel Luong 904f583885 Bug 1550030 - Part 1: Implement the DOM mutation breakpoint context menu items in the markup view. r=loganfsmyth,jdescottes
This implements the context menu items for the DOM mutation breakpoint.
In addition, there were some server changes to:
- Update the mutationBreakpoints form for the NodeActor
- Expose the mutationBreakpoints form
- Moved the setMutationBreakpoints method from the Node spec to Walker spec
since the Node spec only consisted of getter methods. It made more sense
that the setter went into the Walker spec to be more consistent with how
the Walker and Node spec have been arranged.

Unit tests will be followed up in Part 2 immediately.

Differential Revision: https://phabricator.services.mozilla.com/D36074
2019-06-26 15:16:22 -04:00
Logan Smyth 62f5ffc02c Bug 1550835 - DOM mutation breakpoint server API. r=jlast,gl
Differential Revision: https://phabricator.services.mozilla.com/D33528
2019-06-26 06:23:03 +00:00
Mark Banner 3d6aaad3f5 Bug 1486741 - Enable ESLint rule comma-dangle for all of mozilla-central (automatic fixes). r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D8389
2018-10-19 12:55:39 +00:00
Razvan Caliman 0e1a81032c Bug 1475947 - (Part 1) implement getOwnerGlobalDimensions() on Node actor. r=gl
MozReview-Commit-ID: Ij59UBVlCBD
2018-07-16 19:06:06 +02:00
Alexandre Poirot 7e1be13a0a Bug 1399589 - Move domnodelist, disconnectedNode and disconnectedNodeArray to node spec and front. r=jdescottes
MozReview-Commit-ID: B5l1X4pc2Kf
2017-10-03 17:19:56 +02:00
Patrick Brosset 34ce4eae43 Bug 987877 - Add Copy XPath menu item to the inspector; r=miker
MozReview-Commit-ID: A5g0MmWovjk
2017-06-12 16:25:48 +02:00
Rahul Chaudhary 67ebe412d6 Bug 1332090 - Added a contrast ratio component to the Color Widget. r=pbro
MozReview-Commit-ID: 9FA0h9ST62E
2017-02-20 22:27:22 -05:00
Patrick Brosset d045689e66 Bug 1323700 - Adding a copy full path option to the inspector menu; r=gl
MozReview-Commit-ID: IvRnek7e7Xq
2017-01-17 14:14:41 +01:00
Eddy Bruel e347d80f46 Bug 1272724 - Move nodeSpec into its own file;r=ejpbruel 2016-06-02 17:46:11 +02:00