Julian Descottes
aa80c68700
Bug 2043123 - [devtools] Update failure message for DevTools js object generated tests r=ochameau,devtools-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D302978
2026-06-02 10:56:47 +00:00
Chris H-C
d89527a234
Bug 2039650 - Remove Legacy Telemetry devtools probes r=jdescottes,devtools-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D300855
2026-05-28 16:32:18 +00:00
Julian Descottes
02c359a70d
Bug 2028930 - [devtools] Avoid toolbox crashes due to missing localization file r=nchevobbe,devtools-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D293945
2026-04-16 12:00:23 +00:00
alexical
940a9f5ad2
Bug 2022620 - Add new Document() to AllJavascriptTypes.mjs r=ochameau,devtools-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D287191
2026-04-03 16:59:44 +00:00
Sylvestre Ledru
074b376055
Bug 2023419 - Remove Emacs/Vim modelines from devtools/ r=emilio,devtools-backward-compat-reviewers,devtools-reviewers,nchevobbe
...
replaced by .editorconfig
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D287841
2026-03-28 10:21:10 +00:00
Leo McArdle
82767b002b
Bug 2013940 - [devtools] fix floating point errors in font inspector rounding r=devtools-reviewers,bomsy
...
Differential Revision: https://phabricator.services.mozilla.com/D281816
2026-03-24 15:25:56 +00:00
Cristian Tuns
d2bd1d1f36
Revert "Bug 2022620 - Check for null location in ExecutionTracerIntegration.cpp r=arai" for causing dt failures in browser_webconsole_object_inspector_entries.js
...
This reverts commit 473a9add12 .
Revert "Bug 2022620 - Add `new Document()` to AllJavascriptTypes.mjs r=ochameau,devtools-reviewers"
This reverts commit c05ef919a8 .
2026-03-19 05:07:47 +00:00
alexical
c05ef919a8
Bug 2022620 - Add new Document() to AllJavascriptTypes.mjs r=ochameau,devtools-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D287191
2026-03-18 19:28:53 +00:00
Alexandru Marc
630e6cf0e8
Revert "Bug 2023419 - Remove Emacs/Vim modelines from devtools/ r=emilio,devtools-backward-compat-reviewers,devtools-reviewers,nchevobbe" for causing devtools failures
...
This reverts commit ed535dace9 .
2026-03-17 12:46:01 +00:00
Sylvestre Ledru
ed535dace9
Bug 2023419 - Remove Emacs/Vim modelines from devtools/ r=emilio,devtools-backward-compat-reviewers,devtools-reviewers,nchevobbe
...
replaced by .editorconfig
Differential Revision: https://phabricator.services.mozilla.com/D287841
2026-03-17 12:03:34 +00:00
Rob Wu
fdf289b012
Bug 2017996 - Fix crash in test_require.js r=devtools-reviewers,jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D284129
2026-02-20 00:07:13 +00:00
Nicolas Chevobbe
a7039c5b82
Bug 2012091 - [devtools] Render only attribute name in ElementNode rep when attribute has empty value r=devtools-reviewers,jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D280225
2026-01-27 15:30:53 +00:00
iulian moraru
1ae3353ab8
Revert "Bug 2012091 - [devtools] Render only attribute name in ElementNode rep when attribute has empty value r=devtools-reviewers,jdescottes" for causing bc failures on browser_test_feature_jstracing_objtestutils.js.
...
This reverts commit c2a9c038f4 .
2026-01-27 11:17:48 +00:00
Nicolas Chevobbe
c2a9c038f4
Bug 2012091 - [devtools] Render only attribute name in ElementNode rep when attribute has empty value r=devtools-reviewers,jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D280225
2026-01-27 09:19:31 +00:00
Jan-Niklas Jaeschke
32c3f59d40
Bug 2009669 - CSS Highlight API: Remove pref. r=dom-core,devtools-reviewers,webidl,smaug,ochameau
...
Differential Revision: https://phabricator.services.mozilla.com/D278630
2026-01-13 08:21:06 +00:00
Tom Marble
5ce09d7446
Bug 1995583 - test manifest cleanup for idiomatic usage r=jmaher,necko-reviewers,webcompat-reviewers,geckoview-reviewers,application-update-reviewers,media-playback-reviewers,sessionstore-reviewers,tabbrowser-reviewers,translations-reviewers,omc-reviewers,browser-installer-reviewers,twisniewski,masayuki,dom-core,smaug,nalexander,emcminn,sthompson,alwu,ai-ondevice-reviewers,valentin
...
For TOML manifests:
1. Change processor -> arch
2. Use arch instead of bits bits == '64' =>
aarch64 (default on mac 15.30) or x86_64 bits == '32' => x86
3. Replace android_version with corresponding os_version
4. Remove conditions with linux os_version=="18.04"
(unless they contain verify or verify-standalone)
5. Remove conditions with mac os_version=='11.20',
(unless they contain verify or verify-standalone)
6. Remove conditions with win os_version=='11.2009' or win11_2009,
(unless they contain verify or verify-standalone)
7. Linux conditions should have os_version, arch and display
(simple "os == 'linux'" will get expanded to these two)
"os == 'linux' && os_version == '22.04' && arch == 'x86_64' && display == 'wayland'"
"os == 'linux' && os_version == '24.04' && arch == 'x86_64' && display == 'x11'"
8. Mac conditions should have os_version and arch
(simple "os == 'mac'" will get expanded to these three)
"os == 'mac' && os_version == '10.15' && arch == 'x86_64'",
"os == 'mac' && os_version == '14.70' && arch == 'x86_64'",
"os == 'mac' && os_version == '15.30' && arch == 'aarch64'",
9. Replace apple_catalina with
os == 'mac' && os_version == '10.15' && arch == 'x86_64'
10. Replace apple_silicon with
os == 'mac' && os_version = '15.30' && arch == 'aarch64'
11. Replace win10_2009 with
os == 'win' && os_version = '10.2009' && arch == 'x86_64'
12. Replace "!debug" with three conditions "asan", "opt", or "tsan"
13. Replace literal boolean comparison with variables
(e.g. "debug == false" => "!debug)
Resolves 2000285
Signed-off-by: Tom Marble <[email protected] >
Differential Revision: https://phabricator.services.mozilla.com/D272815
2025-11-22 00:30:39 +00:00
Mark Banner
b38cd3110b
Bug 1999554 - Automatically fix ESLint rule jsdoc/check-types for devtools/. r=devtools-reviewers,devtools-backward-compat-reviewers,profiler-reviewers,canaltinova
...
Differential Revision: https://phabricator.services.mozilla.com/D272173
2025-11-21 16:16:08 +00:00
Julian Descottes
fecb7d40d1
Bug 1997708 - [devtools] Fix PluralForm with legacy gecko locale ja-JP-mac r=nchevobbe,devtools-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D271253
2025-11-04 17:39:29 +00:00
Eemeli Aro
49a892dd01
Bug 1760013 - Inline plural rule selection into devtools/shared/plural-form.js. r=devtools-reviewers,nchevobbe
...
The messages depending on this should really be migrated to a better format, but this change at least reduces the burden on translators a little bit.
Differential Revision: https://phabricator.services.mozilla.com/D267415
2025-10-30 11:10:24 +00:00
Tom Marble
f5df00d78c
Bug 1991964 - Remove android_version from test manifests r=jmaher,necko-reviewers,media-playback-reviewers,devtools-reviewers,permissions-reviewers,dom-worker-reviewers,asuth,jesup,nchevobbe,alwu
...
Now includes both code changes and manifest changes.
See also Bug 1991960
Signed-off-by: Tom Marble <[email protected] >
Differential Revision: https://phabricator.services.mozilla.com/D267466
2025-10-08 02:11:45 +00:00
Alexandre Poirot
cc700d53c9
Bug 1989235 - [devtools] Fix eslint configuration for tracer serialization. r=devtools-reviewers,profiler-reviewers,frontend-codestyle-reviewers,canaltinova,nchevobbe,Standard8
...
Register this snapshot file, outside of devtools into eslint/prettier ignore list
so that we keep the JSON objects dumped in the snapshot file as-is.
Also fix eslint issues from ValueSummaryReader.
Differential Revision: https://phabricator.services.mozilla.com/D266971
2025-10-07 23:09:37 +00:00
Alexandre Poirot
0ba8232979
Bug 1989235 - [devtools] Avoid updating object test snapshots unless explicitly requested. r=devtools-reviewers,nchevobbe
...
This is a regression, we should only update the snapshot
if `UPDATE_SNAPSHOT` env is set to true.
Differential Revision: https://phabricator.services.mozilla.com/D266786
2025-10-07 23:09:33 +00:00
Atila Butkovits
b812274f7b
Revert "Bug 1989235: apply code formatting via Lando" for causing failures at ExecutionTracer.h.
...
This reverts commit 7183a1cb0c .
Revert "Bug 1989235 - [devtools] Serialize Errors and Exceptions in the tracer. r=devtools-reviewers,frontend-codestyle-reviewers,mossop,dthayer,nchevobbe"
This reverts commit 8b8fd600c4 .
Revert "Bug 1989235 - [devtools] Fix eslint configuration for tracer serialization. r=devtools-reviewers,profiler-reviewers,frontend-codestyle-reviewers,canaltinova,nchevobbe,Standard8"
This reverts commit dc940445a3 .
Revert "Bug 1989235 - [devtools] Avoid updating object test snapshots unless explicitly requested. r=devtools-reviewers,nchevobbe"
This reverts commit 2813cea7f0 .
2025-10-07 12:28:38 +00:00
Alexandre Poirot
dc940445a3
Bug 1989235 - [devtools] Fix eslint configuration for tracer serialization. r=devtools-reviewers,profiler-reviewers,frontend-codestyle-reviewers,canaltinova,nchevobbe,Standard8
...
Register this snapshot file, outside of devtools into eslint/prettier ignore list
so that we keep the JSON objects dumped in the snapshot file as-is.
Also fix eslint issues from ValueSummaryReader.
Differential Revision: https://phabricator.services.mozilla.com/D266971
2025-10-07 11:40:29 +00:00
Alexandre Poirot
2813cea7f0
Bug 1989235 - [devtools] Avoid updating object test snapshots unless explicitly requested. r=devtools-reviewers,nchevobbe
...
This is a regression, we should only update the snapshot
if `UPDATE_SNAPSHOT` env is set to true.
Differential Revision: https://phabricator.services.mozilla.com/D266786
2025-10-07 11:40:26 +00:00
Nicolas Chevobbe
ecacb2f9a5
Bug 1599082 - [devtools] Remove static EventEmitter methods. r=devtools-reviewers,jdescottes.
...
Let's always use instance methods instead so we're consistent in the whole codebase.
We only keep the EventEmitter.decorate that is used significantly in DevTools
to handle old-syle function + prototype "classes".
We might also save a few cycles by avoid wrapping the static methods that was
done from the inheritence based ones.
Remove the test that was asserting the static methods.
Differential Revision: https://phabricator.services.mozilla.com/D267590
2025-10-07 05:37:56 +00:00
Cristina Horotan
720d9c8fd8
Revert "Bug 1989235 - [devtools] Serialize Errors and Exceptions in the tracer. r=devtools-reviewers,frontend-codestyle-reviewers,mossop,dthayer,nchevobbe" for causing SM failures on ExecutionTracer-traced-values.js
...
This reverts commit 4dbbb7733e .
Revert "Bug 1989235 - [devtools] Fix eslint configuration for tracer serialization. r=devtools-reviewers,profiler-reviewers,frontend-codestyle-reviewers,canaltinova,nchevobbe,Standard8"
This reverts commit 9be06acefa .
Revert "Bug 1989235 - [devtools] Avoid updating object test snapshots unless explicitly requested. r=devtools-reviewers,nchevobbe"
This reverts commit 4c6c028a35 .
2025-10-06 13:08:50 +00:00
Alexandre Poirot
9be06acefa
Bug 1989235 - [devtools] Fix eslint configuration for tracer serialization. r=devtools-reviewers,profiler-reviewers,frontend-codestyle-reviewers,canaltinova,nchevobbe,Standard8
...
Register this snapshot file, outside of devtools into eslint/prettier ignore list
so that we keep the JSON objects dumped in the snapshot file as-is.
Also fix eslint issues from ValueSummaryReader.
Differential Revision: https://phabricator.services.mozilla.com/D266971
2025-10-06 12:41:05 +00:00
Alexandre Poirot
4c6c028a35
Bug 1989235 - [devtools] Avoid updating object test snapshots unless explicitly requested. r=devtools-reviewers,nchevobbe
...
This is a regression, we should only update the snapshot
if `UPDATE_SNAPSHOT` env is set to true.
Differential Revision: https://phabricator.services.mozilla.com/D266786
2025-10-06 12:41:01 +00:00
Nicolas Chevobbe
abc121c612
Bug 1992060 - [devtools] Remove EventEmitter listener as object. r=devtools-reviewers,ochameau.
...
This wasn't used anywhere except in the test checking the feature.
Differential Revision: https://phabricator.services.mozilla.com/D267168
2025-10-02 16:16:35 +00:00
alexical
b3f9f9a50e
Bug 1933787 - Test traced values with JSObjectsTestUtils r=ochameau,devtools-reviewers,profiler-reviewers,canaltinova
...
This does not represent the finalized form for a lot of the entries in the
snapshot since some types are still not handled, but this at least lets us
exercise the code paths and ensure future additions don't change the
representations of any existing covered types. I would also like to move
the serialization code here into a module we can include from Firefox and
the profiler frontend but that's for a future patch.
Differential Revision: https://phabricator.services.mozilla.com/D253219
2025-07-23 22:05:02 +00:00
Atila Butkovits
d0928a3847
Revert "Bug 1933787 - Test traced values with JSObjectsTestUtils r=ochameau,devtools-reviewers,profiler-reviewers,canaltinova" for causing failures at test_feature_java.js.
...
This reverts commit 7d5d0d0cd2 .
Revert "Bug 1933787 - Ingest traced values from profiler backend r=profiler-reviewers,canaltinova"
This reverts commit dba048f0e4 .
Revert "Bug 1933787 - Record basic DOM types in execution tracer r=arai"
This reverts commit af8ea6fa72 .
Revert "Bug 1933787 - Record arg values in tracer-generated profiles r=arai"
This reverts commit 6d7cb1b94f .
2025-07-21 22:43:04 +00:00
alexical
7d5d0d0cd2
Bug 1933787 - Test traced values with JSObjectsTestUtils r=ochameau,devtools-reviewers,profiler-reviewers,canaltinova
...
This does not represent the finalized form for a lot of the entries in the
snapshot since some types are still not handled, but this at least lets us
exercise the code paths and ensure future additions don't change the
representations of any existing covered types. I would also like to move
the serialization code here into a module we can include from Firefox and
the profiler frontend but that's for a future patch.
Differential Revision: https://phabricator.services.mozilla.com/D253219
2025-07-21 20:50:16 +00:00
Sandor Molnar
dc4ef273dd
Revert "Bug 1933787 - Test traced values with JSObjectsTestUtils r=ochameau,devtools-reviewers,profiler-reviewers,canaltinova" for causing build bustages @ ExecutionTracer.h
...
This reverts commit 3f4b38cf99 .
Revert "Bug 1933787 - Ingest traced values from profiler backend r=profiler-reviewers,canaltinova"
This reverts commit 7d647fcc39 .
Revert "Bug 1933787 - Record basic DOM types in execution tracer r=arai"
This reverts commit b44d378744 .
Revert "Bug 1933787 - Record arg values in tracer-generated profiles r=arai"
This reverts commit 9ae82fa7ca .
2025-07-16 16:55:02 +00:00
alexical
3f4b38cf99
Bug 1933787 - Test traced values with JSObjectsTestUtils r=ochameau,devtools-reviewers,profiler-reviewers,canaltinova
...
This does not represent the finalized form for a lot of the entries in the
snapshot since some types are still not handled, but this at least lets us
exercise the code paths and ensure future additions don't change the
representations of any existing covered types. I would also like to move
the serialization code here into a module we can include from Firefox and
the profiler frontend but that's for a future patch.
Differential Revision: https://phabricator.services.mozilla.com/D253219
2025-07-16 16:33:42 +00:00
Joel Maher
b0a2bcee11
Bug 1976582 - Carry over android emulator annotations from api 24 to api 34. r=aryx,necko-reviewers,devtools-reviewers,nchevobbe,kershaw
...
Differential Revision: https://phabricator.services.mozilla.com/D256730
2025-07-11 19:02:18 +00:00
iulian moraru
ddc73f5922
Revert "Bug 1976582 - Carry over android emulator annotations from api 24 to api 34. r=aryx,necko-reviewers,devtools-reviewers,nchevobbe,kershaw" for causing reftest failures on color_quads.html.
...
This reverts commit e59ec21b7b .
2025-07-11 14:15:07 +00:00
Joel Maher
e59ec21b7b
Bug 1976582 - Carry over android emulator annotations from api 24 to api 34. r=aryx,necko-reviewers,devtools-reviewers,nchevobbe,kershaw
...
Differential Revision: https://phabricator.services.mozilla.com/D256730
2025-07-11 12:43:35 +00:00
Gijs Kruitbosch
9c5be039df
Bug 1971751 - update tests that misuse Assert.ok after no-comparison-or-assignment-inside-ok update, r=frontend-codestyle-reviewers,webdriver-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,cookie-reviewers,sessionstore-reviewers,tabbrowser-reviewers,places-reviewers,profiler-reviewers,omc-reviewers,migration-reviewers,home-newtab-reviewers,webcompat-reviewers,urlbar-reviewers,permissions-reviewers,firefox-ai-ml-reviewers,profiles-reviewers,robwu,julienw,bytesized,sthompson,valentin,jhirsch,markh,twisniewski,Standard8,dimi,nbarrett,mconley,timhuang
...
Differential Revision: https://phabricator.services.mozilla.com/D253662
2025-06-26 10:33:09 +00:00
agoloman
fd1e9e499d
Revert "Bug 1971751 - update no-comparison-or-assignment-inside-ok to also cover Assert.ok, r=frontend-codestyle-reviewers,Standard8" for causing lint failures @test_maybeCapExpiry.js.
...
This reverts commit 2744165954 .
Revert "Bug 1971751 - update tests that misuse Assert.ok after no-comparison-or-assignment-inside-ok update, r=frontend-codestyle-reviewers,webdriver-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,cookie-reviewers,sessionstore-reviewers,tabbrowser-reviewers,places-reviewers,profiler-reviewers,omc-reviewers,migration-reviewers,home-newtab-reviewers,webcompat-reviewers,urlbar-reviewers,permissions-reviewers,firefox-ai-ml-reviewers,profiles-reviewers,robwu,julienw,bytesized,sthompson,valentin,jhirsch,markh,twisniewski,Standard8,dimi,nbarrett,mconley,timhuang"
This reverts commit ba7298d756 .
Revert "Bug 1971751 - manual test updates where linter autofix creates issues, r=frontend-codestyle-reviewers,Standard8"
This reverts commit e12e0d3181 .
2025-06-26 01:11:00 +00:00
Gijs Kruitbosch
ba7298d756
Bug 1971751 - update tests that misuse Assert.ok after no-comparison-or-assignment-inside-ok update, r=frontend-codestyle-reviewers,webdriver-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,cookie-reviewers,sessionstore-reviewers,tabbrowser-reviewers,places-reviewers,profiler-reviewers,omc-reviewers,migration-reviewers,home-newtab-reviewers,webcompat-reviewers,urlbar-reviewers,permissions-reviewers,firefox-ai-ml-reviewers,profiles-reviewers,robwu,julienw,bytesized,sthompson,valentin,jhirsch,markh,twisniewski,Standard8,dimi,nbarrett,mconley,timhuang
...
Differential Revision: https://phabricator.services.mozilla.com/D253662
2025-06-26 00:07:43 +00:00
Alexandre Poirot
9d6ab254e9
Bug 1972889 - [devtools] Flag all tests using JSObjectsTestUtils framework and generating snapshots with "object-snapshots" tag. r=devtools-reviewers,nchevobbe
...
This will help run them all easily via `./mach test --tag object-snapshots`.
Differential Revision: https://phabricator.services.mozilla.com/D254269
2025-06-25 00:10:09 +00:00
Alexandre Poirot
95222ec51e
Bug 1970328 - [devtools] Remove DevToolsLoader's invisibleToDebugger flag. r=devtools-reviewers,jdescottes
...
This flag was only used by the allocation tracker test and we can now rely on the
DevTools global spawn by mozJSModuleLoader.
Differential Revision: https://phabricator.services.mozilla.com/D253049
2025-06-11 16:01:34 +00:00
Nicolas Chevobbe
294861d1cd
Bug 1967673 - [devtools] Don't omit valid safe getter undefined values in _findSafeGetterValues. r=devtools-reviewers,jdescottes DONTBUILD
...
Differential Revision: https://phabricator.services.mozilla.com/D250613
2025-05-25 10:56:48 +00:00
Cristian Tuns
2c393cf579
Revert "Bug 1967673 - [devtools] Don't omit valid safe getter undefined values in _findSafeGetterValues. r=devtools-reviewers,jdescottes" for causing failures with "1 not in success codes: [0] "
...
This reverts commit f73f8eabd8 .
2025-05-25 10:25:19 +00:00
Nicolas Chevobbe
f73f8eabd8
Bug 1967673 - [devtools] Don't omit valid safe getter undefined values in _findSafeGetterValues. r=devtools-reviewers,jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D250613
2025-05-25 09:30:55 +00:00
Mark Banner
b20fbf2ba1
Bug 1881701 - Fix remainder of newly raised devtools issues after switching to the ESLint flat config. r=devtools-reviewers,frontend-codestyle-reviewers,mossop,nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D249957
2025-05-24 17:11:32 +00:00
Mark Banner
ee9933d77b
Bug 1881701 - Automatically fix new issues raised in devtools. r=devtools-reviewers,frontend-codestyle-reviewers,mossop,nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D249956
2025-05-24 17:11:28 +00:00
Mark Banner
3cc3379c8f
Bug 1881701 - Change the devtools configurations to work with the ESLint flat configuration.r=devtools-reviewers,profiler-reviewers,julienw,nchevobbe
...
This consolidates the jest environment definition, and the xpcshell globals into the devtools/.eslintrc.mjs file, for easier configurations.
It also changes the restart of the configurations to work with flat config.
Differential Revision: https://phabricator.services.mozilla.com/D249948
2025-05-24 17:10:59 +00:00
Mark Banner
d7c7c5369b
Bug 1881701 - Rename many ESLint files to use .mjs. r=frontend-codestyle-reviewers,perftest-reviewers,Gijs,sparky,webcompat-reviewers,twisniewski
...
This is separate to help preserve history of the files.
Differential Revision: https://phabricator.services.mozilla.com/D249945
2025-05-24 17:10:51 +00:00