Commit Graph
13 Commits
Author SHA1 Message Date
Julian Descottes b5a1d0ac85 Bug 1275096 - [devtools] Fix eslint no aArgs violations r=frontend-codestyle-reviewers,devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D268679
2025-10-15 16:47:26 +00:00
Dave Townsend 2af4d349f3 Bug 1864896: Autofix unused function arguments (devtools). r=profiler-reviewers,devtools-reviewers,nchevobbe,julienw
Differential Revision: https://phabricator.services.mozilla.com/D202959
2024-03-05 14:21:15 +00:00
Tooru Fujisawa cd6d2d881f Bug 1843790 - Part 3: Rewrite toolkit/modules/Console.sys.mjs consumers in html/xhtml to use ChromeUtils.importESModule. r=Gijs,devtools-reviewers,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D183662
2023-07-18 23:06:32 +00:00
Nicolas Chevobbe b003c60585 Bug 1756822 - [devtools] Don't include unnecessary properties in console message resource. r=jdescottes.
Don't clone the whole message we receive as a result of a console API call, but select
properties that are being used on the client.
As a result, we're not sending some properties anymore (`functionName`, `addonId`, `workerType`),
and we also don't include some properties when they are falsy and wouldn't bring
any benefit (`counter`,`timer`, `private`, `prefix`, `stacktrace`)

Hopefully this helps save some cycle since we're not cloning an object, but also in the
JSActor communication since the packet we need to send is smaller.

We do similar changes to the webconsoleActor method, which is still used in non
fission scenarios, and remove WebConsoleUtils.cloneObject which is no longer used.

Differential Revision: https://phabricator.services.mozilla.com/D139686
2022-03-04 07:05:06 +00:00
Nicolas Chevobbe 2ddb02bbee Bug 1730159 - [devtools] Only match console messages of exact same window. r=bomsy.
With dedicated targets for each window, we can now only check that the message
originates from the target window, and not from its window tree
Some tests that were assuming the iframe had the same target as the top level document
are updated.

Differential Revision: https://phabricator.services.mozilla.com/D125935
2021-09-21 13:59:40 +00:00
Kris Maglione 2e15609be2 Bug 1651519: Remove nsIDOMWindowUtils::currentInnerWindowID. r=nika,remote-protocol-reviewers,webcompat-reviewers,whimboo
It has some properties which make it footgunny, especially in the face of
Fission. Callers should use WindowGlobalChild.innerWindowId instead.

Differential Revision: https://phabricator.services.mozilla.com/D82801
2020-08-17 20:20:50 +00:00
Dorel Luca 31c7246867 Backed out 2 changesets (bug 1651519) for WPT failures in webdriver/tests/switch_to_frame/switch.py. CLOSED TREE
Backed out changeset 7b973a0e7be9 (bug 1651519)
Backed out changeset 55e9184c5617 (bug 1651519)
2020-07-22 02:47:34 +03:00
Kris Maglione dbaf353579 Bug 1651519: Remove nsIDOMWindowUtils::currentInnerWindowID. r=nika,remote-protocol-reviewers,webcompat-reviewers,whimboo
It has some properties which make it footgunny, especially in the face of
Fission. Callers should use WindowGlobalChild.innerWindowId instead.

Differential Revision: https://phabricator.services.mozilla.com/D82801
2020-07-21 19:02:27 +00:00
Dorel Luca 5a181a3513 Backed out 2 changesets (bug 1651519) for wpt failures in webdriver/tests/switch_to_frame/switch.py. CLOSED TREE
Backed out changeset 52317abc5c68 (bug 1651519)
Backed out changeset 45448dca59a4 (bug 1651519)
2020-07-21 21:55:57 +03:00
Kris Maglione 2e494d7e1c Bug 1651519: Remove nsIDOMWindowUtils::currentInnerWindowID. r=nika,remote-protocol-reviewers,webcompat-reviewers,whimboo
It has some properties which make it footgunny, especially in the face of
Fission. Callers should use WindowGlobalChild.innerWindowId instead.

Differential Revision: https://phabricator.services.mozilla.com/D82801
2020-07-21 16:59:28 +00:00
Alexandre Poirot 1ea1a546f1 Bug 1614791 - Rename DebuggerServer to DevToolsServer. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D61363
2020-02-17 10:28:24 +00:00
jpmohr ddca670389 Bug 1599731 - Remove callbacks from webconsole attach test helpers. Address revision issues: style improvements. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D61655
2020-02-06 09:16:55 +00:00
Alexandre Poirot 313ad30871 Bug 1609726 - Unify mochitest chrome test folders in devtools. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D60410
2020-02-04 14:03:11 +00:00