Commit Graph
110 Commits
Author SHA1 Message Date
Tom Schuster 13e7ca66b5 Bug 2044268 - Remove test-only workerify function. r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D304018
2026-06-02 11:04:45 +00:00
Alexandre Poirot ff764d01fd Bug 1622857 - [devtools] Use a console instance for logging DevToolsWorker messages. r=devtools-reviewers,nchevobbe
This the last usage of "wantVerbose" flag.

Differential Revision: https://phabricator.services.mozilla.com/D299057
2026-05-18 09:12:37 +00:00
Sylvestre Ledru 074b376055 Bug 2023419 - Remove Emacs/Vim modelines from devtools/ r=emilio,devtools-backward-compat-reviewers,devtools-reviewers,nchevobbe
replaced by .editorconfig
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D287841
2026-03-28 10:21:10 +00:00
Alexandru Marc 630e6cf0e8 Revert "Bug 2023419 - Remove Emacs/Vim modelines from devtools/ r=emilio,devtools-backward-compat-reviewers,devtools-reviewers,nchevobbe" for causing devtools failures
This reverts commit ed535dace9.
2026-03-17 12:46:01 +00:00
Sylvestre Ledru ed535dace9 Bug 2023419 - Remove Emacs/Vim modelines from devtools/ r=emilio,devtools-backward-compat-reviewers,devtools-reviewers,nchevobbe
replaced by .editorconfig

Differential Revision: https://phabricator.services.mozilla.com/D287841
2026-03-17 12:03:34 +00:00
Mark Banner 73473d292f Bug 1967204 - remove superfluous eslint-env annotations from devtools. r=devtools-reviewers,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D279320
2026-01-21 13:57:56 +00:00
Atila Butkovits d95fe903b7 Revert "Bug 1967204 - remove superfluous eslint-env annotations from remaining places. r=frontend-codestyle-reviewers,geckoview-reviewers,whimboo,Gijs,nalexander" for causing failures at browser_webconsole_stubs_page_error.js.
This reverts commit a0fd5cb925.

Revert "Bug 1967204 - remove superfluous eslint-env annotations from devtools. r=devtools-reviewers,ochameau"

This reverts commit 437173a655.

Revert "Bug 1967204 - remove superfluous eslint-env annotations from netwerk. r=necko-reviewers,cookie-reviewers,valentin"

This reverts commit 379e12b4e7.

Revert "Bug 1967204 - remove superfluous eslint-env annotations from tools. r=frontend-codestyle-reviewers,Gijs"

This reverts commit 78ab55c903.

Revert "Bug 1967204 - remove superfluous eslint-env annotations from testing. r=frontend-codestyle-reviewers,perftest-reviewers,sparky,Gijs"

This reverts commit 24b398368a.

Revert "Bug 1967204 - remove superfluous eslint-env annotations from browser. r=frontend-codestyle-reviewers,credential-management-reviewers,omc-reviewers,home-newtab-reviewers,mkennedy,mconley,dimi,Gijs,emcminn"

This reverts commit f9d3a69d83.

Revert "Bug 1967204 - remove superfluous eslint-env annotations from toolkit. r=frontend-codestyle-reviewers,credential-management-reviewers,desktop-theme-reviewers,manuel,mkennedy,dimi,Gijs,dao"

This reverts commit 1a9053a6b4.

Revert "Bug 1967204 - remove superfluous eslint-env annotations from dom/ r=dom-core,media-playback-reviewers,smaug,aosmond"

This reverts commit f342d41a38.
2026-01-20 15:00:04 +00:00
Mark Banner 437173a655 Bug 1967204 - remove superfluous eslint-env annotations from devtools. r=devtools-reviewers,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D279320
2026-01-20 13:45:39 +00:00
Mark Banner 2542790f53 Bug 1998787 - Automatic fixes for enabling ESLint jsdoc/tag-line rule everywhere. r=frontend-codestyle-reviewers,mtigley,perftest-reviewers,nchevobbe,home-newtab-reviewers,Gijs,mconley,sparky
Differential Revision: https://phabricator.services.mozilla.com/D271745
2025-11-10 21:27:12 +00:00
Magnus Melin ae3f6ada11 Bug 1787457 - Use Services.wm.getMostRecentBrowserWindow() to get most recent browser window in devtools (to work better with Android and Thunderbird). r=devtools-reviewers,profiler-reviewers,ochameau,canaltinova
For Firefox, this will get you exactly the same thing as "navigator:browser".
https://searchfox.org/firefox-main/rev/e02959386f6f89c1476edba10b3902f4e4f3ed4c/xpfe/appshell/nsWindowMediator.cpp#254

Differential Revision: https://phabricator.services.mozilla.com/D263243
2025-09-01 09:31:32 +00:00
Mark Banner 26216a2205 Bug 1575506 - Enable ESLint rule no-redeclare with builtinGlobals on all module and worker files. r=frontend-codestyle-reviewers,devtools-reviewers,nchevobbe,mossop
Differential Revision: https://phabricator.services.mozilla.com/D221446
2024-09-12 21:08:45 +00:00
Mark Banner 3dcecced2a Bug 1917530 - Fix ESLint no-shadow issues in devtools code. r=devtools-reviewers,profiler-reviewers,frontend-codestyle-reviewers,nchevobbe,julienw,mossop
Differential Revision: https://phabricator.services.mozilla.com/D221442
2024-09-12 21:08:43 +00:00
Sandor Molnar b59809ee6a Backed out 8 changesets (bug 1917532, bug 1575506, bug 1917530) for causing node newtab failures CLOSED TREE
Backed out changeset 8d6f7bc74d08 (bug 1917532)
Backed out changeset 7c963e72cf06 (bug 1575506)
Backed out changeset d5e110187781 (bug 1917530)
Backed out changeset 1d2325ffded6 (bug 1917530)
Backed out changeset 8a361e37e32c (bug 1917530)
Backed out changeset c4011d92c7f7 (bug 1917530)
Backed out changeset 1a45047dfb3c (bug 1917530)
Backed out changeset ed6b35444c45 (bug 1917530)
2024-09-12 20:45:28 +03:00
Mark Banner a1f8e140ba Bug 1575506 - Enable ESLint rule no-redeclare with builtinGlobals on all module and worker files. r=frontend-codestyle-reviewers,devtools-reviewers,nchevobbe,mossop
Differential Revision: https://phabricator.services.mozilla.com/D221446
2024-09-12 16:41:59 +00:00
Mark Banner 0f1740d7e9 Bug 1917530 - Fix ESLint no-shadow issues in devtools code. r=devtools-reviewers,profiler-reviewers,frontend-codestyle-reviewers,nchevobbe,julienw,mossop
Differential Revision: https://phabricator.services.mozilla.com/D221442
2024-09-12 16:41:57 +00:00
Alexandre Poirot 85bd68b0ae Bug 1888171 - [devtools] Rename worker helper module to ESM. r=devtools-reviewers,nchevobbe
Git isn't able to detect the file being only renamed in the previous changeset
as the changes made to it are too important.
So, use a distinct changeset to apply the file rename.

Differential Revision: https://phabricator.services.mozilla.com/D205988
2024-03-28 15:15:23 +00:00
Alexandre Poirot a44f110542 Bug 1888171 - [devtools] Convert worker helper module to ESM. r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D205866
2024-03-28 15:15:23 +00:00
Dave Townsend d1cd903d43 Bug 1864896: Remove empty destructuring patterns (devtools). r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D202960
2024-03-05 14:21:15 +00:00
Dave Townsend 2af4d349f3 Bug 1864896: Autofix unused function arguments (devtools). r=profiler-reviewers,devtools-reviewers,nchevobbe,julienw
Differential Revision: https://phabricator.services.mozilla.com/D202959
2024-03-05 14:21:15 +00:00
Tom Marble 6c1231e2e8 Bug 1853244 - convert .ini manifests to .toml: batch 6 {caps,devtools,dom}/**/browser.ini r=jmaher,media-playback-reviewers,devtools-reviewers,profiler-reviewers,alwu,nchevobbe,canaltinova
Differential Revision: https://phabricator.services.mozilla.com/D188856
2023-09-22 20:42:14 +00:00
Mark Banner 0666077666 Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu
Differential Revision: https://phabricator.services.mozilla.com/D177027
2023-05-20 12:26:53 +00:00
Mark Banner 91fde42f7b Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish
Differential Revision: https://phabricator.services.mozilla.com/D177025
2023-05-20 12:26:49 +00:00
Alexandre Poirot bde84f5b65 Bug 1793604 - [devtools] Convert Loader.jsm to ESM. r=perftest-reviewers,geckoview-reviewers,preferences-reviewers,owlish,kshampur,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D158582
2022-10-14 12:19:42 +00:00
Alexandre Poirot 07e6ce0083 Bug 1792848 - [devtools] Use absolute URLs to import modules in devtools/shared. r=Honza,devtools-backward-compat-reviewers,bomsy
Differential Revision: https://phabricator.services.mozilla.com/D158643
2022-10-12 15:56:22 +00:00
Alexandre Poirot 0c4e317914 Bug 1789980 - [devtools] Migrate all callsites using require("chrome") to use Components.* global symbols. r=jdescottes,perftest-reviewers,AlexandruIonescu
This will help transition to ES Modules as we won't be able to expose a magic "chrome" ESM.
Also, most of these symbols are exposed as global already.
All but:
* `components` which is `Components`,
* `CC` which is `Components.Constructor`,
* `Cm` which is `Components.manager`.

$ sed -ie "/require(.chrome.)/d" $(git grep -l 'require("chrome")' devtools/)
+ manual edits for all three exceptions

Differential Revision: https://phabricator.services.mozilla.com/D156936
2022-09-20 12:52:27 +00:00
Alexandre Poirot 0f32f335e3 Bug 1789201 - [devtools] Expose Services as a global to all DevTools modules. r=perftest-reviewers,nchevobbe,julienw,AlexandruIonescu
This will help transition to ES Modules as this symbol is exposed to them.

$ sed -ie "/require(.Services.)/d" $(git grep -l 'require("Services")' devtools/)
$ sed -ie "/loader.lazyRequireGetter(this, .Services./d" $(git grep -l 'loader.lazyRequireGetter(this, "Services"' devtools/)
+ the edition of builtin-modules.js + eslintrc.js
+ manual eslint fixes
+ removal of devtools-services in the debugger, except for jest tests

Differential Revision: https://phabricator.services.mozilla.com/D156401
2022-09-09 07:22:51 +00:00
Mark Banner 6d03c63e2d Bug 1330099 - Enable object-shorthand eslint rule. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D153567
2022-08-03 14:57:05 +00:00
Nicolas Chevobbe ca1842b391 Bug 1668219 - [devtools] Remove widgets only used on old perf panel. r=bomsy.
This removes FlameGraph.js, Graphs.js, GraphsWorker.js, LineGraphWidget.js, MountainGraphWidget.js
and their related tests.
DevToolsWorker tests that were relying on GraphsWorker.js are updated to use a test-specific blob worker.

Differential Revision: https://phabricator.services.mozilla.com/D145462
2022-05-06 17:16:27 +00:00
Tooru Fujisawa 08d1d0dba8 Bug 1766099 - Part 2: Explicitly specify import or imported symbol for importScripts in devtools/. r=Standard8
Depends on D144671

Differential Revision: https://phabricator.services.mozilla.com/D144672
2022-04-27 11:40:40 +00:00
Julian Descottes 06b42b006a Bug 1741369 - [devtools] Update paths to loader files in devtools/ r=ochameau
Depends on D131216

Differential Revision: https://phabricator.services.mozilla.com/D131217
2021-11-17 12:43:26 +00:00
Julian Descottes 006fcc4906 Bug 1741369 - [devtools] Move all loader-related files to devtools/shared/loader r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D131216
2021-11-17 12:43:26 +00:00
Alexandre Poirot 4419d79bfb Bug 1731967 - [devtools] Renamed all "watched data" to "session data". r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D128348
2021-10-13 16:35:05 +00:00
Nicolas Chevobbe 1eded2107b Bug 1384527 - [devtools] Stop using Promise.jsm in DevTools. r=ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D127930
2021-10-11 16:30:06 +00:00
Cristian Tuns efc1b74179 Backed out 5 changesets (bug 1384527, bug 1734786, bug 1734782, bug 1734592, bug 1734785) for causing mochitest failures. CLOSED TREE
Backed out changeset fd5088801f6d (bug 1384527)
Backed out changeset 0752e08d7ec9 (bug 1734786)
Backed out changeset 038d15951e1a (bug 1734782)
Backed out changeset a6a1a9b835f4 (bug 1734785)
Backed out changeset aca421f634ea (bug 1734592)
2021-10-11 11:06:16 -04:00
Nicolas Chevobbe 464e9bc129 Bug 1384527 - [devtools] Stop using Promise.jsm in DevTools. r=ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D127930
2021-10-11 14:03:15 +00:00
Alexandre Poirot aa4c30771b Bug 1700106 - [devtools] Remove now-useless eslint files related to mochitests. r=jdescottes,Standard8
I kept a few having some overrides. But they may be irrelevant.
And I kept some eslint files for all folder that aren't matching the pattern matching "**/test*/**/browser*/".
Ideally we would rename these folder to match.

Last but not least, I identified one case where we were using mochitest file for xpcshell tests!

Differential Revision: https://phabricator.services.mozilla.com/D109481
2021-03-23 15:51:18 +00:00
Alexandre Poirot fb57a08aaa Bug 1681698 - [devtools] Bootstrap the thread actor early, when the target actor instantiates r=jdescottes,nchevobbe,devtools-backward-compat-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D99356
2021-02-15 17:08:21 +00:00
Butkovits Atila b2812cfcc9 Backed out 2 changesets (bug 1681698, bug 1681699) for causing failure on browser_browser_resources_console_messages.js. CLOSED TREE
Backed out changeset cf75ed5213a0 (bug 1681698)
Backed out changeset 283763c17ed7 (bug 1681699)
2021-02-11 20:18:10 +02:00
Alexandre Poirot 718cf60340 Bug 1681698 - [devtools] Bootstrap the thread actor early, when the target actor instantiates r=jdescottes,nchevobbe,devtools-backward-compat-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D99356
2021-02-11 15:23:58 +00:00
Ricky Stewart 31b8ca9716 Bug 1654103: Standardize on Black for Python code in mozilla-central.
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.

5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-26 18:34:53 +00:00
Bogdan Tara 612312a64c Backed out 10 changesets (bug 1654103, bug 1672023, bug 1518999) for PanZoomControllerTest.touchEventForResult gv-junit failures CLOSED TREE
Backed out changeset ff3fb0b4a512 (bug 1672023)
Backed out changeset e7834b600201 (bug 1654103)
Backed out changeset 807893ca8069 (bug 1518999)
Backed out changeset 13e6b92440e9 (bug 1518999)
Backed out changeset 8b2ac5a6c98a (bug 1518999)
Backed out changeset 575748295752 (bug 1518999)
Backed out changeset 65f07ce7b39b (bug 1518999)
Backed out changeset 4bb80556158d (bug 1518999)
Backed out changeset 8ac8461d7bd7 (bug 1518999)
Backed out changeset e8ba13ee17f5 (bug 1518999)
2020-10-24 03:36:18 +03:00
Ricky Stewart 065d2eb893 Bug 1654103: Standardize on Black for Python code in mozilla-central. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.

5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-23 20:40:42 +00:00
Dorel Luca 95b44c982f Backed out changeset 7558c8821a07 (bug 1654103) for multiple failures. CLOSED TREE 2020-10-22 03:51:06 +03:00
Ricky Stewart 43baed3c18 Bug 1654103: Standardize on Black for Python code in mozilla-central. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-21 21:27:27 +00:00
Julian Descottes df0567bb2c Bug 1472821 - Support array of String for lazyRequireGetter r=nchevobbe,rcaliman
Differential Revision: https://phabricator.services.mozilla.com/D85268
2020-08-03 05:43:59 +00:00
Logan Smyth aa54da359d Bug 1470768 - Allow sourceURL to apply generally across all types of scripts. r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D72104
2020-04-27 02:13:54 +00:00
Cosmin Sabou 9ac5d4d34a Backed out 6 changesets (bug 1470768, bug 1607639) for causing xpc failures on xpcshell/test_objectgrips-13.js. CLOSED TREE
Backed out changeset 15642af7fdbd (bug 1607639)
Backed out changeset 53565f45e275 (bug 1607639)
Backed out changeset 9f1749c622fe (bug 1607639)
Backed out changeset 747efa62d7d6 (bug 1607639)
Backed out changeset 10d0aed39069 (bug 1607639)
Backed out changeset 70aa92ce25b7 (bug 1470768)
2020-04-24 10:27:28 +03:00
Logan Smyth c6a0369179 Bug 1470768 - Allow sourceURL to apply generally across all types of scripts. r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D72104
2020-04-24 06:11:17 +00:00
Logan Smyth 52eef2830d Bug 1624507 - Part 1: Remove unused lazyRequire(Module). r=ochameau
These functions don't appear to ever be used by devtools since we instead
use the `loader.lazyRequireGetter` utility.

Differential Revision: https://phabricator.services.mozilla.com/D67975
2020-03-30 08:22:52 +00:00
Mark Banner d375cfec54 Bug 1620542 - Automatically fix ESLint errors in .eslintrc.js files. r=mossop
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D65703
2020-03-07 10:09:44 +00:00