Commit Graph
47 Commits
Author SHA1 Message Date
Chris Vander Linden a453ba35a8 Bug 2022405 - Use private class fields in devtools/client/framework/devtools.js. r=nchevobbe,devtools-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D288553
2026-03-24 01:00:07 +00:00
Nicolas Chevobbe 78734c2bf3 Bug 1994372 - [devtools] Enable rollout-valid-jsdoc and rollout-require-jsdoc for devtools/startup. r=devtools-reviewers,frontend-codestyle-reviewers,jdescottes.
Differential Revision: https://phabricator.services.mozilla.com/D268663
2025-10-16 05:05:14 +00:00
Alexandre Poirot 33ffbbf1b5 Bug 1991420 - [devtools] Prevent any further execution once actions are cancelled. r=devtools-reviewers,nchevobbe
This uses a pattern similar to DebuggerContextError exception.
Once the panel closes, we start throwing exception to prevent any further code from running.
As for DebuggerContextError, we need to ignore these exceptions while running tests.

Differential Revision: https://phabricator.services.mozilla.com/D267184
2025-10-06 10:21:38 +00:00
Gijs Kruitbosch 780b4fb75f Bug 1967204 - remove devtools eslint-env browser annotations, r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D266835
2025-10-01 09:59:33 +00:00
Julian Descottes 54c8bd98a4 Bug 1898415 - [devtools] Update test file for browser_command_line_urls.js to define correct line numbers r=devtools-reviewers,bomsy
Test is expecting to select lines 5 and 6, but they are not valid in the test file.
This might also indicate the test is badly written and not properly checking the line / column selection.

Differential Revision: https://phabricator.services.mozilla.com/D257990
2025-07-22 01:16:57 +00:00
Julian Descottes c1dbbd3a81 Bug 1974700 - [devtools] Try to reset all devtools preferences in shared-head's registerCleanupFunction r=devtools-reviewers,nchevobbe,profiler-reviewers,canaltinova
Differential Revision: https://phabricator.services.mozilla.com/D255493
2025-07-01 11:54:39 +00:00
Joel Maher 76447d27c5 Bug 1957258 - cleanup devtools-chrome .toml manifest, enable many tests! r=aryx,devtools-reviewers,profiler-reviewers,julienw,ochameau,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D243603
2025-04-04 15:06:02 +00:00
Sebastian Hengst 8424c52dc1 Bug 1922355 - macOS 14.70: adjust expectations for mochitests and xpcshell tests. r=jmaher,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D228118
2024-11-19 17:19:24 +00:00
Emilio Cobos Álvarez 1e2032c268 Bug 1927404 - Make each line in view-source a <span> rather than a <pre>. r=hsivonen
Differential Revision: https://phabricator.services.mozilla.com/D227061
2024-11-05 09:54:42 +00:00
Alexandre Poirot 7c07e66e35 Bug 1832824 - [devtools] Fix browser_command_line_urls.js intermittent. r=devtools-reviewers,nchevobbe
View source may update the selection late.

Differential Revision: https://phabricator.services.mozilla.com/D210974
2024-05-21 08:32:13 +00:00
Yi Xiong Wong bef11a2dc2 Bug 1880914 - Move browser/tab closing functions. r=Gijs,perftest-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,sfoster,kshampur
Differential Revision: https://phabricator.services.mozilla.com/D206197
2024-04-08 17:21:01 +00:00
Alexandre Poirot 1f027f0328 Bug 1866814 - [devtools] Wait for the location to be updated in browser_command_line_urls.js. r=devtools-reviewers,nchevobbe
This tweak helps run the test many times in a row with --run-until-failure.

Differential Revision: https://phabricator.services.mozilla.com/D204871
2024-03-26 08:30:10 +00:00
Alexandre Poirot 56abd2a450 Bug 1866814 - [devtools] Test against the right tab in browser_command_line_urls.js. r=devtools-reviewers,nchevobbe
The test wasn't selected the newly created tab and was trying to open devtools
on the blank tab.

Differential Revision: https://phabricator.services.mozilla.com/D204652
2024-03-26 08:30:10 +00:00
Dave Townsend 2af4d349f3 Bug 1864896: Autofix unused function arguments (devtools). r=profiler-reviewers,devtools-reviewers,nchevobbe,julienw
Differential Revision: https://phabricator.services.mozilla.com/D202959
2024-03-05 14:21:15 +00:00
Tooru Fujisawa 4a19125f4a Bug 1865005 - Use 1-based column number in tracer and DevToolsStartup command line handling. r=ochameau,devtools-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D193981
2023-11-22 12:31:35 +00:00
Natalia Csoregi e0d56104a6 Backed out 14 changesets (bug 1865005, bug 1864168, bug 1864155, bug 1862814, bug 1862693) for causing bustage on nsRFPService.cpp. CLOSED TREE
Backed out changeset a4f3e7625abf (bug 1865005)
Backed out changeset ab38141e470b (bug 1862814)
Backed out changeset a679b50dc4a9 (bug 1862814)
Backed out changeset e340886ce62a (bug 1862814)
Backed out changeset 1378502e64b0 (bug 1862814)
Backed out changeset 8ee94e5e79c2 (bug 1862814)
Backed out changeset 6d4ef1cdfabb (bug 1864168)
Backed out changeset 2c30c4d757fc (bug 1864168)
Backed out changeset d4db9576559b (bug 1864168)
Backed out changeset 8ffec0d83028 (bug 1864168)
Backed out changeset fa77d852b494 (bug 1864168)
Backed out changeset f6646771a26a (bug 1864168)
Backed out changeset 7bd0ff6986df (bug 1864155)
Backed out changeset 39867b503289 (bug 1862693)
2023-11-22 14:01:55 +02:00
Tooru Fujisawa fcb2a8ff10 Bug 1865005 - Use 1-based column number in tracer and DevToolsStartup command line handling. r=ochameau,devtools-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D193981
2023-11-22 11:13:58 +00:00
Tom Marble 6c1231e2e8 Bug 1853244 - convert .ini manifests to .toml: batch 6 {caps,devtools,dom}/**/browser.ini r=jmaher,media-playback-reviewers,devtools-reviewers,profiler-reviewers,alwu,nchevobbe,canaltinova
Differential Revision: https://phabricator.services.mozilla.com/D188856
2023-09-22 20:42:14 +00:00
Alexandre Poirot 140d755231 Bug 1845768 - [devtools] Only try to open URL as JS files in debugger/view-source if DevTools are opened in the current tab. r=devtools-reviewers,perftest-reviewers,jdescottes,sparky
This will prevent opening any links with the ":\d+" suffix anytime devtools were opened in the past.

Differential Revision: https://phabricator.services.mozilla.com/D185826
2023-08-21 08:01:36 +00:00
Mark Banner 91fde42f7b Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish
Differential Revision: https://phabricator.services.mozilla.com/D177025
2023-05-20 12:26:49 +00:00
Alexandre Poirot 782c6e1335 Bug 1825511 - [devtools] Log JavaScript traces to stdout with hyperlinks and handle them in firefox startup. r=nchevobbe,devtools-reviewers
The JavaScript tracer will log special format of links, including a precise location,
by appending `@${line}:${column}` to each frame's source's URL.
This URL pattern is later interpreted by DevTools command line handler in order
to automatically open the source's location in the debugger.

Differential Revision: https://phabricator.services.mozilla.com/D174098
2023-05-12 11:33:27 +00:00
Gijs Kruitbosch cf966c55ab Bug 1795255 - autofix duplicate imports in tests under devtools, r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D167716
2023-01-31 11:48:42 +00:00
Alexandre Poirot 6cfca638f1 Bug 1797730 - [devtools] Rename gDevTools._toolboxes to gDevTools._toolboxesPerCommands. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D160618
2022-10-29 07:48:08 +00:00
Mark Banner 5407bdffa8 Bug 1792341 - Migrate more toolkit/modules consumers to use direct ES module import. r=Gijs,webdriver-reviewers,perftest-reviewers,necko-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,sgalich,owlish,bytesized,AlexandruIonescu,whimboo,mconley,mixedpuppy
Mainly automated changes. Some manual ESLint fixes and whitespace cleanup.

Differential Revision: https://phabricator.services.mozilla.com/D158452
2022-10-18 11:21:26 +00:00
Alexandre Poirot bde84f5b65 Bug 1793604 - [devtools] Convert Loader.jsm to ESM. r=perftest-reviewers,geckoview-reviewers,preferences-reviewers,owlish,kshampur,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D158582
2022-10-14 12:19:42 +00:00
Alexandre Poirot 58b38d7c16 Bug 1791969 - [devtools] Import all JSM in DevTools via ChromeUtils.import. r=jdescottes
Convert all imports but the one related to SessionDataHelper
as that's an hybrid module which is loaded as a JSM from the main thread,
but loaded as a common js module from the worker thread.

We will be able to drop this once we can migrate this JSM to ESM
once we support loading ESM from the worker thread.

Differential Revision: https://phabricator.services.mozilla.com/D158007
2022-09-26 13:01:33 +00:00
Julian Descottes d4108a1c54 Bug 1609100 - [devtools] Remove unused about:devtools page r=devtools-reviewers,fluent-reviewers,flod,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D141464
2022-03-28 11:12:06 +00:00
Norisz Fay c71e9ba091 Backed out 5 changesets (bug 1609100) for causing mochitest failures on browser_check_identity_state.js CLOSED TREE
Backed out changeset 521cbbae0914 (bug 1609100)
Backed out changeset e22daee724f0 (bug 1609100)
Backed out changeset e5c4afe5dd66 (bug 1609100)
Backed out changeset e6ae2c01908e (bug 1609100)
Backed out changeset 3e59351660ab (bug 1609100)
2022-03-28 13:11:58 +03:00
Julian Descottes d0b575fc32 Bug 1609100 - [devtools] Remove unused about:devtools page r=devtools-reviewers,fluent-reviewers,flod,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D141464
2022-03-28 08:57:36 +00:00
Julian Descottes 06b42b006a Bug 1741369 - [devtools] Update paths to loader files in devtools/ r=ochameau
Depends on D131216

Differential Revision: https://phabricator.services.mozilla.com/D131217
2021-11-17 12:43:26 +00:00
pestanoah a54cb4eeba Bug 1724284 - Renamed Browser Tools id to browserToolsMenu. r=mhowell,mtigley
Differential Revision: https://phabricator.services.mozilla.com/D125331
2021-10-13 14:19:02 +00:00
Sam Foster 0c5b78ddbd Bug 1719463 - Part 10: Remove the devtools button from the pre-proton appMenu view. r=jdescottes,Gijs,mkaply
Differential Revision: https://phabricator.services.mozilla.com/D121810
2021-08-10 05:29:33 +00:00
Alexandre Poirot aa4c30771b Bug 1700106 - [devtools] Remove now-useless eslint files related to mochitests. r=jdescottes,Standard8
I kept a few having some overrides. But they may be irrelevant.
And I kept some eslint files for all folder that aren't matching the pattern matching "**/test*/**/browser*/".
Ideally we would rename these folder to match.

Last but not least, I identified one case where we were using mochitest file for xpcshell tests!

Differential Revision: https://phabricator.services.mozilla.com/D109481
2021-03-23 15:51:18 +00:00
Alexandre Poirot f639f4098e Bug 1700106 - [devtools] Remove the balanced-observers eslint disabling from DevTools mochitests. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D109476
2021-03-23 15:51:17 +00:00
Emma Malysz 81a83433a7 Bug 1634030: lazify main app menu r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D84014
2020-08-10 17:09:55 +00:00
Mark Banner d375cfec54 Bug 1620542 - Automatically fix ESLint errors in .eslintrc.js files. r=mossop
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D65703
2020-03-07 10:09:44 +00:00
Nicolas Chevobbe 290ba5cb21 Bug 1568779 - Remove editors settings comments in devtools files. r=pbro.
Differential Revision: https://phabricator.services.mozilla.com/D42300
2019-08-19 12:48:16 +00:00
Victor Porof 435f7b056d Bug 1561435 - Format remaining devtools/, a=automatic-formatting, CLOSED TREE
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D35894
2019-07-05 11:29:32 +02:00
Kris Maglione 856fa07b17 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750
2019-01-17 10:18:31 -08:00
Jonathan Kingston d50c555bf6 Bug 1362034 - Tests for addTab() to provide the correct triggering principal. r=ckerschb r?=gijs
Summary: Depends on D2046

Reviewers: ckerschb!, Gijs!

Tags: #secure-revision

Bug #: 1362034

Differential Revision: https://phabricator.services.mozilla.com/D2047
2018-07-06 21:16:29 +01:00
dvarga 86b7ee6d9f Backed out 2 changesets (bug 1362034) for failure at browser/tools/mozscreenshots/primaryUI/browser_primaryUI.js on a CLOSED TREE
Backed out changeset 1c3329958b8a (bug 1362034)
Backed out changeset f68b1b76af36 (bug 1362034)
2018-08-08 22:11:56 +03:00
Jonathan Kingston 92858e3e21 Bug 1362034 - Tests for addTab() to provide the correct triggering principal. r=ckerschb,Gijs
Summary: Depends on D2046

Reviewers: ckerschb, Gijs

Reviewed By: ckerschb, Gijs

Bug #: 1362034

Differential Revision: https://phabricator.services.mozilla.com/D2047
2018-08-08 20:05:30 +03:00
Andreea Pavel 31fb9c007c Backed out 2 changesets (bug 1362034) for failing damp | inspector/cold-open.js on a CLOSED TREE
Backed out changeset 8c8925b75aa2 (bug 1362034)
Backed out changeset ff6b05c96094 (bug 1362034)
2018-08-06 20:42:44 +03:00
Jonathan Kingston c7bb2480d8 Bug 1362034 - Tests for addTab() to provide the correct triggering principal. r=ckerschb,Gijs
Summary: Depends on D2046

Reviewers: ckerschb, Gijs

Reviewed By: ckerschb, Gijs

Bug #: 1362034

Differential Revision: https://phabricator.services.mozilla.com/D2047
2018-08-06 19:56:37 +03:00
Julian Descottes 82711b9a8f Bug 1454696 - Run eslint --fix for prefer-const;r=yulia
MozReview-Commit-ID: F6xUXCgdRE4
2018-06-01 12:36:09 +02:00
Julian Descottes 662ad40e62 Bug 1441507 - Fix window focus issue for intermittent browser_shim_disable_devtools;r=pbro
MozReview-Commit-ID: 1e4NmJNdP3G
2018-05-04 19:40:23 +02:00
Julian Descottes 60b399b826 Bug 1444926 - Move devtools/shim to devtools/startup;r=ochameau
MozReview-Commit-ID: K9WuJuTdYHS
2018-03-12 14:41:48 +01:00