Sylvestre Ledru
741bbdea29
Bug 2036402 - Apply std::move in dom/base where values can be moved instead of copied r=dom-core,smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D298095
2026-05-04 11:17:52 +00:00
Emilio Cobos Álvarez
12175ecc61
Bug 2033243 - Other miscellaneous ownerGlobal-related naming removal. r=dom-core,smaug
...
These are manual but straight-forward.
Differential Revision: https://phabricator.services.mozilla.com/D297186
2026-05-02 22:04:23 +00:00
Emilio Cobos Álvarez
22f942bd6d
Bug 2033243 - BindToOwner -> BindToGlobal. r=dom-core,smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D297185
2026-05-02 22:04:20 +00:00
Emilio Cobos Álvarez
1bd0da8bf7
Bug 2033243 - Rename GetOwnerGlobal to GetRelevantGlobal. r=dom-core,media-playback-reviewers,credential-management-reviewers,webrtc-reviewers,dom-storage-reviewers,firefox-style-system-reviewers,dimi,janv,dshin,aosmond,smaug
...
As per the HTML terminology (https://html.spec.whatwg.org/#relevant )
Automatic rename using sed + lints.
Differential Revision: https://phabricator.services.mozilla.com/D297184
2026-05-02 22:04:17 +00:00
smayya
2675a40200
Bug 833462 - suppress NS_BINDING_ABORTED errors for SSE. r=necko-reviewers,valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D295721
2026-05-02 21:32:54 +00:00
iulian moraru
480fc572da
Revert "Bug 2036439, Bug 2033243 - Deal with ownerGlobal -> documentGlobal rename in extensions. r=robwu,home-newtab-reviewers,mconley" for causing newtab failures.
...
This reverts commit 4f62279d0191a4ece3565a95a889e17177a68e675263254690
2026-05-02 16:43:35 +00:00
Emilio Cobos Álvarez
91a4ece356
Bug 2033243 - Other miscellaneous ownerGlobal-related naming removal. r=dom-core,smaug
...
These are manual but straight-forward.
Differential Revision: https://phabricator.services.mozilla.com/D297186
2026-05-02 15:33:29 +00:00
Emilio Cobos Álvarez
5a95a889e1
Bug 2033243 - BindToOwner -> BindToGlobal. r=dom-core,smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D297185
2026-05-02 15:33:26 +00:00
Emilio Cobos Álvarez
7177a68e67
Bug 2033243 - Rename GetOwnerGlobal to GetRelevantGlobal. r=dom-core,media-playback-reviewers,credential-management-reviewers,webrtc-reviewers,dom-storage-reviewers,firefox-style-system-reviewers,dimi,janv,dshin,aosmond,smaug
...
As per the HTML terminology (https://html.spec.whatwg.org/#relevant )
Automatic rename using sed + lints.
Differential Revision: https://phabricator.services.mozilla.com/D297184
2026-05-02 15:33:23 +00:00
rperta
d4cc71008d
Revert "Bug 2033243 - Other miscellaneous ownerGlobal-related naming removal. r=dom-core,smaug" on developer request
...
This reverts commit e58e12213584ca206f3ea7945292ed367d83d299
2026-05-02 06:20:30 +00:00
Emilio Cobos Álvarez
e58e122135
Bug 2033243 - Other miscellaneous ownerGlobal-related naming removal. r=dom-core,smaug
...
These are manual but straight-forward.
Differential Revision: https://phabricator.services.mozilla.com/D297186
2026-05-01 11:58:19 +00:00
Emilio Cobos Álvarez
84ca206f3e
Bug 2033243 - BindToOwner -> BindToGlobal. r=dom-core,smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D297185
2026-05-01 11:58:17 +00:00
Emilio Cobos Álvarez
a7945292ed
Bug 2033243 - Rename GetOwnerGlobal to GetRelevantGlobal. r=dom-core,media-playback-reviewers,credential-management-reviewers,webrtc-reviewers,dom-storage-reviewers,firefox-style-system-reviewers,dimi,janv,dshin,aosmond,smaug
...
As per the HTML terminology (https://html.spec.whatwg.org/#relevant )
Automatic rename using sed + lints.
Differential Revision: https://phabricator.services.mozilla.com/D297184
2026-05-01 11:58:14 +00:00
agoloman
c814da612d
Revert "Bug 2033243 - Other miscellaneous ownerGlobal-related naming removal. r=dom-core,smaug" for causing multiple failures.
...
This reverts commit c7246654bc8873ddf33c8bf999e03c7dea1af2e0
2026-04-30 20:13:14 +00:00
Emilio Cobos Álvarez
c7246654bc
Bug 2033243 - Other miscellaneous ownerGlobal-related naming removal. r=dom-core,smaug
...
These are manual but straight-forward.
Differential Revision: https://phabricator.services.mozilla.com/D297186
2026-04-30 17:47:17 +00:00
Emilio Cobos Álvarez
8873ddf33c
Bug 2033243 - BindToOwner -> BindToGlobal. r=dom-core,smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D297185
2026-04-30 17:47:14 +00:00
Emilio Cobos Álvarez
8bf999e03c
Bug 2033243 - Rename GetOwnerGlobal to GetRelevantGlobal. r=dom-core,media-playback-reviewers,credential-management-reviewers,webrtc-reviewers,dom-storage-reviewers,firefox-style-system-reviewers,dimi,janv,dshin,aosmond,smaug
...
As per the HTML terminology (https://html.spec.whatwg.org/#relevant )
Automatic rename using sed + lints.
Differential Revision: https://phabricator.services.mozilla.com/D297184
2026-04-30 17:47:11 +00:00
Silaghi
8c7a68a4c2
Revert "Bug 833462 - suppress NS_BINDING_ABORTED errors for SSE. r=necko-reviewers,valentin" for causing wpt failures at EventSource
...
This reverts commit 0d35f4d1fd
2026-04-24 17:18:21 +00:00
smayya
0d35f4d1fd
Bug 833462 - suppress NS_BINDING_ABORTED errors for SSE. r=necko-reviewers,valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D295721
2026-04-24 16:06:09 +00:00
Tom Schuster
14d1a3af39
Bug 2031064 - Use ClientInfo when creating EventSource. r=asuth,dom-worker-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D293841
2026-04-16 10:38:35 +00:00
serge-sans-paille
f81328e365
Bug 2023519 - Make our codebase modernize-use-equals-default + modernize-use-equals-delete -safe wrt. clang-tidy r=sylvestre,necko-reviewers,media-playback-reviewers,profiler-reviewers,dom-storage-reviewers,layout-reviewers,dom-worker-reviewers,valentin,jesup,padenot,edenchuang,emilio
...
The changeset has been generated automatically through:
./mach static-analysis check --output ./clang-tidy-bugprone.json --format json --fix
followed by manual adjustment when needed or when the auto-fixer bailed out.
This paves the way for Bug 2023527
Differential Revision: https://phabricator.services.mozilla.com/D287941
2026-03-22 08:35:47 +00:00
Alexandru Marc
04e5f74151
Revert "Bug 2023519 - Make our codebase modernize-use-equals-default + modernize-use-equals-delete -safe wrt. clang-tidy r=sylvestre,necko-reviewers,media-playback-reviewers,profiler-reviewers,dom-storage-reviewers,layout-reviewers,dom-worker-reviewers,valentin,jesup,padenot,edenchuang,emilio"
...
This reverts commit a64dec2665
2026-03-19 17:29:58 +00:00
serge-sans-paille
a64dec2665
Bug 2023519 - Make our codebase modernize-use-equals-default + modernize-use-equals-delete -safe wrt. clang-tidy r=sylvestre,necko-reviewers,media-playback-reviewers,profiler-reviewers,dom-storage-reviewers,layout-reviewers,dom-worker-reviewers,valentin,jesup,padenot,edenchuang,emilio
...
The changeset has been generated automatically through:
./mach static-analysis check --output ./clang-tidy-bugprone.json --format json --fix
followed by manual adjustment when needed or when the auto-fixer bailed out.
This paves the way for Bug 2023527
Differential Revision: https://phabricator.services.mozilla.com/D287941
2026-03-18 17:25:01 +00:00
Sylvestre Ledru
9eb1a31a98
Bug 2023419 - Remove Emacs/Vim modelines from dom/ r=emilio,media-playback-reviewers,webidl,padenot
...
replaced by .editorconfig
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D287843
2026-03-16 21:02:32 +00:00
serge-sans-paille
1f7aef5981
Bug 2013545 - Move copy assignment to move assignment in dom/ r=media-playback-reviewers,webrtc-reviewers,bwc,padenot
...
More specifically: moving nsCOMPtr is more efficient than copying them,
and the comment also applies to scoped_refptr, std::vector.
It's also faster to move a HostObjectURIParams into an URIParams.
Differential Revision: https://phabricator.services.mozilla.com/D281224
2026-02-02 11:00:39 +00:00
Jens Stutte
6829afc661
Bug 1999508 - Introduce nsIEventTarget::GetFeatures. r=xpcom-reviewers,necko-reviewers,dom-worker-reviewers,nika,asuth,valentin
...
Introduces SUPPORTS_SHUTDOWN_TASKS and SUPPORTS_SHUTDOWN_TASK_DISPATCH flags.
This just wires the function through all event targets without ever being used.
Differential Revision: https://phabricator.services.mozilla.com/D272150
2026-01-28 07:24:07 +00:00
serge-sans-paille
1667ec582b
Bug 1995723 - Remove unused inclusion of mozilla/ArrayUtils.h r=necko-reviewers,application-update-reviewers,media-playback-reviewers,profiler-reviewers,win-reviewers,firefox-svg-reviewers,layout-reviewers,gstoll,canaltinova,bytesized,alwu,dholbert
...
Differential Revision: https://phabricator.services.mozilla.com/D269573
2025-10-23 07:30:37 +00:00
serge-sans-paille
7662b3abdc
Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch
...
It is replaced by a standard-conforming cast to (void) which is
understood the same by the compiler.
In some cases this could be replaced by `[[maybe_unused]]` but for
expression whose value is ignored, this requires storing to a temporary
variable first, so not going that way.
One notable change is that marking an object of type already_AddRefed as
unused used to implicitly leak memory. This is now made explicit.
Most of the heavy lifting was done through:
$ git grep -l '\<Unused\> <<' | xargs sed -i -e 's/Unused << /(void)/g'
$ git grep -l mozilla/Unused.h | xargs sed -i -e '/mozilla\/Unused.h/ d'
Differential Revision: https://phabricator.services.mozilla.com/D268706
2025-10-21 19:36:01 +00:00
Cristina Horotan
8a1b1970b7
Revert "Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch" for causing Gtest failures on AlreadyAddRefed.h
...
This reverts commit e98adca292
2025-10-21 16:16:29 +00:00
serge-sans-paille
e98adca292
Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch
...
It is replaced by a standard-conforming cast to (void) which is
understood the same by the compiler.
In some cases this could be replaced by `[[maybe_unused]]` but for
expression whose value is ignored, this requires storing to a temporary
variable first, so not going that way.
One notable change is that marking an object of type already_AddRefed as
unused used to implicitly leak memory. This is now made explicit.
Most of the heavy lifting was done through:
$ git grep -l '\<Unused\> <<' | xargs sed -i -e 's/Unused << /(void)/g'
$ git grep -l mozilla/Unused.h | xargs sed -i -e '/mozilla\/Unused.h/ d'
Differential Revision: https://phabricator.services.mozilla.com/D268706
2025-10-21 15:05:17 +00:00
Valentin Gosu
2340085650
Bug 1995068 - Avoid null pointer deref in EventSourceImpl::ReestablishConnection r=necko-reviewers,sunil
...
Differential Revision: https://phabricator.services.mozilla.com/D269245
2025-10-21 12:38:55 +00:00
Cristina Horotan
aab924e90d
Revert "Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch" for causing build bustage at nsBrowserApp.cpp
...
This reverts commit fd0ffa193c
2025-10-21 10:44:13 +00:00
serge-sans-paille
fd0ffa193c
Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch
...
It is replaced by a standard-conforming cast to (void) which is
understood the same by the compiler.
In some cases this could be replaced by `[[maybe_unused]]` but for
expression whose value is ignored, this requires storing to a temporary
variable first, so not going that way.
One notable change is that marking an object of type already_AddRefed as
unused used to implicitly leak memory. This is now made explicit.
Most of the heavy lifting was done through:
$ git grep -l '\<Unused\> <<' | xargs sed -i -e 's/Unused << /(void)/g'
$ git grep -l mozilla/Unused.h | xargs sed -i -e '/mozilla\/Unused.h/ d'
Differential Revision: https://phabricator.services.mozilla.com/D268706
2025-10-21 09:44:11 +00:00
Narcis Beleuzu
e1e6bbb1c9
Revert "Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch" for causing bustages on Document.cpp
...
This reverts commit b23c15e927
2025-10-21 06:34:58 +00:00
serge-sans-paille
b23c15e927
Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch
...
It is replaced by a standard-conforming cast to (void) which is
understood the same by the compiler.
In some cases this could be replaced by `[[maybe_unused]]` but for
expression whose value is ignored, this requires storing to a temporary
variable first, so not going that way.
One notable change is that marking an object of type already_AddRefed as
unused used to implicitly leak memory. This is now made explicit.
Most of the heavy lifting was done through:
$ git grep -l '\<Unused\> <<' | xargs sed -i -e 's/Unused << /(void)/g'
$ git grep -l mozilla/Unused.h | xargs sed -i -e '/mozilla\/Unused.h/ d'
Differential Revision: https://phabricator.services.mozilla.com/D268706
2025-10-21 06:01:36 +00:00
serge-sans-paille
160944c54a
Bug 1993127 - Remove unused inclusion of mozilla/Attributes.h r=emilio,decoder,devtools-reviewers,win-reviewers,migration-reviewers,dom-worker-reviewers,gstoll
...
Plus a similarly unused inclusion of mozilla/Likely.h
Differential Revision: https://phabricator.services.mozilla.com/D267881
2025-10-17 08:18:04 +00:00
serge-sans-paille
418a8f52a1
Bug 1994393 - Remove unused inclusion of mozilla/UniquePtrExtensions.h r=emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D268683
2025-10-15 19:49:46 +00:00
Kelsey Gilbert
f5e3591910
Bug 1958371 - Reduce header-header-includes of nsGlobalWindowInner.h. r=mccr8,chutten,timhuang
...
* Forward s/nsGlobalWindowInner_CachesEnabled/nsGlobalWindowInner::CachesEnabled/.
Differential Revision: https://phabricator.services.mozilla.com/D244408
2025-09-05 19:36:07 +00:00
Nika Layzell
b66d532c27
Bug 1824189 - Add a NS_DISPATCH_FALLIBLE flag to specify that events should not be leaked on error, r=xpcom-reviewers,necko-reviewers,geckoview-reviewers,media-playback-reviewers,webrtc-reviewers,bwc,padenot,emilio,jstutte,dom-worker-reviewers,asuth,kershaw,ohall
...
Differential Revision: https://phabricator.services.mozilla.com/D258327
2025-08-26 16:47:30 +00:00
agoloman
2c8936cbbf
Revert "Bug 1958371 - Reduce header-header-includes of nsGlobalWindowInner.h. r=mccr8,chutten,timhuang" for causing build bustages @TimeoutManager.cpp.
...
This reverts commit 4b30815167
2025-08-26 16:37:54 +00:00
Kelsey Gilbert
4b30815167
Bug 1958371 - Reduce header-header-includes of nsGlobalWindowInner.h. r=mccr8,chutten,timhuang
...
* Forward s/nsGlobalWindowInner_CachesEnabled/nsGlobalWindowInner::CachesEnabled/.
Differential Revision: https://phabricator.services.mozilla.com/D244408
2025-08-26 15:30:13 +00:00
Atila Butkovits
a906e9e172
Revert "Bug 1824189 - Add a NS_DISPATCH_FALLIBLE flag to specify that events should not be leaked on error, r=xpcom-reviewers,necko-reviewers,geckoview-reviewers,media-playback-reviewers,webrtc-reviewers,bwc,padenot,emilio,jstutte,dom-worker-reviewers,asuth,kershaw,ohall" for causing leaks complaining about MediaTransportHandlerSTS.
...
This reverts commit 381d5dd6f0
2025-08-26 00:43:59 +00:00
Nika Layzell
381d5dd6f0
Bug 1824189 - Add a NS_DISPATCH_FALLIBLE flag to specify that events should not be leaked on error, r=xpcom-reviewers,necko-reviewers,geckoview-reviewers,media-playback-reviewers,webrtc-reviewers,bwc,padenot,emilio,jstutte,dom-worker-reviewers,asuth,kershaw,ohall
...
Differential Revision: https://phabricator.services.mozilla.com/D258327
2025-08-25 23:20:08 +00:00
Tim Huang
c5f9c61be9
Bug 1973574 - Ensure the loadInfo.isInThirdPartyContext is set for channels created by EventSource in workers. r=bvandersloot
...
Differential Revision: https://phabricator.services.mozilla.com/D261762
2025-08-22 10:17:09 +00:00
agoloman
fe283cdba3
Revert "Bug 1973574 - Ensure the loadInfo.isInThirdPartyContext is set for channels created by EventSource in workers. r=anti-tracking-reviewer-rotation,bvandersloot" for causing lint failures @eventsource_worker.js.
...
This reverts commit 1c23772691
2025-08-21 13:23:39 +00:00
Tim Huang
1c23772691
Bug 1973574 - Ensure the loadInfo.isInThirdPartyContext is set for channels created by EventSource in workers. r=anti-tracking-reviewer-rotation,bvandersloot
...
Differential Revision: https://phabricator.services.mozilla.com/D261762
2025-08-21 12:24:25 +00:00
Emilio Cobos Álvarez
791917d8af
Bug 1976665 - Sort headers in dom/. r=dom-core,media-playback-reviewers,webrtc-reviewers,dom-storage-reviewers,padenot,janv,smaug,jesup,jib
...
Most changes are automated. Relevant bit is dom/.clang-format. I had to
manually disable clang-format in a few places where importing external
files and so on that aren't self-contained, and fix a couple includes /
forward declarations.
Differential Revision: https://phabricator.services.mozilla.com/D256800
2025-08-05 11:47:34 +00:00
kernp25
4d18975ff5
Bug 1945924 - Replace SchemeIsFoo functions with the inlined SchemeIs() call. r=valentin,emilio,necko-reviewers,geckoview-reviewers,anti-tracking-reviewers,core-sessionstore-reviewers,ohall,farre
...
No behavior change intended.
Differential Revision: https://phabricator.services.mozilla.com/D236756
2025-03-31 14:25:54 +00:00
Eden Chuang
7e6b550f82
Bug 1932468 - Making EventSourceImpl::mWorkerRef accessing be thread-safe. r=dom-worker-reviewers,asuth
...
EventSourceImpl::mWorkerRef is not accessed on the Worker thread only.
When EventSourceImpl::Dispatch is called, it could be on any thread, so the race could happen if Worker is shuttdown at the same time.
This patch uses DataMutex to protect EventSourceImpl::mWorkerRef.
Differential Revision: https://phabricator.services.mozilla.com/D239515
2025-02-26 08:02:02 +00:00
Andrea Marchesini
ad988ad75c
Bug 1921627 - Fix WPT eventsource-constructor-empty-url.any.worker.html, r=asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D224059
2024-10-01 12:21:12 +00:00
Sylvestre Ledru