Masayuki Nakano
6388e58841
Bug 2044523 - Make nsPIDOMWindow.h stop including nsPIDOMWindowInlines.h r=dom-core-reviewers,geckoview-reviewers,media-playback-reviewers,webrtc-reviewers,win-reviewers,layout-reviewers,manuel,aosmond,smaug,bwc,gstoll,dholbert,farre,m_kato
...
This patch does not make some header files stop including the inline
header because fixing them require more changes.
Note that `#include "nsComponentManagerUtils.h"` is fixing a bustage
caused by "use of undeclared identifier 'do_CreateInstance'" error.
Differential Revision: https://phabricator.services.mozilla.com/D304432
2026-06-09 03:49:55 +00:00
Sylvestre Ledru
9eb1a31a98
Bug 2023419 - Remove Emacs/Vim modelines from dom/ r=emilio,media-playback-reviewers,webidl,padenot
...
replaced by .editorconfig
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D287843
2026-03-16 21:02:32 +00:00
Jonathan Kingston
328a9fb6f7
Bug 2011056 - Handle OwnPropertyKeys according to the spec r=tschuster
...
Differential Revision: https://phabricator.services.mozilla.com/D279096
2026-02-02 11:21:05 +00:00
Atila Butkovits
69888f5835
Revert "Bug 2011056 - Handle OwnPropertyKeys according to the spec r=tschuster" for causing failures at test_window_element_enumeration.html.
...
This reverts commit f63bd5a50f .
2026-01-25 19:50:47 +00:00
Jonathan Kingston
f63bd5a50f
Bug 2011056 - Handle OwnPropertyKeys according to the spec r=tschuster
...
Differential Revision: https://phabricator.services.mozilla.com/D279096
2026-01-25 18:45:48 +00:00
Emilio Cobos Álvarez
791917d8af
Bug 1976665 - Sort headers in dom/. r=dom-core,media-playback-reviewers,webrtc-reviewers,dom-storage-reviewers,padenot,janv,smaug,jesup,jib
...
Most changes are automated. Relevant bit is dom/.clang-format. I had to
manually disable clang-format in a few places where importing external
files and so on that aren't self-contained, and fix a couple includes /
forward declarations.
Differential Revision: https://phabricator.services.mozilla.com/D256800
2025-08-05 11:47:34 +00:00
Edgar Chen
3d0d8aa9c3
Bug 834208 - Align the document name getter with the spec and other browsers; r=smaug,devtools-reviewers,ochameau
...
Original patch: https://hg.mozilla.org/mozreview/gecko/rev/7d93b7e3c1499b0b81d970722537b98f5d88efdd
Original author: Aryeh Gregor <[email protected] >
According to the spec,
- https://html.spec.whatwg.org/#dom-document-nameditem
- https://html.spec.whatwg.org/#named-access-on-the-window-object
the document and window named getters return different values. This patch creates
a separated content list for document named getter while keeping the original
content list for the window named getter. Additionally, the content list now
includes both names and ids, in addition to the id list (which is still used for
other things like getElementById()).
This means one element might be on up to multiple lists, but this implementation
is necessary. Specifically, we must return a consistent live list for document.foo
and for window.foo, so they need to be stored separately and cannot be generated
on the fly from a single shared list.
Differential Revision: https://phabricator.services.mozilla.com/D240951
2025-03-20 15:42:43 +00:00
Norisz Fay
fbba6901d1
Backed out changeset c28cc6141d04 (bug 834208) for causing bustage on nsHTMLDocument.cpp
2025-03-20 15:50:36 +02:00
Edgar Chen
b60c7d8733
Bug 834208 - Align the document name getter with the spec and other browsers; r=smaug,devtools-reviewers,ochameau
...
Original patch: https://hg.mozilla.org/mozreview/gecko/rev/7d93b7e3c1499b0b81d970722537b98f5d88efdd
Original author: Aryeh Gregor <[email protected] >
According to the spec,
- https://html.spec.whatwg.org/#dom-document-nameditem
- https://html.spec.whatwg.org/#named-access-on-the-window-object
the document and window named getters return different values. This patch creates
a separated content list for document named getter while keeping the original
content list for the window named getter. Additionally, the content list now
includes both names and ids, in addition to the id list (which is still used for
other things like getElementById()).
This means one element might be on up to multiple lists, but this implementation
is necessary. Specifically, we must return a consistent live list for document.foo
and for window.foo, so they need to be stored separately and cannot be generated
on the fly from a single shared list.
Differential Revision: https://phabricator.services.mozilla.com/D240951
2025-03-20 11:41:46 +00:00
Peter Van der Beken
c10814e75a
Bug 1846277 - Remove nsGlobalWindow.h. r=dom-core,necko-reviewers,jesup,farre
...
Differential Revision: https://phabricator.services.mozilla.com/D184973
2023-08-02 20:41:48 +00:00
Peter Van der Beken
3baebe5f4e
Bug 1838818 - Give interface objects their own DOMJSClass. r=edgar
...
Differential Revision: https://phabricator.services.mozilla.com/D181223
2023-06-20 12:16:00 +00:00
Edgar Chen
cf1eed086b
Bug 1683281 - Part 2: Move proxy handler utility functions from DOMJSProxyHandler.h to ProxyHandlerUtils.h; r=peterv
...
Depends on D103469
Differential Revision: https://phabricator.services.mozilla.com/D112277
2022-03-10 22:44:27 +00:00
Jan de Mooij
83229f95a9
Bug 1754405 part 6 - Add JS::GetWellKnownSymbolKey. r=evilpie
...
It's very common to call JS::GetWellKnownSymbol and then creating a PropertyKey.
We can make this a bit more ergonomic with this API.
Differential Revision: https://phabricator.services.mozilla.com/D138277
2022-02-13 12:01:45 +00:00
Peter Van der Beken
493a01b6a0
Bug 1712180 - Make GetOwnProperty on the Window named properties object return supported properties that are indices. r=evilpie
...
Differential Revision: https://phabricator.services.mozilla.com/D115638
2021-05-26 17:11:33 +00:00
Peter Van der Beken
16959e39bb
Bug 1712180 - Make defineProperty on the Window named properties object only throw in strict mode. r=evilpie
...
Differential Revision: https://phabricator.services.mozilla.com/D115637
2021-05-26 17:11:33 +00:00
Tom Schuster
d046c29817
Bug 1710064 - Remove FillPropertyDescriptor. r=peterv
...
I hope I got all the PropertyAttributes right, it's easy to get them confused.
Differential Revision: https://phabricator.services.mozilla.com/D114595
2021-05-11 09:23:18 +00:00
Tom Schuster
3879dd4757
Bug 1706404 - BaseDOMProxyHandler::getOwnPropertyDescriptor should return Maybe<PropertyDescriptor>. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D113660
2021-04-29 19:16:42 +00:00
Dorel Luca
6c66885ca0
Backed out 3 changesets (bug 1706404) for Linting failures in builds/worker/checkouts/gecko/dom/bindings/Codegen.py. CLOSED TREE
...
Backed out changeset 5ecbe2eb1d25 (bug 1706404)
Backed out changeset b50507879a6b (bug 1706404)
Backed out changeset b0c0700ce719 (bug 1706404)
2021-04-29 21:31:09 +03:00
Tom Schuster
57a97a7199
Bug 1706404 - BaseDOMProxyHandler::getOwnPropertyDescriptor should return Maybe<PropertyDescriptor>. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D113660
2021-04-29 17:36:48 +00:00
Jan de Mooij
dab720569d
Bug 1673553 part 74 - Remove NewSingletonProxyObject. r=iain
...
Depends on D98505
Differential Revision: https://phabricator.services.mozilla.com/D98506
2020-12-02 20:38:21 +00:00
Sylvestre Ledru
68b806d604
Bug 1674637 - Use nested namespaces in dom/ r=sg,andi
...
Also add some missing namespace qualifications
Done with:
./mach static-analysis check --checks="-*,modernize-concat-nested-namespaces" --fix dom/
./mach clang-format -p $(hg status dom/|grep ^M|awk '{print $2}')
Differential Revision: https://phabricator.services.mozilla.com/D95456
2020-11-04 17:04:01 +00:00
Butkovits Atila
a6e7dcc53f
Backed out changeset c0adbf7522dc (bug 1674637) for bustage on GMPParent.cpp. CLOSED TREE
2020-11-04 10:54:36 +02:00
Sylvestre Ledru
8f709b39e8
Bug 1674637 - Use nested namespaces in dom/ r=sg,andi
...
Also add some missing namespace qualifications
Done with:
./mach static-analysis check --checks="-*,modernize-concat-nested-namespaces" --fix dom/
./mach clang-format -p $(hg status dom/|grep ^M|awk '{print $2}')
Differential Revision: https://phabricator.services.mozilla.com/D95456
2020-11-04 08:29:00 +00:00
Tom Schuster
061ffb19b3
Bug 1277799 - Define @@toStringTag on all DOM interface prototype objects. r=peterv
...
Instead of manually defining toStringTag we now add the toStringTag symbol to the list of properties.
This is also how we usually define toStringTag in the JS engine.
Even though this changes more code I like this approach better. Everything is centralized in the generated bindings file.
Differential Revision: https://phabricator.services.mozilla.com/D72179
2020-05-05 17:54:51 +00:00
Nika Layzell
1cc482023e
Bug 1580565 - Part 4: Use WindowContext to manage BrowsingContext cached status, r=farre
...
The existing infrastructure which stored cached BrowsingContexts on the
BrowsingContextGroup was added before WindowContexts were added, and can cause
racing issues with partially discarded trees during process switches.
Differential Revision: https://phabricator.services.mozilla.com/D71238
2020-04-24 18:33:04 +00:00
Narcis Beleuzu
f160c77a9f
Backed out 7 changesets (bug 1580565) for bustages on nsDocShell.cpp . CLOSED TREE
...
Backed out changeset 8237f9a307f8 (bug 1580565)
Backed out changeset 47f5698d6c72 (bug 1580565)
Backed out changeset e1802670dcc4 (bug 1580565)
Backed out changeset 0a44c410b59b (bug 1580565)
Backed out changeset 20dbcfc9eacc (bug 1580565)
Backed out changeset cdf2b600e779 (bug 1580565)
Backed out changeset a421d33d03ce (bug 1580565)
2020-04-24 05:31:55 +03:00
Nika Layzell
0d1361bf28
Bug 1580565 - Part 4: Use WindowContext to manage BrowsingContext cached status, r=farre
...
The existing infrastructure which stored cached BrowsingContexts on the
BrowsingContextGroup was added before WindowContexts were added, and can cause
racing issues with partially discarded trees during process switches.
Differential Revision: https://phabricator.services.mozilla.com/D71238
2020-04-23 21:52:47 +00:00
Andreea Pavel
8cd16cba50
Backed out 7 changesets (bug 1580565) for bc failures on a CLOSED TREE
...
Backed out changeset e44e0a6366f8 (bug 1580565)
Backed out changeset c0849928f934 (bug 1580565)
Backed out changeset 3d4f155096be (bug 1580565)
Backed out changeset 108d5fb4418e (bug 1580565)
Backed out changeset d8dea951a032 (bug 1580565)
Backed out changeset f9ab41f29552 (bug 1580565)
Backed out changeset fd5d76304c09 (bug 1580565)
2020-04-22 21:51:17 +03:00
Nika Layzell
8e5f9c3d4d
Bug 1580565 - Part 4: Use WindowContext to manage BrowsingContext cached status, r=farre
...
The existing infrastructure which stored cached BrowsingContexts on the
BrowsingContextGroup was added before WindowContexts were added, and can cause
racing issues with partially discarded trees during process switches.
Differential Revision: https://phabricator.services.mozilla.com/D71238
2020-04-22 15:48:17 +00:00
Dorel Luca
4914ab736f
Backed out 7 changesets (bug 1580565) for Gecko-view failures in Test.crashParent. CLOSED TREE
...
Backed out changeset 7da9785ebb06 (bug 1580565)
Backed out changeset a80e177a91b2 (bug 1580565)
Backed out changeset 2cf821f2a6ea (bug 1580565)
Backed out changeset a30f158eba45 (bug 1580565)
Backed out changeset 276b131190a8 (bug 1580565)
Backed out changeset 3c15e4c600c4 (bug 1580565)
Backed out changeset bf8877cdb10f (bug 1580565)
2020-04-22 18:42:24 +03:00
Nika Layzell
b31a5163ac
Bug 1580565 - Part 4: Use WindowContext to manage BrowsingContext cached status, r=farre
...
The existing infrastructure which stored cached BrowsingContexts on the
BrowsingContextGroup was added before WindowContexts were added, and can cause
racing issues with partially discarded trees during process switches.
Differential Revision: https://phabricator.services.mozilla.com/D71238
2020-04-22 06:05:41 +00:00
Bogdan Tara
8557fa3bcd
Backed out 7 changesets (bug 1580565) for browser_entry_point_telemetry.js failures CLOSED TREE
...
Backed out changeset 12a4f3de76a8 (bug 1580565)
Backed out changeset 81d537df2dc1 (bug 1580565)
Backed out changeset b182e872c9d4 (bug 1580565)
Backed out changeset 0b4595b2c153 (bug 1580565)
Backed out changeset 4363e3a3d799 (bug 1580565)
Backed out changeset cbb14b2c7b33 (bug 1580565)
Backed out changeset 46b251848297 (bug 1580565)
2020-04-22 06:15:43 +03:00
Nika Layzell
3e7008cb11
Bug 1580565 - Part 4: Use WindowContext to manage BrowsingContext cached status, r=farre
...
The existing infrastructure which stored cached BrowsingContexts on the
BrowsingContextGroup was added before WindowContexts were added, and can cause
racing issues with partially discarded trees during process switches.
Differential Revision: https://phabricator.services.mozilla.com/D71238
2020-04-22 01:37:55 +00:00
Jeff Walden
7a2ef45277
Bug 949220 - Make |NewProxyObject| return only non-singletons, and add |NewSingletonProxyObject| for the singleton case. r=jandem
...
Differential Revision: https://phabricator.services.mozilla.com/D70502
2020-04-14 16:57:15 +00:00
Bogdan Tara
a5eb751d67
Backed out 30 changesets (bug 949220) for assertion failure on JSObject.cpp CLOSED TREE
...
Backed out changeset b077b434866d (bug 949220)
Backed out changeset 437dc6f1a0b1 (bug 949220)
Backed out changeset 9043d3f4ea6f (bug 949220)
Backed out changeset 761005340836 (bug 949220)
Backed out changeset 650ccbbc2e15 (bug 949220)
Backed out changeset b7459076dbf5 (bug 949220)
Backed out changeset e1ac27ee38e2 (bug 949220)
Backed out changeset 5c07df930240 (bug 949220)
Backed out changeset 42312dec52aa (bug 949220)
Backed out changeset ca28434cf70f (bug 949220)
Backed out changeset c8322158294f (bug 949220)
Backed out changeset 817de77f7cf1 (bug 949220)
Backed out changeset 097d29b3ed26 (bug 949220)
Backed out changeset a2a3821dcc6e (bug 949220)
Backed out changeset cf4659d06791 (bug 949220)
Backed out changeset 53c4c74abb23 (bug 949220)
Backed out changeset a4a124e8f193 (bug 949220)
Backed out changeset 53a89cfb8c24 (bug 949220)
Backed out changeset 69e8d2e49ee1 (bug 949220)
Backed out changeset afb91f3ce31e (bug 949220)
Backed out changeset 43ff0c2fc3dc (bug 949220)
Backed out changeset eda9a8e621b3 (bug 949220)
Backed out changeset 93b33661e87b (bug 949220)
Backed out changeset ddf62ab9e8cc (bug 949220)
Backed out changeset 62fff9f3a631 (bug 949220)
Backed out changeset 45e22642cd49 (bug 949220)
Backed out changeset 54f48761a664 (bug 949220)
Backed out changeset c0d4d9557fac (bug 949220)
Backed out changeset 98ac0d0d392c (bug 949220)
Backed out changeset 2d677ae71924 (bug 949220)
2020-04-14 13:17:51 +03:00
Jeff Walden
675dfc4bcd
Bug 949220 - Make |NewProxyObject| return only non-singletons, and add |NewSingletonProxyObject| for the singleton case. r=jandem
...
Differential Revision: https://phabricator.services.mozilla.com/D70502
2020-04-14 08:37:31 +00:00
Boris Zbarsky
e62a6fc4d1
Bug 1619112 part 2. Pass char literals instead of char16_t literals into ErrorResult throwing methods. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D65538
2020-03-06 21:04:58 +00:00
Simon Giesecke
9bcfd47601
Bug 1611415 - Prefer using std::move over forget. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D60980
2020-02-13 14:38:48 +00:00
shindli
6bb3487209
Backed out changeset 0c982bc69cb3 (bug 1611415) for causing build bustages in /builds/worker/workspace/build/src/obj-firefox/dist/include/nsCOMPtr CLOSED TREE
2020-02-12 20:13:29 +02:00
Simon Giesecke
d45525793f
Bug 1611415 - Applied FixItHints from mozilla-non-std-move. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D60980
2020-02-12 17:24:41 +00:00
Boris Zbarsky
ebaf6de379
Bug 1581173 part 1. Add a way to more easily throw TypeErrors and RangeErrors with custom message strings via ErrorResult. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D45932
2019-09-20 02:19:18 +00:00
Kris Maglione
76d7fc24fd
Bug 1561724: Correctly support exposing remote frames by name. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D36083
2019-06-26 13:35:55 -07:00
Kris Maglione
b885143bce
Bug 1560400: Part 1 - Support remote frames in Window indexed getters. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D35471
2019-06-20 13:52:55 -07:00
Ehsan Akhgari
200d6ea9cc
Bug 836176 - Part 3: Remove nsIHTMLDocument; r=farre
...
Differential Revision: https://phabricator.services.mozilla.com/D32925
2019-06-04 17:27:43 +00:00
Yoshi Cheng-Hao Huang
a25ab4464c
Bug 1534967 - Part 1: use RootedIdVector. r=jonco
...
Differential Revision: https://phabricator.services.mozilla.com/D25042
2019-04-08 10:46:53 +08:00
Jorg K
7fc03594cf
Bug 1519563 - add missing include of WindowProxyHolder.h to WindowNamedPropertiesHandler.cpp. r+a=qdot
2019-01-12 00:32:24 +01:00
Peter Van der Beken
955ad9221e
Bug 1353867 - Change WindowProxyHolder's native type to BrowsingContext. r=bzbarsky
...
Make the WindowProxyHolder hold a strong reference to a BrowsingContext, as in the future
we might not have a nsPIDOMWindowOuter (if the document is loaded in a different process).
Differential Revision: https://phabricator.services.mozilla.com/D12651
2019-01-02 13:27:05 +00:00
Bogdan Tara
a71e3e3f4d
Backed out changeset 82ca028b0524 (bug 1503984) for StaticPrefList failures CLOSED TREE
2018-12-18 22:06:19 +02:00
Felipe Gomes
be30248df5
Bug 1503984 - Add a pref to block chrome code from accessing content subframes. r=nika
...
The pref dom.chrome_frame_access.enabled will default to true. When false, it will block various methods that chrome code can use to traverse subframes. The initial list is:
iframe.contentWindow
iframe.contentDocument
window.top
window.parent
window.opener
window.frames[i]
window.frames.length
MessageEvent.source
More blocks are likely to be added in the future.
Differential Revision: https://phabricator.services.mozilla.com/D13180
2018-12-18 18:53:24 +00:00
Sylvestre Ledru
e5a134f73a
Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
...
# ignore-this-changeset
2018-11-30 11:46:48 +01:00