This patch moves the BlockingErrorCode table and the
IsClassifierBlockingErrorCode / IsClassifierBlockingEventCode /
GetClassifierBlockingEventCode / ClassifierBlockingErrorCodeToConsoleMessage
helpers from UrlClassifierFeatureFactory into ChannelClassifierUtils so the
latter no longer needs to depend on UrlClassifierFeatureFactory.h.
Differential Revision: https://phabricator.services.mozilla.com/D301722
Child actors generally deal with content nodes, and those can be
adopted, in order to preserve behavior, switch to the new
.documentGlobal.
Fix + rename the use-ownerGlobal lint since now it's wrong.
.ownerDocument.defaultView is .documentGlobal, not .ownerGlobal now.
Differential Revision: https://phabricator.services.mozilla.com/D294805
Child actors generally deal with content nodes, and those can be
adopted, in order to preserve behavior, switch to the new
.documentGlobal.
Fix + rename the use-ownerGlobal lint since now it's wrong.
.ownerDocument.defaultView is .documentGlobal, not .ownerGlobal now.
Differential Revision: https://phabricator.services.mozilla.com/D294805
There's still a ton of things that can be cleaned up after this, but
this setup is nicer.
For now, editor keeps getting set-up / torn down on BindToFrame. Seems
all that could be untangled, but step by step.
The preview stuff and placeholder can just be created on demand now,
rather than requiring frame reconstruction.
Also, nsSearchControlFrame and co no longer do anything of interest, so
move the still relevant bits elsewhere and remove them.
test_bug1248459.html is removed because it messes with the editor
selection using SpecialPowers, in a way such that it crosses shadow
boundaries, and messes up the selected state triggering debug asserts.
test_focus_docnav.xhtml now triggers a different code-path because of
the shadow root (rather than the frame tree traversal). Keep it working
for now by replacing it with something that isn't a shadow root.
Differential Revision: https://phabricator.services.mozilla.com/D282953
Move members all to one place in the file. Order them so there are no empty holes of padding to save space. Use initializers.
Differential Revision: https://phabricator.services.mozilla.com/D276631
It is replaced by a standard-conforming cast to (void) which is
understood the same by the compiler.
In some cases this could be replaced by `[[maybe_unused]]` but for
expression whose value is ignored, this requires storing to a temporary
variable first, so not going that way.
One notable change is that marking an object of type already_AddRefed as
unused used to implicitly leak memory. This is now made explicit.
Most of the heavy lifting was done through:
$ git grep -l '\<Unused\> <<' | xargs sed -i -e 's/Unused << /(void)/g'
$ git grep -l mozilla/Unused.h | xargs sed -i -e '/mozilla\/Unused.h/ d'
Differential Revision: https://phabricator.services.mozilla.com/D268706
It is replaced by a standard-conforming cast to (void) which is
understood the same by the compiler.
In some cases this could be replaced by `[[maybe_unused]]` but for
expression whose value is ignored, this requires storing to a temporary
variable first, so not going that way.
One notable change is that marking an object of type already_AddRefed as
unused used to implicitly leak memory. This is now made explicit.
Most of the heavy lifting was done through:
$ git grep -l '\<Unused\> <<' | xargs sed -i -e 's/Unused << /(void)/g'
$ git grep -l mozilla/Unused.h | xargs sed -i -e '/mozilla\/Unused.h/ d'
Differential Revision: https://phabricator.services.mozilla.com/D268706
It is replaced by a standard-conforming cast to (void) which is
understood the same by the compiler.
In some cases this could be replaced by `[[maybe_unused]]` but for
expression whose value is ignored, this requires storing to a temporary
variable first, so not going that way.
One notable change is that marking an object of type already_AddRefed as
unused used to implicitly leak memory. This is now made explicit.
Most of the heavy lifting was done through:
$ git grep -l '\<Unused\> <<' | xargs sed -i -e 's/Unused << /(void)/g'
$ git grep -l mozilla/Unused.h | xargs sed -i -e '/mozilla\/Unused.h/ d'
Differential Revision: https://phabricator.services.mozilla.com/D268706
It is replaced by a standard-conforming cast to (void) which is
understood the same by the compiler.
In some cases this could be replaced by `[[maybe_unused]]` but for
expression whose value is ignored, this requires storing to a temporary
variable first, so not going that way.
One notable change is that marking an object of type already_AddRefed as
unused used to implicitly leak memory. This is now made explicit.
Most of the heavy lifting was done through:
$ git grep -l '\<Unused\> <<' | xargs sed -i -e 's/Unused << /(void)/g'
$ git grep -l mozilla/Unused.h | xargs sed -i -e '/mozilla\/Unused.h/ d'
Differential Revision: https://phabricator.services.mozilla.com/D268706
Most changes are automated. Relevant bit is dom/.clang-format. I had to
manually disable clang-format in a few places where importing external
files and so on that aren't self-contained, and fix a couple includes /
forward declarations.
Differential Revision: https://phabricator.services.mozilla.com/D256800
Just put the map and the state in the Document, we don't need a separate
thread-safe-refcounted object.
This makes it easier to propagate changes to it to the refresh driver
without awkward back-pointers or what not.
No behavior change.
Differential Revision: https://phabricator.services.mozilla.com/D255692
This reverts commit fcf8ae5b87.
Revert "Bug 1967780: Add checks for public IP ranges, roots from the builtin list, and wildcard names. r=jesup,mt"
This reverts commit a4b98f70c7.
Revert "Bug 1967780: Add new ETLD+1 pageload event and ping using ohttp. r=bas,data-stewards,mt"
This reverts commit dbc47a0021.
Revert "Bug 1967780: Reduce frequency of existing pageload event and restructure existing data structures for the pageload event. r=bas"
This reverts commit 8bd2ba9aa4.
This reverts commit 9ac415bd62.
Revert "Bug 1967780: Add checks for public IP ranges, roots from the builtin list, and wildcard names. r=jesup,mt"
This reverts commit 400eb84403.
Revert "Bug 1967780: Add new ETLD+1 pageload event and ping using ohttp. r=bas,mt"
This reverts commit 35ee9f1780.
Revert "Bug 1967780: Reduce frequency of existing pageload event and restructure existing data structures for the pageload event. r=bas"
This reverts commit a2e2c80354.
No behavior-change.
This moves the 'const nsAttrValue* value' decl to its first use where it
belongs; and moves the 'CSSIntSize size' decl a bit earlier, where we'll need
it to be in the next patch.
Differential Revision: https://phabricator.services.mozilla.com/D251987
This patch doesn't change behavior for now (because none of the existing
callsites pass the param to opt out); but a later patch in this series will
add a callsite that does opt out of density-correction.
Differential Revision: https://phabricator.services.mozilla.com/D251986
This patch doesn't change behavior; it's just moving this function from a
derived class to its superclass (because a later patch in this series will need
to call it from the superclass).
Differential Revision: https://phabricator.services.mozilla.com/D251985
This patch makes the usage of `EnumTable`s safer
by using `Span`s instead of relying on an empty
element at the end.
Also the name has been changed from `EnumTable`
to `EnumTableEntry` to be more precise.
Differential Revision: https://phabricator.services.mozilla.com/D247453
This patch makes the usage of `EnumTable`s safer
by using `Span`s instead of relying on an empty
element at the end.
Also the name has been changed from `EnumTable`
to `EnumTableEntry` to be more precise.
Differential Revision: https://phabricator.services.mozilla.com/D247453
Extend the pageload event to store features used on the root document for better signal-to-noise detection in performance experiments.
This patch uses a bit to record documents in which fetchpriority is used on images.
Data-classification-low: Category 1 “Technical data”
Differential Revision: https://phabricator.services.mozilla.com/D222991
Clean-up some legacy nsImageLoadingContent state tracking while at it:
* mLoading was not used to set ElementState anymore, and was only
checked on the "loading" attribute handling, in what seems to be a
poor man's way of preventing lazy loading to start once an image load
is ongoing? However that should already be covered by the image load
not being sync and checking mLazyLoad itself.
* The depth tracking was unneeded, image notifications have been all
async for ages.
Move some bools into nsImageLoadingContent to pack it better.
Differential Revision: https://phabricator.services.mozilla.com/D218971
Tim Huang