The reasoning for having it was faster / inline constructor / destructor
behavior, but bug 2025271 inlines the string destructor, so there isn't
a need for this anymore, and perf profiles agree.
There were some unsound checks like not checking for adopted strings
etc.
There's a subtle loss of functionality in which we can't depend on
another string so easily. However this only affects
non-StringBuffer-backed strings, and it was misused (some of the callers
used it with a temporary string which is clearly wrong). Also most
callers can be trivially tweaked to avoid the copy anyways.
Differential Revision: https://phabricator.services.mozilla.com/D288003
This patch updates InternalRequest and InternalResponse such that it parses the
URL passed to it at creation time, rather than when the channel is created.
This should improve the behaviour of these types around Blob URLs, so that
extra state, such as the "revoked" flag, is calculated at the correct time
as-per spec.
While making this change, I noticed that a previous Cache DB migration could
insert an "" URL in the DB when migrating from a single response URL to a URL
list, rather than storing an empty URL list. The choice was made to do
filtering when reading, rather than performing a migration, to avoid migration
first-time start-up overhead.
Differential Revision: https://phabricator.services.mozilla.com/D276047
This reverts commit 6a6fa9d976.
Revert "Bug 1967540: Merged duplicated code in WorkerScriptLoader::DispatchLoadScript and DispatchLoadScripts.r=edenchuang"
This reverts commit 881e3fe972.
Revert "Bug 1967540: BoundStorageKeyCacheStorage and BoundStorageKeyCache to use new CacheOpChild ctor taking in MozProme.r=edenchuang"
This reverts commit 11a691b1a4.
Revert "Bug 1967540: Extended CacheOpChild to include the support for MozPromise alongside JS::Promise.r=edenchuang"
This reverts commit 5f9e7f4655.
This reverts commit acd4e26b86.
Revert "Bug 1967540: Merged duplicated code in WorkerScriptLoader::DispatchLoadScript and DispatchLoadScripts.r=edenchuang"
This reverts commit ceddca9ac6.
Revert "Bug 1967540: BoundStorageKeyCacheStorage and BoundStorageKeyCache to use new CacheOpChild ctor taking in MozProme.r=edenchuang"
This reverts commit 7803a0b264.
Revert "Bug 1967540: Extended CacheOpChild to include the support for MozPromise alongside JS::Promise.r=edenchuang"
This reverts commit 3a40e09e99.
Most changes are automated. Relevant bit is dom/.clang-format. I had to
manually disable clang-format in a few places where importing external
files and so on that aren't self-contained, and fix a couple includes /
forward declarations.
Differential Revision: https://phabricator.services.mozilla.com/D256800
Emilio Cobos Álvarez