Benjamin VanderSloot
ef79f85b0b
Bug 2027745, part 1 - Remove the storage access unpartitioning of non-cookie Storage - r=timhuang,dom-worker-reviewers,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D290972
2026-05-01 14:22:54 +00:00
Sylvestre Ledru
9eb1a31a98
Bug 2023419 - Remove Emacs/Vim modelines from dom/ r=emilio,media-playback-reviewers,webidl,padenot
...
replaced by .editorconfig
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D287843
2026-03-16 21:02:32 +00:00
serge-sans-paille
7662b3abdc
Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch
...
It is replaced by a standard-conforming cast to (void) which is
understood the same by the compiler.
In some cases this could be replaced by `[[maybe_unused]]` but for
expression whose value is ignored, this requires storing to a temporary
variable first, so not going that way.
One notable change is that marking an object of type already_AddRefed as
unused used to implicitly leak memory. This is now made explicit.
Most of the heavy lifting was done through:
$ git grep -l '\<Unused\> <<' | xargs sed -i -e 's/Unused << /(void)/g'
$ git grep -l mozilla/Unused.h | xargs sed -i -e '/mozilla\/Unused.h/ d'
Differential Revision: https://phabricator.services.mozilla.com/D268706
2025-10-21 19:36:01 +00:00
Cristina Horotan
8a1b1970b7
Revert "Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch" for causing Gtest failures on AlreadyAddRefed.h
...
This reverts commit e98adca292 .
2025-10-21 16:16:29 +00:00
serge-sans-paille
e98adca292
Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch
...
It is replaced by a standard-conforming cast to (void) which is
understood the same by the compiler.
In some cases this could be replaced by `[[maybe_unused]]` but for
expression whose value is ignored, this requires storing to a temporary
variable first, so not going that way.
One notable change is that marking an object of type already_AddRefed as
unused used to implicitly leak memory. This is now made explicit.
Most of the heavy lifting was done through:
$ git grep -l '\<Unused\> <<' | xargs sed -i -e 's/Unused << /(void)/g'
$ git grep -l mozilla/Unused.h | xargs sed -i -e '/mozilla\/Unused.h/ d'
Differential Revision: https://phabricator.services.mozilla.com/D268706
2025-10-21 15:05:17 +00:00
Cristina Horotan
aab924e90d
Revert "Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch" for causing build bustage at nsBrowserApp.cpp
...
This reverts commit fd0ffa193c .
2025-10-21 10:44:13 +00:00
serge-sans-paille
fd0ffa193c
Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch
...
It is replaced by a standard-conforming cast to (void) which is
understood the same by the compiler.
In some cases this could be replaced by `[[maybe_unused]]` but for
expression whose value is ignored, this requires storing to a temporary
variable first, so not going that way.
One notable change is that marking an object of type already_AddRefed as
unused used to implicitly leak memory. This is now made explicit.
Most of the heavy lifting was done through:
$ git grep -l '\<Unused\> <<' | xargs sed -i -e 's/Unused << /(void)/g'
$ git grep -l mozilla/Unused.h | xargs sed -i -e '/mozilla\/Unused.h/ d'
Differential Revision: https://phabricator.services.mozilla.com/D268706
2025-10-21 09:44:11 +00:00
Narcis Beleuzu
e1e6bbb1c9
Revert "Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch" for causing bustages on Document.cpp
...
This reverts commit b23c15e927 .
2025-10-21 06:34:58 +00:00
serge-sans-paille
b23c15e927
Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch
...
It is replaced by a standard-conforming cast to (void) which is
understood the same by the compiler.
In some cases this could be replaced by `[[maybe_unused]]` but for
expression whose value is ignored, this requires storing to a temporary
variable first, so not going that way.
One notable change is that marking an object of type already_AddRefed as
unused used to implicitly leak memory. This is now made explicit.
Most of the heavy lifting was done through:
$ git grep -l '\<Unused\> <<' | xargs sed -i -e 's/Unused << /(void)/g'
$ git grep -l mozilla/Unused.h | xargs sed -i -e '/mozilla\/Unused.h/ d'
Differential Revision: https://phabricator.services.mozilla.com/D268706
2025-10-21 06:01:36 +00:00
Emilio Cobos Álvarez
791917d8af
Bug 1976665 - Sort headers in dom/. r=dom-core,media-playback-reviewers,webrtc-reviewers,dom-storage-reviewers,padenot,janv,smaug,jesup,jib
...
Most changes are automated. Relevant bit is dom/.clang-format. I had to
manually disable clang-format in a few places where importing external
files and so on that aren't self-contained, and fix a couple includes /
forward declarations.
Differential Revision: https://phabricator.services.mozilla.com/D256800
2025-08-05 11:47:34 +00:00
Harveer Singh
134189cdb2
Bug 1969120: Some refactorings to support new top-level actors in Cache and CacheStorage.r=edenchuang
...
Differential Revision: https://phabricator.services.mozilla.com/D254889
2025-07-21 14:39:08 +00:00
Harveer Singh
23cff5c314
Bug 1969120: TypeUtils::GetIPCManager is no longer needed, hence, removing.r=edenchuang
...
Differential Revision: https://phabricator.services.mozilla.com/D257355
2025-07-21 14:38:59 +00:00
Harveer Singh
2c1c4ab1f0
Bug 1969120: Created new Listener class in TypeUtils.h for cache classes to override and register themselves with their respective protocol classes.r=edenchuang
...
Differential Revision: https://phabricator.services.mozilla.com/D256710
2025-07-21 14:38:53 +00:00
Andrew McCreight
ecb7c82162
Bug 1958405 - Move CachesEnabled out of nsGlobalWindowInner. r=webidl,smaug,asuth
...
Having this method here means nsGlobalWindowInner needs to be included in a number
of bindings files, and doesn't make a lot of sense. This patch moves it to Cache
and CacheStorage (the latter being a wrapper around the former) to avoid extra
includes.
Differential Revision: https://phabricator.services.mozilla.com/D244443
2025-04-03 22:26:13 +00:00
Jan Varga
8cdc63b5d9
Bug 1867997 - Move nsIPrincipal/PrincipalInfo helpers to separate files; r=dom-storage-reviewers,jari
...
Differential Revision: https://phabricator.services.mozilla.com/D223992
2024-10-18 01:32:36 +00:00
Peter Van der Beken
c2b9f227d0
Bug 1906744 - Check if constructor is enabled before installing named property. r=mccr8,dom-storage-reviewers,janv,asuth,eemeli
...
Differential Revision: https://phabricator.services.mozilla.com/D216671
2024-08-08 16:35:19 +00:00
Narcis Beleuzu
88649c8662
Backed out changeset 393ab27c060b (bug 1906744) for Hazard bustages on Localization.cpp
2024-08-07 00:57:51 +03:00
Peter Van der Beken
d9561590dd
Bug 1906744 - Check if constructor is enabled before installing named property. r=mccr8,dom-storage-reviewers,janv,asuth,eemeli
...
Differential Revision: https://phabricator.services.mozilla.com/D216671
2024-08-06 15:29:04 +00:00
Iulian Moraru
1506481d39
Backed out changeset e9975f346b2b (bug 1906744) for causing multiple failures. CLOSED TREE
2024-08-05 20:44:20 +03:00
Peter Van der Beken
8d64c21390
Bug 1906744 - Check if constructor is enabled before installing named property. r=mccr8,dom-storage-reviewers,janv,asuth,eemeli
...
Differential Revision: https://phabricator.services.mozilla.com/D216671
2024-08-05 15:58:56 +00:00
Tamas Szentpeteri
21a146b83e
Backed out changeset 2fa58daa8086 (bug 1906744) for causing mochitest browser time outs. CLOSED TREE
2024-07-26 19:33:31 +03:00
Peter Van der Beken
47c9fe0b2b
Bug 1906744 - Check if constructor is enabled before installing named property. r=mccr8,dom-storage-reviewers,janv,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D216671
2024-07-26 15:08:34 +00:00
Tom Schuster
feaa0c77a1
Bug 1904004 - Use OriginAttributes::IsPrivateBrowsing instead of open coding PBM checks. r=timhuang,cookie-reviewers,anti-tracking-reviewers,profiler-reviewers,necko-reviewers,kershaw,dom-storage-reviewers,janv,canaltinova,dom-worker-reviewers,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D214532
2024-06-24 11:06:18 +00:00
Emilio Cobos Álvarez
de09ab0dd6
Bug 1887719 - More consistently use UTF8String/nsCString for URLs. r=necko-reviewers,webidl,anti-tracking-reviewers,places-reviewers,jari,kershaw,janv,smaug,hsivonen
...
Sorry for the massive patch but I found it hard to split without
introducing a bunch of copies around...
This mostly makes necko and DOM agree on which strings to use, which
should result on less copies and conversions.
Differential Revision: https://phabricator.services.mozilla.com/D205601
2024-04-04 11:49:57 +00:00
Peter Van der Beken
a50f002c9b
Bug 1640839 - Stop generating count of WebIDL enum values, use standard enum traits instead. r=mccr8
...
Differential Revision: https://phabricator.services.mozilla.com/D201345
2024-03-02 07:50:25 +00:00
Natalia Csoregi
10b9ceb789
Backed out 13 changesets (bug 1640839) for causing bustage on Element.cpp CLOSED TREE
...
Backed out changeset 179ceb82c9e5 (bug 1640839)
Backed out changeset 73f498a821f0 (bug 1640839)
Backed out changeset dc2d3d0e0365 (bug 1640839)
Backed out changeset ddc989ac0509 (bug 1640839)
Backed out changeset e595bb3feea8 (bug 1640839)
Backed out changeset c85aca04e27f (bug 1640839)
Backed out changeset 98e8e3a4047a (bug 1640839)
Backed out changeset 59ef180517db (bug 1640839)
Backed out changeset af2f5e293662 (bug 1640839)
Backed out changeset 89aa6d9dc598 (bug 1640839)
Backed out changeset 67b722a722f9 (bug 1640839)
Backed out changeset 24a9665c6ced (bug 1640839)
Backed out changeset d93f199385e9 (bug 1640839)
2024-03-01 18:23:08 +02:00
Peter Van der Beken
22089d8166
Bug 1640839 - Stop generating count of WebIDL enum values, use standard enum traits instead. r=mccr8
...
Differential Revision: https://phabricator.services.mozilla.com/D201345
2024-03-01 14:31:16 +00:00
Harveer Singh
4e13012846
Bug 1857066: Enable CacheStorage::Constructor for PBM.r=dom-storage-reviewers,janv
...
Depends on D180904
Differential Revision: https://phabricator.services.mozilla.com/D190121
2023-10-27 14:10:09 +00:00
hsingh
600a4972bc
Bug 1835300: Allow CacheAPI in PBM if pref is toggled. r=dom-storage-reviewers,asuth
...
Depends on D180295
Differential Revision: https://phabricator.services.mozilla.com/D180296
2023-10-27 14:10:07 +00:00
Paul Zuehlcke
348b90237d
Bug 1814733 r=timhuang,dom-storage-reviewers,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D168976
2023-02-27 12:10:39 +00:00
Kagami Sascha Rosylight
18b82ad448
Bug 1784590 - Part 2: Add use counters for unsupported APIs in PBM r=asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D154579
2022-08-24 10:58:47 +00:00
Marian-Vasile Laza
719e13cde2
Backed out 2 changesets (bug 1784590) for causing mochitest failures on test_privateBrowsing.html. CLOSED TREE
...
Backed out changeset cd284ba05fbb (bug 1784590)
Backed out changeset 2f714355a8c8 (bug 1784590)
2022-08-23 01:26:37 +03:00
Kagami Sascha Rosylight
3efeb4cf97
Bug 1784590 - Part 2: Add use counters for unsupported APIs in PBM r=asuth
...
Depends on D154578
Differential Revision: https://phabricator.services.mozilla.com/D154579
2022-08-22 20:48:34 +00:00
Marian-Vasile Laza
8f6ed464ea
Backed out 2 changesets (bug 1784590) for causing mochitest failures on test_privateBrowsing.html.
...
Backed out changeset 36d36e75930f (bug 1784590)
Backed out changeset 35dbbd6dbb70 (bug 1784590)
2022-08-22 22:50:41 +03:00
Kagami Sascha Rosylight
5555b317dc
Bug 1784590 - Part 2: Add use counters for unsupported APIs in PBM r=asuth
...
Depends on D154578
Differential Revision: https://phabricator.services.mozilla.com/D154579
2022-08-22 18:48:12 +00:00
Thomas Wisniewski
5ab0bdec19
Bug 1758745 - Refactor EffectiveStoragePrincipal to EffectiveCookiePrincipal and create new function EffectiveStoragePrincipal that is never unpartitioned; r=bvandersloot
...
Depends on D143626
Differential Revision: https://phabricator.services.mozilla.com/D143627
2022-07-15 13:26:17 +00:00
Cristian Tuns
3357ee59dc
Backed out 19 changesets (bug 1758745, bug 1758740, bug 1762462, bug 1779603) for causing mochitest failures on browser_partitionedConsoleMessage.js CLOSED TREE
...
Backed out changeset e3c8cd6f00b6 (bug 1779603)
Backed out changeset 4e46a6f209b4 (bug 1762462)
Backed out changeset 00c0c6314640 (bug 1762462)
Backed out changeset 8f11221f859f (bug 1762462)
Backed out changeset ffbf90e3bbab (bug 1762462)
Backed out changeset 0c760428dfec (bug 1762462)
Backed out changeset 7c99293cc8f9 (bug 1762462)
Backed out changeset 92bd237a95e1 (bug 1762462)
Backed out changeset 74539a3cc7fc (bug 1762462)
Backed out changeset acf08a10c6fb (bug 1762462)
Backed out changeset 0cf191a7739f (bug 1762462)
Backed out changeset 030c276d6669 (bug 1762462)
Backed out changeset a88a099c684d (bug 1762462)
Backed out changeset cbd69786a24b (bug 1762462)
Backed out changeset e5e0655206a8 (bug 1762462)
Backed out changeset 707f9dfed501 (bug 1762462)
Backed out changeset 619e4bb01a81 (bug 1762462)
Backed out changeset 02b7641683b0 (bug 1758745)
Backed out changeset a2f110442038 (bug 1758740)
2022-07-14 17:26:17 -04:00
Thomas Wisniewski
5a542d4e45
Bug 1758745 - Refactor EffectiveStoragePrincipal to EffectiveCookiePrincipal and create new function EffectiveStoragePrincipal that is never unpartitioned; r=bvandersloot
...
Depends on D143626
Differential Revision: https://phabricator.services.mozilla.com/D143627
2022-07-14 19:26:26 +00:00
Norisz Fay
e8b394df6c
Backed out 18 changesets (bug 1762462, bug 1758745, bug 1758740) for causing mochitest failures on test_storage_copied.html
...
Backed out changeset a27ae15872a9 (bug 1762462)
Backed out changeset b7d979a36324 (bug 1762462)
Backed out changeset 6249efe40513 (bug 1762462)
Backed out changeset 1e81ed3014a0 (bug 1762462)
Backed out changeset 92cec5f5db1c (bug 1762462)
Backed out changeset fa3c45b4de5c (bug 1762462)
Backed out changeset 64df67f43ad7 (bug 1762462)
Backed out changeset d66dd76ec2b6 (bug 1762462)
Backed out changeset 4f8aaba02a03 (bug 1762462)
Backed out changeset 81eb7d60dea9 (bug 1762462)
Backed out changeset 01504f5f818a (bug 1762462)
Backed out changeset 2615b571c9ba (bug 1762462)
Backed out changeset 73ed8be3f117 (bug 1762462)
Backed out changeset edb94ba8ec59 (bug 1762462)
Backed out changeset 21dd6fdc672e (bug 1762462)
Backed out changeset 31a70f9ad879 (bug 1762462)
Backed out changeset 5261ee5a2368 (bug 1758745)
Backed out changeset ad6ffd85ef3c (bug 1758740)
2022-07-14 03:16:08 +03:00
Thomas Wisniewski
fa146804f6
Bug 1758745 - Refactor EffectiveStoragePrincipal to EffectiveCookiePrincipal and create new function EffectiveStoragePrincipal that is never unpartitioned; r=bvandersloot
...
Depends on D143626
Differential Revision: https://phabricator.services.mozilla.com/D143627
2022-07-13 22:44:57 +00:00
Cristian Tuns
fa5ade6c28
Backed out 3 changesets (bug 1758745, bug 1758740, bug 1762462) for causing mochitest failures on test_storagePermissionsAccept.html CLOSED TREE
...
Backed out changeset fa222c0a9a26 (bug 1762462)
Backed out changeset 9daa04b239f9 (bug 1758745)
Backed out changeset c18aecb431c0 (bug 1758740)
2022-05-10 20:12:45 -04:00
Thomas Wisniewski
c131738709
Bug 1758745 - Refactor EffectiveStoragePrincipal to EffectiveCookiePrincipal and create new function EffectiveStoragePrincipal that is never unpartitioned; r=twisniewski
...
Depends on D143626
Differential Revision: https://phabricator.services.mozilla.com/D143627
2022-05-10 21:49:42 +00:00
Butkovits Atila
5ee4443154
Backed out 3 changesets (bug 1758745, bug 1758740, bug 1762462) for causing failures at browser_storage_dfpi.js. CLOSED TREE
...
Backed out changeset a3024e8b2a58 (bug 1762462)
Backed out changeset 8bc1291b9bdb (bug 1758745)
Backed out changeset c7b693b2fd05 (bug 1758740)
2022-05-10 16:17:59 +03:00
Thomas Wisniewski
ed22a3aadb
Bug 1758745 - Refactor EffectiveStoragePrincipal to EffectiveCookiePrincipal and create new function EffectiveStoragePrincipal that is never unpartitioned; r=twisniewski
...
Depends on D143626
Differential Revision: https://phabricator.services.mozilla.com/D143627
2022-05-10 12:05:51 +00:00
Jan Varga
3e73e7ce93
Bug 1731960 - Move all Result extensions from QMResult.h to a dedicated file; r=dom-storage-reviewers,jari
...
Differential Revision: https://phabricator.services.mozilla.com/D126324
2021-11-30 05:05:51 +00:00
Kagami Sascha Rosylight
2fbad9152e
Bug 1726157 - Add GetStorageAccess to nsIGlobalObject r=asuth,timhuang
...
Differential Revision: https://phabricator.services.mozilla.com/D123145
2021-09-24 06:06:51 +00:00
Jan Varga
7345ed5f93
Bug 1728267 - Remove implicit ToResult from QM_TRY when one extra argument is passed; r=dom-storage-reviewers,jstutte,jari
...
Differential Revision: https://phabricator.services.mozilla.com/D125316
2021-09-23 10:16:09 +00:00
Jan Varga
e0c0c469a0
Bug 1728267 - Remove implicit ToResult from QM_TRY when two extra arguments are passed; r=dom-storage-reviewers,jstutte,jari
...
Differential Revision: https://phabricator.services.mozilla.com/D125315
2021-09-23 10:16:09 +00:00
Marian-Vasile Laza
22f676343c
Backed out changeset be76cb91e85a (bug 1726157) for causing xpcshell failures on test_ext_cache_api.js. CLOSED TREE
2021-09-23 13:04:56 +03:00
Kagami Sascha Rosylight
1a7eed3fd6
Bug 1726157 - Add GetStorageAccess to nsIGlobalObject r=asuth,timhuang
...
Differential Revision: https://phabricator.services.mozilla.com/D123145
2021-09-23 08:49:56 +00:00